Birunthan Mohanathas
a29151dc87
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Nicholas Nethercote
8976e2b967
Bug 1179071 - Merge RemovingIterator into Iterator. r=froydnj.
...
The original motivation for the Iterator/RemovingIterator split was that
PLDHashTable Checker class would treat them differently. But that didn't end up
happening (see bug 1131308). So this patch merges them. This is a small code
size win now but it will become bigger when I add iterators to nsTHashTable and
nsBaseHashtable.
The only complication is that PLDHashTable::Iter() is now non-const, which is
a problem if you use it in a const method. So I added PLDHashTable::ConstIter()
which is used in just two places. It's a bit of a hack -- effectively a
const_cast -- but I don't think it's too bad.
2015-07-06 22:02:26 -07:00
Nicholas Nethercote
d68b5e908c
Bug 1175810 (part 2) - Remove PL_DHashTableEnumerate() uses from nsJSNPRuntime. r=bz.
...
Also, remove the |AutoSafeJSContext| because it wasn't being used.
2015-06-18 17:59:42 -07:00
Terrence Cole
88f9bc5932
Bug 1178581 - Interning does not and should not imply infinite lifetime; r=sfink
2015-06-30 07:58:31 -07:00
Jan de Mooij
8bd603a950
Bug 1177892 part 3 - Remove OBJECT_TO_JSVAL. r=evilpie
2015-06-30 21:09:46 -07:00
Jan de Mooij
f3ccbe5797
Bug 1177892 part 1 - Remove BOOLEAN_TO_JSVAL and STRING_TO_JSVAL. r=evilpie
2015-06-30 11:20:56 -07:00
Ryan VanderMeulen
4bb610cee0
Backed out changesets ad58c270ce87 and 849151330d60 (bug 1177892) for B2G bustage.
...
CLOSED TREE
2015-06-30 15:48:11 -04:00
Jan de Mooij
c2c23268db
Bug 1177892 part 1 - Remove BOOLEAN_TO_JSVAL and STRING_TO_JSVAL. r=evilpie
2015-06-30 11:20:56 -07:00
Jan de Mooij
987140de6f
Bug 1177825 - Remove JSVAL_* constants. r=evilpie
2015-06-29 18:36:44 -07:00
Andrew McCreight
cad46615d3
Bug 886459, part 4 - Remove nsIJSRuntimeService. r=bholley,aklotz
2015-06-26 18:44:14 -07:00
Aaron Klotz
42c8de6bf3
Bug 1169457 - Add null check in OnWrapperDestroy. r=jimm
2015-06-23 18:49:55 -07:00
Nicholas Nethercote
4500bfa831
Bug 1170416 (part 3) - Remove the PLDHashTable2 typedef. r=froydnj.
2015-05-19 16:46:17 -07:00
Nicholas Nethercote
632627491b
Bug 1165768 (part 1) - Convert |sNPObjWrappers| to |PLDHashTable2*|. r=froydnj.
...
This involves removing the last uses of PLDHashTable::SetOps(), which is a
nasty encapsulation-breaking hack. Hooray!
2015-05-18 00:52:07 -07:00
Nicholas Nethercote
594f872fe6
Back out all four patches from bug 1161377. r=me.
...
Due to Android startup regressions (bug 1163066) and plugin crashes (bug
1165155).
2015-05-14 21:48:43 -07:00
Nicholas Nethercote
35cc1f7af7
Bug 1161377 (part 2.5) - Move all static PLDHashTable instances onto the heap to avoid static constructors. r=froydnj.
2015-05-12 17:33:22 -07:00
Jan de Mooij
960e7c935d
Bug 1155946 part 1 - Add a mayResolve class hook to optimize objects with resolve hooks better. r=bhackett
2015-04-23 15:51:28 +02:00
Julian Seward
d9a4df47dd
Bug 1153173 - Uninitialised value use in AutoJSExceptionReporter::~AutoJSExceptionReporter. r=aklotz.
2015-04-20 10:02:27 +02:00
Jim Blandy
f94dd3b1df
Bug 1152577: Add 'aReason' argument to AutoEntryScript constructor, and provide plausible names for its instantiations. r=bholley
2015-04-08 21:23:48 -04:00
Tom Schuster
6910bcc31c
Bug 1147005 - Change JSAddPropertyOp signature. r=jorendorff,peterv
2015-03-28 14:47:02 +01:00
Phil Ringnalda
529df7748d
Backed out changeset d72144153749 (bug 1147005) for being on top of a patch on top of a patch being backed out
...
CLOSED TREE
2015-03-28 10:39:09 -07:00
Tom Schuster
023b3ef599
Bug 1147005 - Change JSAddPropertyOp signature. r=jorendorff,peterv
2015-03-28 14:47:02 +01:00
Aaron Klotz
4624718baa
Bug 1135491: Part 2 - Changes to nsJSNPRuntime to ensure that JS exceptions aren't thrown when plugin destruction is pending; r=josh,bholley
2015-03-09 15:07:16 -06:00
Jason Orendorff
20beb2cc48
Bug 1113369, part 5 - [[Delete]] ObjectOpResult support. r=Waldo, r=bz in dom, r=dvander in js/ipc, r=bholley in js/xpconnect.
2015-02-04 10:20:04 -06:00
Jason Orendorff
b180889659
Bug 1113369, part 4 - [[Set]] ObjectOpResult support. r=Waldo, r=bz in dom, r=dvander in js/ipc, r=bholley in js/xpconnect.
2015-02-03 19:51:40 -06:00
Jan de Mooij
b3f1ff13a2
Bug 1137523 - Unprefix most js_* functions. r=bhackett CLOSED TREE
2015-02-27 16:08:15 +01:00
Tom Schuster
7104967189
Bug 1124934 - Add a HasProperty ObjectOp. r=jorendorff
2015-02-13 12:20:02 +01:00
Tom Schuster
4b85b5355a
Bug 1125437 - Get rid of SetPropertyAttributes and use DefineProperty to follow ES6 specification. r=efaust
2015-02-11 23:40:47 +01:00
Nicholas Nethercote
3b0764a330
Bug 1131901 (part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
2015-02-02 14:48:58 -08:00
Nicholas Nethercote
1ce96de5ae
Back out changesets 2fcef6b54be7, 2be07829fefc, 66dfe37b8532, df3fcd2be8fd, 0a436bce77a6 (bug 1050035) for causing intermittent crashes and assertion failures.
2015-02-10 14:39:49 -08:00
Nicholas Nethercote
a3bf151ee6
Bug 1050035 (part 4) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
2015-02-02 14:48:58 -08:00
Jason Orendorff
4333588881
Bug 1127121 - Remove property key type splitting in ObjectOps. r=bhackett.
2015-01-28 17:12:44 -06:00
Tom Schuster
b5139c60f2
Bug 1127443 - Remove JS_NewObject proto argument.
2015-01-31 16:18:51 +01:00
Nicholas Nethercote
3efc7a6cc3
Bug 1124973 (part 4) - Remove erroneous uses of PL_DHASH_ENTRY_IS_{BUSY,FREE} in nsJSNPRuntime.cpp. r=froydnj.
...
The BUSY check is merely useless, because BUSY is always true for a non-null
entry returned by PL_DHashTableAdd.
The FREE check is downright dangerous because it dereferences |entry| and
PL_DHashTableAdd() returns nullptr on OOM. A null check makes more sense here.
2015-01-26 14:05:06 -08:00
Nicholas Nethercote
c38455902a
Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
...
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.
For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.
I'll do the trickier ones in subsequent patches.
2015-01-22 21:06:55 -08:00
Tom Schuster
01891781b2
Bug 1122619 - Remove getPropertyAttributes object ops. r=jorendorff
2015-01-24 16:38:08 +01:00
Tom Schuster
598e20943c
Bug 1122552 - Introduce [[GetOwnProperty]] object op. r=jorendorff,bz
2015-01-22 17:17:26 +01:00
Nicholas Nethercote
16fcb0d8bb
Bug 1123151 (part 3) - Make PLDHashTable::ops private. r=froydnj.
...
This required adding a getter and a setter, but they're used sparingly.
2015-01-19 16:34:44 -08:00
Nicholas Nethercote
4604f714c6
Bug 1123151 (part 2) - Add PLDHashTable::IsInitialized(). r=froydnj.
...
This encapsulates most of the uses of PLDHashTable::ops.
2015-01-19 16:11:34 -08:00
Nicholas Nethercote
009293c72a
Bug 1123151 (part 1) - Set PLDHashTable::ops consistently. r=froydnj.
...
Currently the setting of PLDHashTable::ops is very haphazard.
- PLDHashTable has no constructor, so it's not auto-nulled, so lots of places
null it themselves.
- In the fallible PLDHashTable::Init() function, if the entry storage
allocation fails we'll be left with a table that has |ops| set -- indicating
it's been initialized -- but has null entry storage. I'm not certain this can
cause problems but it feels unsafe, and some (but not all) callers of Init()
null it on failure.
- PLDHashTable does not null |ops| in Finish(), so some (but not all) callers
do this themselves.
This patch makes things simpler.
- It adds a constructor that zeroes |ops|.
- It modifies Init() so that it only sets |ops| once success is ensured.
- It zeroes |ops| in Finish().
- Finally, it removes all the now-unnecessary |ops| nulling done by the users
of PLDHashTable.
2015-01-19 16:01:24 -08:00
Michael Pruett
ad782194ca
Bug 1121202 - Remove unused PL_DHashTableOperate function. r=njn
2015-01-15 18:01:07 -06:00
Nicholas Nethercote
eda870fe92
Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj.
2015-01-13 16:42:13 -08:00
Ms2ger
2c36b38c93
Bug 914067 - Remove JSVAL_VOID from dom/; r=jst
2015-01-14 08:59:06 +01:00
Michael Pruett
cbe37abc44
Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd
2015-01-05 20:27:28 -06:00
Aaron Klotz
06c94e3302
Bug 998863: Asynchronous Plugin Initialization, Part 1: nsJSNPRuntime changes; r=josh
2014-12-29 16:12:25 -07:00
Phil Ringnalda
4227fff1a3
Backed out 15 changesets (bug 1070755, bug 998863) for e10s bustage
...
CLOSED TREE
Backed out changeset 076d1d47d601 (bug 1070755
2014-12-24 18:28:45 -08:00
Aaron Klotz
4e004889e7
Bug 998863: Asynchronous Plugin Initialization, Part 1: nsJSNPRuntime changes; r=josh
2014-12-24 17:55:48 -07:00
Tom Schuster
ffeb361ca3
Bug 1097267 - Use new enumerate hook for plugins. r=josh
2014-12-11 19:31:10 +01:00
Jason Orendorff
ddde8586c6
Bug 1103368, part 5 - Make Class::getProperty and setProperty nullable instead of needing stub functions. Never store stub functions in JSPropertyDescriptors. r=bhackett.
2014-11-22 12:23:39 -06:00
Jason Orendorff
6c66fe3b7e
Bug 1103152 - Remove JS_DeletePropertyStub, JS_EnumerateStub, JS_ResolveStub, and JS_ConvertStub. Make five mandatory JSClass hooks optional (nullable). r=bhackett.
2014-12-02 16:56:35 -06:00
Julian Seward
a93f545433
Bug 1096054 - Uninitialised value use in Interpret(JSContext*, js::RunState&). r=jwalden.
2014-11-14 21:55:03 +01:00
