Commit Graph

4 Commits

Author SHA1 Message Date
Brian Birtles
b7b7237192 Bug 1166164 part 3 - Resolve start time on finish(); r=jwatt
We have already resolved to make calling Finish() clear the pause state (see
https://lists.w3.org/Archives/Public/public-fx/2015AprJun/0038.html, item 2).
Doing that involves resolving the start time when the animation is paused.

Furthermore, as a separate change, we resolved to make the finished promise not
resolve when the animation is paused. That suggests making UpdateFinishedState()
only resolve the finished promise when PlayState() == Finished rather than using
IsFinished() which returns true even if the animation is paused.

However, if we compare PlayState() == Finished in UpdateFinishedState() then we
will *not* resolve the finished promise when the animation is play-pending since
PlayState() == Pending in that case (pause-pending is ok since the call to
SetCurrentTime will cause a transition to the Paused state). Furthermore, the
existing call to cancel the pending play task will effectively leave this
animation forever pending. Hence, in this patch we unconditionally fill in the
start time.
2015-05-19 10:08:46 +09:00
Boris Zbarsky
83864e6984 Bug 1159743. Stop forcing the dom.animations-api.core.enabled preference on in the test harness. r=birtles 2015-04-30 14:25:03 -04:00
Wes Kocher
143b05ecba Backed out changeset 4d85a02e9c28 (bug 1159743) under suspicion of breaking animation tests CLOSED TREE 2015-04-30 15:25:58 -07:00
Boris Zbarsky
fa14fc0c65 Bug 1159743. Stop forcing the dom.animations-api.core.enabled preference on in the test harness. r=birtles 2015-04-30 14:25:03 -04:00