Commit Graph

88 Commits

Author SHA1 Message Date
Florian Quèze
a2877463a4 Bug 1950710 - Migrate histograms to use Glean APIs for FIREFOX_VIEW_CUMULATIVE_SEARCHES, r=chutten,fxview-reviewers,jsudiaman.
Differential Revision: https://phabricator.services.mozilla.com/D242792
2025-03-27 06:36:58 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
2025-02-19 16:19:42 +00:00
Florian Quèze
1ee252004d Bug 1935420 - rewrite JS code storing histograms in local variables to make automatic glean migration easier, r=chutten,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,places-reviewers,markh,nsharpley.
Differential Revision: https://phabricator.services.mozilla.com/D234008
2025-01-24 16:18:32 +00:00
Mark Striemer
52303d1799 Bug 1935876 - Create a single panel-list for fxview history pane r=fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D232250
2025-01-09 15:22:28 +00:00
Stuart Colville
6bd05b9603 Bug 1926119: Remove 2nd empty-state string for don't remember history. r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D226453
2024-10-23 10:31:29 +00:00
Stuart Colville
7f22a561de Bug 1911749 - Update History and Tabs from other devices strings shared with FxView. r=sidebar-reviewers,fluent-reviewers,bolsson,fxview-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D225550
2024-10-17 17:43:08 +00:00
Cosmin Sabou
162894add1 Backed out changeset 290a68970e02 (bug 1911749) for causing bc failures on browser_history_firefoxview. 2024-10-17 00:50:02 +03:00
Stuart Colville
56b5279a66 Bug 1911749 - Update History and Tabs from other devices strings shared with FxView. r=sidebar-reviewers,fluent-reviewers,bolsson,fxview-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D225550
2024-10-16 18:46:35 +00:00
Florian Quèze
03b00e2a53 Bug 1918702 - Migrate telemetry events to use Glean APIs for firefoxview, r=chutten,fxview-reviewers,jsudiaman.
Differential Revision: https://phabricator.services.mozilla.com/D222416
2024-09-20 13:58:15 +00:00
Sukhmeet
3ad327de7f Bug 1893013 - Remove browser.firefox-view.search.enabled preference r=kcochrane,fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D211353
2024-06-03 15:12:53 +00:00
Jonathan Sudiaman
bc6869de58 Bug 1883231 - Don't update search results for a stale query in Firefox View. r=nsharpley,fxview-reviewers,places-reviewers,Standard8,sidebar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208946
2024-05-09 13:34:37 +00:00
Jonathan Sudiaman
22ee9cc924 Bug 1887220 - Rework map computations in history r=fxview-reviewers,places-reviewers,sidebar-reviewers,nsharpley,sclements
- Consolidates `historyMapByDate`, `historyMapBySite`, and `searchResults` into one single `historyCache`, which represents all of the visits that should be rendered by the host and what options are currently in place.
- Converts `HistoryController` to a system level module.
- Adds preventative code to account for race conditions in cases during test verification.

Differential Revision: https://phabricator.services.mozilla.com/D207861
2024-04-30 20:03:14 +00:00
Anna Yeddi
3b2c044581 Bug 1884981 - Import history from another browser section on Firefox View History tab would not announce the context for buttons on it. r=fxview-reviewers,kcochrane
Adding a grouping markup on the `import-history-banner`, so the text outside of the focusable CTAs is being announced to a screen reader user.

Note: the heading remains implicit (being only styled to look as such but it is not marked up appropriately an is a generic `<span>`)

Differential Revision: https://phabricator.services.mozilla.com/D206272
2024-04-16 23:57:18 +00:00
Sandor Molnar
417a655e3b Backed out 2 changesets (bug 1884981, bug 1884986) for causing bc failures @ browser_firefoxview.js CLOSED TREE
Backed out changeset ae9729a59875 (bug 1884981)
Backed out changeset 2ad302b112b2 (bug 1884986)
2024-04-16 00:10:30 +03:00
Anna Yeddi
9de30bd59f Bug 1884981 - Import history from another browser section on Firefox View History tab would not announce the context for buttons on it. r=fxview-reviewers,kcochrane
Adding a grouping markup on the `import-history-banner`, so the text outside of the focusable CTAs is being announced to a screen reader user.

Note: the heading remains implicit (being only styled to look as such but it is not marked up appropriately an is a generic `<span>`)

Differential Revision: https://phabricator.services.mozilla.com/D206272
2024-04-15 18:41:00 +00:00
Hanna Jones
f6c7368e07 Bug 1850037 - Part 2: Use moz-button to remove ghost button styles in fxview r=fxview-reviewers,desktop-theme-reviewers,reusable-components-reviewers,kcochrane,mstriemer,dao
Differential Revision: https://phabricator.services.mozilla.com/D187932
2024-04-01 16:08:41 +00:00
Nikki Sharpley
83a82393ab Bug 1883231 - Prevent "no results" from showing if history search is still in progress r=fxview-reviewers,places-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D205756
2024-04-01 13:14:01 +00:00
Nikki Sharpley
e86624e42b Bug 1879926 - Add Lit history component to Sidebar r=fxview-reviewers,desktop-theme-reviewers,dao,kcochrane,fluent-reviewers,jsudiaman,kpatenio
Styling and templates will change as we receive UX specs.

Depends on D202726

Differential Revision: https://phabricator.services.mozilla.com/D204226
2024-03-26 20:09:37 +00:00
Nikki Sharpley
c5dc18eeec Bug 1880540 - Refactor History component functionality into Lit controller r=fxview-reviewers,jsudiaman,sclements,hjones
Extrapolate common history functionality to a controller that can be used across view and sidebar.
This includes the ability to delete from history, visit a link from history, sort by options, search history and format results.

Differential Revision: https://phabricator.services.mozilla.com/D202726
2024-03-18 04:59:43 +00:00
Nikki Sharpley
5357a2cc6f Bug 1884170 - Missing options button icon in history fixed r=fxview-reviewers,kcochrane
Added correct secondary class names to show options button icon in history.

Differential Revision: https://phabricator.services.mozilla.com/D203928
2024-03-07 21:39:31 +00:00
Nikki Sharpley
487579b587 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 19:37:22 +00:00
Stanca Serban
c67b0bdbfc Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
2024-02-28 20:47:18 +02:00
Nikki Sharpley
0fc9567678 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 17:31:17 +00:00
Jonathan Sudiaman
b2cf584037 Bug 1880067 - Typing in Firefox View's history search causes flickering and loss of characters typed r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D202248
2024-02-20 19:51:09 +00:00
Iulian Moraru
3725609047 Backed out changeset 37ef0aa2d2b5 (bug 1857298) for causing bc failures on browser_recentlyclosed_firefoxview.js. 2024-02-20 18:06:25 +02:00
Nikki Sharpley
c6710ccaf5 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-20 14:50:25 +00:00
Jules Simplicio
dbf6341376 Bug 1877793 - Standardize headings 1-3 r=kcochrane,desktop-theme-reviewers,settings-reviewers,fxview-reviewers,dao,hjones,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D200203
2024-02-09 15:15:11 +00:00
Kelly Cochrane
7b849b24e9 Bug 1869765 - Add test coverage for View search telemetry. r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D199578
2024-02-05 17:07:45 +00:00
Nikki Sharpley
7e42a6aec5 Bug 1869765 - Add telemetry to Firefox View search. r=fxview-reviewers,kcochrane
- record frequency and page of search
- record how often show all search results is clicked on recent browsing and from which section
- record how often sort by date or site is clicked on history
- record how many searches are made before clicking on a search result

Differential Revision: https://phabricator.services.mozilla.com/D199285
2024-01-26 19:52:59 +00:00
Nikki Sharpley
17c37d523d Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
- this patch also resolves Bug 1872919 by adding a scroll into view during the `search_synced_tabs_recent_browsing` test

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-18 14:32:33 +00:00
Cristian Tuns
7368009cd2 Backed out changeset 7ec1dad4bca4 (bug 1869836) for causing bc failures in browser_syncedtabs_firefoxview.js CLOSED TREE 2024-01-16 17:36:03 -05:00
Nikki Sharpley
ac2d496df5 Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-16 21:46:47 +00:00
Kelly Cochrane
e55a0a81fb Bug 1873683 - Ensure card collapsed state is preserved on the History page when the view is changed in Fx View r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198164
2024-01-16 14:32:21 +00:00
Norisz Fay
920554c646 Backed out changeset 1ec7a77be890 (bug 1869836) for causing bc and lint failures CLOSED TREE 2024-01-15 19:09:33 +02:00
Nikki Sharpley
9e4b7d5342 Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-15 15:34:34 +00:00
Jonathan Sudiaman
7e33046f35 Bug 1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D196216
2024-01-02 14:56:54 +00:00
Natalia Csoregi
bf7cbfc17e Backed out changeset 8e11ea7d34e4 (bug 1868776) for causing failures on browser_firefoxview_paused.js. CLOSED TREE 2023-12-22 19:10:28 +02:00
Kelly Cochrane
beedd99590 Bug 1868847 - Debounce search in Fx View r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D196970
2023-12-22 16:48:56 +00:00
Jonathan Sudiaman
675b8cf666 Bug 1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D196216
2023-12-22 16:33:33 +00:00
Cristian Tuns
2595ce3656 Backed out changeset 84f22b125d8b (bug 1868847) for causing bc failures in firefoxview-next/browser_syncedtabs_firefoxview_next.js CLOSED TREE 2023-12-21 16:39:51 -05:00
Kelly Cochrane
7681267c72 Bug 1868847 - Debounce search in Fx View r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D196970
2023-12-21 21:03:20 +00:00
Kelly Cochrane
93848884bc Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 21:50:56 +00:00
Noemi Erli
3e946ffda9 Backed out changeset c5f52ea7e7d0 (bug 1857634) for causing failures in test_fxview_tab_list.html 2023-12-12 22:39:33 +02:00
Kelly Cochrane
5870650e8d Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 18:02:04 +00:00
Jonathan Sudiaman
030e6a6131 Bug 1867030 - Hardcode the value for limiting history search results r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D195894
2023-12-08 18:46:26 +00:00
Kelly Cochrane
c3711a4fb7 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-12-04 17:50:04 +00:00
Cosmin Sabou
c4e9d6e90f Backed out changeset e1b32d718ed1 (bug 1859788) for high frequency failures on browser_firefoxview_next_general_telemetry.js. 2023-11-30 20:33:51 +02:00
Kelly Cochrane
844d64ea75 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-11-30 16:54:08 +00:00
Kelly Cochrane
cfe9853751 Bug 1833102 - Add search to Tabs from other devices page in Fx View r=jsudiaman,fluent-reviewers,fxview-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D195004
2023-11-30 14:46:41 +00:00
Norisz Fay
d8c0cbb618 Backed out changeset d3d999e4ff71 (bug 1859788) for causing bc failures on browser_firefoxview_next.js 2023-11-28 20:31:50 +02:00