ExperimentManager.unenroll() is now effectively async when running in a
browser test (because we are now executing SQL queries during
unenrollment) so all cleanup functions that trigger unenrollment are
async as well.
Differential Revision: https://phabricator.services.mozilla.com/D250508
This reverts commit ec5fa1d4c0.
Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"
This reverts commit baa5d72bbd.
Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"
This reverts commit 9604b0a8ae.
Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"
This reverts commit 686c1cf85f.
Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"
This reverts commit a7a4f31251.
Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"
This reverts commit 41bc4d5237.
Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"
This reverts commit 7bb7f82374.
Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"
This reverts commit c22e910235.
Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"
This reverts commit c08e43fc3d.
Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"
This reverts commit 4f2a32d1a4.
Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"
This reverts commit c05f675ddf.
Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"
This reverts commit b10c7de8d0.
Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"
This reverts commit d32c555e37.
Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"
This reverts commit 965887a708.
Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"
This reverts commit 8338860f74.
Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"
This reverts commit d66681f553.
Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"
This reverts commit 530b815cad.
Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"
This reverts commit 813c864381.
The failures were caused by onAccept in addEngine.js being asynchronous. Since promise reactions are not called if the window the promise was created in is closing, onAccept will not finish intermittently. See Bug 1663090.
Differential Revision: https://phabricator.services.mozilla.com/D249964
The browser_quicksuggest_ping_deletionRequest.js test now runs two separate set of tasks,
depending on whether or not context ID rotation is enabled.
The rotation set of tasks can be tested by calling ./mach test with `--setpref browser.contextual-services.contextId.rust-component.enabled=true --setpref browser.contextual-services.contextId.rotation-in-days=1`
Differential Revision: https://phabricator.services.mozilla.com/D248975
We already reject recipes in the RemoteSettingsExperimentLoader if they
have reference features not found in the feature manifest. However,
there are several tests that reference bogus features which should
really be failing. We now refuse to enroll silently in these recipes.
Tests will now fail loudly if they use the `NimbusTestUtils.enroll()` or
`NimbusTestUtils.enrollWithFeatureConfig()` APIs.
Differential Revision: https://phabricator.services.mozilla.com/D248561
We already reject recipes in the RemoteSettingsExperimentLoader if they
have reference features not found in the feature manifest. However,
there are several tests that reference bogus features which should
really be failing. We now refuse to enroll silently in these recipes.
Tests will now fail loudly if they use the `NimbusTestUtils.enroll()` or
`NimbusTestUtils.enrollWithFeatureConfig()` APIs.
Differential Revision: https://phabricator.services.mozilla.com/D248561
We already reject recipes in the RemoteSettingsExperimentLoader if they
have reference features not found in the feature manifest. However,
there are several tests that reference bogus features which should
really be failing. We now refuse to enroll silently in these recipes.
Tests will now fail loudly if they use the `NimbusTestUtils.enroll()` or
`NimbusTestUtils.enrollWithFeatureConfig()` APIs.
Differential Revision: https://phabricator.services.mozilla.com/D248561
Also separates out _setIcon to allow re-using the resize functionality, and simplifies the edit engine dialog to use UserSearchEngine directly.
Differential Revision: https://phabricator.services.mozilla.com/D247571
This reverts commit 0a65c6f1cb.
Revert "Bug 1661664 - Part 3: Add tests for UserSearchEngine favicons. r=search-reviewers,Standard8,settings-reviewers,mossop"
This reverts commit f093133692.
Revert "Bug 1661664 - Part 2: Include favicon when adding custom search engine. r=Standard8"
This reverts commit 8a4a96e8b8.
Revert "Bug 1661664 - Part 1: Add changeIcon method to UserSearchEngine. r=Standard8,settings-reviewers,mossop"
This reverts commit 15a19beb80.
Also separates out _setIcon to allow re-using the resize functionality, and simplifies the edit engine dialog to use UserSearchEngine directly.
Differential Revision: https://phabricator.services.mozilla.com/D247571
This reverts commit 69c71c02b7.
Revert "Bug 1661664 - Part 3: Add tests for UserSearchEngine favicons. r=search-reviewers,Standard8,settings-reviewers,mossop"
This reverts commit ae924c0d7f.
Revert "Bug 1661664 - Part 2: Include favicon when adding custom search engine. r=Standard8"
This reverts commit 9ba1a99736.
Revert "Bug 1661664 - Part 1: Add changeIcon method to UserSearchEngine. r=Standard8,settings-reviewers,mossop"
This reverts commit 0077af7276.
Also separates out _setIcon to allow re-using the resize functionality, and simplifies the edit engine dialog to use UserSearchEngine directly.
Differential Revision: https://phabricator.services.mozilla.com/D247571
