corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,658 Commits 1 Branch 0 Tags
45be3e630f72b0b25f3186e3d84694d77357d903
Commit Graph

342 Commits

Author SHA1 Message Date
James Teow
5b1655eb9b Bug 1976102 - r=mak,urlbar-reviewers a=RyanVM 
Differential Revision: https://phabricator.services.mozilla.com/D257093
 2025-07-23 16:10:41 +00:00
James Teow
3c671a8628 Bug 1970997 - Add origin validation check for persisted search terms - r=urlbar-reviewers,mak a=pascalc 
Unable to reproduce the original issue, but adding a safeguard
to ensure search terms only persist when the current URI matches
the origin of the URI used to load the page.

Differential Revision: https://phabricator.services.mozilla.com/D253982
 2025-07-09 10:38:06 +00:00
Mark Banner
8a3c99b9cb Bug 1966662 - Migrate most of toolkit/components/search to moz-src uris. r=search-reviewers,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D249563
 2025-05-17 17:38:49 +00:00
Mark Banner
0362463c59 Bug 1964675 - Fix various jsdoc type definitions across urlbar code. r=urlbar-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D247921
 2025-05-14 01:25:11 +00:00
Daisuke Akatsuka
5f6608b27e Bug 1960900: Not use isUnifiedSearchButtonAvailable upon reverting urlbar r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D245850
 2025-05-07 02:47:26 +00:00
Daisuke Akatsuka
3bda5e2fd3 Bug 1960668: Make Unified Search Button unavailable if the page was loaded as background r=tabbrowser-reviewers,daleharvey,dao 
Differential Revision: https://phabricator.services.mozilla.com/D245714
 2025-05-05 12:46:06 +00:00
Sam Foster
c14accb225 Bug 1926118 - Fix the perf tests for the urlbar breakout. r=desktop-theme-reviewers,urlbar-reviewers,jteow,emilio 
- Remove the 'browser.urlbar.disableExtendForTests' pref codepath.
- Fix the rect filters to reflect the extent of re-paints we expect when the urlbar opens and the
  results repopulate

Differential Revision: https://phabricator.services.mozilla.com/D226414
 2025-04-23 21:27:57 +00:00
Moritz Beier
5d41f55f7f Bug 1915252 - Add telemetry for use of shift-click/enter in the search bar & address bar. r=urlbar-reviewers,scunnane,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D245704
 2025-04-22 16:57:19 +00:00
Moritz Beier
0817f89625 Bug 1788088 - Correctly record SERP sources when searches are opened in new tabs. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D243793
 2025-04-22 16:56:56 +00:00
smolnar
bd53552bfd Backed out changeset fd4dea70596b (bug 1788088) for causing bc failures @ browser_search_telemetry_sources.js CLOSED TREE 2025-04-22 13:59:49 +03:00
Moritz Beier
b7b73bf476 Bug 1788088 - Correctly record SERP sources when searches are opened in new tabs. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D243793
 2025-04-22 09:52:07 +00:00
Dão Gottwald
ff54df4c81 Bug 1957448 - Disabled context menu within UrlbarView rather than the #urlbar div. r=urlbar-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D245055
 2025-04-11 16:14:06 +00:00
Eric Chen
38b476436b Bug 1958142 - Disable event handling and remove background colours for URL bars in taskbar tab windows r=dao,desktop-theme-reviewers,urlbar-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D244279
 2025-04-10 20:22:52 +00:00
Goloman Adrian
ba26c8e947 Backed out changeset 7114f85e40e4 (bug 1958142) for causing bc failures @browser_ext_themes_autocomplete_popup.js. CLOSED TREE 2025-04-10 22:17:37 +03:00
Eric Chen
36a31a5531 Bug 1958142 - Disable event handling and remove background colours for URL bars in taskbar tab windows r=dao,desktop-theme-reviewers,urlbar-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D244279
 2025-04-10 17:47:46 +00:00
Daisuke Akatsuka
18acc09b5f Bug 1957630: Restore Unified Search Button availability even after switching tab r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D244709
 2025-04-10 02:19:34 +00:00
Iulian Moraru
ff3b90d82d Backed out changeset 030feec729dd (bug 1788088) for causing bc failures on browser_new_tab_insert_position.js. CLOSED TREE 2025-04-07 18:00:10 +03:00
Moritz Beier
274063e54e Bug 1788088 - Correctly record SERP sources when searches are opened in new tabs. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D243793
 2025-04-07 13:37:02 +00:00
Stephanie Cunnane
f5c0b3c735 Bug 1953239 - Stop calling BrowserSearchTelemetry.recordSearchSuggestionSelectionMethod from address bar code. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D243196
 2025-03-31 16:13:37 +00:00
Marco Bonardo
231564e327 Bug 1952213. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D242155
 2025-03-20 09:47:06 +00:00
Francesco Lodolo (:flod)
0f4b702c89 Bug 1955004 - Avoid generating Fluent IDs at run-time in address bar, r=urlbar-reviewers,adw 
Also removed unused string in browser.ftl

Differential Revision: https://phabricator.services.mozilla.com/D242192
 2025-03-19 18:21:15 +00:00
Jason Prickett
d51e46b708 Bug 1953129 - Cap totalSearches pref at 100 r=omc-reviewers,urlbar-reviewers,mviar,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D241671
 2025-03-18 23:08:15 +00:00
Moritz Beier
a1b188cce4 Bug 1817233 - Pasting urls with linebreaks into urlbar does not set valueIsTyped. r=urlbar-reviewers,mak 
Differential Revision: https://phabricator.services.mozilla.com/D240355
 2025-03-05 15:01:41 +00:00
Emilio Cobos Álvarez
831e0b767e Bug 1951284 - Fix a race condition in UrlbarInput.startLayoutExtend(). r=urlbar-reviewers,jteow 
hasAttribute("breakout") isn't the right check for "do we support
breakout", since we might be in the middle of recomputing the breakout
dimensions (which removes the attribute temporarily).

Use this.#allowBreakout instead.

Differential Revision: https://phabricator.services.mozilla.com/D240111
 2025-03-05 12:37:11 +00:00
Mark Banner
878a5d5415 Bug 1951652 - Convert browser/components/search/ modules to use moz-src uris. r=search-reviewers,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D240333
 2025-03-05 09:24:37 +00:00
Gijs Kruitbosch
8c703a7db2 Bug 1951072 - switch reader mode modules to use moz-src URLs, r=firefox-desktop-core-reviewers ,sync-reviewers,urlbar-reviewers,mossop,jteow,markh 
Differential Revision: https://phabricator.services.mozilla.com/D240004
 2025-03-04 21:20:35 +00:00
Daisuke Akatsuka
dee672b38c Bug 1936557: Remove delayUpdate parameter and #searchInitComplete flag r=search-reviewers,daleharvey,Standard8 
Depends on D239701

Differential Revision: https://phabricator.services.mozilla.com/D239702
 2025-02-26 19:50:51 +00:00
Daisuke Akatsuka
a25636e1a5 Bug 1936557: Wait to update placeholder/icon until user interaction on booting r=sessionstore-reviewers,daleharvey,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D239701
 2025-02-26 19:50:50 +00:00
Marco Bonardo
b1c63066f1 Bug 1945422 - Change Ctrl+Enter canonization to Cmd+Enter on MacOS, due to new Sequoia context menu shortcut. r=daisuke,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238060
 2025-02-20 14:06:22 +00:00
Goloman Adrian
89bb435086 Backed out changeset 6c1483bf5f26 (bug 1945422) for causing bc failures @browser_searchSuggestions.js. CLOSED TREE 2025-02-19 23:38:47 +02:00
Marco Bonardo
3c196e2f8a Bug 1945422 - Change Ctrl+Enter canonization to Cmd+Enter on MacOS, due to new Sequoia context menu shortcut. r=daisuke,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238060
 2025-02-19 14:45:20 +00:00
Dale Harvey
e7bd680c67 Bug 1947742 - Prevent search actions overriding other actions. r=dao,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238407
 2025-02-17 21:48:21 +00:00
Meg Viar
7ecf60304b Bug 1946517 - Prevent URL bar from showing through preonboarding modal UI r=nalexander,emilio,urlbar-reviewers,adw 
Addresses issue where the URL bar appeared through the UI of the preonboarding modal (see screenshot in bug).
- Show the preonboarding after the "MozAfterPaint" event fires for the browser chrome.
- If for some reason the "MozAfterPaint" event never fires of the event listener was added after it fired, show the modal after 1 second as a fallback.

Differential Revision: https://phabricator.services.mozilla.com/D237100
 2025-02-10 22:46:06 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-10 15:24:32 +00:00
Stephanie Cunnane
c9ddaf4b3d Bug 1932716 - Remove legacy urlbar.tips scalar and Glean urlbar.tips labeled counter. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D236590
 2025-02-07 14:53:12 +00:00
Emilio Cobos Álvarez
ab23c6cf79 Bug 1945451 - Avoid breaking out the urlbar while in customize mode. r=dao,urlbar-reviewers 
Density changes called directly into the urlbar input to update the
breakout. But when customizing the urlbar shouldn't break out.

That means that this code is mostly for when density is changed via
another window, or direct pref changes I guess.

Differential Revision: https://phabricator.services.mozilla.com/D236539
 2025-02-04 19:42:04 +00:00
Moritz Beier
152f732f88 Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235597
 2025-02-04 11:07:12 +00:00
Moritz Beier
6c0a5096a8 Bug 1880913 - Part 1: Move urlbar placeholder handling from BrowserSearch to UrlbarInput. r=urlbar-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D235595
 2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-04 08:25:28 +00:00
James Teow
e18fba3011 Bug 1941467 - Allow Scotch Bonnet pref to toggle Persisted Search preference visibility - r=daleharvey,settings-reviewers,mossop 
I also removed the Nimbus feature since there are no future plans to
run experiments solely on this feature.

Differential Revision: https://phabricator.services.mozilla.com/D234135
 2025-01-16 16:54:14 +00:00
Sandor Molnar
f776616d69 Backed out 2 changesets (bug 1297008) for causing M-vt failures @ browser_link_in_tab_title_and_url_prefilled_blank_page.js CLOSED TREE 
Backed out changeset ce85088a9340 (bug 1297008)
Backed out changeset cd90c0935331 (bug 1297008)
 2025-01-10 01:14:53 +02:00
Emma Zuehlcke
5ca6a4bb43 Bug 1297008, r=mak,Gijs,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226694
 2025-01-09 17:49:09 +00:00
Daisuke Akatsuka
82f19238e9 Bug 1936545: Close search mode switcher popup when opening new tab r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D233470
 2025-01-08 22:06:49 +00:00
Dale Harvey
21f91aa3cb Bug 1938036 - Dont maintain user input when selecting contextual engine. r=daisuke,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232946
 2025-01-08 12:55:19 +00:00
Yazan Al Macki
9724bc1d84 Bug 1936278 - Prevent search mode chiclet from being dismissed when clicking in page content. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D232365
 2024-12-25 04:08:06 +00:00
Daisuke Akatsuka
abd3414bd9 Bug 1937363: Show/Focus Unified Search Button when P&S icon group gets focus r=desktop-theme-reviewers,urlbar-reviewers,dao,tabbrowser-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D232160
 2024-12-24 04:02:25 +00:00
Cristian Tuns
568f68ebab Backed out changeset de5d3f6c2e3e (bug 1936278) for causing bc failures in browser_searchModeSwitcher_emptyInput.js CLOSED TREE 2024-12-19 17:57:30 -05:00
Yazan Al Macki
82b17701af Bug 1936278 - Prevent search mode chiclet from being dismissed when clicking in page content. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D232365
 2024-12-19 19:38:50 +00:00
Daisuke Akatsuka
aafffaa930 Bug 1936090: Show/Hide Unified Search Button dependent on pageproxystate r=desktop-theme-reviewers,tabbrowser-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D231636
 2024-12-11 21:35:57 +00:00