Commit Graph

675 Commits

Author SHA1 Message Date
Ryan VanderMeulen
99c859a252 Revert "Bug 1973189 - Enable context menu for input elements in History and Synced Tabs. a=RyanVM DONTBUILD"
This reverts commit a2c5175274.
2025-09-30 23:58:18 +00:00
Jonathan Sudiaman
a2c5175274 Bug 1973189 - Enable context menu for input elements in History and Synced Tabs. a=RyanVM DONTBUILD
Original Revision: https://phabricator.services.mozilla.com/D263441

Differential Revision: https://phabricator.services.mozilla.com/D266649
2025-09-29 21:01:39 +00:00
Michael Kaply
af95c4ca67 Bug 1948934 - Don't show new sidebar in kiosk mode. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D254001

Differential Revision: https://phabricator.services.mozilla.com/D257007
2025-07-12 13:30:33 +00:00
Sam Foster
b42b497a1f Bug 1922777 - Retain the last-used sidebar view/command id even when the panel is closed. a=pascalc
Original Revision: https://phabricator.services.mozilla.com/D254261

Differential Revision: https://phabricator.services.mozilla.com/D256867
2025-07-11 08:23:07 +00:00
Beth Rennie
3650082401 Bug 1956080 - Use async experiment cleanup in browser/components/sidebar r=sidebar-reviewers,sclements
ExperimentManager.unenroll() is now effectively async when running in a
browser test (because we are now executing SQL queries during
unenrollment) so all cleanup functions that trigger unenrollment are
async as well.

Differential Revision: https://phabricator.services.mozilla.com/D250555
2025-05-22 21:46:00 +00:00
agoloman
63c83deb26 Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
This reverts commit ec5fa1d4c0.

Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"

This reverts commit baa5d72bbd.

Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"

This reverts commit 9604b0a8ae.

Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"

This reverts commit 686c1cf85f.

Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"

This reverts commit a7a4f31251.

Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"

This reverts commit 41bc4d5237.

Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"

This reverts commit 7bb7f82374.

Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"

This reverts commit c22e910235.

Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"

This reverts commit c08e43fc3d.

Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"

This reverts commit 4f2a32d1a4.

Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"

This reverts commit c05f675ddf.

Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"

This reverts commit b10c7de8d0.

Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"

This reverts commit d32c555e37.

Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"

This reverts commit 965887a708.

Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"

This reverts commit 8338860f74.

Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"

This reverts commit d66681f553.

Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"

This reverts commit 530b815cad.

Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"

This reverts commit 813c864381.
2025-05-21 04:49:28 +00:00
hannajones
d32c555e37 Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D249172
2025-05-21 03:54:32 +00:00
mark
dc89961c6d Bug 1949259 - Enforce valid HTML in HTML for Lit templates r=frontend-codestyle-reviewers,mtigley,credential-management-reviewers,fxview-reviewers,sidebar-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D245591
2025-05-19 16:00:42 +00:00
Gijs Kruitbosch
8000e1a525 Bug 1966155 - use moz-src for sidebar modules, r=sidebar-reviewers,zombie,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D249098
2025-05-16 17:55:28 +00:00
Kelly Cochrane
6dde4e5cbf Bug 1965825 - Don't disarm mouseEnterTask on popupshown in browser-sidebar.js r=sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D249602
2025-05-15 20:08:10 +00:00
Kelly Cochrane
b9f3692262 Bug 1965742 - Don't add/remove MosPosTracker listeners for tab preview popups r=sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D248958
2025-05-12 20:59:25 +00:00
Kelly Cochrane
f8a2979106 Bug 1957017 - Prevent sidebar from collasing when context menu is open and expand on hover is enabled r=sidebar-reviewers,nsharpley,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D247793
2025-05-09 16:00:28 +00:00
Serban Stanca
769229ac8f Revert "Bug 1957017 - Prevent sidebar from collasing when context menu is open and expand on hover is enabled r=sidebar-reviewers,nsharpley,jsudiaman" for causing mochitests failures in browser_sidebar_expand_on_hover.js.
This reverts commit 92704055ca.
2025-05-08 23:00:21 +00:00
Kelly Cochrane
92704055ca Bug 1957017 - Prevent sidebar from collasing when context menu is open and expand on hover is enabled r=sidebar-reviewers,nsharpley,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D247793
2025-05-08 21:37:40 +00:00
Fred Chasen
32bb998a69 Bug 1961955 - Clean up Review Checker sidebar panel. r=shopping-reviewers,fluent-reviewers,sidebar-reviewers,kpatenio,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D246993
2025-05-06 02:24:28 +00:00
Kelly Cochrane
0c164b52d8 Bug 1964371 - Fix for intermittent browser/components/sidebar/tests/browser/browser_sidebar_expand_on_hover.js r=sidebar-reviewers,nsharpley,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D247783
2025-05-05 23:52:01 +00:00
Kelly Cochrane
40832e607b Bug 1941189 - Make vertical pinned tabs container adjustable r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,jsudiaman,nsharpley,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D246484
2025-05-05 09:13:55 +00:00
Daniel Thorn
f4d3de73b2 Bug 1959483 - Port tests from ExperimentFakes and ExperimentTestUtils to NimbusTestUtils in browser/components/sidebar r=nimbus-reviewers,sidebar-reviewers,beth,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D247012
2025-05-01 22:06:21 +00:00
Alexandru Marc
b06c4c0583 Revert "Bug 1941189 - Make vertical pinned tabs container adjustable r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,jsudiaman,nsharpley,sfoster" for causing bc failures @ browser_resize_sidebar.js
This reverts commit 5c1d9210e4.
2025-05-01 21:42:02 +00:00
Kelly Cochrane
5c1d9210e4 Bug 1941189 - Make vertical pinned tabs container adjustable r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,jsudiaman,nsharpley,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D246484
2025-05-01 20:52:57 +00:00
Tim Giles
134dc6c03a Bug 1936648 - Replace searchfield-cancel with close-12 icon. r=desktop-theme-reviewers,fxview-reviewers,tabbrowser-reviewers,reusable-components-reviewers,omc-reviewers,emilio,aminomancer,hjones
Replaces the searchfield-cancel icon with the close-12 icon so that we
can style the background-color of the icon as needed.

Since we need close-12.svg to be content accessible, I needed to move
the icon to layout/style/res and add it as a content accessible file.
This resulted in replacing the existing uses of
chrome://global/skin/icons/close-12.svg with the new resource URL,
resource://content-accessible/close-12.svg.

Differential Revision: https://phabricator.services.mozilla.com/D243564
2025-05-01 15:24:34 +00:00
Sam Foster
3bc128efc2 Bug 1905958 - Add a JSON schema for browser session state and a way to validate against it. r=sessionstore-reviewers,sidebar-reviewers,nsharpley,dwalker
- Add the schema itself with definitions for the various data structures the serialized browser
  session state contains
- Add means of validating the current state against the schema with a new SessionStore.vaidateState
  method
- Add a smoke test to the schema by validating against sample session restore document
- Fix an issue in SidebaState which was returning undefined for some property values which isn't valid JSON

Differential Revision: https://phabricator.services.mozilla.com/D246163
2025-05-01 15:21:00 +00:00
Jonathan Sudiaman
fe8d37e73d Bug 1943147 - Add close button on sidebar of addon when sidebar.revamp = true r=sidebar-reviewers,desktop-theme-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D246987
2025-05-01 02:27:27 +00:00
Beth Rennie
084082a969 Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/sidebar r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D246154
2025-04-30 04:39:01 +00:00
Iulian Moraru
6951b54b38 Backed out changeset 646fc6fe1859 (bug 1961955) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2025-04-30 04:33:43 +03:00
Fred Chasen
b099c87ad0 Bug 1961955 - Clean up Review Checker sidebar panel. r=shopping-reviewers,fluent-reviewers,sidebar-reviewers,kpatenio,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D246993
2025-04-29 23:59:01 +00:00
Nikki Sharpley
b775b7a6df Bug 1896421 - Clean up extra windows and common functions in sidebar test suite r=sidebar-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D246628
2025-04-28 14:33:44 +00:00
Sam Foster
2acb53bb57 Bug 1961190 - Only set initial sidebar launcher visibility to a default when its never been seen. r=sidebar-reviewers,kcochrane,sclements
Differential Revision: https://phabricator.services.mozilla.com/D246009
2025-04-25 19:33:41 +00:00
Goloman Adrian
17befc4396 Backed out changeset 9838e2ffe509 (bug 1961190) for causing xpcshell failures @test_sidebar_state.js. CLOSED TREE 2025-04-25 21:31:22 +03:00
Sam Foster
5c9f87dc15 Bug 1961190 - Only set initial sidebar launcher visibility to a default when its never been seen. r=sidebar-reviewers,kcochrane,sclements
Differential Revision: https://phabricator.services.mozilla.com/D246009
2025-04-25 16:59:53 +00:00
Nikki Sharpley
c6a32ad537 Bug 1961065 - Fix perma failing browser_history_sidebar.js r=sidebar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D246105
2025-04-24 15:15:54 +00:00
Jonathan Sudiaman
dd5f922a22 Bug 1959268 - Implement keyboard navigation for History while sorting by "Date and site" or "Last visited" r=sidebar-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D245981
2025-04-23 22:08:26 +00:00
Jonathan Sudiaman
da69f0ea90 Bug 1959272 - Tweak styling for History while sorting by Date and site r=sidebar-reviewers,reusable-components-reviewers,nsharpley,mstriemer
- Remove bold styles from inner headings.
- Reduce gaps and remove borders from inner cards.
- Align indentations between outer headings, inner headings, and visits.

Differential Revision: https://phabricator.services.mozilla.com/D245435
2025-04-23 16:54:30 +00:00
Emilio Cobos Álvarez
0c8b2bd7f8 Bug 1960926 - More explicitly wait for sidebar update. r=sidebar-reviewers,kcochrane
This is the front-end side fix. We might want to change the rendering
code too, I'm still investigating if this is web observable.

Differential Revision: https://phabricator.services.mozilla.com/D246131
2025-04-22 16:51:17 +00:00
smolnar
671d93ed3b Backed out changeset 5a2b98798636 (bug 1960926) for causing bc failures @ browser_customize_sidebar.js CLOSED TREE 2025-04-22 18:37:17 +03:00
Emilio Cobos Álvarez
02a342eb75 Bug 1960926 - More explicitly wait for sidebar update. r=sidebar-reviewers,kcochrane
This is the front-end side fix. We might want to change the rendering
code too, I'm still investigating if this is web observable.

Differential Revision: https://phabricator.services.mozilla.com/D246131
2025-04-22 13:52:06 +00:00
Norisz Fay
adf5071a37 Backed out changeset 049f31f0ba6c (bug 1957425) as requested by developer 2025-04-21 23:00:20 +03:00
Jonathan Sudiaman
47d00b42ba Bug 1957936 - Add state management documentation to Firefox Source Docs r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D245731
2025-04-18 19:44:36 +00:00
Kelly Cochrane
468df0e1fe Bug 1957904 - Prevent sidebar resize below minimum width when expand on hover is enabled r=sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D245974
2025-04-18 16:59:26 +00:00
Nikki Sharpley
9dc7dba546 Bug 1953900 - Update "Forget Site Data" prompt to new dialog r=sidebar-reviewers,fluent-reviewers,places-reviewers,bolsson,kcochrane,mak
Depends on D241874

Differential Revision: https://phabricator.services.mozilla.com/D245463
2025-04-18 16:23:02 +00:00
smolnar
e373a72183 Backed out changeset 1044d79e4efd (bug 1953900) for causing bc failures @ browser_history_sidebar CLOSED TREE 2025-04-17 17:42:56 +03:00
Nikki Sharpley
d1a21c0c14 Bug 1953900 - Update "Forget Site Data" prompt to new dialog r=sidebar-reviewers,fluent-reviewers,places-reviewers,bolsson,kcochrane,mak
Depends on D241874

Differential Revision: https://phabricator.services.mozilla.com/D245463
2025-04-17 13:54:46 +00:00
Nikki Sharpley
1c7e0d81c6 Bug 1919475 - Update context menu for History entries r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,places-reviewers,bolsson,Standard8,kcochrane
- added "open in new tab", "open in new container tab", "bookmark page", "clear all data for website".
- updated "delete page from history"

Differential Revision: https://phabricator.services.mozilla.com/D241874
2025-04-16 18:22:15 +00:00
Micah Tigley
beab2573ce Bug 1957425 - Add sidebar.newTool.migration.passwords pref for visibility in sidebar launcher. r=sidebar-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D243682
2025-04-15 14:30:04 +00:00
Micah Tigley
44634783bd Bug 1956952 - Add a probe for when CPM is enabled in sidebar customization panel. r=rsafaeian,sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D243389
2025-04-15 14:30:04 +00:00
Ed Lee
26865b29fa Bug 1943208 - Allow callout primary CTA to flip multiple prefs and open the chatbot panel r=sidebar-reviewers,sclements
Reopen panel if one was open when toggling revamp and still available. This avoids race condition of trying to open chatbot and flip revamp at the same time.

Differential Revision: https://phabricator.services.mozilla.com/D245367
2025-04-14 14:23:39 +00:00
Rob Wu
62248a8bcc Bug 1953004 - Run test-manifest-toml --fix on all toml files in the trees r=credential-management-reviewers,places-reviewers,desktop-theme-reviewers,Standard8,devtools-reviewers,hjones,jmaher,jdescottes,dimi,necko-reviewers,sidebar-reviewers,jsudiaman,kershaw
This diff was generated as follows:

List all toml files in the tree:

`find * -name '*.toml' > /tmp/toml`

Manually edited /tmp/toml to drop non-relevant entries (objdir).

Ran the toml linter for all files:

`cat /tmp/toml | xargs ./mach lint -l test-manifest-toml --fix`

Differential Revision: https://phabricator.services.mozilla.com/D240948
2025-04-14 08:30:13 +00:00
Nikki Sharpley
fb02ebbfdb Bug 1959902 - Ensure close button on panels is reachable by keyboard r=sidebar-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D245298
2025-04-11 21:32:18 +00:00
Norisz Fay
db5fc6c027 Backed out changeset 93c537af6ab8 (bug 1919475) for causing multiple bc failures CLOSED TREE 2025-04-12 01:10:21 +03:00
Nikki Sharpley
5b6624cacf Bug 1919475 - Update context menu for History entries r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,places-reviewers,bolsson,Standard8,kcochrane
- added "open in new tab", "open in new container tab", "bookmark page", "clear all data for website".
- updated "delete page from history"

Differential Revision: https://phabricator.services.mozilla.com/D241874
2025-04-11 19:33:04 +00:00