Commit Graph

557 Commits

Author SHA1 Message Date
Bogdan Tara
2c040ca027 Backed out 2 changesets (bug 1510569) for crashtests/1419902.html crashes CLOSED TREE
Backed out changeset fc0ae629221a (bug 1510569)
Backed out changeset 97f6ac273b5d (bug 1510569)
2019-05-03 03:48:15 +03:00
Barret Rennie
48a2bc08bb Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124
2019-05-02 23:35:02 +00:00
Bogdan Tara
c203974769 Backed out 2 changesets (bug 1510569) for crashtests/1419902.html failures CLOSED TREE
Backed out changeset 13c5249d66a7 (bug 1510569)
Backed out changeset a6ad4039d785 (bug 1510569)
2019-05-02 21:30:20 +03:00
Barret Rennie
2e21ffaa02 Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124
2019-05-02 17:00:51 +00:00
Mike Conley
f060772432 Bug 1533955 - Show some UI to indicate that a subframe has crashed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D29238
2019-05-01 20:05:24 +00:00
Emilio Cobos Álvarez
28cf34ed8c Bug 1546019 - When a focused browser changes remoteness, make sure to activate the remote browser if needed. r=qdot
Not quite sure what's a good way to add a test for this... Ideas?

Differential Revision: https://phabricator.services.mozilla.com/D29104
2019-04-29 20:06:22 +00:00
Ryan Hunt
c6e302039f Bug 1534395 - Rename nsITabParent to nsIRemoteTab. r=nika,mconley
nsITabParent is exposed to frontend code and is generally used as a representation of a remote tab. We could just rename the interface to nsIBrowserParent and worry about it later, but I think it's better to rename the interface to nsIRemoteTab so that we can later work on splitting the interface away from the PBrowser protocol.

Note: Some frontend code refers to a TabParentId. This commit renames this to RemoteTabId. We need to figure out the purpose of TabId with fission.

Differential Revision: https://phabricator.services.mozilla.com/D28132
2019-04-09 15:59:37 -05:00
Nika Layzell
32a1c47e61 Bug 1542791 - Part 2: Add a [F] marker to fission-enabled tabs, r=mconley
This should make it easier to tell whether a particular window is
fission-enabled as testing with fission enabled improves.

Differential Revision: https://phabricator.services.mozilla.com/D26561
2019-04-17 00:53:30 +00:00
Jonathan Kingston
7af9989152 Bug 1479433 - Changing icons and colors for containers to be class based. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D24918
2019-04-10 11:19:00 +00:00
Dão Gottwald
38955d1627 Bug 1542299 - Remove Array.unshift usage from tabbrowser.js. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D26685
2019-04-09 10:30:39 +00:00
Dão Gottwald
b36ed16b82 Bug 1542298 - Remove Array.filter usage from tabbrowser.js. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D26688
2019-04-09 10:48:27 +00:00
Dão Gottwald
983a91a78d Bug 1504775 - Ensure externally provided addTab index is within bounds. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D26296
2019-04-05 17:23:07 +00:00
Brian
83c5bc6d2e Bug 1523763 - Move tab context menu strings to FTL file loaded on-demand. r=Gijs,flod
Moved tab context menu out of browser.dtd to browser.xul except for sendPageToDevice, sendLinkToDevice, moveTabOptions, moveSelectedTabOptions, undoCloseTab. Not sure if tabbrowser.js and tabbrowser.xul are working as intended.

Differential Revision: https://phabricator.services.mozilla.com/D19312
2019-03-29 14:55:12 +00:00
sakshaat
8b67bd2a1d Bug 1517483 - Get rid of nsIScriptSecurityManager::IsSystemPrincipal r=bzbarsky
Replaced instances of callers in both C++ and JS files to query the state from the principal directly.

Differential Revision: https://phabricator.services.mozilla.com/D22532
2019-03-24 20:36:25 +00:00
Gijs Kruitbosch
dd378f1bce Bug 1530500 - remove obsolete browser swapping flags, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D24114
2019-03-20 08:49:04 +00:00
Gijs Kruitbosch
e7f95a8c30 Bug 1353013 - allow using the preloaded new tab page in private windows, too, r=dthayer
This didn't use to work and was disabled in
https://bugzilla.mozilla.org/show_bug.cgi?id=1195981 . I expect my changes in
https://bugzilla.mozilla.org/show_bug.cgi?id=1427186 fixed the issue. It works
in my testing, anyway.

Differential Revision: https://phabricator.services.mozilla.com/D21127
2019-03-19 17:29:34 +00:00
Gijs Kruitbosch
866709f525 Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126
2019-03-19 17:29:14 +00:00
shindli
244d2d9547 Backed out 3 changesets (bug 1353013) for a11y failures in accessible/tests/mochitest/relations/test_tabbrowser.xul CLOSED TREE
Backed out changeset af8bce2330e9 (bug 1353013)
Backed out changeset a3d1302b06c0 (bug 1353013)
Backed out changeset 976afd1adf84 (bug 1353013)
2019-03-18 18:21:16 +02:00
Gijs Kruitbosch
fa62c2b6c0 Bug 1353013 - allow using the preloaded new tab page in private windows, too, r=dthayer
This didn't use to work and was disabled in
https://bugzilla.mozilla.org/show_bug.cgi?id=1195981 . I expect my changes in
https://bugzilla.mozilla.org/show_bug.cgi?id=1427186 fixed the issue. It works
in my testing, anyway.

Differential Revision: https://phabricator.services.mozilla.com/D21127
2019-03-12 14:34:24 +00:00
Gijs Kruitbosch
6a19ff891f Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126
2019-03-12 14:34:04 +00:00
Thomas Nguyen
e5f8eebf98 Bug 1528695 - Part 2 : Use referrerInfo in openWindow, contextmenu and openLinkIn r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D21911
2019-03-15 05:10:17 +00:00
Kyle Machulis
4e9160ad90 Bug 1522713 - Don't change node binding to tree when updating remoteness; r=nika
Since we now have a method on nsFrameLoaderOwner/MozFrameLoaderOwner
that can update remoteness, we should no longer need to unbind and
rebind browser elements to the tree to change their remoteness
attributes. We can just call the method and have the Frameloaders
rebuilt in the backend.

We're still getting some test breakage in Marionette and browser
chrome with this patch. Putting this behind a pref so the fission
team can still work with it while the tests are being fixed.

Depends on D22790

Differential Revision: https://phabricator.services.mozilla.com/D22791
2019-03-14 00:52:02 +00:00
Kyle Machulis
84c4937745 Bug 1524709 - Remove aShouldBeRemote from updateBrowserRemoteness; r=nika
Just set the RemoteType in the options object argument, instead of
doubling up the information.

Differential Revision: https://phabricator.services.mozilla.com/D23250
2019-03-14 00:51:30 +00:00
James Willcox
b93b9fa90d Bug 1524992 - Treat command line URIs as external r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D20890
2019-03-12 20:20:58 +00:00
Mark Striemer
7d423144d2 Bug 1520068 - Handle more system shortcuts in add-on shortcuts ui r=dao
This centralizes the checks for system shortcuts into ShortcutUtils.jsm, so
they can be checked for in the add-on shortcut assignment UI. It also
introduces a mechanism for skipping the system event handler if it is already
being handled by the shortcuts UI.

Differential Revision: https://phabricator.services.mozilla.com/D17586
2019-03-08 18:32:20 +00:00
arthur.iakab
f17d4fd122 Merge inbound to mozilla-central a=merge 2019-03-07 23:58:42 +02:00
Dão Gottwald
b36158466e Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D22474
2019-03-07 11:47:26 +00:00
Nikki S
d19c0b6443 Bug 1484071 - Crop large data URLs before displaying them in the status bar r=Felipe
This commit provides a simple fix to reduce the time spent
rendering larger data URLs (such as large screenshots) in
the status panel when the Highlights tab is hovered over.
By limiting the number of characters displayed, this
decreases the time spent in the _showDelayed function.

Differential Revision: https://phabricator.services.mozilla.com/D21593
2019-03-06 14:09:31 +00:00
Doug Thayer
7192f70ab5 Bug 1532841 - Don't preopen pinned tabs for private browser window r=Gijs
If we're opening a private browsing window on startup, we won't run the
session restore code, and thus we won't end up cleaning up the preopened
tabs. This raises the question: are there other scenarios where we won't
run restoreWindow at all? Eyeballing the code I think not, but I'm not
sure.

Depends on D22195

Differential Revision: https://phabricator.services.mozilla.com/D22216
2019-03-06 11:51:55 +00:00
Brindusan Cristian
c85bc9d0dd Backed out changeset 6890499eb5d1 (bug 1484071) for ESlint failure at tabbrowser.js. CLOSED TREE 2019-03-06 01:42:21 +02:00
Nikki S
fc01c4d0e4 Bug 1484071 - Crop large data URLs before displaying them in the status bar r=Felipe
This commit provides a simple fix to reduce the time spent
rendering larger data URLs (such as large screenshots) in
the status panel when the Highlights tab is hovered over.
By limiting the number of characters displayed, this
decreases the time spent in the _showDelayed function.

Differential Revision: https://phabricator.services.mozilla.com/D21593
2019-03-05 22:11:37 +00:00
Andreea Pavel
7abc387e2b Backed out 3 changesets (bug 1524992) for valgrind failures on a CLOSED TREE
Backed out changeset face9d1e8868 (bug 1524992)
Backed out changeset ae1e20a595c4 (bug 1524992)
Backed out changeset b0b9322c7a59 (bug 1524992)
2019-03-05 01:36:59 +02:00
James Willcox
76ac6ea731 Bug 1524992 - Treat command line URIs as external r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D20890
2019-03-04 22:06:30 +00:00
Doug Thayer
babdb4405d Bug 1442694 - Preopen pinned tabs before session restore r=Gijs
When we open firefox with pinned tabs, we first paint a window with
one tab open, and then that tab gets displaced after the pinned tabs
come in. This aims to ensure that our first paint contains the
pinned tab, so that we don't have tabs moving around after first
paint.

MozReview-Commit-ID: GC1y6NlgLTd

Differential Revision: https://phabricator.services.mozilla.com/D18742
2019-03-01 18:28:53 +00:00
Dão Gottwald
34334eec7e Backed out changeset 59c8fffe9e41 (bug 1442694) 2019-03-07 11:41:29 +01:00
Johann Hofmann
fe0768a7ad Bug 1525267 - Move auth prompt rate limiting to nsIAuthPrompt2.promptAuth. r=MattN
This also changes the name of 'canceledAuthenticationPromptCounter' to account for the
fact that we no longer count up when the prompt was cancelled, but when it was shown.

Differential Revision: https://phabricator.services.mozilla.com/D21680
2019-03-01 15:24:19 +00:00
Oriol Brufau
a4f73f9ae1 Bug 1521923 - Preserve lazyness of the first inactive tab moved into a new window. r=jaws CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D20100
2019-02-28 23:21:40 +00:00
Narcis Beleuzu
21ac2fde9f Backed out changeset 51ffa59f1488 (bug 1521923) for WR failures on outline-013.html . CLOSED TREE 2019-03-01 06:25:27 +02:00
Oriol Brufau
d0e705f76d Bug 1521923 - Preserve lazyness of the first inactive tab moved into a new window. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D20100
2019-02-28 23:21:40 +00:00
Gabriele Svelto
3e3e8f05ab Bug 675539 - Make tab discard functionality work on tab objects directly r=mconley
This removes the need to go through the browser-to-tab mapping when discarding
a tab and simplifies the relevant code. Besides being renamed discardBrowser()
was also split so that one can check if a tab can be discarded prior to trying
it.

Differential Revision: https://phabricator.services.mozilla.com/D20475
2019-02-26 05:35:09 +00:00
Coroiu Cristina
f57ea27ef7 Backed out 2 changesets (bug 1524992) for multiple failures and timeout on a CLOSED TREE
Backed out changeset fb1d7e57e253 (bug 1524992)
Backed out changeset bd215cd3c8d7 (bug 1524992)
2019-02-27 19:02:03 +02:00
James Willcox
ec0fc52124 Bug 1524992 - Treat command line URIs as external r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D20890
2019-02-27 15:57:44 +00:00
Daniel Varga
35da162d3b Backed out 2 changesets (bug 1524992) for linting opt failure on a CLOSED TREE
Backed out changeset 998c1f756e51 (bug 1524992)
Backed out changeset e5da75d979ef (bug 1524992)
2019-02-27 17:19:45 +02:00
James Willcox
6244a2a0f5 Bug 1524992 - Treat command line URIs as external r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D20890
2019-02-26 19:23:43 +00:00
shindli
641b0ef885 Backed out 2 changesets (bug 1442694) for breaking session restores on update a=backout
Backed out changeset f100f8631f78 (bug 1442694)
Backed out changeset 7a20c79a0e12 (bug 1442694)
2019-02-26 18:32:20 +02:00
Doug Thayer
82f10b5098 Bug 1442694 - Preopen pinned tabs before session restore r=Gijs
When we open firefox with pinned tabs, we first paint a window with
one tab open, and then that tab gets displaced after the pinned tabs
come in. This aims to ensure that our first paint contains the
pinned tab, so that we don't have tabs moving around after first
paint.

MozReview-Commit-ID: GC1y6NlgLTd

Differential Revision: https://phabricator.services.mozilla.com/D18742
2019-02-25 19:19:07 +00:00
Christoph Kerschbaumer
3dd19b31a3 Bug 1518454: Part 2, frontend changes, add CSP to loadURIOptions dictionary and pass CSP explicitly from frontend to docshell. r=gijs 2019-02-22 09:19:26 +01:00
Christoph Kerschbaumer
b0812aa988 Bug 1529252: Remove the 2 from the various version to create a channel within nsIIOService.idl. r=valentin 2019-02-21 12:48:20 +01:00
Jonathan Kingston
540181c731 Bug 1521549 - Move (de)serializePrincipal from sessionstore Utils to E10SUtils. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D17261
2019-02-19 02:34:09 +00:00
Thomas Nguyen
7405fdc8a3 Bug 1517703 - Part 2 - Use ReferrerInfo in loadURIOptions from js r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D17922
2019-02-12 19:35:24 +00:00