Commit Graph

9 Commits

Author SHA1 Message Date
Cullen Rhodes
44dc9f68ea servo: Merge #11329 - Report use statements that use {} with only one entry (from c-rhodes:11320); r=jdm
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X ] `./mach build -d` does not report any errors
- [X ] `./mach test-tidy --faster` does not report any errors
- [X ] These changes fix #11320  (github issue number if applicable).

Either:
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

Source-Repo: https://github.com/servo/servo
Source-Revision: 2f9796fa696e9514280777398467696dd4f004b3
2016-05-27 07:11:17 -05:00
aeischeid
089ce7d073 servo: Merge #10713 - add tidy test for space after ":" in stucts (from aeischeid:master); r=jdm
Addresses issue #10702

the tidy self-test doesn't seem to catch the `member_name:"Foo"` line like it should. the regex follows similar pattern in the file and works in my regex tester tool, so not really sure what is going on there.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8c2c0bd964bfbf1a2d7494bd8fbbdd263173ef7d
2016-05-11 16:27:37 -07:00
askeing
24399c26e4 servo: Merge #10835 - Adding parameter to tidy for skipping print text when running tests (from askeing:fix_10832); r=Wafflespeanut
fix #10832

Source-Repo: https://github.com/servo/servo
Source-Revision: b853383afc6760286018933b400925e1dbd6a48a
2016-04-25 12:48:49 -07:00
Maciej Skrzypkowski
415c8c0758 servo: Merge #10775 - Test for tidy.check_lock function #9152 (from mskrzypkows:tidy_tests); r=Wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: edb58040c82c9c333e0c0a04051e17ed6fb17bd7
2016-04-25 00:19:33 -07:00
Zbynek Winkler
a911446820 servo: Merge #10786 - tidy check for vim and emacs modelines (from zwn:tidy-modelines); r=Manishearth
See #10719.

It skips *.webidl files for now since I am not sure where they come from and if they should be edited in tree or not.

Source-Repo: https://github.com/servo/servo
Source-Revision: 04f8ae56db0ba9df798b39a5b2f1bb1e23d6dcf3
2016-04-22 21:46:30 -07:00
Zbynek Winkler
a2221f5bbe servo: Merge #10751 - Report lines starting with && in tidy (from zwn:tidy-start-operator); r=Wafflespeanut
Partial implementation of the issue #10692 (the easy part).

Source-Repo: https://github.com/servo/servo
Source-Revision: d926b5d3762a101d5280266f806f2b979f73b695
2016-04-22 10:40:06 -07:00
Josh Matthews
2e5b8dbe5c servo: Merge #10758 - Ensure that we aren't missing any errors in the tidy self-test (from jdm:tidy_check_completeness); r=Wafflespeanut
r? @Wafflespeanut

Source-Repo: https://github.com/servo/servo
Source-Revision: 6f801e3f3f806f55fd955a469ed175915f24d6cb
2016-04-22 02:40:29 -07:00
askeing
e3c99fddcd servo: Merge #10653 - Cleanup tidy for external deps (from askeing:cleanup_tidy_for_external_deps); r=edunham
fix #10639

Source-Repo: https://github.com/servo/servo
Source-Revision: 4d80e0634ed58580a7d30fc7f57e6bdf4aa4e19d
2016-04-19 01:51:01 +05:00
askeing
b7e6a9471a servo: Merge #10590 - Package tidy (from edunham:package-tidy); r=larsbergstrom
This fixes https://github.com/servo/servo/issues/861.

@askeing, I've copied your work from https://github.com/askeing/servo_tidy and attributed the commit to you. My commit in this PR is Git housekeeping to preserve `tidy`'s history. If you'd like to make additional changes, I've given you and @shinglyu push access to my fork of Servo. Apologies if this is already familiar, but the workflow for pushing to my branch is:

```
$ git remote add edunham git@github.com:edunham/servo.git
$ git checkout -b package-tidy
$ git pull edunham package-tidy
$ git push edunham package-tidy
```

Once this lands, I'll look at how to publish it to PyPI and automate that process.

Please don't merge this yet; we still need to discuss how the change should work around https://github.com/servo/servo/blob/master/python/servo/testing_commands.py#L33 , as I've yet to figure out how to get the egg to actually expose its tests.

Source-Repo: https://github.com/servo/servo
Source-Revision: bfe54539d290cb287e59e8ba106a54a3fab6201a
2016-04-15 22:50:16 +05:00