Ting-Yu Lin
7e5a56b15d
Bug 1277129 Part 7c - Rename various RS variables to RI. r=dbaron
...
This patch is generated by the following script:
function rename() {
find layout\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename aChildRS aChildRI
rename aContainingBlockRS aContainingBlockRI
rename aFrameRS aFrameRI
rename aLastRS aLastRI
rename aOuterRS aOuterRI
rename aRS aRI
rename blockHtmlRS blockHtmlRI
rename captionRS captionRI
rename cellRS cellRI
rename childRS childRI
rename firstAncestorRS firstAncestorRI
rename flexContainerRS flexContainerRI
rename gridRS gridRI
rename innerRS innerRI
rename lastButOneRS lastButOneRI
rename LineContainerRS LineContainerRI
rename mBlockRS mBlockRI
rename parentRS parentRI
rename secondAncestorRS secondAncestorRI
rename lastRSSize lastRISize
rename lastRSPadding lastRIPadding
MozReview-Commit-ID: YEgZs3WMow
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
d3e8cf1818
Bug 1277129 Part 7b - Rename various ReflowState variables to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "([[:alpha:]]*)([rR])eflowState(s?)" "\1\2eflowInput\3"
MozReview-Commit-ID: ITFO7uMTkSb
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
3b9a7090d9
Bug 1277129 Part 6b - Rename rendContext to mRenderingContext in SizeComputationInput. r=dbaron
...
MozReview-Commit-ID: LczLJDtDncy
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
a16062e5d0
Bug 1277129 Part 6a - Rename frame to mFrame in SizeComputationInput. r=dbaron
...
MozReview-Commit-ID: 3SXZ4qEZJc
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
bb0825b5c7
Bug 1277129 Part 5c - Rename nsHTMLReflowMetrics to ReflowOutput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsHTMLReflowMetrics" "ReflowOutput"
MozReview-Commit-ID: 2HBb7DkooH5
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
1f18cda846
Bug 1277129 Part 5b - Rename nsHTMLReflowMetrics.h/cpp to ReflowOutput.h/cpp and fix #includes. r=dbaron
...
The modification to nsAbsoluteContainingBlock.h and nsBlockFrame.cpp are
needed to fix the build error due to the file order changed in the unified
build.
The #includes are fixed by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsHTMLReflowMetrics\.h" "mozilla\/ReflowOutput\.h"
MozReview-Commit-ID: KWvcG3UtKNn
2016-07-21 18:36:37 +08:00
Ting-Yu Lin
61c507eb10
Bug 1277129 Part 2c - Rename nsBlockReflowState to BlockReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsBlockReflowState" "BlockReflowInput"
MozReview-Commit-ID: FtjqkQpGfcI
2016-07-21 18:36:36 +08:00
Ting-Yu Lin
d5f7b21d39
Bug 1277129 Part 2b - Rename nsBlockReflowState.h/cpp to BlockReflowInput.h/cpp and fix #includes. r=dbaron
...
The #includes are fixed by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsBlockReflowState\.h" "BlockReflowInput\.h"
MozReview-Commit-ID: 6QMqko1XOsT
2016-07-21 18:36:36 +08:00
Ting-Yu Lin
0623510910
Bug 1277129 Part 1d - Rename nsCSSOffsetState to SizeComputationInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsCSSOffsetState SizeComputationInput
MozReview-Commit-ID: GUJ99qNiSwD
2016-07-21 18:36:35 +08:00
Ting-Yu Lin
10912a51e3
Bug 1277129 Part 1c - Rename nsHTMLReflowState to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsHTMLReflowState ReflowInput
MozReview-Commit-ID: 9r9vdVv1pXc
2016-07-21 18:36:35 +08:00
Michael Li
a5d5ed2560
Bug 1283273 - Change nsAutoPtr to UniquePtr in classes within layout/generic. r=dholbert
2016-07-08 08:08:00 +02:00
Xidorn Quan
db9f69aeaa
Bug 1283721 - Use block-size rather than height for computing float available space. r=jfkthame
...
MozReview-Commit-ID: HyGmoYJDOkd
2016-07-07 16:48:21 +10:00
Brad Werth
69ccb7e3db
Bug 1243559 - Removes static casts from calls to FrameProperties::Get, ::Set, and ::Remove, and forces callers to use the type associated with the property. r=dbaron
2016-06-21 13:17:11 -07:00
Phil Ringnalda
ae1f6b874d
Back out changeset 0bb00282a4c2 (bug 1243559) for widespread SVG assertion failures
...
CLOSED TREE
2016-06-22 18:45:08 -07:00
Brad Werth
665cd94da6
Bug 1243559 - Removes static casts from calls to FrameProperties::Get, ::Set, and ::Remove, and forces callers to use the type associated with the property. r=dbaron
2016-06-21 13:17:11 -07:00
Mats Palmgren
19b7786950
Bug 1278080 - Make nsContainerFrame::RemoveFrame deal with overflow containers. r=dholbert
2016-06-10 02:56:23 +02:00
Ting-Yu Lin
16cc2366c3
Bug 1276870 - Rename parentReflowState to mParentReflowState in nsHTMLReflowState. r=dholbert
...
MozReview-Commit-ID: ETfT1Iow7kF
2016-05-31 17:40:31 +08:00
Jeremy Chen
07acd5f470
Bug 1275831 - part6: remove unused block layout debug flag. r=dholbert
...
1.Remove NOISY_FIRST_LINE, NOISY_MAX_ELEMENT_SIZE, NOISY_MAXIMUM_WIDTH.
2.Remove REALLY_NOISY_FIRST_LINE.
Only one static function, which has no caller, but defined under this flag.
3.Move REALLY_NOISY_REFLOW_CHILD into REALLY_NOISY_REFLOW.
The chunk of REALLY_NOISY_REFLOW_CHILD seems dead for long time, so make it
alive by moving it under REALLY_NOISY_REFLOW.
MozReview-Commit-ID: E7IW0qStdck
2016-05-27 16:06:27 +08:00
Jeremy Chen
26753cb058
Bug 1275831 - part4: fix NOISY_BLOCK_DIR_MARGINS block layout debug flag. r=dholbert
...
MozReview-Commit-ID: 24JUxzbSeYQ
2016-05-27 16:06:27 +08:00
Jeremy Chen
6c330ebd91
Bug 1275831 - part3: fix NOISY_COMBINED_AREA block layout debug flag. r=dholbert
...
MozReview-Commit-ID: 2LchMKfWNba
2016-05-27 16:06:27 +08:00
Jeremy Chen
00e4c92d9f
Bug 1275831 - part2: fix NOISY_FINAL_SIZE block layout debug flag. r=dholbert
...
MozReview-Commit-ID: APtHNT1nohi
2016-05-27 16:06:27 +08:00
Jeremy Chen
315352c619
Bug 1275831 - part1: fix NOISY_FLOAT block layout debug flag. r=dholbert
...
MozReview-Commit-ID: AOgV0TK6uyj
2016-05-27 16:06:27 +08:00
Mats Palmgren
1f89536089
Bug 1271392 part 6 - [css-grid] Remove now dead code. r=dholbert
2016-05-18 13:49:33 +02:00
Mats Palmgren
b0713aff57
Bug 1271392 part 4 - [css-grid] Make sure a grid item's last fragment fills its grid area. r=dholbert
2016-05-18 13:49:33 +02:00
Cameron McCormack
3bb5936996
Bug 1271869 - Rename NS_STYLE_TEXT_ALIGN_DEFAULT to NS_STYLE_TEXT_ALIGN_START. r=dholbert
2016-05-11 14:03:34 +10:00
Matt Woodrow
61200a9c5c
Bug 1243610 - Refactor UpdateOverflow to separate out local overflow from that contributed by descendants. r=dbaron
2016-05-04 12:27:43 +12:00
Ting-Yu Lin
2d9af614f7
Bug 1260090 - Remove nsBlockFrameSuper as nsContainerFrame alias. r=dholbert
...
MozReview-Commit-ID: IzI88HCayfi
2016-03-28 14:39:42 +08:00
Xidorn Quan
a775f13687
Bug 1235321 - Enable using line cursor to optimize reflowing absolute frames. r=bz
...
MozReview-Commit-ID: 4tVq5S4eTtS
2016-04-13 13:42:28 +10:00
Mats Palmgren
1a83f57b72
Bug 645647 part 4 - Add an 'm' prefix to some members to follow our naming conventions. r=dholbert
2016-04-14 01:32:12 +02:00
Ting-Yu Lin
6658072156
Bug 1258657 Part 1 - Change summary default style to "display: list-item" to match html spec. r=bz
...
Per html spec, the disclosure triangle can be generated via "display:
list-item", I removed the code to generate the triangle in
SummaryFrame::SetInitialChildList(). That is, when a web page set
"display: block" to the summary, the triangle will disappear, too.
Now SummaryFrame does nothing and is going to be removed in Part 2.
Also summary element should not increment the counter as hinted as
"counter-increment: list-item 0" in the spec. Hence the change in
nsBlockFrame::RenumberListsFor().
The rendering hint in html spec:
https://html.spec.whatwg.org/multipage/rendering.html#the-details-and-summary-elements
MozReview-Commit-ID: DELGYFe3zGX
2016-04-13 13:34:14 +08:00
Xidorn Quan
ba620a636b
Bug 1257121 part 4 - Use return value rather than out param to return font metrics. r=jfkthame
...
MozReview-Commit-ID: 6xrHYbgHGVd
2016-03-17 13:55:48 +08:00
Xidorn Quan
289ca1f35e
Bug 1257121 part 3 - Add GetInflatedFontMetricsForFrame function to simplify a common use pattern. r=jfkthame
...
MozReview-Commit-ID: 4KMLCz6wQHQ
2016-03-17 12:07:47 +08:00
Cameron McCormack
8a879b8032
Bug 1244068 - Part 4: Use StyleSetHandle instead of concrete style set class in most places. r=dholbert
2016-02-24 18:01:11 +11:00
Boris Chiou
16edfa82cd
Bug 1244049 - Part 1: Define scoped enum for CSSPseudoElement type. r=dbaron
2016-02-16 23:07:00 +01:00
Ting-Yu Lin
5ec9e745ba
Bug 591737 - Construct details and summary in nsCSSFrameConstructor. r=bz
2016-02-02 17:39:49 +08:00
L. David Baron
f0ac0f84d4
Bug 1236745 - Fix infinite loop resulting from block formatting context entering resize oscillation due to considering floats over its whole height when sizing it. r=dholbert
...
What's happening here is that we enter an infinite loop by oscillating
between two states. The code assumes that (a) the available space will
never grow, only stay the same or shrink, and (b) that we should break
out of the loop if it stays the same. This also means we hit the
assertion about the available space growing every other time through the
loop.
This is in the inner loop in nsBlockFrame::ReflowBlockFrame that was
introduced in https://hg.mozilla.org/mozilla-central/rev/80ef9bb2c2e9 .
The problem is fundamentally a logic error in that code. The makes the
assumption that if you reduce the width available to a block formatting
context or replaced block-level element, its height does not shrink.
(The "replaced block" (really block formatting context) in this case, as
in the original testcase, is a scroll frame. I didn't debug the
original testcase enough to figure out what caused its sizing
characteristics, although a percentage-width image does seem like the
most likely candidate.)
Without the patch, the reftest test (but not reference) hangs, as does
the semi-simplified test in the bug (given a narrow window).
With the patch, neither the semi-simplified test in the bug nor the
reference hangs, and the reftest passes.
2016-02-04 09:41:44 +11:00
Daniel Holbert
d19bd3cc0f
Bug 1245406: In ReflowBlockFrame, use Maybe<> to destroy & reconstruct a stack-allocated object, instead of an explicit call to destructor & placement 'new'. r=dbaron
2016-02-03 12:37:23 -08:00
Birunthan Mohanathas
bfee0fb40c
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
Phil Ringnalda
d871b9515f
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas
245cd6a02f
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00
Ting-Yu Lin
122e5b9aeb
Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats
2016-01-29 22:42:14 +08:00
Xidorn Quan
0b78aca734
Bug 1230034 part 10 - Convert remaining frame properties to by typed and remove the unsafe declaring macro. r=dbaron
2016-01-28 14:23:59 +11:00
Xidorn Quan
9ad6eb8dd0
Bug 1230034 part 8 - Convert frame properties which assert on destructor to be typed. r=dbaron
2016-01-28 14:23:59 +11:00
Xidorn Quan
c26e860288
Bug 1230034 part 6 - Convert all frame properties which do not hold pointer to be typed. r=dbaron
2016-01-28 14:23:59 +11:00
Xidorn Quan
0f1150d793
Bug 1064843 part 5 - Ensure frames behave properly for unknown child list id passed into SetInitialChildList. r=dholbert
...
Note that nsMathMLContainerFrame and its subclasses are unchanged since
they are not target of fullscreen (and thus no backdrop frame), and they
have an assertion to ensure we really don't pass any unexpected list in.
2016-01-28 10:11:00 +11:00
Nicholas Nethercote
7fabd8754f
Bug 1231550 - Use DrawTarget instead of gfxContext and/or nsRenderingContext in many places in font/text code. r=jfkthame.
...
AutoTextRun now only needs a DrawTarget instead of an nsRenderingContext, and
similar nsRenderingContext/gfxContext-to-DrawTarget replacements can be
propagated a long way up the call graph. This patch replaces 93 occurrences of
nsRenderingContext and 135 occurrences of gfxContext with DrawTarget; that's
13% of them.
The patch is mostly plumbing changes. A couple of not-entirely-plumbing
changes:
- It adds a comment about the null check in
gfxGlyphExtents::GetTightGlyphExtentsAppUnits().
- A couple of functions simply had an unused gfxContext or nsRenderingContext
parameter removed, e.g. SetLineBreaks().
2015-12-15 13:56:41 -08:00
Mats Palmgren
871c9ae3b7
Bug 1151243 part 1 - Replace three bool params for nsAbsoluteContainingBlock::Reflow with a flag param (idempotent patch). r=dholbert
2015-12-22 23:03:16 +01:00
Nicholas Nethercote
3d8166e857
Bug 1231256 (part 6) - Remove unused parameter from Damage functions. r=roc.
2015-12-07 15:23:34 -08:00
Nicholas Nethercote
fe73890223
Bug 1230413 (part 4) - Remove unused nsRenderingContext argument from ForceBreak() and OptionallyBreak(). r=mattwoodrow.
2015-12-06 14:13:57 -08:00
Anup Kumar
f7654c8a69
Bug 1197307 - remove PR_snprintf calls in layout/ r=froydnj r=dholbert
2015-12-01 12:50:47 -08:00