corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
878,851 Commits 1 Branch 0 Tags
4268ec21d49fca6507a8267ce59312619343715c
Commit Graph

62 Commits

Author SHA1 Message Date
Dão Gottwald
4268ec21d4 Bug 1923635 - Various MozTabbrowserTabs cleanup. r=dwalker,tabbrowser-reviewers 
Did this while working on drag-and-drop code.

Differential Revision: https://phabricator.services.mozilla.com/D225062
 2024-10-09 14:46:09 +00:00
Sam Foster
58c1f20705 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements 
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
 2024-10-02 22:14:13 +00:00
Iulian Moraru
4a9432209c Backed out changeset 98b6ddc6deed (bug 1899598) for causing marionette failures on test_initialize_vertical_tabs.py. CLOSED TREE 2024-10-02 07:49:47 +03:00
DJ
d6722b5ab0 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222017
 2024-10-02 00:48:13 +00:00
Sam Foster
15a36fe751 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements 
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
 2024-10-01 23:37:37 +00:00
Jeremy Swinarton
f7d52456e8 Bug 1918710: Move tab to tab group from tab context menu r=dao,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222487
 2024-10-01 17:25:28 +00:00
Butkovits Atila
883f96f3dd Backed out changeset 2e5b4312b174 (bug 1908426) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-10-01 13:17:36 +03:00
Stanca Serban
24647acde4 Backed out changeset 0b970f2cd8fd (bug 1899598) for causing devtools failures in browser_aboutdebugging_devtoolstoolbox_tooltip_markupview.js. CLOSED TREE 2024-10-01 01:54:25 +03:00
DJ
5cf4713f6b Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222017
 2024-09-30 20:57:36 +00:00
Sam Foster
ef30ebaf5c Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements 
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
 2024-09-30 18:10:42 +00:00
Dão Gottwald
97f432dc06 Bug 1920922 - Update hidden tab checks to account for tabs in collapsed groups. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D223469
 2024-09-26 04:18:45 +00:00
Sarah Clements
02a48271c6 Bug 1906881 - Update tab context menu strings for vertical tabs mode r=fluent-reviewers,mconley,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223153
 2024-09-25 10:32:30 +00:00
Jeremy Swinarton
054865a576 Bug 1917417: Prevent intermittents by closing tabs in tests without animation r=dao,sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D223182
 2024-09-25 06:20:49 +00:00
Dão Gottwald
b05aac4958 Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D223292
 2024-09-25 05:08:37 +00:00
Norisz Fay
09a2236ef6 Backed out changeset fad1cda93cc8 (bug 1908426) for causing multiple failures CLOSED TREE 2024-09-24 02:13:41 +03:00
DJ
6ca1b918f3 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222017
 2024-09-23 21:17:14 +00:00
Jeremy Swinarton
ca4df10a2c Bug 1908424: Context menu to create a group from single or multiple tabs r=dao,dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D221825
 2024-09-19 18:54:12 +00:00
Dão Gottwald
23da2b3201 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-17 08:21:24 +00:00
Noemi Erli
353976cead Backed out 2 changesets (bug 1918676, bug 1918638) for causing browser chrome failures 
Backed out changeset c36ab1469893 (bug 1918638)
Backed out changeset f973faab6674 (bug 1918676)
 2024-09-17 02:34:41 +03:00
Dão Gottwald
2b53d56022 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-16 19:53:42 +00:00
Emilio Cobos Álvarez
90897ae6d8 Bug 1917458 - Remove bookmarks-toolbar-overlapping-browser code. r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.

Differential Revision: https://phabricator.services.mozilla.com/D221996
 2024-09-16 13:21:51 +00:00
Cristian Tuns
482d5b9f87 Backed out 5 changesets (bug 1917458) for causing wpt failures in no_window_open_when_term_nesting_level_nonzero.window.html CLOSED TREE 
Backed out changeset 157eb2ada2ca (bug 1917458)
Backed out changeset 3f6d758ac9c6 (bug 1917458)
Backed out changeset 65384dcd3d9a (bug 1917458)
Backed out changeset e4cca274eb5a (bug 1917458)
Backed out changeset 2b1c3c2aef15 (bug 1917458)
 2024-09-14 21:04:04 -04:00
Emilio Cobos Álvarez
8d2ba7e03e Bug 1917458 - Remove bookmarks-toolbar-overlapping-browser code. r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.

Differential Revision: https://phabricator.services.mozilla.com/D221996
 2024-09-14 23:23:52 +00:00
Sarah Clements
5e0ea4a4f0 Bug 1916188 - Fix issue with selected pinned tab reordering for vertical tabs r=mconley 
* Add a condition in createTabsForSessionRestore to account for pinned tabs that are selected and update test

Differential Revision: https://phabricator.services.mozilla.com/D221324
 2024-09-13 13:44:59 +00:00
Florian Quèze
7346c45e51 Bug 1917838 - Remove expired telemetry event close_tab_warning.shown, r=chutten,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao. 
Differential Revision: https://phabricator.services.mozilla.com/D221650
 2024-09-12 13:42:22 +00:00
Jeremy Swinarton
8a865f454f Bug 1908408: API to move tab group to a new window r=dao,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220601
 2024-09-03 14:06:07 +00:00
Stanca Serban
629a9a3617 Backed out changeset b20f0a3ffccf (bug 655445) for causing mochitests failures in browser_new_tab_insert_position.js. CLOSED TREE 2024-09-03 17:43:52 +03:00
codesuki
e60bdb02a5 Bug 655445 - Add setting to control position of tabs opened from pinned tabs. r=dao,tabbrowser-reviewers 
This patch introduces `browser.tabs.insertAfterCurrentExceptPinned`.
Setting it to `true` open links from pinned tabs at the end of the tabbar.

Differential Revision: https://phabricator.services.mozilla.com/D69489
 2024-09-03 13:12:27 +00:00
isaacylee
cfa004f3c1 Bug 1558149 - Use 'loadFlags' instead of 'flags' for flags eventually passed to 'loadURI' or 'fixupAndLoadURIString' r=Gijs,geckoview-reviewers,tabbrowser-reviewers,dao,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D216324
 2024-08-31 22:00:59 +00:00
Jeremy Swinarton
aaa87e6120 Bug 1908413: Delete tab group when closing the last tab r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220486
 2024-08-29 15:29:03 +00:00
timw-dev
7275427d4a Bug 1804166 - favicon not reseting when changing tab to about:newtab with newtab to Blank Page.r=tgiles,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D216357
 2024-08-28 15:33:38 +00:00
Jeremy Swinarton
6a9ffdb4fe Bug 1908411: API to remove tab group r=dao,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220273
 2024-08-28 11:29:44 +00:00
Dão Gottwald
fccdffe4bf Bug 345399 - Update scroll buttons' disabled state when the scrollbox width changes. r=emilio,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220153
 2024-08-27 20:19:18 +00:00
Jeremy Swinarton
b44f09e709 Bug 1914952: Grouping tabs doesn't fire TabMove event if position unchanged r=dao,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220140
 2024-08-26 17:22:39 +00:00
DJ
6248ea2cf3 Bug 1908419 - add method to retrieve list of groups from tabContainer. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220142
 2024-08-26 16:59:51 +00:00
DJ
bfb53ac9de Bug 1908405 - accept optional list of tabs in addTabGroup. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D219941
 2024-08-23 09:44:53 +00:00
Florian Quèze
65bf72cdca Bug 1913624 - Remove expired telemetry histogram HOVER_UNTIL_UNSELECTED_TAB_OPENED, r=chutten,tabbrowser-reviewers,dao. 
Depends on D219440

Differential Revision: https://phabricator.services.mozilla.com/D219441
 2024-08-20 10:26:51 +00:00
Florian Quèze
171499434e Bug 1913624 - Remove expired telemetry histogram TAB_AUDIO_INDICATOR_USED, r=chutten,tabbrowser-reviewers,dao. 
Depends on D219439

Differential Revision: https://phabricator.services.mozilla.com/D219440
 2024-08-20 10:26:51 +00:00
Jan-Niklas Jaeschke
de1c63ce2a Bug 1911339 - Text Fragments: Preserve user activation when opening a link in a new tab or window. r=dom-core,tabbrowser-reviewers,dao,farre 
Differential Revision: https://phabricator.services.mozilla.com/D218655
 2024-08-20 08:47:49 +00:00
Anna Yeddi
f351d96411 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod 
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
 2024-08-06 13:51:06 +00:00
Stefan Richter
551e400b7c Bug 1409262 - Notify when openerTabId changed via tabs.update() r=robwu,dao 
Differential Revision: https://phabricator.services.mozilla.com/D164982
 2024-08-05 17:49:06 +00:00
Dão Gottwald
5cc15d0779 Bug 1908412 - add API for adding tabs to a group. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218204
 2024-08-05 09:25:19 +00:00
Dão Gottwald
95d5536b2f Bug 1910576 - tabbrowser.js needs to check tabContainer.verticalMode rather than tabContainer.inVerticalTabsMode. r=tabbrowser-reviewers,dwalker 
Borrowed from https://phabricator.services.mozilla.com/D218052

Differential Revision: https://phabricator.services.mozilla.com/D218185
 2024-07-31 15:18:09 +00:00
Dão Gottwald
57b3a833e4 Bug 1908162 - Basic Tab Group custom element. r=dwalker,desktop-theme-reviewers,tabbrowser-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D217980
 2024-07-30 14:57:41 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane 
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
 2024-07-29 11:30:37 +00:00
Sammy Khamis
994493e803 Bug 1909783: Synced tabs list should de-dupe r=markh,fxview-reviewers,sync-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao 
Differential Revision: https://phabricator.services.mozilla.com/D217700
 2024-07-26 20:31:03 +00:00
timw-dev
139987ebda Bug 1804166 - favicon not reseting when changing tab to about:newtab with newtab to Blank Page.r=tgiles,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D216357
 2024-07-23 17:07:39 +00:00
Amy Lee
0be4c4335f Bug 1902430 - Update strings for close duplicate tabs in tab overview menu. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D214455
 2024-07-02 18:56:44 +00:00
Cristian Tuns
49bd8e8edd Backed out changeset 6ac47dbd939c (bug 1884970) for causing bc failures in browser_tab_tooltips.js CLOSED TREE 2024-06-28 15:23:44 -04:00
Anna Yeddi
f0d91c0df0 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod 
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
 2024-06-28 18:23:45 +00:00