corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
501,587 Commits 1 Branch 0 Tags
424682e3b61c63ac75b51d38c03e12a4ff512122
Commit Graph

146 Commits

Author SHA1 Message Date
Marco Bonardo
2703fb553f Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8 
MozReview-Commit-ID: 2pSbYtPGtYx
 2017-08-03 12:16:36 +02:00
Marco Bonardo
a90abdc771 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8 
MozReview-Commit-ID: 7vli02K19bt
 2017-07-18 19:18:02 +02:00
Mark Banner
854703d979 Bug 1381027 - Remove unnecessary async definitions for functions in editBookmarkOverlay.js. r=mak 
MozReview-Commit-ID: HvSotonXYJM
 2017-07-14 15:42:05 +01:00
Marco Bonardo
337b1dae96 Bug 1379611 - Avoid GetItemTitle() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: 9Ig63XHcEIE
 2017-07-10 16:13:55 +02:00
Marco Bonardo
90366bedcc Bug 1379611 - Avoid GetBookmarkURI() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: 1LmJqSj1xnw
 2017-07-10 16:21:01 +02:00
Marco Bonardo
652f85e780 Bug 1379611 - Avoid GetFolderIdForItem() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: LLikbxfAN4u
 2017-07-10 15:37:55 +02:00
Mark Banner
cbbea669bd Bug 1376925 - Avoid some warnings about this._paneInfo being undefined in editBookmarkOverlay.js when an event happens during closing the dialog. r=mak 
MozReview-Commit-ID: GZKe4z6kpGP
 2017-07-04 14:18:11 +01:00
Marco Bonardo
a380c4f53e Bug 1376929 - Fix places-related mochitests in chrome/ for async-transactions. r=standard8 
MozReview-Commit-ID: ILrvOGzu1zo
 2017-07-03 15:46:56 +02:00
Mark Banner
ef8538e9c4 Bug 1376531 - Fix some issues when enabling async places transactions - updating bookmarks names and pasting bookmarks. r=mak 
MozReview-Commit-ID: 4sqbSMtMkDD
 2017-06-27 12:54:16 -07:00
Florian Quèze
38c24463e4 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
b2499a4c57 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Marco Bonardo
e978792553 Bug 1343256 - Bookmark keywords disappear from one bookmark when adding a keyword to another bookmark. r=standard8 
MozReview-Commit-ID: Av8pDQi6Yyp
 2017-04-29 15:15:06 +02:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Kirk Steuber
a5f3668356 Bug 1349823 - Populate bookmark panel before showing it r=enndeakin+6102,mak 
When panel behavior became asynchronous, |StarUI._doShowEditBookmarkPanel| needed to be changed to wait for the panel to finish opening before initializing it. Although the content of the panel can be changed successfully before the panel opens, the element focus at the end of initialization fails. This prevents the capturing of certain events, such as an Esc keypress (which should close the panel).

However, this introduced the problem where there is a short delay between when the bookmark panel opens and when the correct content is displayed in it. To fix this, the initialization function |gEditItemOverlay.initPanel| will now be called before the panel opens, but the element focus code will wait for the panel's popupshown event.

MozReview-Commit-ID: 6SrcCz963qW
 2017-04-05 15:38:37 -07:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8 
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
 2017-03-21 14:29:43 -04:00
Mark Banner
e2dabf7035 Bug 1344017 - Fix an issue where the folder picker in the edit bookmark overlay is not always be updated correctly. r=mak 
MozReview-Commit-ID: 7AuIyuFWlGF
 2017-03-07 22:11:38 +00:00
Mark Banner
7d691acb44 Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws 
MozReview-Commit-ID: DUnxVITvZgh
 2017-03-03 09:29:14 +00:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Marco Bonardo
0261f8f54a Bug 1314013 - Allow the bookmarking ui to add a new keyword when the provided postData differs from the existing one. r=adw 
MozReview-Commit-ID: FRqwTxNpej
 2016-11-16 15:31:46 +01:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop 
MozReview-Commit-ID: LdoXLniNeT7
 2016-11-03 11:51:48 +00:00
Kirk Steuber
2c1ac87580 Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin 
MozReview-Commit-ID: Dh1npORCQ6J
 2016-08-16 15:33:05 -07:00
Marco Bonardo
3c8be8a7e0 Bug 1150678 - Changing url of a bookmark with a keyword breaks the keyword forever. r=adw 
MozReview-Commit-ID: 89Od4PKpQse
 2016-08-30 11:04:22 +02:00
Jared Wein
99638e1465 Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs 
MozReview-Commit-ID: 8izEqc8IyCu
 2016-08-12 11:50:35 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt
 2016-08-04 03:28:58 -04:00
Dão Gottwald
afd98e3cc6 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-24 14:31:33 +02:00
Sebastian Hengst
e2b9fd07a5 Backed out changeset 54ebf85e8731 (bug 1219788) for leaks in many mochitests on Linux. r=backout 2016-05-21 09:35:06 +02:00
Dão Gottwald
f294e5ef5b Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-20 14:41:49 +02:00
Marco Bonardo
2456bebdca Bug 1230471 - Basic eslint fixes in places. r=mconley 2015-12-10 06:46:49 -05:00
Hassen ben tanfous
aa7b48bf89 Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Marco Bonardo
f4ec8ceb6b Bug 1208063 - The name input field on the new bookmark dialog doesn't get focus. r=adw 2015-10-07 15:40:13 +02:00
Tooru Fujisawa
735dfed4e6 Bug 1207491 - Part 10: Remove use of expression closure from browser/components/places/content/. r=Gijs 2015-09-23 18:36:21 +09:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Marco Bonardo
28bac68066 Bug 1193621 - Can't change tag name in library. r=ttaubert 2015-09-02 16:41:01 +02:00
Marco Bonardo
0a1df808e2 Bug 1167915 - "Add a Keyword for this Search" does not work anymore on POST forms. r=ttaubert 2015-06-03 21:12:48 +02:00
Tom Schuster
5d2068da71 Bug 1150855 - Remove uses of the curly syntax. r=jaws 2015-05-22 21:23:57 +02:00
Marco Bonardo
fa43c2730f Bug 1163341 - Cannot edit location of a bookmark. r=ttaubert 2015-05-11 20:26:25 +02:00
Marco Bonardo
1e9a160779 Bug 1160864 - The description field is not shown when editing a read-only container child in the Library. r=mano 2015-05-08 12:43:29 +02:00
Marco Bonardo
72be7839f8 Bug 1161882 - "Add a Keyword for this search..." dialog accept button is disabled. r=ttaubert 2015-05-08 12:43:24 +02:00