Commit Graph

102 Commits

Author SHA1 Message Date
Mike de Boer
bc72a05e37 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Sebastian Hengst
2b4cc8b55c Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Mike de Boer
6cb3ed2016 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Paolo Amadini
d1e1b518d1 Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB
2017-08-04 14:48:53 +01:00
Paolo Amadini
1a2766e349 Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1
2017-07-17 12:05:12 +01:00
Paolo Amadini
81fd3d7bde Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa
2017-07-17 12:07:17 +01:00
Paolo Amadini
1907d28bdd Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4
2017-07-16 17:36:00 +01:00
Paolo Amadini
0943598d9f Bug 1357915 - Fix download commands operating on multiple items in the Library window. r=Standard8
This was regressed by bug 1264206 while removing legacy array comprehensions, because selectedItems is a NodeList and not an Array.

MozReview-Commit-ID: 61GG3SiiWwS
2017-07-18 10:19:48 +01:00
Florian Quèze
b622c2b081 Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Paolo Amadini
fece3c6437 Bug 1281186 - Remove uses of nsIDownloadManager from DownloadsCommon.jsm, DownloadsViewUI.jsm, and allDownloadsViewOverlay.js. r=mak
MozReview-Commit-ID: 28nc8aTea5v
2017-05-05 11:20:53 +01:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Yiren Wang
fd7cf240a8 Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
David Rajchenbach-Teller
d557516aec Bug 1087255 - Convert Download JS clients of RemovePage(s) to History.remove;r=paolo
MozReview-Commit-ID: KpXAh74W12E
2014-10-31 12:39:28 +01:00
Sean Lee
e9de65ebe2 Bug 1282662 - Part 1: Redesign the detail description of Download item in normal or hover cases.; r=Paolo
MozReview-Commit-ID: ITkv5XdQxEI
2016-12-07 11:54:41 -10:00
Pavan
a1c2fe38a5 Bug 1324571 - Use cases of some multi-selection commands in Downloads Library not clear. r=mak 2017-01-19 01:37:00 +01:00
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Sean Lee
e6a4eae011 Bug 1282664 - Redesign the right-menu on a download item in Downloads Panel.; r=Paolo
MozReview-Commit-ID: DyTisE3dX1A
2016-10-14 14:07:00 +08:00
Boris Zbarsky
89d7a546a8 Bug 1298243 part 7. Change DataTransfer.types from being a DOMStringList to being a frozen array. r=mystor,gijs 2016-10-10 21:07:47 -04:00
Tooru Fujisawa
fe8a360906 Bug 92737 - Part 9: Download multiple files when multiple items are dropped on Downloads view in Library Window. r=enndeakin 2014-12-21 19:05:03 +09:00
Paolo Amadini
4b4a9792a3 Bug 1243445 - Pasting an invalid URL breaks the Downloads View in the Library. r=jaws
MozReview-Commit-ID: DCPhxiB1i0Y
2016-08-22 14:22:18 +01:00
Sumit Tiwari
4edded08d9 Bug 1290698 - Replace Iterator() with Object.{values, entries}; r=mossop
MozReview-Commit-ID: DEoVeqEZWpd
2016-08-07 21:58:24 -04:00
Paolo Amadini
6fd94ac5bf Bug 1282050 - Fix the updating of download commands in the Library. r=jaws
MozReview-Commit-ID: 7zSMcKe2REi
2016-07-15 15:09:10 +01:00
Jared Wein
fc1418d97d Bug 1280799 - Update the state of the 'Clear Downloads' button when download item state changes, even if the item is selected. r=paolo
MozReview-Commit-ID: 2YXLDuBxkTe
2016-06-24 21:36:40 -04:00
Panos Astithas
c45849d52b Bug 1139472 - Extend the attention state of the Downloads Indicator to indicate success or failure. r=paolo
With this change two new attention states are introduced, "severe" and "warning",
along with the previous "success" and "no attention" states. "No attention" is
still a falsy value in order to mitigate any add-on compatibility issues.
"severe" and "warning states" now display an icon badge to the downloads button
(or the hamburger button if the downloads button is tucked away).

MozReview-Commit-ID: 3gc9Ji7zCXY
2016-04-22 23:09:07 +03:00
Paolo Amadini
c69ef4bd4a Bug 1265387 - The default action for uncommon downloads should open the file directly. r=past
MozReview-Commit-ID: GrZev8J5MRN
2016-04-20 15:44:38 +01:00
Paolo Amadini
1ca2e7074f Bug 1198181 - Part 5 - Change the unblock dialog actions based on the verdict. r=past
MozReview-Commit-ID: 3NkvpI9EqpB
2016-04-20 11:16:00 +01:00
Paolo Amadini
eaa8692867 Bug 1198181 - Part 2 - Unify the code that updates the state of download items. r=jaws
MozReview-Commit-ID: KptYcAGbMG2
2016-04-15 15:37:22 +01:00
Paolo Amadini
3e0a5054f6 Bug 1139914 - Downloads with blocked data should be persisted across sessions. r=mak
MozReview-Commit-ID: 4XkSTaNZcLo
2016-03-20 14:25:42 +00:00
Paolo Amadini
8a79832341 Bug 1254100 - Part 2 - Downloads blocked by Application Reputation should provide information about the verdict. r=mak
MozReview-Commit-ID: FYH5Tdtbzn
2016-03-16 14:29:23 +00:00
Paolo Amadini
be12a70c50 Bug 1117145 - Part 5 - Share the implementation of some of the download item commands. r=jaws
MozReview-Commit-ID: La6km3izidY
2016-02-14 17:28:12 +00:00
Paolo Amadini
1e4079adf2 Bug 1117145 - Part 4 - Unify how commands are handled in the Downloads Panel and the Library. r=jaws
MozReview-Commit-ID: 2Irgwu5YI72
2016-02-29 15:50:57 +00:00
Paolo Amadini
b0f5fff9b3 Bug 1117145 - Part 3 - Share the download item binding between the Panel and the Library. r=jaws
MozReview-Commit-ID: D8wNJxSJm84
2016-02-11 21:00:38 +00:00
Gijs Kruitbosch
79cc61c615 Bug 120684 - use ChromeNodeList in toolkit's listboxes' selectedItems implementation, r=dao,smaug 2015-10-26 17:25:29 +01:00
Tooru Fujisawa
7fc9d2c511 Bug 1207491 - Part 6: Remove use of expression closure from browser/components/downloads/. r=Gijs 2015-09-23 18:36:20 +09:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Ian Neal
2c6e8e3026 Bug 1195279 - Fix typo in allDownloadsViewOverlay.js following landing of bug 1127867 r=paolo 2015-08-17 15:26:29 -07:00
Birunthan Mohanathas
fe337d7c5e Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
ziyunfei
649e7033e4 Bug 1102219 - Part 4: Replace String.prototype.contains with String.prototype.includes in chrome code. r=till 2015-04-30 00:32:05 +09:00
Jared Wein
325a0016a0 Bug 1137909 - part 2: context menuitem to unblock downloads and an X button to confirm the blocked download. r=paolo 2015-03-05 12:25:45 -05:00
Marco Bonardo
32485da9dc Bug 1135348 - Fix about:downloads by adding missing XPCOMUtils imports. r=paolo 2015-02-26 19:06:15 +01:00
Paolo Amadini
0333cf8e9e Bug 1129896 - Part 2 of 2 - Convert the shared front-end code to a JavaScript code module. r=mak 2015-02-16 18:49:56 +00:00
Paolo Amadini
c91332e4d9 Bug 1129896 - Part 1 of 2 - Keep cached metadata for history downloads indefinitely. r=mak 2015-02-16 18:49:54 +00:00
Paolo Amadini
7643037fa3 Bug 1127867 - Use the new back-end property to get the size of downloads asynchronously. r=mak 2015-02-16 18:49:52 +00:00
Paolo Amadini
31f72b0f7d Bug 1117141 - Part 2 of 2 - Refactor notifications and remove the DownloadsDataItem object. r=mak 2015-02-16 18:49:51 +00:00