Commit Graph

334 Commits

Author SHA1 Message Date
Zibi Braniecki
424682e3b6 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Sebastian Hengst
3a807c09ee Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
8c25be70ea Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Mike de Boer
bc72a05e37 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Sebastian Hengst
2b4cc8b55c Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Mike de Boer
6cb3ed2016 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Wes Kocher
08356deb1c Merge m-c to autoland, a=merge
MozReview-Commit-ID: LEKykpTAKjv
2017-08-25 17:32:33 -07:00
Gijs Kruitbosch
663af591de Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6
2017-08-25 13:32:47 +01:00
Blake Winton
cbe7a23f74 Bug 1384692 - Update the download doorhanger style. ui-r=amylee, r=Paolo.
MozReview-Commit-ID: 4pY9JxnLNYk
2017-08-01 09:18:11 -04:00
Gijs Kruitbosch
89a0e2f431 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ
2017-08-16 15:54:36 +01:00
Sam Foster
188cda4801 Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65
2017-08-11 16:06:02 -07:00
Sebastian Hengst
d73ac6aebe Backed out changeset bf522e33426e (bug 1388183) for eslint failure browser/components/downloads/content/indicator.js. r=backout on a CLOSED TREE 2017-08-17 22:04:54 +02:00
Sam Foster
0d626d6698 Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65
2017-08-11 16:06:02 -07:00
Jared Wein
d016c13ec8 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU
2017-08-07 12:37:34 -04:00
Paolo Amadini
d1e1b518d1 Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB
2017-08-04 14:48:53 +01:00
Sam Foster
09681512db Bug 1376519 - Photon download notifications. r=Paolo
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds
* Have #downloads-notification-anchor hidden by default, and show it before measuring for placement. This avoids the interference with scrolling/APZ when the notifier element is tall enough to overlap the tabbrowser element

MozReview-Commit-ID: LJF6iV9HiJi
2017-07-31 09:36:27 -07:00
Sebastian Hengst
7b711a731f Backed out changeset c6bbe349d654 (bug 1376519) on suspicion of letting mochitest test_bug574663.html fail. r=backout 2017-07-24 21:06:49 +02:00
Sam Foster
e60afc208c Bug 1376519 - Photon download notifications. r=Paolo
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds

MozReview-Commit-ID: LJF6iV9HiJi
2017-07-13 10:59:59 -07:00
Florian Quèze
e62545f7be Bug 1381853 - lazy load downloads scripts into the browser window, r=mconley. 2017-07-23 00:18:00 +02:00
Paolo Amadini
1a2766e349 Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1
2017-07-17 12:05:12 +01:00
Paolo Amadini
81fd3d7bde Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa
2017-07-17 12:07:17 +01:00
Paolo Amadini
1907d28bdd Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4
2017-07-16 17:36:00 +01:00
Paolo Amadini
0943598d9f Bug 1357915 - Fix download commands operating on multiple items in the Library window. r=Standard8
This was regressed by bug 1264206 while removing legacy array comprehensions, because selectedItems is a NodeList and not an Array.

MozReview-Commit-ID: 61GG3SiiWwS
2017-07-18 10:19:48 +01:00
Gijs Kruitbosch
2a9b14d9e7 Bug 1369729 - use descriptionheightworkaround for sync panel, r=mconley,Paolo
MozReview-Commit-ID: LQg6NEgCqz2
2017-06-28 17:50:43 +01:00
Sam Foster
cbfdf2d63d Bug 1375309 - Implement Photon download progressbar r=Paolo
* Split out the arrow and progressbar in the indicatorOverlay for individual animation.
* Group icon and progressbar parts into addressable elements in a single download-icons.svg

MozReview-Commit-ID: KAn0gFqjKjc
2017-06-28 15:03:52 -07:00
Florian Quèze
b622c2b081 Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Sebastian Hengst
a3e07c288c merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-05-24 11:27:29 +02:00
Paolo Amadini
efed284f45 Bug 1009116 - Redo resizing architecture of panelmultiview. r=Gijs
The height of the "panelmultiview" binding is now determined by the stack layout code, and doesn't have to be calculated manually via JavaScript anymore. This allows the removal of mutation and overflow observers, and reduces the number of synchronous layouts being made.

There is still a workaround included for wrapping blocks not being taken into account in height calculations.

MozReview-Commit-ID: 9rrPU5O5hUx
2017-05-23 17:08:01 +01:00
Doug Thayer
21ea798d89 Bug 1359733 - (pt. 5) Pull out indicator.js badges r=Gijs
See also pt. 4. We are moving app menu notification state
into a jsm since it is not specific to one window and this
simplifies work for the new app update UI.

MozReview-Commit-ID: InEp5b0y2n0
2017-05-15 11:57:58 -07:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Wes Kocher
76ce4b0d6d Merge m-c to autoland, a=merge
MozReview-Commit-ID: 3BrkDVl7521
2017-05-08 16:24:51 -07:00
Sam Foster
799e3c8af3 Bug 1329109 - remove unused time and progressbar code from downloads toolbar icon. r=Paolo
This removes the arrowStyledIndicator killswitch and the associated ability for system add-ons to restore the previous design of the Downloads Indicator in the toolbar. The removal includes all the related code, styles, and strings. Based on the original patch by :rexboy.

MozReview-Commit-ID: 2OEBzPNzl0O
2017-05-08 10:11:52 -07:00
Paolo Amadini
b972e9cc0c Bug 1362207 - Remove the dropdown menu from the footer of the Downloads Panel. r=mak
MozReview-Commit-ID: CFrHklbB7TK
2017-05-05 15:37:00 +01:00
Paolo Amadini
fece3c6437 Bug 1281186 - Remove uses of nsIDownloadManager from DownloadsCommon.jsm, DownloadsViewUI.jsm, and allDownloadsViewOverlay.js. r=mak
MozReview-Commit-ID: 28nc8aTea5v
2017-05-05 11:20:53 +01:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Doug Thayer
a5b27a8e9b Bug 893505 - Simplify the application update UI r=chmanchester,enndeakin+6102,Gijs,rstrong
There's quite a few changes in here. At a high level, all we're trying to do
is to replace the old update popup with a less intrusive and more modern
doorhanger (set of doorhangers) for various update failure conditions.

MozReview-Commit-ID: 24sESMTosNX
2017-03-21 13:50:09 -07:00
Rex Lee
9734c37866 Bug 1349406 - Avoid reflows for arrow-typed download indicators by using stack instead of position: absolute. r=Paolo
MozReview-Commit-ID: KLsYueSWKId
2017-03-24 19:54:59 +08:00
Yiren Wang
fd7cf240a8 Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
David Rajchenbach-Teller
d557516aec Bug 1087255 - Convert Download JS clients of RemovePage(s) to History.remove;r=paolo
MozReview-Commit-ID: KpXAh74W12E
2014-10-31 12:39:28 +01:00
Rex Lee
21ed3ddf62 Bug 1270012 - Show a bouncing animation for toolbar download icon whenever a download is started. r=paolo
MozReview-Commit-ID: GCDhtYCVC6
2016-09-12 18:27:22 +08:00
Rex Lee
9c1e3c5822 Bug 1338984 - Adjust brightness with respect to download progress for arrow-typed progress icon. r=Paolo
MozReview-Commit-ID: 9pMRmsduskA
2017-02-24 17:33:41 +08:00
Rex Lee
d0e1630d30 Bug 1270006 - Fill portion of the icon on download button as indicator to download progress r=Paolo
MozReview-Commit-ID: BqYow8jWCVD
2016-08-24 18:39:53 +08:00
Sean Lee
233ef57ca5 Bug 1282662 - Part 2: Implement the detail description in hover button case.; r=Paolo
MozReview-Commit-ID: G3L0sULmRLD
2016-12-21 22:50:07 +08:00
Sean Lee
e9de65ebe2 Bug 1282662 - Part 1: Redesign the detail description of Download item in normal or hover cases.; r=Paolo
MozReview-Commit-ID: ITkv5XdQxEI
2016-12-07 11:54:41 -10:00
George Pîrlea
7262d5afe4 Bug 991965 - Inhibit item selection and update commands when the DownloadsBlockedSubview is open. r=paolo
MozReview-Commit-ID: Akly0NenY8Z
2017-01-21 17:42:36 +00:00