Commit Graph

163 Commits

Author SHA1 Message Date
Kris Maglione
0fb6b2e73c Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj
2017-08-09 13:03:36 -07:00
Marco Castelluccio
7501412ad3 Bug 1357517 - Remove or delay Preferences.jsm usage from some browser/base/content/* files. r=Gijs 2017-07-31 12:51:35 +02:00
Florian Quèze
b622c2b081 Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Andrew McCreight
7e922836a7 Bug 1371042 - Fix destructuring assignment in sanitize.js. r=Gijs
MozReview-Commit-ID: 4farchkzM60
2017-06-07 14:23:47 -07:00
Andrew McCreight
e354c6d560 Bug 1370732 - Define Cc and Ci in sanitize.js. r=Gijs
These are referred to, but never explicitly defined. Under some
circumstances with shared JSM globals, this will cause an error.

MozReview-Commit-ID: 5DP2NSRoNML
2017-05-31 14:24:52 -07:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Mark Banner
1b6f3efb6e Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
MozReview-Commit-ID: BuTyJAfUoWR
2017-02-22 17:02:59 +00:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Marco Bonardo
8ae862c600 Bug 1345075 - Remove FX_SANITIZE_LOADED_FLASH and FX_SANITIZE_UNLOADED_FLASH. r=Felipe
MozReview-Commit-ID: 1WoxWh3OkL4
2017-03-07 14:13:07 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Aman Dwivedi
aec48bf322 Bug 1323685 - Remove workarounds for bug 449811. r=mak 2016-12-22 16:33:28 +05:30
Bob Silverberg
0bd0eb6f24 Bug 1324760 - Expose a function that clears plugin data in sanitize.js, r=mak
MozReview-Commit-ID: A8AxhyzyEwk
2016-12-20 09:24:06 -05:00
Dão Gottwald
1f4f975c74 Bug 1323807 - Make sanitize.js handle the search bar having moved to the overflow or menu panel. r=mak 2016-12-16 19:57:08 +01:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Matthew Noorenberghe
43b68a5876 Bug 1297905 - Remove usage of getAllDisabledHosts in sanitize implementations. r=liuche,markh
Bug 1058438 moved disabled hosts to the permission manager which are already cleared by these modules.

MozReview-Commit-ID: InprrYLvjMR
2016-08-24 17:41:10 -07:00
Marco Bonardo
6ba307bc32 Bug 1287428 - Fix expiration of the FX_SANITIZE_ probes expiring in v50.r=adw
MozReview-Commit-ID: IckqRR0RBbd
2016-07-26 17:27:17 +02:00
Kit Cambridge
9a306d9099 Bug 1275436 - Remove push subscriptions from the server after clearing permissions and site data. r=mt
Previously, we removed records locally, but didn't notify the server.
We can be nice and avoid making the server buffer messages for
subscriptions that the client will never use again.

MozReview-Commit-ID: 5iohGQPHXuz
2016-05-20 09:38:26 -07:00
Marco Bonardo
4055c69152 Bug 1258354 - Sanitize on shutdown adds 2 blockers, when only one is really needed. r=yoric
MozReview-Commit-ID: BbtZMIwT54N
2016-04-13 14:08:18 +02:00
Andrea Marchesini
0d6b911fbc Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-10 05:46:07 +01:00
Ryan VanderMeulen
f16cc2b8b7 Backed out changeset 7d5f1e9ce04c (bug 1259169) for various cookie-related crashes and test failures. 2016-04-09 15:36:07 -04:00
Andrea Marchesini
c505892d92 Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-09 19:09:49 +01:00
Dave Townsend
17d8a23b3f Bug 1257246: Update browser for eslint 2. r=felipe
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: DEskVIjiKDM
2016-04-05 11:33:33 -07:00
David Rajchenbach-Teller
80aac4e977 Bug 1253204 - Don't abort shutdown on plugins sanitization;r=mak
MozReview-Commit-ID: 5bub8n8cCsZ
2016-03-04 16:11:21 +01:00
Marco Bonardo
d9958282f0 Bug 1252089 - Report the in-progress sanitization in shutdown abort metadata. r=yoric
MozReview-Commit-ID: KjmRVLpBLJx
2016-02-29 17:26:12 +01:00
Marco Bonardo
fa0aca0ccb Bug 1251469 - Add telemetry probes for the time needed to sanitize a loaded or unloaded Flash. r=yoric
MozReview-Commit-ID: 8j9teGzMSV2
2016-02-26 14:50:41 +01:00
Andrea Marchesini
5685489215 Bug 1245184 - nsICookieManager.remove should use the OriginAttributes, r=sicking 2016-02-25 16:41:13 +01:00
Marco Bonardo
584fdc06bb Bug 1250362 - don't flush prefs on startup unless it's really needed. r=yoric
MozReview-Commit-ID: FLrlrF4A1Om
2016-02-23 23:29:43 +01:00
Marco Bonardo
05837e1168 Bug 1249786 - fix typo. r=me on a CLOSED TREE
MozReview-Commit-ID: 3AeOpRsNd23
2016-02-22 16:52:06 +01:00
Marco Bonardo
a808cc3582 Bug 1249786 - Sanitize on startup prefs are broken. r=yoric
MozReview-Commit-ID: LDmK7G1BhGP
2016-02-19 23:22:24 +01:00
Carsten "Tomcat" Book
a50632893b Backed out changeset 27f3968ae8b2 (bug 1245184) 2016-02-19 15:55:23 +01:00
Andrea Marchesini
9111a1ecc9 Bug 1245184 - CookieManager should remove cookies only if they match the userContextId, r=sicking 2016-02-19 14:49:50 +01:00
Marco Bonardo
8876034697 Bug 1244650 - Failure to clear Forms and Search Data on exit. r=yoric
The problem is due to sanitization happening too late in the shutdown cycle.
The Sanitizer depends on Places shutdown, that recently moved to async shutdown.
That change caused shutdown to happen completely at profile-before-change, unfortunately
during that phase it's impossible to predict which services are already shutdown.
The patch restores the previous Places shutdown procedure, thus clients are notified
earlier, during profile-change-teardown.

Additional meaningful changes:
* Fixes FX_SANITIZE_TOTAL telemetry to properly count total time taken by sanitize.
* Makes each cleanup operation isolated from other errors to try cleaning up as most as possible.
* In case of multiple sanitization sub steps, each step is isolated by a try/catch, the last seen exception is reported upstream.
* Makes FX_SANITIZE_HISTORY actually measure history, not other random stuff.
* Removes TOPIC_SIMULATE_PLACES_MUST_CLOSE_1 since we can now just use profile-change-teardown for shutdown phase 1.

MozReview-Commit-ID: HroLvbi25IC
2016-02-04 13:51:34 +01:00
Marco Bonardo
90d333995b Bug 1243549 - Add missing bits. r=post-facto
MozReview-Commit-ID: BTRUMtNsSeQ
2016-02-11 16:09:17 +01:00
David Rajchenbach-Teller
5f96c50446 Bug 1243549 - Make sure that startup sanitization doesn't throw because it can't find a tabbrowser. r=mak 2016-02-04 09:40:40 -05:00
Matthew Noorenberghe
b50b95d9ec Bug 1244908 - Remove privacy.clearOnShutdown.passwords migration code. r=dolske 2016-02-03 15:26:14 -08:00
Matthew Noorenberghe
5e818f4225 Bug 1242176 - Don't migrate privacy.clearOnShutdown.passwords if privacy.sanitize.sanitizeOnShutdown is false. r=dolske 2016-01-28 10:49:00 -08:00
Mélanie Chauvel (ariasuni)
3a1b3af8b3 bug 1211849 - Remove canClear support from the Sanitizer. r=mak
Modifications by Patrick <nwokop@uni.coventry.ac.uk>
2015-10-07 19:46:35 +02:00
Kit Cambridge
4bb109e9c0 Bug 1189998, Part 2 - Migrate Push service callers. r=mt 2015-12-08 15:41:48 -05:00
Felipe Gomes
cc4e635794 Bug 1229603 - Make most of browser/base lintable by removing non-standard syntax. r=Mossop 2015-12-02 17:51:26 -02:00