corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
501,587 Commits 1 Branch 0 Tags
424682e3b61c63ac75b51d38c03e12a4ff512122
Commit Graph

476 Commits

Author SHA1 Message Date
Marco Bonardo
70c4a90e76 Bug 625778 - Contextual commands on the main menubar bookmarks menu don't work after a customization. r=adw 
MozReview-Commit-ID: 8Atiql9Zplv
 2017-06-09 16:15:28 +02:00
Drew Willcoxon
d28a56eefb Bug 1363183 - Add a "bookmark" item to the page action menu. r=mikedeboer 
MozReview-Commit-ID: 9RR4U3X3gIT
 2017-05-25 16:19:02 -07:00
milindl
d307ef0df3 Bug 1350377 - Remove getPlacesInfo and change associated files and tests, r=mak 
Files which make use of `getPlacesInfo` have been replaced with `History.fetch`.
The code for `GetPlacesInfo` has been deleted from the cpp and idl files.
The test for `getPlacesInfo` has been suitably rewritten and moved alongside the
other History.jsm tests.

There were 2 places where the fact that `getPlacesInfo` takes an array as opposed
to a single uri mattered, in `test_getPlacesInfo.js` and `test_refresh_firefox.py`.

MozReview-Commit-ID: KQSMHCvvlrQ
 2017-05-17 16:02:21 +05:30
Marco Bonardo
9cd385fe81 Bug 1364488 - Allow fetch to use a concurrent connection. r=standard8 
MozReview-Commit-ID: 4L4PFtXsjsy
 2017-05-17 15:51:02 +02:00
Marco Bonardo
8488ea9641 Bug 1364488 - Recover from a Talos regression due to recent changes to the Star button. r=standard8 
The main reason for these changes is to avoid initializing the bookmarks service too early,
plus a lot of micro-optimizations to reduce the code-bloat compared to the previous bogus
(but slick) async getter.

MozReview-Commit-ID: Fy4fshsDaIw
 2017-05-15 19:32:47 +02:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Pauline
903b853642 Bug 1157709 - Removed all uses of PlacesUtils.asyncGetBookmarkIds. r=mak77 
MozReview-Commit-ID: FPhhbbIxOwz
 2017-05-11 14:23:03 +01:00
Nihanth Subramanya
e8ef9ee48c Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao 
MozReview-Commit-ID: EWgOI8x4Qdj
 2017-04-28 21:47:07 +05:30
Carsten "Tomcat" Book
efd5419472 Backed out changeset 4d6cbe2ebbd1 (bug 1347543) for causing bc6 issues 2017-05-03 15:50:55 +02:00
Nihanth Subramanya
82b97772b5 Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao 
MozReview-Commit-ID: 27zDcyScFnj
 2017-04-28 21:47:07 +05:30
Wes Kocher
2e2823a7c7 Backed out changeset 0e3f9e184e6b (bug 1347543) for landing on the wrong tree a=backout 
MozReview-Commit-ID: 33rhqi8g77s
 2017-04-28 12:32:38 -07:00
Nihanth Subramanya
53ce1a1e14 Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao 
MozReview-Commit-ID: AdW6POOBeeh
 2017-04-28 21:47:07 +05:30
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Kirk Steuber
a5f3668356 Bug 1349823 - Populate bookmark panel before showing it r=enndeakin+6102,mak 
When panel behavior became asynchronous, |StarUI._doShowEditBookmarkPanel| needed to be changed to wait for the panel to finish opening before initializing it. Although the content of the panel can be changed successfully before the panel opens, the element focus at the end of initialization fails. This prevents the capturing of certain events, such as an Esc keypress (which should close the panel).

However, this introduced the problem where there is a short delay between when the bookmark panel opens and when the correct content is displayed in it. To fix this, the initialization function |gEditItemOverlay.initPanel| will now be called before the panel opens, but the element focus code will wait for the panel's popupshown event.

MozReview-Commit-ID: 6SrcCz963qW
 2017-04-05 15:38:37 -07:00
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Jared Wein
bcfb85b065 Bug 1294799 - Disable the autoclosing of the bookmark popup if there is any interaction with it such as mousedown or keypress. r=mak 
MozReview-Commit-ID: JRo5ZVu0uFD
 2017-02-10 11:11:57 -05:00
Jared Wein
65cc3fc0d6 Bug 1335043 - Prevent the bookmark panel from closing automatically if the mouse is hovering over it. r=mak 
MozReview-Commit-ID: 2jor6H2cQck
 2017-01-30 10:34:53 -05:00
Thom Chiovoloni
43289b1e98 Bug 1295237 - Add 'Mobile Bookmarks' root to the bookmark menus if we have it. r=markh 
MozReview-Commit-ID: 3ybnskOID1O
 2017-01-17 13:15:49 -05:00
Ehsan Akhgari
ec238285dd Bug 1319908 - Load the menu icons for the bookmarks menu with the correct content type and principal on OSX; r=baku 
This patch makes nsMenuItemIconX also participate in the setup
introduced in bug 1277803.
 2017-01-20 10:55:23 -05:00
Masayuki Nakano
4da8f2b45c Bug 1331798 Bookmark panel for new bookmark shouldn't be closed automatically during composition and after text input without keyboard events nor composition events r=jaws 
Bookmark panel for a new bookmark shouldn't be closed automatically during composition even if mouse cursor is moved outside the panel because user may click in IME's UI.

Additionally, editor might be modified without keyboard events nor composition events.  In such case, the bookmark panel shouldn't be closed automatically too.

MozReview-Commit-ID: 1FAUmkXjid
 2017-01-19 15:04:56 +09:00
Jared Wein
be861fe6d3 Bug 1327938 - Clear the existing timeout before creating a new one, as we should only have one autoclose timer running at a time. r=mak 
MozReview-Commit-ID: 9HdSMGWRvb1
 2017-01-18 11:17:10 -05:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Florian Quèze
b36a8b8f42 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Jared Wein
1cde0c1e45 Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop 
MozReview-Commit-ID: AQ0Q4zb2g2Q
 2017-01-03 17:02:09 -05:00
Phil Ringnalda
d436071a6a Backed out changeset 83d895c1c1ea (bug 1326712) for failures in browser_bookmark_popup.js 2017-01-03 19:36:42 -08:00
Jared Wein
af375db7c6 Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop 
MozReview-Commit-ID: AQ0Q4zb2g2Q
 2017-01-03 17:02:09 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Marco Bonardo
e00ec4e5e7 Bug 1321556 - Remove unused bindings from urlbarbindings.xml. r=dao 
MozReview-Commit-ID: FfIsoh76ajn
 2016-12-09 14:17:12 -10:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws 
MozReview-Commit-ID: 2ZvTiZDHchz
 2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws 
MozReview-Commit-ID: HBpjT2uHJaZ
 2016-11-10 14:48:04 -08:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop 
MozReview-Commit-ID: HIUTSdkXxbY
 2016-11-03 14:42:06 -04:00
Mark Banner
6b3a6a4cda Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop 
MozReview-Commit-ID: IyFGBotfd11
 2016-10-31 10:33:38 +00:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8 
MozReview-Commit-ID: 7Gx90a5y8t6
 2016-10-24 13:14:19 -04:00
Mark Banner
9b40970863 Bug 1313626 - Clean up more issues found by eslint no-undef rule. r=mossop 
MozReview-Commit-ID: HGiOmpyN5zV
 2016-10-28 11:40:32 +01:00
Dão Gottwald
541f5a3c25 Bug 1304617 - Avoid using the ordinal attribute for positioning the Hide / Show Recently Bookmarked menu items. r=mak 2016-10-13 18:47:52 +02:00
Kirk Steuber
2c1ac87580 Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin 
MozReview-Commit-ID: Dh1npORCQ6J
 2016-08-16 15:33:05 -07:00
Katie Broida[:ktbee]
0bcb756d06 Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws 2016-08-19 07:27:00 -04:00
Wes Kocher
60df6d1b56 Backed out changeset 33fcf83eefe4 (bug 1171746) for browser_visibleFindSelection.js failures a=backout 2016-08-12 19:11:21 -07:00
Katie Broida[:ktbee]
d45a62dd73 Bug 1171746 - ensure tab specific panels close when you switch the tab r=jaws 
Adds a tabspecific attribute to the edit bookmarks panel and the Pocket subview panel to signal that these popups should close when the user navigates away from the tab. It also specifies that the localized keyboard short cut for closing a  window should close the edit bookmarks panel and the tab by adding a general function to check whether a certain <key> has been pressed. Adds tests for both closing specific tabs and checking keys.

MozReview-Commit-ID: AxW5uQgDQQB
 2016-08-11 16:51:45 -04:00
Dão Gottwald
9fe86c0970 Bug 1289659 - Account for placesContext not existing in non-browser windows on Mac. r=mdeboer 2016-08-10 13:49:20 +02:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt
 2016-08-04 03:28:58 -04:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00