* Group imports
* Convert seralization helper function to use `Iterator::fold`
* Remove basically pointless `serialize_value` helper function
* Wrap lines longer than 100 chars
* Add URLs to spec
Source-Repo: https://github.com/servo/servo
Source-Revision: 018e1f726d0ec0bf3d0dee68594ef1151dc8049d
Changed Key::N to KeyN, also changed Equals to Equal, and NumpadEquals to NumpadEqual.
Source-Repo: https://github.com/servo/servo
Source-Revision: 629edc5c46a869b5bb6bc51b8d39b0115702a00c
"Negative values for radius must cause the implementation to throw an IndexSizeError exception."
Source-Repo: https://github.com/servo/servo
Source-Revision: 1bd8e18d92c291418ce6a5712f7b4503d9b5104c
We should ensure the parameter is lowercased. Right now, the assert will
always return true.
Discussed in #5445
Introduced in ee2ccc4f872ba33a86057d87a99d1015b3c41cf1
Source-Repo: https://github.com/servo/servo
Source-Revision: 350a35428ab547e45e86826d2a818cb15d004bf5
For the majority of these cases, `as_slice` can be removed due to
`Deref`. In particular, `Deref` for:
* `String` -> `str`
* `Atom` -> `str`
The latter of those two requires, a bump of the locked `string-cache`
library
Source-Repo: https://github.com/servo/servo
Source-Revision: 0fd41847a39be387c03bd5d8b6f2aec2b1bb6f66
These became unused in f45db7714c8c3244fe20d1b0a104cb845d0b79f5; I don't know
why I didn't notice that.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2b9bfb9af387fba1a080bed070cf6134eb5d10e1
This is for #4704. I'm not sure if this is the best approach, so I'm open to suggestions.
Source-Repo: https://github.com/servo/servo
Source-Revision: 439e3150d74453b86abbcc7934b7e5152f102940
Also adding some newlines for visual separation between
functions/methods
Source-Repo: https://github.com/servo/servo
Source-Revision: 699ace844c939ab97180acad67a984dc71108a12
Was introduced in 7aee1cae84704b885988a5985a7604747125ec1e
I noticed it isn't actively in use, so unless there's some bigger reason
why it exists, it could probably be removed
Source-Repo: https://github.com/servo/servo
Source-Revision: 96fb1dac3d346cf2e46e5d5ec5abf79134743dad
It was originally titled XHRDone to prevent conflicts with other
variants called Done. This was done before enum namespacing landed, but
now that it has, the prefixing is not necessary.
Source-Repo: https://github.com/servo/servo
Source-Revision: 88ca398cae4070957306890b0c7006ac7b9e5cef
This fixes the case of clicking a link in an iframe, going back, then clicking the link again.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2f85c5bb502c2582d34772db979e27c741ee76e3
In these cases for `format!`, we're just constructing a String of the
single argument with no special format.
Source-Repo: https://github.com/servo/servo
Source-Revision: dfb8929b001c8d0fb6d5e63f5a9d6dcc17cb388a
There were a few things that were bothering me with `SetBody`:
* The 'Step 3' comment is in the wrong place
* The logic of 'Step 4' comes before 'Step 3'
* 'Step 5' was not documented
Source-Repo: https://github.com/servo/servo
Source-Revision: 445f1c891a5536a26b4759ba4b2dab99c31505f4
Gives us a place to store polyfills and other userscripts so that we can:
- Quickly determine what DOM features are needed to make stuff like jQuery work by iteratively writing stub implementations
- Write spec-incompatible but "good enough" polyfills for stuff like jQuery to make Servo more testable on live sites, for demos, and for browser.html
r? @jdm
cc @eddyb
Source-Repo: https://github.com/servo/servo
Source-Revision: 72e2c79a089ff6654a36951ce4aedac62006e6a1
Fixes#1871
I thought I'd take a look at this for a first contribution to servo. A couple of things I'm not 100% sure on are:
1) `get_proto_or_iface_array` returns a `*mut *mut JSObj`, which I'm assuming is really an array of pointers to `JSObj`s. So dropping its return value will drop the memory for the array of pointers. Do we also need to drop each element, or is that handled by GC?
2) Are there any tests I need to add for this? I don't know if there are existing leak tests, or if leaks are mostly discovered by profiling.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8998edb912b4f6efea7b2ff4e707325d7c03488c
Fixing ConsoleMsg for console.log messages in the Developer Tools web console.
Source-Repo: https://github.com/servo/servo
Source-Revision: ab8d43910ca2f3e60e3dd1417be80ab53f438b6e