Commit Graph

914 Commits

Author SHA1 Message Date
Dão Gottwald
6876424fca Bug 1850721 - Correctly check boolean attributes when deciding whether to set indicator-replaces-favicon, and correctly carry over boolean attributes when moving a tab to another window. r=mak,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D187183
2023-09-05 09:57:27 +00:00
Sandor Molnar
bff2d3b8b8 Backed out changeset ad7684944acc (bug 1850721) for causing bc failures in dom/base/test/browser_timeout_throttling_with_audio_playback.js CLOSED TREE 2023-09-01 19:46:14 +03:00
Dão Gottwald
603d3e682f Bug 1850721 - Correctly check boolean attributes when deciding whether to set indicator-replaces-favicon, and correctly carry over boolean attributes when moving a tab to another window. r=mak,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D187183
2023-09-01 15:41:22 +00:00
Dão Gottwald
5e89f4908b Bug 1849904 - Convert a bunch of psuedo-boolean tab strip attributes to be standard boolean attributes. r=mconley,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D186729
2023-08-29 06:52:49 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Mathew Hodson
28aa899942 Bug 1564391 - Rename internal uses of mozInputSource. r=emilio,pip-reviewers,tabbrowser-reviewers,dao,kpatenio
This allows us to deprecate `mozInputSource` for the Web while
avoiding console warnings for internal uses, which now use the
ChromeOnly `inputSource` attribute.

Differential Revision: https://phabricator.services.mozilla.com/D183643
2023-07-26 09:27:45 +00:00
Tooru Fujisawa
c734647bbc Bug 1766765 - Update the comment that mentions ContentLinkHandler.jsm to point FaviconLoader.sys.mjs instead. r=Gijs DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D183641
2023-07-18 19:59:26 +00:00
Dão Gottwald
bbec0cb63b Bug 1705215 - Stop resizing all background browsers when showing the bookmarks toolbar only on the new tab page. r=Gijs,tabbrowser-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D183493
2023-07-17 15:59:59 +00:00
Shane Hughes
99e82b0f08 Bug 1821826 - Refactor FeatureCallout to support generic triggers. r=omc-reviewers,fxview-reviewers,tabbrowser-reviewers,dao,jprickett,sclements
Also disable the Firefox View feature tour to avoid any risk of
regressions. The feature tour code will be removed in a later patch.
It's still present for now for testing purposes.

Differential Revision: https://phabricator.services.mozilla.com/D180927
2023-07-11 16:00:40 +00:00
Sam Foster
b23b17ffa1 Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00
Cosmin Sabou
a41e837bdf Backed out 2 changesets (bug 1819675) for causing a spike in wpt and browser-chrome failures.
Backed out changeset aa4368bfb81a (bug 1819675)
Backed out changeset e5be8edfd9cf (bug 1819675)
2023-07-08 13:44:40 +03:00
Sam Foster
5ddefef54e Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00
Gregory Pappas
6a57b64306 Bug 1841969 - Remove markupDocumentViewer getters r=mconley,tabbrowser-reviewers,dao
They're unused and the tabbrowser one seems to be broken

Differential Revision: https://phabricator.services.mozilla.com/D182875
2023-07-06 17:24:09 +00:00
Dão Gottwald
760282cdb1 Bug 1777870 - Format the urlbar value after tab select and focus change, and avoid formatting multiple times when handling blur events. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D181888
2023-06-27 12:42:07 +00:00
James Teow
d6897c0c12 Bug 1781806 - Trigger afterTabSwitchFocusChange in the Urlbar even if the tab is already selected and is going to receive a TabSelect event - r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D181115
2023-06-22 12:06:43 +00:00
Gregory Pappas
7b8c07142a Bug 1809094 - Implement tab.autoDiscardable property r=robwu,geckoview-reviewers,extension-reviewers,Gijs,owlish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D166440
2023-06-21 07:50:17 +00:00
Cosmin Sabou
811d79e739 Backed out changeset f3fe6cc42791 (bug 1809094) for bc failures on browser_ext_tabs_autoDiscardable.js. 2023-06-21 03:24:56 +03:00
Gregory Pappas
ad10790d6e Bug 1809094 - Implement tab.autoDiscardable property r=robwu,geckoview-reviewers,extension-reviewers,Gijs,owlish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D166440
2023-06-20 23:59:08 +00:00
Sandor Molnar
1e6677e684 Backed out changeset 0ee2d1b2ec37 (bug 1809094) for causing android bustages. CLOSED TREE 2023-06-21 02:20:26 +03:00
Gregory Pappas
b89c0a7e67 Bug 1809094 - Implement tab.autoDiscardable property r=robwu,geckoview-reviewers,extension-reviewers,Gijs,owlish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D166440
2023-06-20 23:06:37 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Daisuke Akatsuka
c1ce24fd5a Bug 1836051: Restore selection range when tab switching r=tabbrowser-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D180415
2023-06-14 22:16:21 +00:00
Daisuke Akatsuka
1f42ad0209 Bug 1836051: Make the urlbar to revert its previous focus state when switching tabs r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D180266
2023-06-14 22:16:20 +00:00
Butkovits Atila
e013ce3291 Backed out 2 changesets (bug 1836051) for causing failures at browser_keepStateAcrossTabSwitches.js. CLOSED TREE
Backed out changeset 1b340c6a4e28 (bug 1836051)
Backed out changeset b15e56c19bb7 (bug 1836051)
2023-06-14 19:19:31 +03:00
Daisuke Akatsuka
f01241b6d9 Bug 1836051: Restore selection range when tab switching r=tabbrowser-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D180415
2023-06-14 12:53:12 +00:00
Daisuke Akatsuka
7e13016aa7 Bug 1836051: Make the urlbar to revert its previous focus state when switching tabs r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D180266
2023-06-14 12:53:12 +00:00
Dão Gottwald
a1da4da44d Bug 1837174 - Replace [first-visible-unpinned-tab] selector with :nth-child and get rid of _setPositionalAttributes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D180213
2023-06-07 18:42:07 +00:00
Niklas Baumgardner
cafd4fd680 Bug 1811115 - Make tab owner a weak reference. r=dao,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D179558
2023-06-06 13:26:39 +00:00
Sam Foster
ffc79712f2 Bug 1819675 - rename SessionStore.getClosedTabCount and getClosedTabData to getClosedTabCountForWindow and getClosedTabDataForWindow. r=dao,fxview-reviewers,kcochrane
- As closed tabs will change to mean closed tabs from all windows, rename these functions to make
  changes in later patches clearer when we mean closed tabs from this window specifically, or closed
  tabs for all private/non-private windows

Differential Revision: https://phabricator.services.mozilla.com/D177849
2023-05-30 18:54:12 +00:00
Fred Chasen
b2ee1caee5 Bug 574385 - Reset related tabs on system triggered page navigations r=mhowell
Check the triggering principal of document loads in TabProgressListener's onLocationChange event,
and clear the related tabs if load was triggered by the system principal (typed in the url bar / bookmarks / history, etc.) to prevent grouping unrelated tabs.

Differential Revision: https://phabricator.services.mozilla.com/D178373
2023-05-23 16:47:48 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Niklas Baumgardner
30cead34a2 Bug 1791231 - Open link in new tab after selected tab. r=dao,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D178242
2023-05-18 15:18:11 +00:00
Brice Laurencin
f7bb93f59c Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
2023-05-10 10:08:24 +00:00
Stanca Serban
67a233d35f Backed out changeset 50c9a0bea4c6 (bug 1418462) for causing mochitests failures in browser_middleClick.js. CLOSED TREE 2023-05-10 02:50:36 +03:00
Brice Laurencin
b6311d6f18 Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
2023-05-09 20:50:04 +00:00
Niklas Baumgardner
ec558f08b8 Bug 1188978 - Expose tab playing to accessibility clients. r=dao,mhowell,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D176814
2023-05-03 17:51:57 +00:00
Emilio Cobos Álvarez
7b99f3eb89 Bug 1828477 - Support input type=date in non-tabbrowser windows. r=Gijs,geckoview-reviewers,ohall
Differential Revision: https://phabricator.services.mozilla.com/D175771
2023-04-20 21:14:07 +00:00
Cristina Horotan
1f70ff41ad Backed out changeset fcd3e501bdac (bug 1828477) for causing gv-junit failures. CLOSED TREE 2023-04-19 17:28:42 +03:00
Emilio Cobos Álvarez
2290a1d8e2 Bug 1828477 - Support input type=date in non-tabbrowser windows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D175771
2023-04-19 11:15:08 +00:00
Natalia Csoregi
34a8f8c95d Backed out changeset 8abb5d78b663 (bug 1828477) for causing multiple failures e.g gv-junit on emptyShareReturnsTypeError. CLOSED TREE 2023-04-18 22:27:29 +03:00
Emilio Cobos Álvarez
df2c483941 Bug 1828477 - Support input type=date in non-tabbrowser windows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D175771
2023-04-18 17:35:48 +00:00
Daisuke Akatsuka
f1441c3114 Bug 1824040: Make the loading URL opened in _blank target to be the target of Session Restore r=mak,smaug,farre,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D173790
2023-04-14 01:59:44 +00:00
Emilio Cobos Álvarez
a0c2c34335 Bug 1819721 - Add some debugging utilities for StatusPanel debugging. r=dao
Not sure if this is worth it, your call. But I wrote this so I figured
someone debugging this code might find it useful.

Depends on D172033

Differential Revision: https://phabricator.services.mozilla.com/D172034
2023-04-13 15:31:03 +00:00
Dão Gottwald
e7a78cd6d0 Bug 1822532 - Avoid flushing layout to determine a tab's width when closing it. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D174127
2023-03-30 21:01:22 +00:00
Shane Hughes
7cf9a86c67 Bug 1818829 - Implement Feature Callout theme configuration. r=jprickett,omc-reviewers,fxview-reviewers,sfoster
Add logic to apply theme colors to Feature Callout based on where it's
going to show. We can use in-content CSS properties for Firefox View and
other themed system pages, but not for PDF.js, nor for any callouts we
might show in the browser chrome in the future. For the browser chrome
in general, we can use the lightweight theme properties directly, in the
same way the chrome frontend does. But PDF.js is a special case, since
although it exists in the chrome, it's meant to appear like it's in the
PDF.js viewer. And the PDF.js viewer has its own theme totally
independent of everything else. So this dynamically applies themes from
different sources.

This also fixes the bug where the PDF.js color scheme could mismatch the
PDF.js viewer if the browser theme and system color scheme don't match,
e.g. where system color scheme is light but a dark theme is installed,
or vice versa. For PDF.js specifically, we can use the
-moz-content-prefers-color-scheme media query to follow the color scheme
as it exists in the PDF.js viewer page instead of the color scheme in
the chrome window where the Feature Callout actually exists.

It also adds or modifies some colors that were previously missing or
different from the prototype, fixes the illegibility of buttons in HCM
and forced colors mode, and makes some other minor color changes.

Differential Revision: https://phabricator.services.mozilla.com/D173088
2023-03-28 00:38:42 +00:00
Cosmin Sabou
c31085cb42 Backed out changeset fecef27ba1fa (bug 1818829) for causing newtab failures on _feature-callout-theme.scss. CLOSED TREE 2023-03-28 02:46:44 +03:00
Shane Hughes
43bb7f08b0 Bug 1818829 - Implement Feature Callout theme configuration. r=jprickett,omc-reviewers,fxview-reviewers,sfoster
Add logic to apply theme colors to Feature Callout based on where it's
going to show. We can use in-content CSS properties for Firefox View and
other themed system pages, but not for PDF.js, nor for any callouts we
might show in the browser chrome in the future. For the browser chrome
in general, we can use the lightweight theme properties directly, in the
same way the chrome frontend does. But PDF.js is a special case, since
although it exists in the chrome, it's meant to appear like it's in the
PDF.js viewer. And the PDF.js viewer has its own theme totally
independent of everything else. So this dynamically applies themes from
different sources.

This also fixes the bug where the PDF.js color scheme could mismatch the
PDF.js viewer if the browser theme and system color scheme don't match,
e.g. where system color scheme is light but a dark theme is installed,
or vice versa. For PDF.js specifically, we can use the
-moz-content-prefers-color-scheme media query to follow the color scheme
as it exists in the PDF.js viewer page instead of the color scheme in
the chrome window where the Feature Callout actually exists.

It also adds or modifies some colors that were previously missing or
different from the prototype, fixes the illegibility of buttons in HCM
and forced colors mode, and makes some other minor color changes.

Differential Revision: https://phabricator.services.mozilla.com/D173088
2023-03-27 23:07:45 +00:00