This vendors this revision:
8986582d37
It also makes some desktop fixes due to some breaking changes in Suggest, which
@daisuke previously reviewed. It's a large vendor due to vendoring some new
crates plus some app-services revisions that made changes to logging and error
reporting and touched lots of files.
Differential Revision: https://phabricator.services.mozilla.com/D250877
ExperimentManager.unenroll() is now effectively async when running in a
browser test (because we are now executing SQL queries during
unenrollment) so all cleanup functions that trigger unenrollment are
async as well.
Differential Revision: https://phabricator.services.mozilla.com/D250505
This reverts commit ec5fa1d4c0.
Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"
This reverts commit baa5d72bbd.
Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"
This reverts commit 9604b0a8ae.
Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"
This reverts commit 686c1cf85f.
Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"
This reverts commit a7a4f31251.
Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"
This reverts commit 41bc4d5237.
Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"
This reverts commit 7bb7f82374.
Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"
This reverts commit c22e910235.
Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"
This reverts commit c08e43fc3d.
Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"
This reverts commit 4f2a32d1a4.
Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"
This reverts commit c05f675ddf.
Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"
This reverts commit b10c7de8d0.
Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"
This reverts commit d32c555e37.
Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"
This reverts commit 965887a708.
Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"
This reverts commit 8338860f74.
Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"
This reverts commit d66681f553.
Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"
This reverts commit 530b815cad.
Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"
This reverts commit 813c864381.
- Hooked the RustSharedRemoteSettingsService code to the Region module.
The new system updates the app context as the home region changes.
- Updated `RemoteSettingsService.updateConfig` to be sync rather than
async wrapped. It should execute quickly and I want to have
confidence that the config is actually updated when that function
returns.
- Updated/Simplified the SuggestBackendRust.sys.mjs testing code. Now
we just need to track if we should disable the Rust backend for the
tests or not.
- Updated `QuickSuggest._test_reinit` to wait for any unfinished
ingestion from `SuggestBackendRust`. This is needed now because
changing the remote settings service affects all active clients. If
there are unfinished ingestion tasks, then this creates a race
between those task finishing and the test finishing and uninitializing
the remote settings mock server.
Differential Revision: https://phabricator.services.mozilla.com/D248467
The browser_quicksuggest_ping_deletionRequest.js test now runs two separate set of tasks,
depending on whether or not context ID rotation is enabled.
The rotation set of tasks can be tested by calling ./mach test with `--setpref browser.contextual-services.contextId.rust-component.enabled=true --setpref browser.contextual-services.contextId.rotation-in-days=1`
Differential Revision: https://phabricator.services.mozilla.com/D248975
Rather than introducing a new pref, keep using the existing one. The
idea is that semantic history search will be part of the normal history
search functionality, so it doesn't need a separate pref.
Also add some checks to avoid unnecessary work in unrelated search modes.
Differential Revision: https://phabricator.services.mozilla.com/D248925
Rather than introducing a new pref, keep using the existing one. The
idea is that semantic history search will be part of the normal history
search functionality, so it doesn't need a separate pref.
Also add some checks to avoid unnecessary work in unrelated search modes.
Differential Revision: https://phabricator.services.mozilla.com/D248925
- Hooked the RustSharedRemoteSettingsService code to the Region module.
The new system updates the app context as the home region changes.
- Updated `RemoteSettingsService.updateConfig` to be sync rather than
async wrapped. It should execute quickly and I want to have
confidence that the config is actually updated when that function
returns.
- Updated/Simplified the SuggestBackendRust.sys.mjs testing code. Now
we just need to track if we should disable the Rust backend for the
tests or not.
- Updated `QuickSuggest._test_reinit` to wait for any unfinished
ingestion from `SuggestBackendRust`. This is needed now because
changing the remote settings service affects all active clients. If
there are unfinished ingestion tasks, then this creates a race
between those task finishing and the test finishing and uninitializing
the remote settings mock server.
Differential Revision: https://phabricator.services.mozilla.com/D248467
In bug 1933744 we prevented SessionStore from reopening a saved tab group into a private window. In bug 1946761 we prevented users from saving tab groups from a private window. The general design principle has been to prevent tab group information leaking between private and non-private windows.
ActionsProviderTabGroups already respected privacy through the implementation of `Tabbrowser.getAllTabGroups`, but `SessionStore.getSavedTabGroups` doesn't respect privacy. Perhaps it should. But in any case, this patch ensures that search results in private windows don't include saved tab groups.
Differential Revision: https://phabricator.services.mozilla.com/D248351
As part of this bug, the global ExperimentManager will no longer be
exported from ExperimentManager.sys.mjs and will only be available as a
property on the ExperimentAPI.
Differential Revision: https://phabricator.services.mozilla.com/D248317
Defines and/or updates JSDoc types on all ActionsResult properties.
The pre-existing property `ActionsResult.providerName` never gets set. `Query.add` sets a `providerName` on UrlbarResult objects, so to follow that pattern, I made `ProviderGlobalActions.startQuery` responsible for setting `providerName` on already constructed `ActionsResult` instances. Having the provider name available for actions results will make it easier for tests to find relevant actions results within search results.
Differential Revision: https://phabricator.services.mozilla.com/D248373
