James Teow
e18fba3011
Bug 1941467 - Allow Scotch Bonnet pref to toggle Persisted Search preference visibility - r=daleharvey,settings-reviewers,mossop
...
I also removed the Nimbus feature since there are no future plans to
run experiments solely on this feature.
Differential Revision: https://phabricator.services.mozilla.com/D234135
2025-01-16 16:54:14 +00:00
Sandor Molnar
f776616d69
Backed out 2 changesets (bug 1297008) for causing M-vt failures @ browser_link_in_tab_title_and_url_prefilled_blank_page.js CLOSED TREE
...
Backed out changeset ce85088a9340 (bug 1297008)
Backed out changeset cd90c0935331 (bug 1297008)
2025-01-10 01:14:53 +02:00
Emma Zuehlcke
5ca6a4bb43
Bug 1297008, r=mak,Gijs,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D226694
2025-01-09 17:49:09 +00:00
Daisuke Akatsuka
82f19238e9
Bug 1936545: Close search mode switcher popup when opening new tab r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D233470
2025-01-08 22:06:49 +00:00
Dale Harvey
21f91aa3cb
Bug 1938036 - Dont maintain user input when selecting contextual engine. r=daisuke,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D232946
2025-01-08 12:55:19 +00:00
Yazan Al Macki
9724bc1d84
Bug 1936278 - Prevent search mode chiclet from being dismissed when clicking in page content. r=jteow
...
Differential Revision: https://phabricator.services.mozilla.com/D232365
2024-12-25 04:08:06 +00:00
Daisuke Akatsuka
abd3414bd9
Bug 1937363: Show/Focus Unified Search Button when P&S icon group gets focus r=desktop-theme-reviewers,urlbar-reviewers,dao,tabbrowser-reviewers,daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D232160
2024-12-24 04:02:25 +00:00
Cristian Tuns
568f68ebab
Backed out changeset de5d3f6c2e3e (bug 1936278) for causing bc failures in browser_searchModeSwitcher_emptyInput.js CLOSED TREE
2024-12-19 17:57:30 -05:00
Yazan Al Macki
82b17701af
Bug 1936278 - Prevent search mode chiclet from being dismissed when clicking in page content. r=jteow
...
Differential Revision: https://phabricator.services.mozilla.com/D232365
2024-12-19 19:38:50 +00:00
Daisuke Akatsuka
aafffaa930
Bug 1936090: Show/Hide Unified Search Button dependent on pageproxystate r=desktop-theme-reviewers,tabbrowser-reviewers,daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D231636
2024-12-11 21:35:57 +00:00
Yazan Al Macki
f73656a212
Bug 1919549 - Quit actions search mode after using quick actions in new tab page. r=urlbar-reviewers,jteow
...
Differential Revision: https://phabricator.services.mozilla.com/D230313
2024-12-06 19:03:26 +00:00
Daisuke Akatsuka
8c442be904
Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-12-05 07:13:31 +00:00
Norisz Fay
5caeaca8fe
Backed out 2 changesets (bug 1928132) for causing failures on browser_mouseout_notification_panel.js and Bug 1934387, Bug 1934388, Bug 1934389 CLOSED TREE
...
Backed out changeset 2ea4986f9eb8 (bug 1928132)
Backed out changeset 4a72ad308d0c (bug 1928132)
2024-11-30 15:43:28 +02:00
Daisuke Akatsuka
38412e4cd1
Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-11-29 21:24:53 +00:00
Goloman Adrian
2cd2737f6f
Backed out 2 changesets (bug 1928132) for causing bc failures browser_popupNotification_2.js. CLOSED TREE
...
Backed out changeset 5882194e7456 (bug 1928132)
Backed out changeset 0d13b91f55e0 (bug 1928132)
2024-11-29 15:18:36 +02:00
Daisuke Akatsuka
c738c0eb32
Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-11-29 11:18:02 +00:00
Manuel Bucher
53e7c24e8d
Bug 1924493 - Copy without site tracking: Rename to "Copy Clean Link" r=anti-tracking-reviewers,fluent-reviewers,urlbar-reviewers,flod,dao,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D230251
2024-11-28 11:40:11 +00:00
Yazan Al Macki
579f372259
Bug 1923686 - Exit search mode for non app-provided search engines. r=jteow,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D229158
2024-11-20 01:17:09 +00:00
Florian Quèze
48a799d50d
Bug 1927093 - Migrate scalars to use Glean APIs for contextual.services.topsites.*, r=chutten,urlbar-reviewers,jteow,Standard8,home-newtab-reviewers,thecount.
...
Differential Revision: https://phabricator.services.mozilla.com/D227815
2024-11-15 11:53:39 +00:00
Simon Friedberger
4fcd691190
Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 17:15:57 +00:00
Sandor Molnar
9e0c14a80e
Backed out changeset c4dfee1f9194 (bug 1919544) for causing bc failures @ browser_UrlbarInput_formatValue.js CLOSED TREE
2024-11-13 15:20:39 +02:00
Simon Friedberger
8eafd874fe
Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 11:44:43 +00:00
Daisuke Akatsuka
708d0195d5
Bug 1925532: Enter search mode without preview mode by key if there is single result r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D226865
2024-11-11 22:19:45 +00:00
Daisuke Akatsuka
c2f5c3753c
Bug 1921731: Keep actions' layout until changing the results r=urlbar-reviewers,daleharvey,adw
...
Differential Revision: https://phabricator.services.mozilla.com/D226107
2024-11-11 05:44:29 +00:00
James Teow
935394d9f6
Bug 1927113 - Ensure persisted search doesn't show search mode from another tab - r=adw,urlbar-reviewers
...
this.searchMode can return null even if a search mode is shown
in the address bar, as the getter uses the current browser as the
context and attempts to use the state data. I try to solve this
by relying on the fact that a tab switch and invalid pageproxystate
results in restoring the search mode state.
Differential Revision: https://phabricator.services.mozilla.com/D228483
2024-11-08 23:04:24 +00:00
Marco Bonardo
f13efc6b93
Bug 1925496. r=jfkthame,adw
...
Differential Revision: https://phabricator.services.mozilla.com/D228315
2024-11-08 13:50:43 +00:00
Dale Harvey
d6bf7c5a2d
Bug 1926241 - Provide tab-to-search results via actions. r=urlbar-reviewers,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D227236
2024-11-08 13:35:12 +00:00
Alexandru Marc
e2fa59c2ee
Backed out changeset 40518e514fc1 (bug 1925496) for causing bc failures @ browser_copying.js . CLOSED TREE
2024-11-08 14:51:02 +02:00
Marco Bonardo
4a15af511c
Bug 1925496. r=jfkthame,adw
...
Differential Revision: https://phabricator.services.mozilla.com/D228315
2024-11-08 10:43:36 +00:00
Florian Quèze
e704e70b3b
Bug 1927093 - Migrate scalars to use Glean APIs for urlbar.*, r=chutten,urlbar-reviewers,mak.
...
Differential Revision: https://phabricator.services.mozilla.com/D226513
2024-11-05 13:22:58 +00:00
Emilio Cobos Álvarez
a1ae05d74e
Bug 1928255 - Fix bug 1927111 in a better way. r=urlbar-reviewers,mak
...
Keep using the static position as we did before. As long as we don't
have anchor positioning this seems better than whack-a-mole-ing every
possible urlbar position change.
In order to make the fullscreen animation work, make our position
computation ignore transforms, which is how anchor positioning would
behave anyways.
Differential Revision: https://phabricator.services.mozilla.com/D227758
2024-11-04 16:11:58 +00:00
Paul Zuehlcke
4922189f11
Bug 1927220 - Remove broken check for insert location in _initStripOnShare in UrlbarInput. r=urlbar-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D227480
2024-11-04 13:58:13 +00:00
Moritz Beier
4983a8b7fa
Bug 1916499 - Add searchForm support back to OpenSearch engines. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D225968
2024-11-04 13:53:51 +00:00
Emilio Cobos Álvarez
303a90ea1b
Bug 1928550 - Don't breakout on readonly urlbar. r=urlbar-reviewers,dao
...
This was a pre-existing issue that was only papered by chance.
this._toolbar is set before the early return for readonly urlbars, but
the ResizeObserver is only set up after it.
Be more explicit about when we allow breaking out of the container (and
effectively do it only for non-readonly urlbars).
Differential Revision: https://phabricator.services.mozilla.com/D227760
2024-11-04 10:11:07 +00:00
Alexandru Marc
5a5f7b93df
Backed out 2 changesets (bug 1916505, bug 1916499) for causing bc failures @ browser_oneOffContextMenu.js
...
Backed out changeset dbd2ce7823c2 (bug 1916505)
Backed out changeset 5082d347bbf7 (bug 1916499)
2024-10-31 16:05:29 +02:00
Moritz Beier
36f3384408
Bug 1916499 - Add searchForm support back to OpenSearch engines. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D225968
2024-10-31 13:01:12 +00:00
Emilio Cobos Álvarez
6e6b254c42
Bug 1927111 - Shift urlbar during macOS fullscreen animation. r=Gijs,sfoster,urlbar-reviewers,mak
...
See comment for sadness.
Differential Revision: https://phabricator.services.mozilla.com/D226933
2024-10-30 13:09:46 +00:00
Emilio Cobos Álvarez
2b95871a34
Bug 1927111 - Don't rely on static position (top: auto) for urlbar position. r=Gijs,sfoster,desktop-theme-reviewers,urlbar-reviewers,mak
...
The static position of these boxes is not great to depend upon, see:
https://github.com/w3c/csswg-drafts/issues/9939
Right now, we are relying on the static pos to be properly set which is
going to go away, eventually, and it is bogus, because it doesn't update
if e.g. only transform changes.
Use getBoxQuads to get the content box bounds properly. Also, make
breakout position: absolute explicitly, to prevent confusion.
Differential Revision: https://phabricator.services.mozilla.com/D226932
2024-10-30 13:09:46 +00:00
Butkovits Atila
2271d1135d
Backed out changeset 6668994ba84c (bug 1925532) for causing failures at browser_ime_composition.js. CLOSED TREE
2024-10-30 06:45:52 +02:00
Daisuke Akatsuka
2aeaf78698
Bug 1925532: Enter search mode without preview mode by KEY_Tab, VK_RIGHT and VK_DOWN r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D226865
2024-10-30 02:58:57 +00:00
Butkovits Atila
f2d9be08fd
Backed out 2 changesets (bug 1927111) for causing failures at browser_add_search_engine.js. CLOSED TREE
...
Backed out changeset b12f12db6d50 (bug 1927111)
Backed out changeset 8afe68ed6509 (bug 1927111)
2024-10-30 02:27:06 +02:00
Emilio Cobos Álvarez
826ab1afd3
Bug 1927111 - Shift urlbar during macOS fullscreen animation. r=Gijs,sfoster,urlbar-reviewers,mak
...
See comment for sadness.
Differential Revision: https://phabricator.services.mozilla.com/D226933
2024-10-29 22:03:22 +00:00
Emilio Cobos Álvarez
80dcdf14de
Bug 1927111 - Don't rely on static position (top: auto) for urlbar position. r=Gijs,sfoster,desktop-theme-reviewers,urlbar-reviewers,mak
...
The static position of these boxes is not great to depend upon, see:
https://github.com/w3c/csswg-drafts/issues/9939
Right now, we are relying on the static pos to be properly set which is
going to go away, eventually, and it is bogus, because it doesn't update
if e.g. only transform changes.
Use getBoxQuads to get the content box bounds properly. Also, make
breakout position: absolute explicitly, to prevent confusion.
Differential Revision: https://phabricator.services.mozilla.com/D226932
2024-10-29 22:03:22 +00:00
Marco Bonardo
631e8d05ce
Bug 1912416 - Ctrl+Shift+Left in the Address Bar should not unselect all. r=urlbar-reviewers,daisuke
...
Differential Revision: https://phabricator.services.mozilla.com/D226684
2024-10-29 09:50:07 +00:00
Emilio Cobos Álvarez
4ea54f6e0f
Bug 1921811 - Make URLBar a popover. r=emilio,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,urlbar-reviewers,dao,mak,dao?
...
* Fix various z-index/paint order issues by making the urlbar a popover - which moves the open
urlbar to the top layer, outside the toolbox
* Adjust the urlbar position when the autohide menubar shows and hides
* Temporarily disable the browser_urlbar_keyed_search.js which needs revisiting to measure reflows under regular, non-test-specific conditions
Combines work from nsharpley and sfoster on top of emilio's original popover patch
Differential Revision: https://phabricator.services.mozilla.com/D224201
2024-10-21 23:39:16 +00:00
Dale Harvey
37dbf730f3
Bug 1922570 - Show global actions on seperate row from heuristic. r=daisuke,desktop-theme-reviewers,urlbar-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D225051
2024-10-21 19:36:57 +00:00
Norisz Fay
224773d44d
Backed out changeset d4c4540a5a4a (bug 1921811) for causing bc failures on browser_urlbar_keyed_search.js CLOSED TREE
2024-10-21 15:10:55 +03:00
Emilio Cobos Álvarez
9fa478edc3
Bug 1921811 - Make URLBar a popover. r=emilio,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,urlbar-reviewers,dao,mak,dao?
...
* Fix various z-index/paint order issues by making the urlbar a popover - which moves the open
urlbar to the top layer, outside the toolbox
* Adjust the urlbar position when the autohide menubar shows and hides
Combines work from nsharpley and sfoster on top of emilio's original popover patch
Differential Revision: https://phabricator.services.mozilla.com/D224201
2024-10-21 10:24:06 +00:00
Norisz Fay
9b743ec4a9
Backed out changeset 1de300781d3f (bug 1916499) for causing multiple search related failures CLOSED TREE
2024-10-18 22:17:36 +03:00
Moritz Beier
eedeed877c
Bug 1916499 - Add searchForm support back to OpenSearch engines. r=Standard8,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D225968
2024-10-18 13:46:52 +00:00