Commit Graph

173 Commits

Author SHA1 Message Date
Oriol Brufau
34f47a6359 Bug 1809364 - Make tabs.move on multiple tabs more reliable (2). r=robwu
Bug 1323311 tried to improve browser.tabs.move, but the logic didn't
really make sense (e.g. why use 2 different maps to track indices?),
and it broke moving multiple tabs between windows: they would appear
in the wrong order.

Differential Revision: https://phabricator.services.mozilla.com/D166405
2023-01-19 13:51:31 +00:00
Oriol Brufau
ca1a72c7a6 Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu
And make callers rely on that instead of allowInheritPrincipal when
creating lazy tabs.

Unlike allowInheritPrincipal, skipLoad sets the nodefaultsrc attribute.
This avoids a load instead of falling back to about:blank.

One consequence of that is that switching to a lazy about:blank tab will
not notify invoke listeners registered with addTabsProgressListener
(listeners registered with addProgressListener will still be invoked).

Thus test browser_open_in_lazy_tab.js needs to be updated.

Differential Revision: https://phabricator.services.mozilla.com/D166012
2023-01-07 13:51:47 +00:00
Sandor Molnar
4f5ee6f941 Backed out changeset 2b67bd0dd255 (bug 1808615) for causing bc failures in browser/components/customizableui/test/browser_open_in_lazy_tab.js CLOSED TREE 2023-01-07 03:18:23 +02:00
Oriol Brufau
60b9a931c7 Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu
And make callers rely on that instead of allowInheritPrincipal when
creating lazy tabs.

Differential Revision: https://phabricator.services.mozilla.com/D166012
2023-01-07 00:37:36 +00:00
Gregory Pappas
6c82a9320a Bug 1772166 - Implement 'ZoomSettings.defaultZoomFactor' r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158731
2023-01-02 13:32:42 +00:00
Gijs Kruitbosch
965c6e86fc Bug 1803158 - convert session restore consumers to reference the sys.mjs files instead, r=webdriver-reviewers,perftest-reviewers,extension-reviewers,credential-management-reviewers,Standard8,sgalich,whimboo,sparky,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D163350
2022-12-06 16:02:03 +00:00
Butkovits Atila
74e26649e5 Backed out changeset 470fffc6ff9a (bug 1772166) for causing failures at browser_ext_webNavigation_onCreatedNavigationTarget.js. CLOSED TREE 2022-12-06 16:44:41 +02:00
Gregory Pappas
31354f56b1 Bug 1772166 - Implement 'ZoomSettings.defaultZoomFactor' r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158731
2022-12-06 13:22:09 +00:00
Sandor Molnar
adfe63bce9 Backed out changeset 26d4da528112 (bug 1772166) for causing bc failures in browser/components/extensions/test/browser/browser_ext_webNavigation_onCreatedNavigationTarget.js CLOSED TREE 2022-12-05 18:26:15 +02:00
Gregory Pappas
fdcd365e65 Bug 1772166 - Implement 'ZoomSettings.defaultZoomFactor' r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158731
2022-12-05 14:49:40 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Shane Caraveo
cd3dba3928 Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl,geckoview-reviewers,calu
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
2022-08-02 17:08:58 +00:00
Butkovits Atila
b01ed36979 Backed out 3 changesets (bug 1711168, bug 1773115) for causing failures at test_ext_web_accessible_resources.html. CLOSED TREE
Backed out changeset 703c909eb009 (bug 1773115)
Backed out changeset 902385a7ce60 (bug 1711168)
Backed out changeset 3d061ce03de7 (bug 1711168)
2022-07-27 00:13:26 +03:00
Shane Caraveo
26d3eac02e Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
2022-07-26 19:39:14 +00:00
kernp25
0ee68a9f02 Bug 1770651 - Make sure tabs.update don't use loadURI on a discarded tab. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D149702
2022-07-04 09:10:38 +00:00
Jonathan Watt
b677f00ccc Bug 1769388 - Change nsIPrintSettingsService's 'newPrintSettings' attribute to a 'createNewPrintSettings' function. r=bobowen,webdriver-reviewers,whimboo
Having an attribute be a constructor is just...wrong.

Differential Revision: https://phabricator.services.mozilla.com/D146383
2022-05-16 11:50:34 +00:00
Shane Caraveo
594876b513 Bug 1748567 support persistent events in tabs api r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D140915
2022-03-31 23:29:25 +00:00
Emilio Cobos Álvarez
202fcd0999 Bug 1760836 - Support printing to an nsIOutputStream. r=jfkthame,jrmuizel,webdriver-reviewers,geckoview-reviewers,agi
The trickiest bits are the PrintTargetCG ones, the rest is just plumbing
and cleanups and tests, but let me know if you want those to be split
out, can do.

The GTK change to nsPrintSettingsGTK::GetResolution is a no-op (we only
read resolution on windows), but I did that because we assume that it
doesn't fail and GTK returns a sane default anyways.

Differential Revision: https://phabricator.services.mozilla.com/D142199
2022-03-30 18:51:58 +00:00
Iulian Moraru
7106f0368c Backed out changeset d42d7505c9cf (bug 1760836) for causing mochitest failures on browser_print_stream.js. CLOSED TREE 2022-03-29 23:32:39 +03:00
Emilio Cobos Álvarez
2ee3ba7653 Bug 1760836 - Support printing to an nsIOutputStream. r=jfkthame,jrmuizel,webdriver-reviewers,geckoview-reviewers,agi
The trickiest bits are the PrintTargetCG ones, the rest is just plumbing
and cleanups and tests, but let me know if you want those to be split
out, can do.

The GTK change to nsPrintSettingsGTK::GetResolution is a no-op (we only
read resolution on windows), but I did that because we assume that it
doesn't fail and GTK returns a sane default anyways.

Differential Revision: https://phabricator.services.mozilla.com/D142199
2022-03-29 17:50:58 +00:00
kernp25
f3b6f248eb Bug 1372100 - Support muted in tabs.create. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D140677
2022-03-23 21:20:31 +00:00
Jonathan Watt
79109555b9 Bug 1702501 - Remove print.tab_modal.enabled pref and old frontend print preview code. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D134699
2022-01-06 18:55:38 +00:00
Jonathan Watt
d70db9baf8 Bug 1745452 - Remove the print progress dialog code. r=mstriemer,bobowen,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D133500
2021-12-16 15:12:33 +00:00
Butkovits Atila
6c14d03852 Backed out changeset 51d7c5d96ceb (bug 1745452) for causing failures at browser_all_files_referenced.js. CLOSED TREE 2021-12-16 15:13:34 +02:00
Jonathan Watt
260ef48d25 Bug 1745452 - Remove the print progress dialog code. r=mstriemer,bobowen,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D133500
2021-12-16 11:45:59 +00:00
Tomislav Jovanovic
e9f6c7f260 Bug 1708243 - Part 3: Use actor messaging for tabs.detectLanguage, stop loading MessageChannel.jsm, r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D126623
2021-09-29 16:52:59 +00:00
Richa Sharma
9eed107905 Bug 1683058 - Change tabs API internals to support container access. r=robwu,rpl
Differential Revision: https://phabricator.services.mozilla.com/D100232
2021-04-20 12:59:26 +00:00
Emilio Cobos Álvarez
0e55bca38f Bug 1705757 - Move FrameLoader.print to BrowsingContext.print. r=nika,remote-protocol-reviewers,marionette-reviewers,extension-reviewers,zombie
This makes it trivial to choose the right BrowserParent to print a
browsing context, by removing the OuterWindowID / FrameLoader
indirections.

Differential Revision: https://phabricator.services.mozilla.com/D112412
2021-04-17 18:41:11 +00:00
Rob Wu
f1d1a8b43f Bug 1695346 - Skip tabs amidst restoration in tabs.onUpdated r=Gijs,rpl
`swapBrowsersAndCloseOther` calls `SessionStore.setTabState`, but the
latter may trigger several tab events before the tab has fully been
restored. This results in duplicate tabs.onUpdated events and in
unexpected access to properties of the tab/browser (which in turn
triggers the reported bug).

Fix this specific case by ignoring events that happen while the tab is
amidst a restoration.

Differential Revision: https://phabricator.services.mozilla.com/D108259
2021-03-26 19:51:14 +00:00
Luca Greco
af06fcfd97 Bug 1698158 - part 2 - Remove unnecessary jsm imports in existing WebExtensions API modules. r=mixedpuppy
Depends on D108226

Differential Revision: https://phabricator.services.mozilla.com/D108227
2021-03-16 18:15:40 +00:00
Rob Wu
026cd90f5a Bug 1680279 - Support "url" properties in filter r=rpl
The patch for bug 1498432 will include a unit test that uses
tabs.onUpdated with the "url" filter for "properties".

The updated test here verifies that the tabs.onUpdated event does not
include other properties in changeInfo when filtering by "status".

Differential Revision: https://phabricator.services.mozilla.com/D106733
2021-03-07 16:16:36 +00:00
Alexandru Michis
d28b5e906b Backed out 2 changesets (bug 1498432, bug 1680279) for causing bc failures in browser_ext_tabs_discard_reversed.js
CLOSED TREE

Backed out changeset 9ce142e600af (bug 1498432)
Backed out changeset 4c8c60ac262a (bug 1680279)
2021-03-05 02:50:58 +02:00
Rob Wu
c53b19cfab Bug 1680279 - Support "url" properties in filter r=rpl
The patch for bug 1498432 will include a unit test that uses
tabs.onUpdated with the "url" filter for "properties".

The updated test here verifies that the tabs.onUpdated event does not
include other properties in changeInfo when filtering by "status".

Differential Revision: https://phabricator.services.mozilla.com/D106733
2021-03-04 20:50:35 +00:00
Emilio Cobos Álvarez
9a73b05d1b Bug 1694951 - Remove printing.trigger telemetry. r=jwatt,marionette-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106465
2021-03-01 11:36:43 +00:00
Rob Wu
e926e0c0e6 Bug 1694699 - Minimize access to tab.hasTabPermission r=rpl,geckoview-reviewers,agi
tab.hasTabPermission indirectly triggers an access to
browser.currentURI, which for lazy tab browsers causes an incorrect
value to be cached. To avoid this, skip the call to hasTabPermission.

Differential Revision: https://phabricator.services.mozilla.com/D106622
2021-02-26 21:34:54 +00:00
Rob Wu
5412065387 Bug 1694699 - Avoid unnecessary string->URI conversions r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D106317
2021-02-26 21:34:54 +00:00
Kris Maglione
caf1d0e771 Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 20:58:43 +00:00
Mihai Alexandru Michis
e10f79168a Backed out 12 changesets (bug 1685801) for causing bc failures in browser_ctrlTab.js
CLOSED TREE

Backed out changeset 021924b62f13 (bug 1685801)
Backed out changeset 38cc10101c1f (bug 1685801)
Backed out changeset 9ab9574ac72a (bug 1685801)
Backed out changeset 1a7f259cc2ec (bug 1685801)
Backed out changeset b267b19a7f6e (bug 1685801)
Backed out changeset 7dfcf0257487 (bug 1685801)
Backed out changeset ee0d0169b079 (bug 1685801)
Backed out changeset 0c358ee51951 (bug 1685801)
Backed out changeset 338ab91af557 (bug 1685801)
Backed out changeset a49415007aaf (bug 1685801)
Backed out changeset b91098299143 (bug 1685801)
Backed out changeset edf6209861a8 (bug 1685801)
2021-01-28 22:55:11 +02:00
Kris Maglione
2d5f151948 Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 05:25:03 +00:00
Butkovits Atila
91af0d3269 Backed out 12 changesets (bug 1685801) for causing failures on browser_fission_maxOrigins.js. CLOSED TREE
Backed out changeset 0d7153110519 (bug 1685801)
Backed out changeset 5175062925c7 (bug 1685801)
Backed out changeset 2c1250e786f0 (bug 1685801)
Backed out changeset 0ce3c773ba74 (bug 1685801)
Backed out changeset 9d51c6e24dee (bug 1685801)
Backed out changeset 3f4dc6349441 (bug 1685801)
Backed out changeset a80de9abb9f8 (bug 1685801)
Backed out changeset 30786893a5e7 (bug 1685801)
Backed out changeset 8007b12d6e32 (bug 1685801)
Backed out changeset fa814f4b7125 (bug 1685801)
Backed out changeset 14e4e47ee99f (bug 1685801)
Backed out changeset d9f1feba9454 (bug 1685801)
2021-01-28 07:15:59 +02:00
Kris Maglione
cebae4d59b Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 03:32:43 +00:00
Robbendebiene
c1a024b056 Bug 1679688 - make host permissions grant access to privileged parts of the tabs API and fix Bug 1686443 r=robwu,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D98471
2021-01-23 14:09:22 +00:00
Oriol Brufau
16afb0e01f Bug 1580003 - Remove isLastMultiSelectChange parameter. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45245
2021-01-20 11:56:54 +00:00
Narcis Beleuzu
2b5886c817 Backed out changeset 81be428b9df0 (bug 1580003) for bc failures on browser_multiselect_tabs_close_other_tabs.js. CLOSED TREE 2021-01-14 21:19:04 +02:00
Oriol Brufau
98b41b9fde Bug 1580003 - Remove isLastMultiSelectChange parameter. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45245
2021-01-14 15:32:24 +00:00
Sonia Singla
441cbc1780 Bug 1458764 - Removed the references with extensions.webextensions.tabhide.enabled pref. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D97092
2020-12-17 19:14:07 +00:00
Liz Krane
9949f148fb Bug 1650956 - browser.tabs.remove() now calls removeTabs(). r=robwu,Gijs
Removing multiple tabs via extensions now calls `gBrowser.removeTabs()`
once for each window that has tabs being removed. Also adds automated
browser tests for removing one tab or multiple tabs.

Differential Revision: https://phabricator.services.mozilla.com/D93438
2020-11-19 19:01:40 +00:00
Razvan Maries
f5c6155926 Backed out changeset b952d7de3e3e (bug 1650956) for perma failures on browser_ext_tabs_successors.js. CLOSED TREE 2020-10-30 01:29:15 +02:00