Commit Graph

311 Commits

Author SHA1 Message Date
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Gijs Kruitbosch
1113bc0e43 Bug 1475606 - remove loadOneTab and switch its callers over, r=dao,perftest-reviewers,sparky
Depends on D165774

Differential Revision: https://phabricator.services.mozilla.com/D165775
2023-01-03 22:24:44 +00:00
Gijs Kruitbosch
965c6e86fc Bug 1803158 - convert session restore consumers to reference the sys.mjs files instead, r=webdriver-reviewers,perftest-reviewers,extension-reviewers,credential-management-reviewers,Standard8,sgalich,whimboo,sparky,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D163350
2022-12-06 16:02:03 +00:00
Mike Conley
6c7bae4c4d Bug 1798896 - Prevent extension buttons from moving to the palette or overflow panel if Unified Extensions is enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D161840
2022-11-17 01:59:58 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
Mike Conley
bd0a2d6a38 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Depends on D160292

Differential Revision: https://phabricator.services.mozilla.com/D160293
2022-11-01 21:50:56 +00:00
Butkovits Atila
517ae6c72a Backed out 3 changesets (bug 1797155) for causing failures at browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset 67f5e4af25b6 (bug 1797155)
Backed out changeset b8a8bd646606 (bug 1797155)
Backed out changeset ec7cdd68c414 (bug 1797155)
2022-11-01 19:33:25 +02:00
Mike Conley
7ba904bf88 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Differential Revision: https://phabricator.services.mozilla.com/D160293
2022-11-01 16:44:33 +00:00
Marian-Vasile Laza
e32d202d39 Backed out 3 changesets (bug 1797155) for causing bc failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset ee3f27f43bc5 (bug 1797155)
Backed out changeset 863603ed770a (bug 1797155)
Backed out changeset 3fbfc3d94e5a (bug 1797155)
2022-10-31 21:29:22 +02:00
Mike Conley
fc80458832 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Differential Revision: https://phabricator.services.mozilla.com/D160293
2022-10-31 18:05:20 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
9ac8a72331 Bug 1772100 - Part 3: Use plain object for lazy getter in browser/components/customizableui/. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D148013
2022-06-10 19:42:59 +00:00
Tooru Fujisawa
ebcb6dfd9c Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 04:42:10 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
81758ebac5 Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 02:49:14 +00:00
Cristian Tuns
a392ccb35a Backed out changeset 5029c82449ff (bug 1764081) for causing mochitest failures on browser_locale_changes.js CLOSED TREE 2022-04-28 12:18:15 -04:00
Greg Tatum
6190be5e09 Bug 1764081 - Fix Fluent locale switching in CustomizeUI; r=platform-i18n-reviewers,dminor
This fixes the Fluent live switching, but does not fix the elements
defined by properties files.

Differential Revision: https://phabricator.services.mozilla.com/D144443
2022-04-28 15:21:02 +00:00
Mark Banner
d22663f0f9 Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-17 22:13:08 +00:00
Cristian Tuns
a180c6cba3 Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE 2022-03-14 12:27:48 -04:00
Mark Banner
beed912c8e Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-14 10:19:40 +00:00
Julien Wajsberg
a0311c9aa8 Bug 1745208 - [utilityOverlay] Make getTopWin take an option parameter r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133376
2022-01-26 17:26:19 +00:00
Emilio Cobos Álvarez
92f83cf19e Bug 1739539 - Rename titlebar pref and add migration from old pref. r=mconley
Something like this ought to do?

Differential Revision: https://phabricator.services.mozilla.com/D130858
2021-11-10 21:17:32 +00:00
Emilio Cobos Álvarez
d37eb95bc7 Bug 1736518 - Make browser.tabs.drawInTitlebar a tri-state. r=stransky,Gijs
To more properly support Linux having a different default at runtime.

Expose the resolved value in appinfo for convenience, and use it in the
front-end as needed.

Differential Revision: https://phabricator.services.mozilla.com/D129004
2021-10-21 09:07:12 +00:00
Harry Twyford
3043fad3a2 Bug 1729534 - Change Customize window theme picker to a button that points to about:addons#themes. r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125120
2021-09-23 13:55:07 +00:00
Harry Twyford
eba55a238f Bug 1730262 - Add first monochromatic theme. r=desktop-theme-reviewers,dao,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D125283
2021-09-21 13:32:57 +00:00
Butkovits Atila
91d0db9a30 Backed out 3 changesets (bug 1719939, bug 1726437, bug 1730262) for causing failures on test_browserGlue_migration_ctrltab_recently_used_order.js.
Backed out changeset ea1653e9644f (bug 1719939)
Backed out changeset 01f90db715a7 (bug 1726437)
Backed out changeset c0e23b2acfbb (bug 1730262)
2021-09-21 05:15:31 +03:00
Harry Twyford
dd50b7c0e6 Bug 1730262 - Add first monochromatic theme. r=desktop-theme-reviewers,dao,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D125283
2021-09-20 18:30:49 +00:00
Cristian Tuns
9566bdbc2e Backed out changeset 2ac8b24d476e (bug 1729534) for causing mochitest failures on browser_customizemode_uidensity.js. CLOSED TREE 2021-09-14 13:14:01 -04:00
Harry Twyford
eec3b0a79c Bug 1729534 - Change Customize window theme picker to a button that points to about:addons#themes. r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125120
2021-09-14 14:11:47 +00:00
Harry Twyford
831ee727ef Bug 1725468 - Add prototype monochromatic theme for UX iteration. r=Gijs,amy
Differential Revision: https://phabricator.services.mozilla.com/D122515
2021-08-18 13:13:38 +00:00
Narcis Beleuzu
91a0466204 Backed out changeset 7546da95431a (bug 1725468) for screenshot failures on browser_controlCenter.js 2021-08-18 04:44:25 +03:00
Harry Twyford
9c59d6b1f3 Bug 1725468 - Add prototype monochromatic theme for UX iteration. r=Gijs,amy
Differential Revision: https://phabricator.services.mozilla.com/D122515
2021-08-17 23:28:31 +00:00
Kagami Sascha Rosylight
40b97ae847 Bug 1635018 - Part 2: Replace dragexit with dragleave in browser/ r=Gijs,mak
Differential Revision: https://phabricator.services.mozilla.com/D121190
2021-08-05 14:33:39 +00:00
Gijs Kruitbosch
d2f652ce40 Bug 1711519 - remove trivial gProton and gProtonDoorhangers checks, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D116630
2021-06-03 11:41:54 +00:00
Ed Lee
a664a5abaa Bug 1706366 - Update builtin theme icons to reuse on about:welcome, customize and upgrade dialog r=emcminn
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.

Differential Revision: https://phabricator.services.mozilla.com/D113701
2021-04-30 05:13:31 +00:00
Dorel Luca
82ab95e902 Backed out changeset 69811ad1a854 (bug 1706366) for Browser-chrome failures in browser/components/customizableui/test/browser_1007336_lwthemes_in_customize_mode.js. CLOSED TREE 2021-04-30 06:10:41 +03:00
Sam Foster
c5c4a2fb76 Bug 1705049 - Update chevron/overflow menu animation. r=mconley
* New filmstrip animation svg. It animates between the currentColor and attention color. We *could* do this via a CSS animation changing the fill value over time, but my understanding is to ensure animation happens on the compositor/GPU, the filmstrip is the better way to go.

Differential Revision: https://phabricator.services.mozilla.com/D113856
2021-04-30 00:43:40 +00:00
Ed Lee
30d568996f Bug 1706366 - Update builtin theme icons to reuse on about:welcome, customize and upgrade dialog r=emcminn
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.

Differential Revision: https://phabricator.services.mozilla.com/D113701
2021-04-30 00:42:33 +00:00
Dorel Luca
f46a7f2574 Backed out changeset 8fd40805444e (bug 1705049) for Browser-chrome failures in browser/components/customizableui/test/browser_widget_animation.js. CLOSED TREE 2021-04-30 02:47:50 +03:00
Sam Foster
fe11b075d1 Bug 1705049 - Update chevron/overflow menu animation. r=mconley
* New filmstrip animation svg. It animates between the currentColor and attention color. We *could* do this via a CSS animation changing the fill value over time, but my understanding is to ensure animation happens on the compositor/GPU, the filmstrip is the better way to go.

Differential Revision: https://phabricator.services.mozilla.com/D113856
2021-04-29 21:41:52 +00:00
Barret Rennie
9ad4361e00 Bug 1702116 - Fix races in AddonManager & XPIDatabase r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D110363
2021-04-22 01:15:54 +00:00
Michael Kohler
1be16968ee Bug 1701990 - Remove Drag Space r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D111011
2021-04-11 11:42:57 +00:00
Butkovits Atila
6fcf242672 Backed out changeset 2ee25a7f42f2 (bug 1701990) for causing failures at browser_970511_undo_restore_default.js. CLOSED TREE 2021-04-10 10:50:31 +03:00