Commit Graph

69 Commits

Author SHA1 Message Date
Jan Varga
3b682567d6 Bug 1816388 - Use NS_AsyncCopy directly in FileSystemWritableFileStream::Write. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D169609
2023-02-13 16:11:36 +00:00
Jan Varga
0133f11600 Bug 1816093 - Verify WritableFileStream quota management; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D169445
2023-02-10 13:24:05 +00:00
Jari Jalkanen
998949c63c Bug 1815837 - Deserialize RandomAccessStream on WritableFileStream TaskQueue. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D169226
2023-02-09 08:47:16 +00:00
Jari Jalkanen
bc2b706cfb Bug 1798513 - Perform stateful WritableFileStream shutdown. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D168796
2023-02-09 06:20:28 +00:00
Jari Jalkanen
36846f2d70 Bug 1798513 - Start using XPCOM streams in WritableFileStream implementation. r=dom-storage-reviewers,janv,ipc-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D161892
2023-02-09 06:20:28 +00:00
Kagami Sascha Rosylight
977208bb61 Bug 1811538 - Part 3: Remove ErrorResult that became redundant r=smaug
Some spec comments now matches the implementations (as `Perform ! Foo()` means Foo can't fail).

This only covers a small part of actual redundant ErrorResult parameters because:

1. This patch stack only covers Promise::CreateFallible and does not cover helper functions e.g. Promise::CreateResolvedWithUndefined.
2. All callback calls still require ErrorResult as the IDL layer uses the existing Promise::Create

Differential Revision: https://phabricator.services.mozilla.com/D167701
2023-01-31 19:21:35 +00:00
Kagami Sascha Rosylight
daebb4cf81 Bug 1812315 - Part 1: Implement WritableStream::SetUpNative for File System r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D167824
2023-01-31 17:31:08 +00:00
Iulian Moraru
023e2b3441 Backed out 3 changesets (bug 1811538) for causing build bustages on Promise.cpp. CLOSED TREE
Backed out changeset 0a665be7896a (bug 1811538)
Backed out changeset b949053bae31 (bug 1811538)
Backed out changeset 57d4dbe88611 (bug 1811538)
2023-01-31 19:00:59 +02:00
Kagami Sascha Rosylight
c06dc6c3dd Bug 1811538 - Part 3: Remove ErrorResult that became redundant r=smaug
Some spec comments now matches the implementations (as `Perform ! Foo()` means Foo can't fail).

This only covers a small part of actual redundant ErrorResult parameters because:

1. This patch stack only covers Promise::CreateFallible and does not cover helper functions e.g. Promise::CreateResolvedWithUndefined.
2. All callback calls still require ErrorResult as the IDL layer uses the existing Promise::Create

Differential Revision: https://phabricator.services.mozilla.com/D167701
2023-01-31 15:49:08 +00:00
Jari Jalkanen
18eed26cda Bug 1798513 - Replace USVString with UTF8String in union types with Blob getter. r=nika
Depends on D165730

Differential Revision: https://phabricator.services.mozilla.com/D165731
2023-01-11 08:33:47 +00:00
Noemi Erli
6023fa2a43 Backed out 2 changesets (bug 1798513, bug 1808009) for causing failures in FileSystemDirectoryHandle-removeEntry.https.any.worker.html CLOSED TREE
Backed out changeset 428ea11e738d (bug 1798513)
Backed out changeset 3e69320f3e5c (bug 1808009)
2023-01-10 22:11:45 +02:00
Jari Jalkanen
15dcf60a4c Bug 1798513 - Replace USVString with UTF8String in union types with Blob getter. r=nika
Depends on D165730

Differential Revision: https://phabricator.services.mozilla.com/D165731
2023-01-10 19:08:22 +00:00
Jan Varga
c5ee11ae76 Bug 1803062 - Add a fallible way to create FileSystemSyncAccessHandle objects; r=dom-storage-reviewers,jari
This is a preparation for creating a task queue and a strong worker ref during
FileSystemSyncAccessHandle construction.

Differential Revision: https://phabricator.services.mozilla.com/D163562
2022-12-16 06:38:05 +00:00
Jan Varga
ed542249f8 Bug 1805135 - Fix FileSystemWritableFileStream to use the default writer for all IO operations; r=dom-storage-reviewers,webidl,smaug,jari
Differential Revision: https://phabricator.services.mozilla.com/D164444
2022-12-14 13:20:45 +00:00
Narcis Beleuzu
b7f6b324df Backed out changeset 0e5d5b851391 (bug 1805135) for Hazard bustages on FileSystemWritableFileStream.cpp . CLOSED TREE 2022-12-13 15:25:18 +02:00
Jan Varga
be9c5c1b7c Bug 1805135 - Fix FileSystemWritableFileStream to use the default writer for all IO operations; r=dom-storage-reviewers,webidl,smaug,jari
Differential Revision: https://phabricator.services.mozilla.com/D164444
2022-12-13 06:43:55 +00:00
Olli Pettay
274d50847b Bug 1800470, make it possible to extend WritableStream with another cycle collectable class, r=saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D162287
2022-11-24 13:58:39 +00:00
Cosmin Sabou
53febc09c3 Backed out changeset 779cf97ae5de (bug 1800470) for crashtest failures on 1800470.html. CLOSED TREE 2022-11-18 01:09:55 +02:00
Olli Pettay
d652d9fa29 Bug 1800470, make it possible to extend WritableStream with another cycle collectable class, r=saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D162287
2022-11-17 21:32:57 +00:00
Jari Jalkanen
b3fc06c246 Bug 1772617: Unify OPFS Logging r=dom-storage-reviewers,jari,janv
Differential Revision: https://phabricator.services.mozilla.com/D148318
2022-11-10 17:13:40 +00:00
Jan Varga
6328518386 Bug 1798459 - Disable WritableFileStream on the main thread; r=dom-storage-reviewers,jesup
WritableFileStream can be enabled on the main thread only when bug 1798513 gets fixed.

Differential Revision: https://phabricator.services.mozilla.com/D161354
2022-11-09 17:15:38 +00:00
Jari Jalkanen
822dc92bb6 Bug 1798459 - Restore seek position after truncate on Windows. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D161681
2022-11-09 17:15:37 +00:00
Jan Varga
abfdaade13 Bug 1798459 - Move TruncFile to FileSystemWritableFileStream.cpp; r=dom-storage-reviewers,jesup
There are no other callers anymore.

Differential Revision: https://phabricator.services.mozilla.com/D161543
2022-11-09 17:15:37 +00:00
Jan Varga
98096acbf8 Bug 1798459 - Reduce code duplication and data copying in FileSystemWritableFileStream.cpp; r=dom-storage-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D161372
2022-11-09 17:15:36 +00:00
Jan Varga
29105e19f5 Bug 1798459 - Null check actor before sending the close message; r=dom-storage-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D161541
2022-11-09 17:15:35 +00:00
Jan Varga
c056020b0f Bug 1798459 - Call SetStream on actor only when FileSystemWritableFileStream was successfully created; r=dom-storage-reviewers,jesup
This patch also moves a similar call for SyncAccessHandle.

Differential Revision: https://phabricator.services.mozilla.com/D161274
2022-11-09 17:15:34 +00:00
Jan Varga
1a52108ea5 Bug 1798459 - Support writes with length less than 2GB for now; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D161269
2022-11-09 17:15:32 +00:00
Jan Varga
391e25ad49 Bug 1798459 - Remove dead code related to now removed mTaskQueue; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D161268
2022-11-09 17:15:32 +00:00
Jan Varga
c246574e00 Bug 1798459 - Use a dedicated close message for closing writable file streams; r=dom-storage-reviewers,jesup,jari
Depends on D160915

Differential Revision: https://phabricator.services.mozilla.com/D161023
2022-11-09 17:15:32 +00:00
Jan Varga
26b670a586 Bug 1798459 - Remove unnecessary include directives; r=dom-storage-reviewers,jari
Depends on D160913

Differential Revision: https://phabricator.services.mozilla.com/D160914
2022-11-09 17:15:31 +00:00
Jan Varga
b5f9db5c29 Bug 1798459 - Clean up FileSystemWritableFileStream member variables; r=dom-storage-reviewers,jari
Having protected members in a final class doesn't make sense.

Depends on D160910

Differential Revision: https://phabricator.services.mozilla.com/D160911
2022-11-09 17:15:30 +00:00
Jan Varga
4ba511a8e3 Bug 1798459 - Move FileSystemWritableFileStream::ClearActor to the correct place; r=dom-storage-reviewers,jari
Depends on D160909

Differential Revision: https://phabricator.services.mozilla.com/D160910
2022-11-09 17:15:29 +00:00
Jan Varga
86db4cc961 Bug 1798459 - Synchronize the order of WebIDL methods between the h and cpp file; r=dom-storage-reviewers,jari
Depends on D160908

Differential Revision: https://phabricator.services.mozilla.com/D160909
2022-11-09 17:15:29 +00:00
Jan Varga
081dad1bdb Bug 1798459 - Make FileSystemWritableFileStream::DoSeek a private method; r=dom-storage-reviewers,jari
Depends on D160907

Differential Revision: https://phabricator.services.mozilla.com/D160908
2022-11-09 17:15:29 +00:00
Jan Varga
eac625df45 Bug 1798459 - Separate out FileSystemWritableFileStream::Close and IsClosed which are not part of the WebIDL interface; r=dom-storage-reviewers,jari
Depends on D160906

Differential Revision: https://phabricator.services.mozilla.com/D160907
2022-11-09 17:15:28 +00:00
Jan Varga
ab1adabb72 Bug 1798459 - Clean up FileSystemWritableFileStream construction code; r=dom-storage-reviewers,jari
Depends on D160905

Differential Revision: https://phabricator.services.mozilla.com/D160906
2022-11-09 17:15:28 +00:00
Jan Varga
41cb13f116 Bug 1798459 - Remove dead code related to blobs; r=dom-storage-reviewers,jari
Depends on D160904

Differential Revision: https://phabricator.services.mozilla.com/D160905
2022-11-09 17:15:27 +00:00
Jan Varga
2f8ffb3c7b Bug 1798459 - Add FileSystemWritableFileStream::mManager to cycle collection; r=dom-storage-reviewers,jari
Depends on D160903

Differential Revision: https://phabricator.services.mozilla.com/D160904
2022-11-09 17:15:27 +00:00
Jan Varga
28fa0114be Bug 1798459 - Remove unused FileSystemWritableFileStream::mRequestHandler; r=dom-storage-reviewers,jari
Depends on D160901

Differential Revision: https://phabricator.services.mozilla.com/D160903
2022-11-09 17:15:26 +00:00
Jan Varga
707e69b8dd Bug 1798459 - Move StreamAlgorithms to the cpp file and rename it to WritableFileStreamUnderlyingSinkAlgorithms; r=dom-storage-reviewers,jari
Depends on D161025

Differential Revision: https://phabricator.services.mozilla.com/D160901
2022-11-09 17:15:26 +00:00
Jari Jalkanen
63774cda24 Bug 1769057 - Fix static analysis issues. r=dom-storage-reviewers,janv
Depends on D146203

Differential Revision: https://phabricator.services.mozilla.com/D161025
2022-11-09 17:15:25 +00:00
Randell Jesup
7aa1ba7c78 Bug 1769057: WritableFileStream for OPFS implementation r=janv,webidl,dom-storage-reviewers,smaug
Differential Revision: https://phabricator.services.mozilla.com/D146203
2022-11-09 17:15:25 +00:00
Butkovits Atila
551331d5f1 Backed out 30 changesets (bug 1777361, bug 1798459, bug 1769057) for causing failures at fs/FileSystemBaseHandle-IndexedDB. CLOSED TREE
Backed out changeset 89c3a814819c (bug 1798459)
Backed out changeset 83b1e1b3c168 (bug 1798459)
Backed out changeset 179d6204b3bb (bug 1798459)
Backed out changeset b371599177b6 (bug 1798459)
Backed out changeset b68c63983ae7 (bug 1798459)
Backed out changeset 3b1eaafa31d2 (bug 1798459)
Backed out changeset d9b3c17a5549 (bug 1798459)
Backed out changeset 243631cf4913 (bug 1798459)
Backed out changeset 7d2ffb13d1cc (bug 1798459)
Backed out changeset 1a86d4746c65 (bug 1798459)
Backed out changeset 0f197d402d63 (bug 1798459)
Backed out changeset 5e9ca1b1c95c (bug 1798459)
Backed out changeset 4f07a77a4abd (bug 1798459)
Backed out changeset 985f88adbc8e (bug 1798459)
Backed out changeset 326b8b13aca3 (bug 1798459)
Backed out changeset 9f4f237f33bb (bug 1798459)
Backed out changeset cc31ee7652a8 (bug 1798459)
Backed out changeset 3ed207332879 (bug 1798459)
Backed out changeset 7e8b4f40c31d (bug 1798459)
Backed out changeset e3740924348f (bug 1798459)
Backed out changeset 8c6510e97a9c (bug 1798459)
Backed out changeset 5bfb07498c30 (bug 1798459)
Backed out changeset db0c3d15084b (bug 1798459)
Backed out changeset f92f19dc1a9f (bug 1798459)
Backed out changeset cc82403152c1 (bug 1777361)
Backed out changeset 21d087d3ca5d (bug 1798459)
Backed out changeset da1781f32050 (bug 1798459)
Backed out changeset f768630d046c (bug 1798459)
Backed out changeset 5ad098d5b4b9 (bug 1769057)
Backed out changeset e450859e6f0a (bug 1769057)
2022-11-09 04:16:33 +02:00
Jan Varga
3c6eb8547d Bug 1798459 - Disable WritableFileStream on the main thread; r=dom-storage-reviewers,jesup
WritableFileStream can be enabled on the main thread only when bug 1798513 gets fixed.

Depends on D161543

Differential Revision: https://phabricator.services.mozilla.com/D161354
2022-11-08 16:59:24 +00:00
Jan Varga
1a512c708c Bug 1798459 - Move TruncFile to FileSystemWritableFileStream.cpp; r=dom-storage-reviewers,jesup
There are no other callers anymore.

Differential Revision: https://phabricator.services.mozilla.com/D161543
2022-11-08 16:59:24 +00:00
Jan Varga
782df1b067 Bug 1798459 - Reduce code duplication and data copying in FileSystemWritableFileStream.cpp; r=dom-storage-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D161372
2022-11-08 16:59:23 +00:00
Jan Varga
bb919b1d7a Bug 1798459 - Null check actor before sending the close message; r=dom-storage-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D161541
2022-11-08 16:59:23 +00:00
Jan Varga
34c6fc39ad Bug 1798459 - Call SetStream on actor only when FileSystemWritableFileStream was successfully created; r=dom-storage-reviewers,jesup
This patch also moves a similar call for SyncAccessHandle.

Differential Revision: https://phabricator.services.mozilla.com/D161274
2022-11-08 16:59:21 +00:00
Jan Varga
f6b3f38a32 Bug 1798459 - Support writes with length less than 2GB for now; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D161269
2022-11-08 16:59:20 +00:00
Jan Varga
4518571c03 Bug 1798459 - Remove dead code related to now removed mTaskQueue; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D161268
2022-11-08 16:59:19 +00:00