corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
893,459 Commits 1 Branch 0 Tags
3a0cdaac95dc9372eb59e8e81f1c8d91bbdc0192
Commit Graph

475 Commits

Author SHA1 Message Date
Nikki Sharpley
3a0cdaac95 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-31 17:20:04 +00:00
Ed Lee
8b77709dbf Bug 1933524 - Flip chatbot default and remove from Labs in Nightly and Release r=ngrato,settings-reviewers,sidebar-reviewers,nsharpley,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,jsudiaman,Gijs,sclements,desktop-theme-reviewers,hjones 
Flip default pref to true and remove featuregate entry/strings/styles. Switch actor enabled to actual opt-in / provider. Update sidebar tests for chatbot as default tool.

Differential Revision: https://phabricator.services.mozilla.com/D233204
 2025-01-31 16:58:55 +00:00
Nikki Sharpley
e88f046412 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-31 15:31:22 +00:00
Stanca Serban
20ad1078ea Backed out changeset fed22f8c018a (bug 1944842) for causing mochitests failures in browser_toolbar_sidebar_button.js. CLOSED TREE 2025-01-31 18:02:47 +02:00
Jonathan Sudiaman
5effea42bc Bug 1944842 - Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r=sidebar-reviewers,sfoster 
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.

This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.

Differential Revision: https://phabricator.services.mozilla.com/D236240
 2025-01-31 14:09:59 +00:00
Goloman Adrian
f318ff63af Backed out changeset 93bbf90232b7 (bug 1944190) for causing bc failures @browser_fullscreen_context_menu.js. CLOSED TREE 2025-01-31 03:18:31 +02:00
Nikki Sharpley
7ecca5c680 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-31 00:36:53 +00:00
Goloman Adrian
2d40cae4ae Backed out changeset 55b692ccd15f (bug 1944190) for causing bc failures @browser_fullscreen_context_menu.js. CLOSED TREE 2025-01-31 00:51:02 +02:00
Nikki Sharpley
ae210aa960 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-30 21:00:20 +00:00
Goloman Adrian
93e9d720c3 Backed out changeset 85ef05d78aa4 (bug 1944842) for causing bc failures @browser_resize_sidebar.js. 2025-01-30 23:28:35 +02:00
Goloman Adrian
076b72e294 Backed out changeset bcb4fe8937d9 (bug 1939917) for causing bc failures @browser_toolbar_sidebar_button.js. 2025-01-30 23:12:08 +02:00
Nikki Sharpley
90377aaee3 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-30 19:51:57 +00:00
Jonathan Sudiaman
1294445e6e Bug 1944842 - Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r=sidebar-reviewers,sfoster 
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.

This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.

Differential Revision: https://phabricator.services.mozilla.com/D236240
 2025-01-30 19:25:30 +00:00
Goloman Adrian
a2f88b27ce Backed out changeset fd1a85f26bc5 (bug 1939917) for causing bc failures @browser_all_files_referenced.js. 2025-01-30 21:14:06 +02:00
Nikki Sharpley
a205e140f0 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-30 16:52:11 +00:00
Sandor Molnar
cc838f6396 Backed out changeset 97ac16a67945 (bug 1939917) for causing bc failures @ browser_customize_sidebar.js CLOSED TREE 2025-01-30 01:58:33 +02:00
Jonathan Sudiaman
70919ebe73 Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs r=sidebar-reviewers,fluent-reviewers,tabbrowser-reviewers,dao,bolsson,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236035
 2025-01-29 23:29:40 +00:00
Nikki Sharpley
c3ae33f79c Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-29 23:02:52 +00:00
Sandor Molnar
289ab282d7 Backed out changeset 1ddeda5cc40a (bug 1939917) for causing sidebar related failures CLOSED TREE 2025-01-30 00:23:19 +02:00
Nikki Sharpley
89a42ee5df Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-29 20:59:31 +00:00
Sarah Clements
a9d54a8b9e Bug 1941344 - changes to vertical close tabs button r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,dao,jsudiaman 
* Hide close button for selected and pinned tabs
* Adjust positioning for close button in collapsed state

Differential Revision: https://phabricator.services.mozilla.com/D235202
 2025-01-28 15:06:07 +00:00
Nikki Sharpley
551f8d2aaa Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane,sessionstore-reviewers 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-28 00:51:28 +00:00
Butkovits Atila
a375e8316f Backed out changeset ead9919b0da6 (bug 1938249) for causing failures at test_restore_sidebar.py. CLOSED TREE 2025-01-27 23:43:36 +02:00
Nikki Sharpley
5d44461250 Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-27 18:19:26 +00:00
Goloman Adrian
7dc18d7e06 Backed out changeset 2e8e6c3c9ad8 (bug 1938249) for causing bc failures @browser_glean_sidebar.js. CLOSED TREE 2025-01-27 18:50:28 +02:00
Nikki Sharpley
e80180f302 Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-27 15:52:05 +00:00
Tim Xia
1e483f4009 Bug 1922595 - Change icon and label in sidebar to be that of the selected provider, r=Mardak,firefox-ai-ml-reviewers,fluent-reviewers,jsudiaman 
- implement handling for unset ChatProvider selections
- add `iconUrl` attribute to ChatProvider object
- ensure icon and label synchronization when opening new windows or switching providers
- update tooltip l10nId string template to include `{ $provider } ({ $shortcut })`
- replace existing l10nId strings, sidebar-menu-open-ai-chatbot-tooltip
- use fluent strings for fallback
- fix ftl file: wrap shortcut in ()
- add property getter currentChatProviderInfo
- use lazy.chatProvider
- remove fallbackProvider10nId
- add new test_genai_chat_sidebar_tooltip test

Differential Revision: https://phabricator.services.mozilla.com/D231963
 2025-01-24 23:29:22 +00:00
Sandor Molnar
0e23de4f07 Backed out changeset 125d12cc3cdb (bug 1938249) for causing bc failures @ browser_sidebar_keys.js CLOSED TREE 2025-01-25 01:11:14 +02:00
Nikki Sharpley
463d047cea Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-24 21:34:33 +00:00
kpatenio
49e79df143 Bug 1938428 - Add new probe for RC sidebar tool being enabled or disabled in sidebar settings. r=sidebar-reviewers,shopping-reviewers,rking 
Differential Revision: https://phabricator.services.mozilla.com/D235053
 2025-01-24 18:16:41 +00:00
kpatenio
9463115662 Bug 1941047 - Add new probe for tracking whenever RC is loaded/unloaded in the sidebar. r=sidebar-reviewers,shopping-reviewers,rking 
Differential Revision: https://phabricator.services.mozilla.com/D235052
 2025-01-24 18:16:41 +00:00
Sandor Molnar
991d828365 Backed out changeset 63792baa34ad (bug 1935432) for causing bc perma failures @ browser_customize_sidebar.js CLOSED TREE 2025-01-24 20:26:33 +02:00
Jonathan Sudiaman
5fbb160ed8 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane 
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
 2025-01-24 17:14:01 +00:00
Goloman Adrian
0acf0b8472 Backed out changeset 71732d1ca82f (bug 1935432) for causing bc failures @browser_customize_sidebar.js. CLOSED TREE 2025-01-23 16:14:02 +02:00
Jonathan Sudiaman
38276f5013 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane 
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
 2025-01-23 13:15:15 +00:00
Jonathan Sudiaman
5b20602824 Bug 1941184 - Fix browser_sidebar_collapsed_close_tab_button.js failures caused by close button appearing on mouse hover. r=sidebar-reviewers,kcochrane 
Beta Sim: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7f5490d156d5e7077053e3b6afe4eeaf7102ba1
Nightly: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d6c71ab73854ca8bee3a92270322850f0064a87

Differential Revision: https://phabricator.services.mozilla.com/D235062
 2025-01-23 13:11:49 +00:00
Jonathan Sudiaman
28e3caf8b0 Bug 1940163 - Add telemetry probe to distinguish between panel toggles coming from the old and new sidebar r=sidebar-reviewers,firefox-ai-ml-reviewers,nsharpley,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D233882
 2025-01-16 18:04:24 +00:00
Kelly Cochrane
83a68f1c64 Bug 1933479 - Add tab close button on hover to vertical tabs when sidebar is collapsed r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,emilio,dao 
Differential Revision: https://phabricator.services.mozilla.com/D232561
 2025-01-11 14:52:26 +00:00
Cosmin Sabou
e701b9e4e9 Backed out changeset 4b7b61de1b16 (bug 1933479) for causing failures on browser_startup_images. CLOSED TREE 2025-01-11 06:24:23 +02:00
Kelly Cochrane
6ce815c50c Bug 1933479 - Add tab close button on hover to vertical tabs when sidebar is collapsed r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,emilio,dao 
Differential Revision: https://phabricator.services.mozilla.com/D232561
 2025-01-10 21:55:38 +00:00
Alexandru Marc
7ef1c829eb Backed out changeset ac1633f93f5c (bug 1933479) for causing bc failures @ browser_sidebar_collapsed_close_tab_button.js CLOSED TREE 2025-01-10 23:20:43 +02:00
Kelly Cochrane
af5cca44b2 Bug 1933479 - Add tab close button on hover to vertical tabs when sidebar is collapsed r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,emilio,dao 
Differential Revision: https://phabricator.services.mozilla.com/D232561
 2025-01-10 20:11:50 +00:00
Jonathan Sudiaman
9372222c8c Bug 1935482 - Replace legacy properties with SidebarState properties r=sidebar-reviewers,sessionstore-reviewers,nsharpley,sfoster 
- Move resize observer (setting max width) logic over to SidebarState.
- Add `command` property to SidebarState.
- Handle receiving legacy session restore data.
- Add unit tests along with mocking structures to get a better idea of state/controller coupling (which we should ultimately reduce).

Differential Revision: https://phabricator.services.mozilla.com/D232730
 2025-01-08 23:06:42 +00:00
Nikki Sharpley
2f35a317dc Bug 1939180 - Add test to ensure expanded sidebar remains expanded after exiting DOMFullscreen r=sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D233273
 2025-01-07 15:52:14 +00:00
Cristina Horotan
6ce292dc3a Backed out changeset 2e1d003838c2 (bug 1939180) for causing bc failures at browser_domfullscreen_sidebar.js. CLOSED TREE 2025-01-07 04:35:30 +02:00
Nikki Sharpley
43afc6f56e Bug 1939180 - Add test to ensure expanded sidebar remains expanded after exiting DOMFullscreen r=sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D233273
 2025-01-06 21:06:08 +00:00
Gijs Kruitbosch
c462bad48a Bug 1939639 - don't try to access this.toolbarButton before it's available, r=kcochrane,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233068
 2025-01-02 14:27:46 +00:00
Nikki Sharpley
80815e4664 Bug 1938301 - Wrap tools and extensions when sidebar is expanded r=sidebar-reviewers,desktop-theme-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D232675
 2024-12-26 15:17:48 +00:00
Nikki Sharpley
00ac6faf8b Bug 1935901 - Don't reset sidebar expanded state after entering and leaving inDOMFullscreen mode r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D232878
 2024-12-26 15:13:41 +00:00
Nikki Sharpley
935eac6d0a Bug 1932354 - Fix sidebar visual styling nits r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,dao,hjones,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D232286
 2024-12-20 15:13:04 +00:00