Commit Graph

894 Commits

Author SHA1 Message Date
Florian Quèze
1ee252004d Bug 1935420 - rewrite JS code storing histograms in local variables to make automatic glean migration easier, r=chutten,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,places-reviewers,markh,nsharpley.
Differential Revision: https://phabricator.services.mozilla.com/D234008
2025-01-24 16:18:32 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Nicholas Rishel
7034f58767 Bug 1932795 - Fix debug build assert by moving SourceSurface::GetFrame call to main thread during nsWindowsShellService::CreateWindowsIcon. r=nalexander,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D229849
2024-11-27 21:56:01 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Nicholas Rishel
57ab7f1ebd Bug 1930048 - Fix MinGW compile errors. r=mpohle,win-reviewers,gstoll
Tagalong: Clean up include order and remove unnecessary includes.

Differential Revision: https://phabricator.services.mozilla.com/D229033
2024-11-14 20:45:22 +00:00
Max Christian Pohle
846bcd126a Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical
Differential Revision: https://phabricator.services.mozilla.com/D224975
2024-11-12 22:48:55 +00:00
Nicholas Rishel
2a8da6a369 Bug 1893458 - Verify Start Menu shortcuts created at runtime have propagated to shell:appsfolder before attempting to pin them. r=win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D227131
2024-11-07 21:51:23 +00:00
Stanca Serban
1cefb44ccb Backed out changeset 2fe294eb4a06 (bug 1923448) for causing nsWindowsShellService.cpp. CLOSED TREE 2024-11-07 12:37:21 +02:00
Max Christian Pohle
423ab686ff Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical
Differential Revision: https://phabricator.services.mozilla.com/D224975
2024-11-07 09:54:52 +00:00
Nicholas Rishel
085457c06f Bug 1926151 - Remove Desktop and Public Desktop from folders a pinnable shortcut can exist in. r=bhearsum
We prioritize using `ITaskbarManager` now, which requires a shortcut exist in a location visible from `shell:appsfolder`. `IPinnedList3` can use shortcuts from Desktop and Public Desktop (and potentially other locations) but there's no reason to check for these cases since we have already created the shortcut for `ITaskbarManager`. The rare case of failing to create as shortcut for `ITaskbarManager` is not worth accounting for given `IPinnedList3` is not supported in newer versions of Windows.

Differential Revision: https://phabricator.services.mozilla.com/D227134
2024-10-31 19:53:56 +00:00
Nicholas Rishel
51fef936bb Bug 1926151 - Pre: Rename Matching to Pinnable to better convey usage of hasPinnableShortcut. r=bhearsum,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227133
2024-10-31 19:53:55 +00:00
serge-sans-paille
262f78c07f Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-28 08:21:19 +00:00
Alexandru Marc
a5eb905bf4 Backed out changeset d92f391b3b0c (bug 1922838) for backing out bug 1915351 2024-10-25 16:42:33 +03:00
serge-sans-paille
07101ac24d Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 09:06:01 +00:00
Alexandru Marc
004e704b22 Backed out changeset 448597bce69d (bug 1922838) for causing build bustages. CLOSED TREE 2024-10-24 11:37:49 +03:00
serge-sans-paille
2c916d4973 Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 07:38:30 +00:00
Emilio Cobos Álvarez
4c840d573b Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig
Remove it and related functions, and update the callers.

Differential Revision: https://phabricator.services.mozilla.com/D226261
2024-10-22 09:38:16 +00:00
stransky
c8940b8f54 Bug 1921719 [Linux] Gnome shell search - quit early if we don't have any search results r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D224089
2024-10-01 09:02:43 +00:00
Martin Sirringhaus
74d886e471 Bug 1634961 - Add option to list/switch to open tabs in gnome shell search provider. r=emilio,stransky
Differential Revision: https://phabricator.services.mozilla.com/D220671
2024-09-25 11:17:43 +00:00
Nicholas Rishel
fa92b82d1a Bug 1917674 - Part 2: Ensure shell service native interface members are present on ShellService. r=nalexander
A quirk of the JavaScript implementation of XPCOM's QueryInterface is that it loads the interface's functions onto the queried object. For Services like `ShellService` this creates situations where the interface can be initialized at a distance, causing races depending on how Firefox is run - e.g. Desktop vs Background Task. To ensure consistent behavior this patch forces `ShellService` initialization of the native interface so that the native functions are always present.

To accomplish this, `nsIWindowsShellService` has been modified to inherit from `nsIShellService` to match other platforms and ensure that querying it also loads the `nsIShellService` members into `shellService`.

Differential Revision: https://phabricator.services.mozilla.com/D222154
2024-09-13 17:38:50 +00:00
Nicholas Rishel
303dbaa6f5 Bug 1917674 - Part 1: Fix set to default throwing exception from ShellService in Firefox Background Tasks. r=nalexander,mossop
This succeeds in normal Firefox due to `QueryInterface(Ci.nsIWindowsShellService)` having likely been called on the `nsIShellService` prior to this call, which populates the root `nsIShellService` JavaScript object with the queried interface methods. In Firefox Background Tasks the relevant `QueryInterface` is unlikely to be called ahead of time, resulting in an exception.

Differential Revision: https://phabricator.services.mozilla.com/D221540
2024-09-13 17:38:49 +00:00
stransky
d8ddeccbaa Bug 1917515 [Linux] Check remote command line params before use r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D221624
2024-09-12 12:17:06 +00:00
Nicholas Rishel
08191d01a4 Bug 1917373 - Check that method is present for shellService to prevent exception and dead logging code. r=mpohle
Differential Revision: https://phabricator.services.mozilla.com/D221537
2024-09-10 18:57:00 +00:00
Butkovits Atila
491ec7019a Backed out changeset b469fb3f8d08 (bug 1917373) for causing failures at browser_setDefaultBrowser.js. CLOSED TREE 2024-09-10 03:52:37 +03:00
Nicholas Rishel
5375fe8d3c Bug 1917373 - Check that method is present for shellService to prevent exception and dead logging code. r=mpohle
Differential Revision: https://phabricator.services.mozilla.com/D221537
2024-09-09 21:40:47 +00:00
Joel Maher
3c323306ab Bug 1917158 - move some skip-if -> run-if for browser/components/**/browser.toml. r=sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D221286
2024-09-06 10:08:18 +00:00
Nipun Shukla
8c339c2a58 Bug 1912790 - Prevent Windows pinning notification from being shown twice r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D219063
2024-08-26 20:34:57 +00:00
Dave Townsend
92efa10eef Bug 1892400: Windows remote client should send the intended command line. r=jhirsch,rkraesig
Currently the windows client sends the current process command line which is
potentially an issue since some of those arguments may have been consumed
already. It will also not support sending custom command lines after startup.

This also switches to sending the UTF-8 command line we already have since that
matches other platforms better and makes some arguments const.

Differential Revision: https://phabricator.services.mozilla.com/D216031
2024-08-15 13:45:57 +00:00
Sandor Molnar
d7f53c7f93 Backed out 6 changesets (bug 1892400) for Gtest failures CLOSED TREE
Backed out changeset 25b37643e1fe (bug 1892400)
Backed out changeset 7c12bcdfd937 (bug 1892400)
Backed out changeset bf5862fa2a1d (bug 1892400)
Backed out changeset a0bb5ed531ce (bug 1892400)
Backed out changeset beb16099057e (bug 1892400)
Backed out changeset 82111a5fc831 (bug 1892400)
2024-08-14 11:53:24 +03:00
Dave Townsend
bb48be5f26 Bug 1892400: Windows remote client should send the intended command line. r=jhirsch,rkraesig
Currently the windows client sends the current process command line which is
potentially an issue since some of those arguments may have been consumed
already. It will also not support sending custom command lines after startup.

This also switches to sending the UTF-8 command line we already have since that
matches other platforms better and makes some arguments const.

Differential Revision: https://phabricator.services.mozilla.com/D216031
2024-08-14 06:57:51 +00:00
Dave Townsend
8814ffd2ef Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-13 14:13:10 +00:00
Nipun Shukla
9044371423 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-12 17:05:48 +00:00
Nipun Shukla
72d8c3e995 Bug 1794159 - Part 2: Add LAF unlocking and check for pinning status using new APIs r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D213331
2024-08-12 17:05:47 +00:00
Nipun Shukla
43442a6c30 Bug 1794159 - Part 1: Change C-style strings to nsString classes in LimitedAccessFeatures r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D217762
2024-08-12 17:05:47 +00:00
Narcis Beleuzu
bc91793ab3 Backed out changeset f0866652e65f (bug 1906260) for bc failure on /browser_startup_mainthreadio.js . CLOSED TREE 2024-08-09 12:33:45 +03:00
Alexandre Lissy
155be95bb9 Bug 1907512 - Remove duplicated desktop files r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D216050
2024-08-08 20:48:01 +00:00
Dave Townsend
5d4ad37c57 Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-08 19:35:41 +00:00
pstanciu
4aef4243c2 Backed out 3 changesets (bug 1794159) for causing bc failures on browser_browserGlue_telemetry.js CLOSED TREE
Backed out changeset 764e14e5df4a (bug 1794159)
Backed out changeset 76b8d6cebe8b (bug 1794159)
Backed out changeset f28a29199ba8 (bug 1794159)
2024-08-08 11:16:27 +03:00
Nipun Shukla
9f77b85299 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-08 02:48:50 +00:00
Nipun Shukla
8ab6d14094 Bug 1794159 - Part 2: Add LAF unlocking and check for pinning status using new APIs r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D213331
2024-08-08 02:48:50 +00:00
Nipun Shukla
c85c9a467d Bug 1794159 - Part 1: Change C-style strings to nsString classes in LimitedAccessFeatures r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D217762
2024-08-08 02:48:49 +00:00
Nipun Shukla
5d442069c0 Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-08-07 13:12:20 +00:00
Sandor Molnar
f5c1f4fe7c Backed out changeset 82cd657ce425 (bug 1906260) for causing mochitest failures @ test_interactive_widget.html & pup wd test failures CLOSED TREE 2024-08-06 18:06:20 +03:00
Dave Townsend
b3f84cff12 Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-06 11:46:07 +00:00
Joel Maher
bd1a0e2de3 Bug 1909759 - s/preferences/settings/ for >= macosx 13.x. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D217835
2024-07-26 16:22:15 +00:00
Stanca Serban
973a3fec8c Backed out changeset 0218b28ab8ed (bug 1904436) for crashes related to taskbar pinning. a=backout 2024-07-25 17:28:14 +03:00
Nipun Shukla
93c6531ceb Bug 1900035 - Added Windows start menu pinning to MSIX set-to-default and taskbar pinning scenarios r=omc-reviewers,firefox-desktop-core-reviewers ,Gijs,mpohle,aminomancer,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D212461
2024-07-24 21:13:35 +00:00
Nipun Shukla
627adad1af Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-07-24 18:40:33 +00:00
Sylvestre Ledru
a3ea006705 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
This new version of clang 17 also slightly changed the formatting.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Norisz Fay
d75ebb2a50 Backed out changeset d06c14636494 (bug 1904436) as requested for crashes related to Windows pinning to taskbar CLOSED TREE 2024-07-10 22:27:46 +03:00