corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
893,459 Commits 1 Branch 0 Tags
3a0cdaac95dc9372eb59e8e81f1c8d91bbdc0192
Commit Graph

961 Commits

Author SHA1 Message Date
Rebecca King
16716b7b5a Bug 1931402 - Add undo button for new theme installation - r=fluent-reviewers,rpl,Gijs,willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D229410
 2025-01-28 18:55:55 +00:00
Tom Schuster
b5796e10bf Bug 1936523 - Remove inline event handlers from PopupNotifications. r=Gijs,extension-reviewers,reusable-components-reviewers,mstriemer 
I ended up having to change some of the fundamentals of the popupnotification element because the code relied on being able to inherit inline event handler attributes such as buttoncommand as oncommand on the button element and so on.

The primary user of the popupnotification element seems to be `PopupNotifications`. Following a pre-existing coupling with `PopupNotifications._onCheckboxCommand`, by default all commands/actions will simply call the corresponding `PopupNotifications` handler. However, I found at least one instance in `panelUI.js` that tries to override the command handlers. I solved this by dispatching a custom cancelable event on the popupnotification element.

Differential Revision: https://phabricator.services.mozilla.com/D231927
 2024-12-18 17:38:57 +00:00
Robin Steuber
0e04f7611b Bug 1907120 - Remove other multi-instance checks now that we check at startup r=nrishel,nalexander,desktop-theme-reviewers,application-update-reviewers,dao 
This does keep the checks in the interactive update interface, since we don't want to to show the user the "Restart to Update" button at the end if restarting will not update.

Differential Revision: https://phabricator.services.mozilla.com/D227285
 2024-12-13 02:57:36 +00:00
Cristina Horotan
84e4c5d98c Backed out 9 changesets (bug 1907127, bug 1907126, bug 1907128, bug 1907120) for causing build bustages at nsAppRunner.cpp CLOSED TREE 
Backed out changeset 7a9ba6ef7133 (bug 1907126)
Backed out changeset c500e441e887 (bug 1907126)
Backed out changeset 6cec10a15827 (bug 1907126)
Backed out changeset 636054838661 (bug 1907126)
Backed out changeset d6310226067f (bug 1907128)
Backed out changeset 386145953b08 (bug 1907120)
Backed out changeset 77099a71e959 (bug 1907127)
Backed out changeset b9604bb0b576 (bug 1907127)
Backed out changeset cb625b7eb786 (bug 1907127)
 2024-12-13 04:00:23 +02:00
Robin Steuber
882992c53b Bug 1907120 - Remove other multi-instance checks now that we check at startup r=nrishel,nalexander,desktop-theme-reviewers,application-update-reviewers,dao 
This does keep the checks in the interactive update interface, since we don't want to to show the user the "Restart to Update" button at the end if restarting will not update.

Differential Revision: https://phabricator.services.mozilla.com/D227285
 2024-12-13 00:18:34 +00:00
Tom Schuster
a7bbaa266b Bug 1936519 - Remove inline event handler from panic-button success panel. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D231786
 2024-12-11 18:40:00 +00:00
Luca Greco
764246b5cb Bug 1935726 - Use default OK button string in the addon post install dialog. r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D226953
 2024-12-09 12:25:29 +00:00
Tom Schuster
00c657d84c Bug 1934875 - Remove inline event handler from unified extension panel. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D230928
 2024-12-06 13:45:33 +00:00
Tom Schuster
2f100cb460 Bug 1927155 - Remove inline event handlers from customize popups/panels. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D226919
 2024-12-06 11:04:40 +00:00
Tom Schuster
5da46ad0f5 Bug 1925488 - Remove inline click handler from the customization panel. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D226149
 2024-10-23 08:50:17 +00:00
Tom Schuster
09718f8134 Bug 1925488 - Remove inline popupshowing handlers from the customization panel. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D226148
 2024-10-23 08:50:16 +00:00
Tom Schuster
b558f54685 Bug 1925488 - Remove the UI density menu inline event handlers. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D226137
 2024-10-23 08:50:16 +00:00
Tom Schuster
0367bfc064 Bug 1925488 - Remove inline command handlers from the customization panel. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D226128
 2024-10-23 08:50:15 +00:00
Jared Hirsch
971718cd11 Bug 1883162 - Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao 
Differential Revision: https://phabricator.services.mozilla.com/D223238
 2024-10-18 23:57:55 +00:00
Sandor Molnar
5eb3d8fc2b Backed out changeset e7719ffbcf2e (bug 1883162) for causing bc failures @ browser_sentence_case_strings.js CLOSED TREE 2024-10-18 04:22:37 +03:00
Jared Hirsch
d6887069ea Bug 1883162 - Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao 
Differential Revision: https://phabricator.services.mozilla.com/D223238
 2024-10-17 23:55:53 +00:00
Tom Schuster
86f31dc0de Bug 1924466 - Remove inline popupshowing event handler from the overflow customize context menu. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D225505
 2024-10-16 08:31:58 +00:00
Tom Schuster
04cd7d9f95 Bug 1924466 - Remove inline command event handlers from the overflow customize context menu. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D225481
 2024-10-16 08:31:58 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett 
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
 2024-10-15 16:15:09 +00:00
Florian Quèze
165920b94c Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi. 
Differential Revision: https://phabricator.services.mozilla.com/D222608
 2024-09-25 10:00:41 +00:00
Sandor Molnar
5095328e2d Backed out 5 changesets (bug 1918702) for causing bc failures @ browser_aaa_eventTelemetry_run_first.js CLOSED TREE 
Backed out changeset f55480885aeb (bug 1918702)
Backed out changeset db1eaf09430d (bug 1918702)
Backed out changeset a9179f6e684d (bug 1918702)
Backed out changeset f9d3349e6fe3 (bug 1918702)
Backed out changeset 10d2957bbfe8 (bug 1918702)
 2024-09-25 12:38:05 +03:00
Florian Quèze
3cf2dde6da Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi. 
Differential Revision: https://phabricator.services.mozilla.com/D222608
 2024-09-25 07:19:05 +00:00
timw-dev
84076b9d83 Bug 1896764 - onViewToolbarsPopupShowing and ToolbarContextMenu should move out of browser.js.r=scunnane,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D217795
 2024-08-22 11:11:50 +00:00
Tom Schuster
728dc2abf5 Bug 1904029 - Correctly init View > Toolbars in the menubar. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D214543
 2024-06-21 15:11:46 +00:00
Dão Gottwald
25644d743c Bug 1902314 - Consolidate toolbarpaletteitem rules. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D213590
 2024-06-17 16:26:14 +00:00
Tom Schuster
a8c9401904 Bug 1893068 - Remove command inline event handlers from the menubar. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D212246
 2024-06-14 21:08:03 +00:00
Gijs Kruitbosch
004090bf97 Bug 1890718 - move bookmark and library panelview event handling to not use inline event attributes, r=places-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D207881
 2024-04-23 15:21:21 +00:00
Gijs Kruitbosch
efe284f711 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207120
 2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
f63cdcf1d7 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D207119
 2024-04-15 23:23:50 +00:00
Cosmin Sabou
d17bfe39f8 Backed out 3 changesets (bug 1890718) for failing sevaral UI related bc tests. CLOSED TREE 
Backed out changeset 3d91014dfcef (bug 1890718)
Backed out changeset 8c09e2028ad9 (bug 1890718)
Backed out changeset ff91ebffa8ab (bug 1890718)
 2024-04-15 21:11:48 +03:00
Gijs Kruitbosch
9d2dbb58f2 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207120
 2024-04-15 14:45:51 +00:00
Gijs Kruitbosch
bee5c98c47 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207119
 2024-04-15 14:45:51 +00:00
Yi Xiong Wong
03a2372d77 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D207110
 2024-04-15 10:22:46 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201867
 2024-03-21 22:05:28 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201124
 2024-02-12 18:49:34 +00:00
Mike Conley
19a6e40b11 Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200082
 2024-02-05 22:03:13 +00:00
Itiel
cd3ef922f3 Bug 1869574 - Refactor the headerText setter to cater for more panelview needs r=twisniewski,Gijs,translations-reviewers 
This introduces `mainview-with-header` attribute for panels that their
mainview should have a header (no matter where they appear); and
`has-custom-header` for panels that their panelview (not necessarily a
mainview) has a custom design for a header, one that headerText setter
can't anticipate in advance (due to UX needs that may arise).
If one of these attributes are set on the panel, this signals headerText
that the panelview's header should NOT be removed and that the markup
should be respected.

Differential Revision: https://phabricator.services.mozilla.com/D196671
 2024-01-09 17:01:25 +00:00
Gijs Kruitbosch
87fba25ea4 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194632
 2023-11-27 23:27:36 +00:00
Iulian Moraru
df1ac624b2 Backed out changeset 49b89e35b5f5 (bug 1866503) for causing multiple bc failures related to panelUI. CLOSED TREE 2023-11-27 15:39:13 +02:00
Gijs Kruitbosch
ae5f8336a8 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194632
 2023-11-27 12:14:03 +00:00
Emilio Cobos Álvarez
f3634c1549 Bug 1863724 - Improve alignment of customization mode footer items. r=dao,desktop-theme-reviewers 
On Linux it doesn't look as bad without this, but on macOS it's very
noticeable.

This ensures that items are properly centered.

The flex display / alignment of the link isn't needed (it only has text
anyways).

Differential Revision: https://phabricator.services.mozilla.com/D193784
 2023-11-16 14:44:21 +00:00
Emilio Cobos Álvarez
d45fa4cc60 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189630
 2023-10-23 15:51:37 +00:00
Cristina Horotan
c1f4823686 Backed out changeset 6d11e2f54668 (bug 1855875) for causing bug 1856697 2023-10-04 18:46:25 +03:00
Emilio Cobos Álvarez
253a8284f6 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189630
 2023-10-02 16:51:52 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
Shane Hughes
6da3c5e401 Bug 1831906 - Add release notes link to update modal prompts. r=bytesized,omc-reviewers,application-update-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D177410
 2023-06-08 15:48:01 +00:00
William Durand
ffdc71c1cd Bug 1833438 - Add support for notifications in the extensions panel. r=Itiel,rpl,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D179345
 2023-05-30 20:07:39 +00:00