Test by Gijs. Note that I removed the .isActive assertion, because this doesn't
affect activeness.
We could make that change too, but that's a bigger change, and I think we want
to do this regardless.
The CAN_RUN_SCRIPT annotations are obsolete (they come from bug 1582042
which directly fired docshell activity events, but that's not true
anymore, bug 1635914 changed the setup a bit later).
Differential Revision: https://phabricator.services.mozilla.com/D185643
If the user has not opted in, automatically set the sidebar to `active` if:
1. The sidebar has not already been automatically set to `active` twice.
2. It's been at least 24 hours since the user last saw the sidebar because
of this auto-activation behavior.
3. The sidebar was not already auto-activated in this session. This is
unlikely to come into play for most users, since this only executes on
startup and when the `enabled` Nimbus variable changes.
Also, if the user has still not opted in at the end of the session, and
we auto-activated the sidebar for them, auto-close the sidebar on
shutdown. This means we show the onboarding to the user automatically in
each PDP for up to 2 sessions. After that, if the user still has not
opted in, we will stop trying.
Differential Revision: https://phabricator.services.mozilla.com/D184994
This prevents fullscreen states that hide chrome while WebAuthn prompts are shown. Specifically, it
1) ensures that the navigation toolbox is shown in fullscreen windows, and
2) disallows fullscreen DOM elements.
Differential Revision: https://phabricator.services.mozilla.com/D187001
Adds functionality to the Translations panel settings
menu for users to disable whether translations will
be automatically offered, i.e. that the translations
panel automatically pops open on relevant web pages.
Co-authored-by: Greg Tatum <tatum.creative@gmail.com>
Differential Revision: https://phabricator.services.mozilla.com/D186251
Test by Gijs. Note that I removed the .isActive assertion, because this doesn't
affect activeness.
We could make that change too, but that's a bigger change, and I think we want
to do this regardless.
The CAN_RUN_SCRIPT annotations are obsolete (they come from bug 1582042
which directly fired docshell activity events, but that's not true
anymore, bug 1635914 changed the setup a bit later).
Differential Revision: https://phabricator.services.mozilla.com/D185643
Previously the translations button would stay visible in reader
mode but no interact with the page when clicked. This patch
ensures that the translations button is no longer visible
once a user enters reader mode.
Differential Revision: https://phabricator.services.mozilla.com/D185607
If the menu is opened, the corresponding `mouseup` event that generates
this `click` event will be handled by the menuitem, so we don't
need to handle this `click` event.
Differential Revision: https://phabricator.services.mozilla.com/D185465
This cannot be done during "showing" because the richlistbox does not have a
frame at that point.
As well as enabling arrow keys, focus also clearly identifies the speaker
being considered for a permission grant. Without focus, the selected item is
identified by subtle background color changes, and so the selected item would
not be clear in a list of two items.
Depends on D182318
Differential Revision: https://phabricator.services.mozilla.com/D182319
This patch replaces both toggles in the different sub views of the ETP panel with `moz-toggle`. Previously there was a small discrepancy where we were setting an `aria-label` on one toggle but not the other. I added a method to handle updating both toggles at once to ensure they stay in sync/always receive the same updates.
Differential Revision: https://phabricator.services.mozilla.com/D176700
Test by Gijs. Note that I removed the .isActive assertion, because this doesn't
affect activeness.
We could make that change too, but that's a bigger change, and I think we want
to do this regardless.
The CAN_RUN_SCRIPT annotations are obsolete (they come from bug 1582042
which directly fired docshell activity events, but that's not true
anymore, bug 1635914 changed the setup a bit later).
Differential Revision: https://phabricator.services.mozilla.com/D185643
