Commit Graph

27 Commits

Author SHA1 Message Date
Masatoshi Kimura
0204c8f25e Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot
MozReview-Commit-ID: 81ZkeYdSPVW
2017-08-06 13:15:31 +09:00
Nicholas Nethercote
723f585d9c Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.

The patch also removes a couple of unused declarations from
nsIStringBundle.idl.

Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.
2017-08-04 14:40:52 +10:00
Nicholas Nethercote
8b5bdf0867 Bug 1380227 - Avoid many UTF16toUTF8 and UTF8toUTF16 conversions in nsStringBundle. r=emk.
Most of the names passed to nsIStringBundle::{Get,Format}StringFromUTF8Name
have one of the two following forms:

- a 16-bit C string literal, which is then converted to an 8-bit string in
  order for the lookup to occur;

- an 8-bit C string literal converted to a 16-bit string, which is then
  converted back to an 8-bit string in order for the lookup to occur.

This patch introduces and uses alternative methods that can take an 8-bit C
string literal, which requires changing some signatures in other methods and
functions. It replaces all C++ uses of the old methods.

The patch also changes the existing {Get,Format}StringFromName() methods so
they take an AUTF8String argument for the name instead of a wstring, because
that's nicer for JS code.

Even though there is a method for C++ code and a different one for JS code,
|binaryname| is used so that the existing method names can be used for the
common case in both languages.

The change reduces the number of NS_ConvertUTF8toUTF16 and
NS_ConvertUTF16toUTF8 conversions while running Speedometer v2 from ~270,000 to
~160,000. (Most of these conversions involved the string
"deprecatedReferrerDirective" in nsCSPParser.cpp.)
2017-07-12 15:13:37 +10:00
b4ca835e98 Bug 1321321 - Ensure that we always save files with the given extension / Work-around NSSavePanel limitations when saving files with multiple extensions. r=mstange. 2017-02-25 00:34:46 +01:00
da6ebf2e86 Bug 1320377 - Allow users to change file extension in the Save dialog. r=mstange. 2016-11-28 18:04:55 +01:00
Olli Pettay
d06eced574 Bug 1295914, improve the label of the button of folder picker, r=baku,mstange,karlt,jimm 2016-08-24 02:07:21 +03:00
Nate Weaver
0df57c50ec Bug 426680 - Set allowedFileTypes on NSSavePanel so the file extension isn't selected. r=mstange. 2016-07-22 08:24:02 +02:00
Chris Peterson
6c0f810682 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
b566e2af67 Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
Makoto Kato
32db2e3207 Bug 1218315 - Replace NS_LITERAL_STRING(...).get() with MOZ_UTF16(...) on widget. r=nfroyd 2015-10-28 14:28:06 +09:00
Birunthan Mohanathas
eeb9aaaa94 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Ehsan Akhgari
abfa179fa3 Bug 924019 - Do not assume that PRUnichar and UniChar/unichar are the same type; r=smichaud 2013-10-10 12:59:40 -04:00
Jonathan Watt
7695a3a508 Bug 894840, part 1 - Refactor and move the mode storage to nsBaseFilePicker. r=mounir 2013-07-22 10:12:32 +01:00
Josh Aas
9a107e4d3d Bug 903788 - Fix a few memory leaks in Cocoa file picker code. r=smichaud 2013-08-12 13:29:00 -04:00
Gijs Kruitbosch
b6fbf28aa4 Bug 865803 - allow not setting defaultDirectory (nullcheck before converting to URL), r=joshmoz 2013-04-26 19:46:32 +02:00
Andre Reinald
69f7c94228 Bug 802776 - Update deprecated calls in NSOpenPanel and NSSavePanel and transform default directory paths strings to URIs so they work as expected. r=josh 2013-04-18 12:39:09 -04:00
Mats Palmgren
d87341df89 Bug 786533 - On OSX, one of the system header files (exception_defines.h) defines 'try' and 'catch' as macros which breaks @try/@catch. We need to #undef those before using nsObjCExceptions.h. r=ehsan 2013-01-15 13:22:03 +01:00
Josh Aas
c7e8d524c1 Bug 801601: Remove code specific to OS X 10.5 in Cocoa widgets. r=smichaud 2012-11-09 05:22:36 -05:00
Ehsan Akhgari
243c878d26 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Josh Aas
c29d6f17c5 Bug 780489: Fix some compiler warnings in plugin and mac code. r=smichaud 2012-08-07 00:09:23 -04:00
Aryeh Gregor
8b4a23fc4c Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Geoff Lankow
7a64448b03 Bug 749930 - Replace uses of nsILocalFile with nsIFile (compiled code only); r=bsmedberg 2012-06-06 14:08:30 +12:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Cameron McCormack
7ce11ac0b6 Bug 715024 - Remove duplicate functions on nsCocoaFeatures and nsToolkit. r=bgirard 2012-05-17 17:53:20 +10:00
Cameron McCormack
16270bcb0a Back out bug 715024 due to bustage. 2012-05-17 12:13:02 +10:00
Cameron McCormack
24310eb7f8 Bug 715024 - Remove duplicate functions on nsCocoaFeatures and nsToolkit. r=bgirard 2012-05-17 11:36:56 +10:00
Brian R. Bondy
d0a93b0ace Bug 679226 - Fold widget/src into widget. r=roc 2012-01-03 22:09:29 -05:00