Commit Graph

88 Commits

Author SHA1 Message Date
Andrew Swan
24ee59fdc9 Bug 1353194 Streamline the startup extension compatibility check r=kmag
Also extend activeAddons records with a started flag to avoid
double-starting extensions that are upgraded during the startup check.

MozReview-Commit-ID: FPX71Q3lSrw
2017-09-10 12:23:45 -07:00
Phil Ringnalda
05ee23cfc3 Backed out 2 changesets (bug 1353194) for leaving unreferenced files
Backed out changeset 246b6aae8157 (bug 1353194)
Backed out changeset e3c293ceedf3 (bug 1353194)

MozReview-Commit-ID: EshIZ3vmebw
2017-09-10 19:15:39 -07:00
Andrew Swan
98d209d7fe Bug 1353194 Streamline the startup extension compatibility check r=kmag
Also extend activeAddons records with a started flag to avoid
double-starting extensions that are upgraded during the startup check.

MozReview-Commit-ID: FPX71Q3lSrw
2017-09-10 12:23:45 -07:00
Florian Quèze
b622c2b081 Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Kris Maglione
7e8387fa92 Bug 987512: Part 5 - Remove manual AddonManager promise wrappers. r=rhelmer
MozReview-Commit-ID: LrEiGbQGrt6
2016-12-15 12:03:24 -10:00
Kris Maglione
c6f4e86064 Bug 1318089: Turn on no-unused-vars ESLint rule for toolkit/mozapps/extensions. r=rhelmer
MozReview-Commit-ID: 1GdxLoW3FLX
2016-11-16 13:01:16 -08:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Robert Helmer
f8116c2128 bug 1228792 - remove use of array comprehensions r=mossop 2015-12-02 18:40:59 -08:00
Dave Townsend
315c15417d Bug 1226386: Remove functions names where possible. r=rhelmer
We used to need explicit names for functions to make stack traces display
properly. The JS engine is smarter now so doesn't need them and they just
make the code messy and redundant.
2015-11-19 16:35:41 -08:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Irving Reid
a803765fb8 Bug 760356: Only show the addon compat UI when necessary; r=unfocused 2014-05-20 13:16:39 -04:00
Irving Reid
b814820d30 Bug 760356: #1 Always request all add-ons when loading AddonRepository; r=unfocused 2014-05-20 13:16:37 -04:00
Irving Reid
f9b81592db Bug 1010449: Add telemetry for add-on compatibility changes, upgrades during startup time add-on update check; r=unfocused 2014-05-20 13:15:24 -04:00
Irving Reid
1b152f9fe9 Bug 772484 - Allow user to cancel add-on update check and clean up correctly when they do. r=Unfocused 2014-03-14 08:52:55 -04:00
Alexander J. Vincent
124eff5db7 Bug 952307 - Move some addon-private JSM's to a subdirectory. r=Unfocused 2014-01-07 20:14:08 -08:00
Irving Reid
95cf27ed4c Bug 965788 - Use XHR timeout for addon checks. r=Mossop, r=Unfocused 2014-02-11 14:14:32 -05:00
Jonathan Kamens
3797f4a999 Bug 823042 - Fix redeclared argument warnings. r=Mossop 2012-12-19 09:10:19 -05:00
Atul Jangra
db8be2ae7c Bug 767236 - Part 4: Name all anonymous functions in remaining Add-ons Manager code. r=Unfocused 2012-10-24 22:58:00 +13:00
Marcos S.
d10d3c97af Bug 758950 - Part 2a: Use more for...of loops in Add-ons Manager frontend and backend code. r=Unfocused 2012-09-21 22:35:00 +12:00
Neil Rashbrook
3f194429dd Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-26 00:11:16 +01:00
Ed Morley
4bd90ea948 Backout ec9451e9e830 (bug 758354) for PGO linux permaorange in browser_bug422590.js and friends 2012-06-25 19:14:43 +01:00
Neil Rashbrook
d9a10be7eb Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-25 09:24:49 +01:00
Blair McBride
b3b05ec84b Bug 746908 - Add parameter guards to AddonManager/AddonManagerPrivate API functions. r=dtownsend 2012-05-30 18:34:32 +12:00
Marcos Santiago
59df26ce78 Bug 740237 - Use for...of loops in Add-ons Manager frontend and backend code. r=Unfocused 2012-05-28 00:21:48 +12:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Blair McBride
5c141ea5c9 Bug 718630 - Add-ons with compatibility override are displayed as enabled and incompatible if skipping compatibility check after upgrade. r=dtownsend 2012-02-15 15:07:29 +13:00
Dave Townsend
5edc7e570b Bug 704987: Ignore the hotfix add-on when warning users about incompatible add-ons. r=robstrong 2011-12-16 12:04:40 -08:00
Blair McBride
5bf15b09c4 Bug 706777 - Automatically repopulate AddonRepository database on application upgrade. r=dtownsend 2011-12-07 23:48:33 +13:00
Blair McBride
e57aa19f20 Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Gavin Sharp
7a6bbaa11d Back out 0f11ca4d1733 (bug 670023) due to xpcshell test failures 2011-07-21 22:20:21 -04:00
Blair McBride
a27157de11 Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Tim Taubert
39def6724d Backed out changeset a115d824218c (bug 670023) 2011-07-20 03:28:05 +02:00
Blair McBride
8c3e67983f Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Dave Townsend
fa7d28d97e Bug 666431: Track changes made to add-ons during early startup. r=robstrong
try: -b do -p linux,linuxqt,linux64,macosx64,win32,macosx -u xpcshell,mochitest-o -t none
2011-06-29 14:50:43 -07:00
Robert Strong
4e337362c9 Bug 608138 - Exclude plugins from the compatibility wizard checks. r=dtownsend, a=b7 2010-10-29 12:04:52 -07:00
Robert Strong
9e24522f45 Bug 608115 - ReferenceError: strings is not defined in a couple of obvious places in update.js. r=dtownsend, a=b7 2010-10-29 12:04:38 -07:00
Dave Townsend
3ba86f405e Bug 599105: Default wizard page of update extensions window shown when switching between builds. r=robstrong, a=blocks-final 2010-10-12 10:52:44 -07:00
Dave Townsend
6f3926e557 Bug 557956: Update compatibility information for installed add-ons when the application is upgraded. r=robstrong, a=blocking-beta5 2010-08-17 12:08:33 -07:00