corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
508,231 Commits 1 Branch 0 Tags
38662e82c89140a4917bd901b26e2817b17686f3
Commit Graph

92 Commits

Author SHA1 Message Date
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Zibi Braniecki
b8f141fa61 Bug 1386015 - Do not generate styling for each element with inherited color. r=jaws 
This patch does a minor refactor of the code used to style popup menu for
the <select> element.
It improves the custom styling experience on MacOS, preserves the functionality
on Windows and removes the unnecessary per-item CSS rules significantly
improving the performance of opening the <select> list.


MozReview-Commit-ID: 7myXq8aDAWr
 2017-08-11 17:38:14 -07:00
Mike Conley
6352bfc45f Bug 1387583 - Avoid leaking a window in SelectParentHelper. r=jaws 
MozReview-Commit-ID: 6YILe7gi2fZ
 2017-08-10 16:26:37 -04:00
Kris Maglione
6efaf66ac4 Bug 1381337: Don't contstrain popup select dropdowns to the document viewport. r=aswan 
MozReview-Commit-ID: HzISTjddHHK
 2017-07-16 13:13:03 -07:00
Jared Wein
e3ce8f6f2a Bug 1375224 - Remove use of <style scoped> from SelectParentHelper.jsm. r=mconley 
MozReview-Commit-ID: HeTSfqFTeVc
 2017-06-21 15:31:31 -04:00
Jared Wein
024ba531f3 Bug 1343569 - Delay hiding the popup on blur if the search field gains focus. r=enndeakin+6102 
Since the order of events is 'blur' followed by 'focus', we send a message from the content process to the parent process and wait for a reply to give enough time for the parent process to signal that the 'blur' was related to the focusing of the search field. If the parent process hasn't signaled as such, then the content process will proceed with hiding the dropdown.

MozReview-Commit-ID: 6ngoo9uHcsM
 2017-04-25 20:19:42 -04:00
Jared Wein
ea863e391a Bug 1355078 - Restore scroll position after updating select popup. r=mossop 
MozReview-Commit-ID: 7HfuUCymDz
 2017-04-11 01:36:07 -04:00
Jared Wein
ffb4cdda2c Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling. r=mossop 
MozReview-Commit-ID: 3jzZOIiJyXT
 2017-04-10 16:03:03 -04:00
Jared Wein
62a7b70f59 Bug 1350662 - Don't compare the select background color with the foreground color since it may be changed by the options. r=mossop 
The comparison being removed was only put in place because it seemed like a "good-idea" to prevent <select> from being unreadable, though it's not a fool-proof strategy and it breaks content that uses different styling approaches. This removal does not regress any of the other test cases.

MozReview-Commit-ID: 8HeXZXnjpbl
 2017-03-28 15:27:57 -04:00
Jared Wein
86ce1a312b Bug 1349701 - Update the styles of <select> popups on focus. r=mossop 
This patch also fixes a bug in our UpdateDropDown code where we weren't computing updated styles for <select> element, as well as another bug where we weren't passing the correct number of arguments to this.populate.

MozReview-Commit-ID: 8LAeIliRXhZ
 2017-03-23 13:34:21 -04:00
Jared Wein
dc32b9ca7e Bug 1348617 - Use the alpha channel of custom styled select backgrounds by applying the requested color on top of the system's background. r=mossop 
This matches parity with Google Chrome Canary Version 59.0.3046.0 (Official Build) canary (64-bit).

MozReview-Commit-ID: 3rkhiFv8ezX
 2017-03-21 10:51:40 -04:00
Saghan
5e74f0e93d Bug 1337025 - Add event listener to command event which will be triggered when x button is clicked and repopulate the list. r=jaws 2017-03-16 15:58:31 -07:00
Jared Wein
d8ed36d1c1 Bug 1347329 - Make sure that the nth-child index gets updated when recursing so that colors get applied correctly when optgroups are used. r=mossop 
This problem only occurs when optgroups are involved since they introduce recursion in to the menu-building code and we weren't correctly passing state through
the recursion.

MozReview-Commit-ID: 514zcjgXbIY
 2017-03-14 19:06:57 -04:00
Sebastian Hengst
dbf93f818e Backed out changeset 899f6ba2fe55 (bug 1347329) for failing browser_selectpopup_colors.js. r=backout 2017-03-16 00:25:57 +01:00
Jared Wein
16a27bd8ea Bug 1347329 - Make sure that the nth-child index gets updated when recursing so that colors get applied correctly when optgroups are used. r=mossop 
This problem only occurs when optgroups are involved since they introduce recursion in to the menu-building code and we weren't correctly passing state through
the recursion.

MozReview-Commit-ID: 514zcjgXbIY
 2017-03-14 19:06:57 -04:00
Jared Wein
b9e51d878a Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers. r=mossop 
Previously we were respecting the webpages request to show a translucent background on popups, though it now seems that content didn't actually
want a translucent background. After comparing with Chrome, I see that they remove the alpha channel and always show the background color as
fully opaque. This patch also fixes a related bug where the background-color may have been set to a transparent color (not rgba(0, 0, 0, 0)) and
we would show the popup as transparent. This is now fixed with this patch as well.

MozReview-Commit-ID: KqDtvI0zwqP
 2017-03-14 14:43:00 -04:00
Jared Wein
d72377ba95 Bug 1344574 - Compare the option foreground color to the used select background color instead of just the user-agent default select background color. r=mconley 
MozReview-Commit-ID: A01xHyGP9ec
 2017-03-06 12:10:14 -05:00
Xidorn Quan
57b3c7d52d Bug 1339394 - Don't serialize transparent color to transparent keyword when not necessary. r=heycam,jaws 
MozReview-Commit-ID: 59cmaCoFJMR
 2017-02-16 10:26:13 +11:00
Jared Wein
99590058d8 Bug 1339966 - Add a pref to disable content styling for <select> and <option>. r=mconley 
MozReview-Commit-ID: FMSbuHUKLY
 2017-02-15 18:25:31 -05:00
Jared Wein
d0cabaaa49 Bug 1338850 - Only set the background color and foreground color on the select element if it is not transparent or equal to each other. r=mconley 
MozReview-Commit-ID: AjzZhoBbcFL
 2017-02-15 13:30:50 -05:00
Jared Wein
43e67c7c8c Bug 1336301 - Styles that are applied directly to the select element should be forwarded to the popup. r=mconley 
MozReview-Commit-ID: 29DjcUUqEkx
 2017-02-04 00:33:13 -05:00
Jared Wein
1f5534bff9 Bug 1336125 - Apply option styles using a scoped stylesheet to allow for disabling custom styling on the active item. r=mconley 
MozReview-Commit-ID: 1dZ1rbKbNY9
 2017-02-03 12:46:45 -05:00
Wes Kocher
ebb0c2f598 Backed out changeset 87d2810770f3 (bug 1336125) for OSX failures in browser_selectpopup.js a=backout 
MozReview-Commit-ID: 59dxqPvMXmo
 2017-02-07 15:15:48 -08:00
Jared Wein
d6db6fc431 Bug 1336125 - Apply option styles using a scoped stylesheet to allow for disabling custom styling on the active item. r=mconley 
MozReview-Commit-ID: 1dZ1rbKbNY9
 2017-02-03 12:46:45 -05:00
Jared Wein
e12169bf6e Bug 1335483 - Compare the user agent value for the select option styling to determine if content has opted-in to custom styling. r=mconley 
MozReview-Commit-ID: 8wqclzJr2si
 2017-01-31 15:58:27 -05:00
Wes Kocher
8973294639 Backed out changeset 88872e0b68d2 (bug 1335483) for failures in browser_selectpopup.js a=backout 
MozReview-Commit-ID: 39EV3LzTBiI
 2017-02-03 11:54:32 -08:00
Jared Wein
1d335e9426 Bug 1335483 - Compare the user agent value for the select option styling to determine if content has opted-in to custom styling. r=mconley 
MozReview-Commit-ID: 8wqclzJr2si
 2017-01-31 15:58:27 -05:00
Jared Wein
eff6c54cb2 Bug 910022 - Allow websites to provide custom background colors and foreground colors for <select> popups. r=mconley 
Portions of the patch were written by Jared Beach (beachjar@msu.edu)

MozReview-Commit-ID: 1SpUTJP8tPq
 2017-01-30 17:35:14 -05:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Neil Deakin
7c4d9770b2 Bug 1321472, move the drag-scrolling behaviour into the menulist binding so that both remote <select> elements and <menulist> can share this behaviour, r=mconley 2017-01-19 10:04:20 -05:00
Neil Deakin
378cab4a19 Bug 1321472, allow drag-scrolling the select popup when the mouse is pressed on an option in the list, r=mconley 2017-01-19 10:04:11 -05:00
Neil Deakin
80cfdcf004 Bug 1311279, when the mouse is released, check if it should be retargetted at the select element in the content process, so that a click event is received, r=mconley 2017-01-19 10:03:56 -05:00
Neil Deakin
b0f77a8e72 Bug 1311279, scroll the select popup when click+drag is used, r=mconley 2016-11-17 09:56:43 -05:00
Tyler Maklebust
562973cc78 Bug 1309935 - Add ability to find within select dropdown when over 40 elements. r=jaws 
Original patch by Tyler Maklebust <tmaklebust@gmail.com> and Jared Beach <beachjar@msu.edu>

MozReview-Commit-ID: 7FW6PHIrXF4
 2017-01-17 15:40:15 -05:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Mark Banner
ac52569fff Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws 
MozReview-Commit-ID: 5NKHHb70YA6
 2017-01-09 10:12:26 +00:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Joel Maher
62614255bf backout aba885aafee0210b1f063a423b1c0b3ce28d15f7 for intermittent bug 1272834 
MozReview-Commit-ID: BTJ13wWojaI
 2016-12-14 10:59:43 -05:00
Mark Banner
dc46a8fba3 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop 
MozReview-Commit-ID: CiIsUjQzp4D
 2016-11-09 22:06:32 +00:00
beachjar
039569dbd1 Bug 430745 - Select dropdown popups will anchor on a selected element for Mac r=jaws 
Select dropdown popups now anchor on the currently selected element in a <select> dropdown for Mac instead of above/below the <select> dropdown.

MozReview-Commit-ID: JlgrZdArehq
 2016-11-07 16:19:19 -05:00
Neil Deakin
ba9f7af93f Bug 1311279, scroll the select popup when click+drag is used, r=mconley 2016-11-17 09:56:43 -05:00
Neil Deakin
17743fa12c Bug 1314647, clear active state of select on mouseup, r=mconley 2016-11-17 09:56:43 -05:00
Carsten "Tomcat" Book
4a51e35bc2 Backed out changeset deec8c2ba931 (bug 1314647) for eslint failures 2016-11-17 15:42:59 +01:00
Carsten "Tomcat" Book
7bd0ed75c9 Backed out changeset 09093d38540e (bug 1311279) 2016-11-17 15:42:38 +01:00
Neil Deakin
e51adfaed8 Bug 1311279, scroll the select popup when click+drag is used, r=mconley 2016-11-17 09:28:27 -05:00
Neil Deakin
94b5ea1a03 Bug 1314647, clear active state of select on mouseup, r=mconley 2016-11-17 09:28:26 -05:00
Sebastian Hengst
9e6ba2c570 Backed out changeset d67c6dcba478 (bug 430745) on request from jaws. r=backout 
MozReview-Commit-ID: DGzLTDimdZZ
 2016-11-14 16:25:04 +01:00
beachjar
7a98f9ee51 Bug 430745 - Select dropdown popups will anchor on a selected element for Mac r=jaws 
Select dropdown popups now anchor on the currently selected element in a <select> dropdown for Mac instead of above/below the <select> dropdown.

MozReview-Commit-ID: JlgrZdArehq
 2016-11-07 16:19:19 -05:00