corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
508,231 Commits 1 Branch 0 Tags
38662e82c89140a4917bd901b26e2817b17686f3
Commit Graph

41 Commits

Author SHA1 Message Date
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Mike de Boer
eb3dc3be32 Bug 1302470 Part 6: Properly check for a frame's visibility, do not abuse isRangeVisible() for that purpose. r=mikedeboer 
MozReview-Commit-ID: ErviFQrJR1u
 2017-04-28 19:06:35 +02:00
Mike de Boer
1045c0615c Bug 1302470 Part 5: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer 
MozReview-Commit-ID: ABfAoZ4CBjP
 2017-01-23 17:39:07 +01:00
Steve Armand
b03be0d87e Bug 1368967 - Enable the ESLint generator-star-spacing rule across mozilla-central. r=standard8 
MozReview-Commit-ID: 5do3eoCEAMR
 2017-09-04 00:49:32 -04:00
Phil Ringnalda
cf0ba65c47 Backed out 6 changesets (bug 1302470) for mochitest-chrome failures 
CLOSED TREE

Backed out changeset 3aab8b1494ef (bug 1302470)
Backed out changeset fdd40abac611 (bug 1302470)
Backed out changeset a67bc2f1b624 (bug 1302470)
Backed out changeset 160522290018 (bug 1302470)
Backed out changeset 6b948c533944 (bug 1302470)
Backed out changeset 399011313b3c (bug 1302470)

MozReview-Commit-ID: 2B3uMAkzNGv
 2017-08-31 20:04:24 -07:00
Mike de Boer
da063d20dc Bug 1302470 Part 6: Properly check for a frame's visibility, do not abuse isRangeVisible() for that purpose. r=mikedeboer 
MozReview-Commit-ID: ErviFQrJR1u
 2017-04-28 19:06:35 +02:00
Mike de Boer
7eaf588b6f Bug 1302470 Part 5: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer 
MozReview-Commit-ID: ABfAoZ4CBjP
 2017-01-23 17:39:07 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Phil Ringnalda
c728e05216 Backed out 7 changesets (bug 1302470) for mochitest-chrome failures 
CLOSED TREE

Backed out changeset de9f42b512c8 (bug 1302470)
Backed out changeset 2394e63f50ff (bug 1302470)
Backed out changeset 3542d7bacbdc (bug 1302470)
Backed out changeset 22793139a866 (bug 1302470)
Backed out changeset cc6ff95187d0 (bug 1302470)
Backed out changeset 033fce5ecd39 (bug 1302470)
Backed out changeset 0bb3e70e5f46 (bug 1302470)

MozReview-Commit-ID: 5DmpbQp335X
 2017-04-28 20:12:06 -07:00
Mike de Boer
3e16704ab1 Bug 1302470 Part 7: Properly check for a frame's visibility, do not abuse isRangeVisible() for that purpose. r=mikedeboer 
MozReview-Commit-ID: ErviFQrJR1u
 2017-04-28 19:06:35 +02:00
Mike de Boer
89f8aced12 Bug 1302470 Part 6: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer 
MozReview-Commit-ID: ABfAoZ4CBjP
 2017-01-23 17:39:07 +01:00
Sebastian Hengst
768235dfb0 Backed out changeset 726e98cd071e (bug 1302470) 2017-04-21 19:09:11 +02:00
Mike de Boer
1407e46ad9 Bug 1302470 Part 6: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer 
MozReview-Commit-ID: ABfAoZ4CBjP
 2017-01-23 17:39:07 +01:00
Carsten "Tomcat" Book
392b2aed0f Backed out changeset eb2930fc7c59 (bug 1302470) 2017-04-21 17:10:35 +02:00
Mike de Boer
da277e5707 Bug 1302470 Part 6: Connect up FinderHighlighter.jsm with the new isRangeVisible function. r=mikedeboer 
MozReview-Commit-ID: ABfAoZ4CBjP
 2017-01-23 17:39:07 +01:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Mike de Boer
f92ef6bfc5 Bug 1316514 - if we attempt to make the 'Highlight All' toggle a global setting, then we need to set the pref when toggled. r=Gijs 
What you see first is the removal of the line `this._highlightAll = aHighlight;`, which is repeated in the `_setHighlightAll` method.
This line was put here initially to make the test_findbar_events.xul test pass but in fact makes it so that the pref is never set in `_setHighlightAll`!
In other words, we never actually persisted the 'Highlight All' state properly.
Reading further: the `_dispatchFindEvent` attaches some findbar state flags to the event details, including the value of `_highlightAll`.
Even though none of our consumers use it currently (haven't checked if TB does, though), you can cancel further execution of highlighting all ranges.
Since the `_setHighlightAll` doesn't do that kind of processing, but merely makes sure the internal state is up to snuff, is persisted properly and the buttons are updated, I moved it up to be invoked before dispatching the event.

MozReview-Commit-ID: 4BBy4FR1r5c
 2017-01-13 17:27:18 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Wes Kocher
e1b9233077 Backed out 5 changesets (bug 1302470) for causing bug 1323200 a=backout 
Backed out changeset 005adbf78cd2 (bug 1302470)
Backed out changeset 113f7b13475c (bug 1302470)
Backed out changeset 3d2569996ebc (bug 1302470)
Backed out changeset b92b78271941 (bug 1302470)
Backed out changeset 5b92678afff8 (bug 1302470)


MozReview-Commit-ID: FgeA5OQV8WP
 2016-12-16 16:45:09 -08:00
Mark Banner
dc46a8fba3 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop 
MozReview-Commit-ID: CiIsUjQzp4D
 2016-11-09 22:06:32 +00:00
Mike de Boer
674f371e53 Bug 1302470 Part 3: Call the new isRangeVisible function to determine whether or not to draw a highlight rect. r=mikedeboer 
MozReview-Commit-ID: ExO6zdjHGVO
 2016-11-10 09:03:58 -08:00
Mike de Boer
a8293a3ea3 Bug 1302470 Part 2: Use a hit-test method to determine if the rect of a range is visible on the page or not to the eye, for use in find-in-page. r=mstange,smaug 
MozReview-Commit-ID: 9P7gf0GcREv
 2016-11-09 15:09:36 -08:00
Sebastian Hengst
1efa6af3c5 Backed out changeset cc04b61c9f23 (bug 1302470) 2016-11-20 20:31:31 +01:00
Mike de Boer
4a1caa283e Bug 1302470 Part 2: Use a hit-test method to determine if the rect of a range is visible on the page or not to the eye, for use in find-in-page. r=mstange,smaug 
MozReview-Commit-ID: 9P7gf0GcREv
 2016-11-09 15:09:36 -08:00
Sebastian Hengst
e1946ef759 Backed out changeset 8243da10a171 (bug 1302470) 2016-11-17 17:49:46 +01:00
Mike de Boer
f1cdd4359c Bug 1302470 Part 2: Use a hit-test method to determine if the rect of a range is visible on the page or not to the eye, for use in find-in-page. r=mstange,smaug 
MozReview-Commit-ID: 9P7gf0GcREv
 2016-11-09 15:09:36 -08:00
Mike de Boer
5340767785 Bug 1309207 - the finder iterator doesn't find occurrences properly in links-only mode. r=jaws 
MozReview-Commit-ID: 4kdxyX9zrKl
 2016-11-02 13:38:59 +01:00
Mike de Boer
44f855f3a2 Bug 1305194 - wait a little longer when the finder iterator is requested to find a query of only one or two characters, which improves usability due to less flickering of highlighter results and performance due to avoiding the most costly nsFind operations there are on a page. r=jaws 
Single and double character find operations cause a big hit on nsFind, because
it usually yields many more occurrences than other queries. But most importantly,
it needs to keep iterating each text node much longer than other queries, because
there is much less escapes/ loop exits happening.
This also fixes the FinderIterator infinite-depth call-stack due to unresolved
promises that remain active during the lifetime of the FinderIterator. Unwinding
the call-stack properly should save us bytes from the heap.

MozReview-Commit-ID: 4K19X0yngC7
 2016-10-12 15:46:44 +02:00
Mike de Boer
941c774def Bug 1303874 - make the active window object part of the iterator params to make sure that similar iterator runs for different runs are not treated as the same, thus potentially yielding incorrect results. r=jaws 
MozReview-Commit-ID: H6gB2IMndM8
 2016-10-11 13:08:00 +02:00
Mike de Boer
a20c2bde64 Bug 1295759 - make sure selected ranges in iframes are cleared when the findbar is hidden as well. Adds a test to guard against regressions. r=jaws 
MozReview-Commit-ID: 5rudNSNK8GK
 2016-08-29 16:22:29 +02:00
Mike de Boer
7e1c629660 Bug 1294392 - consolidate the highlight and counter timers into one iterator timer. r=jaws 
This introduces a new NLP (Natural Language Processing) module with only one
method: 'levenstein'. We're using it to allow the highlighter to keep running
when the it starts the iterator with a word that's one edit distance behind the
value in the findField.

MozReview-Commit-ID: K8oeiXoiLUe
 2016-08-25 20:11:44 +02:00
Mike de Boer
c9a9a89a4c Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws 
MozReview-Commit-ID: 1j0C0BUfT8r
 2016-08-19 17:18:41 +02:00
Sebastian Hengst
850eb0c175 Backed out changeset bc160abe215b (bug 1282070) for docshell leakage in browser_visibleFindSelection.js. r=backout 2016-08-16 16:05:45 +02:00
Mike de Boer
831853c0e4 Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws 
MozReview-Commit-ID: JKzUehP4pyP
 2016-08-16 12:16:29 +02:00
Mike de Boer
858aad5164 Bug 1294644 - prevent drawing the rectangles all too often when modal highlighting is off and make sure to restore the outline of found links and the highlight color of the currentle highlighted occurrence. r=jaws 
Many thanks to Tooru Fujisawa [:arai] for helping write this patch and testing it.

MozReview-Commit-ID: BxAd3WdqUXU
 2016-08-16 11:25:56 +02:00
Mike de Boer
4292ac8e62 Bug 1290842 - reduce the amount calls to the highlighter upon the first find action and improve the behavior when modal highlighting is not enabled now that we have a FinderHighlighter class we can use. r=jaws 
MozReview-Commit-ID: K01dpqp8LSf
 2016-08-02 10:40:21 +02:00
Mike de Boer
09c6e01b6b Bug 1281421 - followup - fix ESLint error, even though the syntax was correct. r=me 
MozReview-Commit-ID: GXEEeuoqlxt
 2016-07-28 13:15:09 +02:00
Mike de Boer
d5e6f96d31 Bug 1281421 - add new test to cover the new FinderIterator module code. r=jaws 
MozReview-Commit-ID: HZHdjyqFiYq
 2016-07-28 12:34:17 +02:00
Mike de Boer
0145f8eec4 Bug 1281421 - Merge the find counter and highlighter iterators into a FinderIterator singleton. r=jaws 
MozReview-Commit-ID: 9fhOKWIkOXN
 2016-07-28 12:34:13 +02:00