Commit Graph

299 Commits

Author SHA1 Message Date
Edouard Oger
d341d6e1de Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7
2017-09-22 15:19:56 -04:00
Sebastian Hengst
46db05e661 Backed out changeset 553d26ab8ee8 (bug 1395427) 2017-09-27 17:10:26 +02:00
Edouard Oger
aefbf9f5b9 Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7
2017-09-22 15:19:56 -04:00
Jonathan Guillotte-Blouin
f44e3e4738 Bug 1372427 - enforce balanced-listeners. r=MattN
MozReview-Commit-ID: KpPZA2godKg
2017-06-16 15:12:32 -07:00
Jonathan Guillotte-Blouin
88b7a0d657 Bug 1372427 - prevent using arguments.caller. r=MattN
MozReview-Commit-ID: J6NceWWJzbP
2017-06-16 14:55:06 -07:00
Jonathan Guillotte-Blouin
9b9ea381d4 Bug 1372427 - add "no-unused-vars" rule, with laxist variation in head_satchel + satchel_common. r=MattN
MozReview-Commit-ID: 9HBxDyUF01Q
2017-06-15 16:39:50 -07:00
Jonathan Guillotte-Blouin
246e1d8e72 Bug 1372427 - enforce "comma-dangle". r=MattN
auto --fix

MozReview-Commit-ID: KKmDI0Pt43K
2017-06-14 17:46:42 -07:00
Jonathan Guillotte-Blouin
441be83e7f Bug 1372427 - add rule to not put spacing inside parens. r=MattN
auto --fix

MozReview-Commit-ID: 7jCl2Z0Q3SI
2017-06-14 17:37:09 -07:00
Jonathan Guillotte-Blouin
68432b1c69 Bug 1372427 - add rule to not put spacing inside arrays. r=MattN
auto --fix

MozReview-Commit-ID: BiEzl4OawuU
2017-06-14 17:35:30 -07:00
Jonathan Guillotte-Blouin
4fb78b27aa Bug 1372427 - enforce "var" declarations only at top-level. r=MattN
MozReview-Commit-ID: 1bzsOoyidnR
2017-06-14 17:30:32 -07:00
Jonathan Guillotte-Blouin
9076dd22f3 Bug 1372427 - force radix argument in parseInt. r=MattN
MozReview-Commit-ID: J4VoeedZpGa
2017-06-14 13:38:17 -07:00
Jonathan Guillotte-Blouin
8a8db1097e Bug 1372427 - add error to not pad blocks. r=MattN
auto --fix

MozReview-Commit-ID: 6tXXL7Ncmso
2017-06-14 13:28:01 -07:00
Jonathan Guillotte-Blouin
0b8e86ced6 Bug 1372427 - add rule to not throw litterals. r=MattN
MozReview-Commit-ID: F962Z4jhm2l
2017-06-14 12:01:50 -07:00
Jonathan Guillotte-Blouin
ddb9887bc4 Bug 1372427 - limit lines to a maximum of 100 chars. r=MattN
MozReview-Commit-ID: 3OSKaTMMBot
2017-06-13 16:48:31 -07:00
Jonathan Guillotte-Blouin
db59f9296e Bug 1372427 - add "dot-location" rule so that dots are on the same line as properties. r=MattN
MozReview-Commit-ID: A6IKfSiVXAN
2017-06-13 16:34:54 -07:00
Jonathan Guillotte-Blouin
815a325de3 Bug 1372427 - add cyclomatic-complexity limit. r=MattN
MozReview-Commit-ID: GRiJw8SBq9e
2017-06-13 15:56:31 -07:00
Jonathan Guillotte-Blouin
6e1ffff1ea Bug 1372427 - add "no-use-before-define" rule. r=MattN
MozReview-Commit-ID: BRhwhnxzlpG
2017-06-13 14:34:12 -07:00
Jonathan Guillotte-Blouin
065f07ec40 Bug 1372427 - add "block-scoped-var" rule. r=MattN.
MozReview-Commit-ID: K3Zwr0jy6U2
2017-06-13 14:23:11 -07:00
Jonathan Guillotte-Blouin
29b30a4a82 Bug 1372427 - add js-doc rule. r=MattN
MozReview-Commit-ID: YgDBHM88PW
2017-06-13 10:48:52 -07:00
Jonathan Guillotte-Blouin
4aee0d02d2 Bug 1372427 - add semi-colon rule. r=MattN
auto --fix

MozReview-Commit-ID: F9GvxcghPkt
2017-06-13 09:51:07 -07:00
Jonathan Guillotte-Blouin
10ee9a5b3d Bug 1372427 - Add indentation rules. r=MattN
MozReview-Commit-ID: 62a7RvVlcco
2017-06-12 15:45:00 -07:00
Jonathan Guillotte-Blouin
b01f8949aa Bug 1372427 - Add "curly" eslint rule to fix missing curly braces. r=MattN.
MozReview-Commit-ID: LwVEPezNiCx
2017-06-09 15:56:08 -07:00
Jonathan Guillotte-Blouin
c0c0d89bde Bug 1371554 - Use Components.aliases where not used. r=mattn.
MozReview-Commit-ID: 8uElbXeSN3J
2017-06-06 13:23:49 -07:00
Ray Lin
1f98db0895 Bug 1300996 - Part 1: Set selectedIndex of autocomplete popup when mousemove over profile item. r=adw
Currently mouseover autocomplete item would not change the selectedIndex
of popup but show grey highlight. For form autofill, we don't want
two indicators to represent the selection of keyboard and mouse
separately that might confuse user which profile preview is exactly
being shown. I added a new <field> in formautofill profile item binding
that helps autocomplete to determine whether to change selectedIndex
when mouseover.

MozReview-Commit-ID: LmW8g08V9mf
2017-04-25 16:48:52 +08:00
Matthew Noorenberghe
8d290944f2 Backed out changeset baea1f6031e8 (bug 1300996)
MozReview-Commit-ID: Cj9pE4QZfvI
2017-06-08 19:54:53 +08:00
Ray Lin
b181c02e6f Bug 1300996 - Part 1: Set selectedIndex of autocomplete popup when mousemove over profile item. r=adw
Currently mouseover autocomplete item would not change the selectedIndex
of popup but show grey highlight. For form autofill, we don't want
two indicators to represent the selection of keyboard and mouse
separately that might confuse user which profile preview is exactly
being shown. I added a new <field> in formautofill profile item binding
that helps autocomplete to determine whether to change selectedIndex
when mouseover.

MozReview-Commit-ID: LmW8g08V9mf
2017-04-25 16:48:52 +08:00
Carsten "Tomcat" Book
e5821d6818 Backed out changeset f54fca58d189 (bug 1300996) for eslint failure in own test 2017-06-07 11:46:36 +02:00
Ray Lin
bc20906730 Bug 1300996 - Part 1: Set selectedIndex of autocomplete popup when mousemove over profile item. r=adw
Currently mouseover autocomplete item would not change the selectedIndex
of popup but show grey highlight. For form autofill, we don't want
two indicators to represent the selection of keyboard and mouse
separately that might confuse user which profile preview is exactly
being shown. I added a new <field> in formautofill profile item binding
that helps autocomplete to determine whether to change selectedIndex
when mouseover.

MozReview-Commit-ID: LmW8g08V9mf
2017-04-25 16:48:52 +08:00
Florian Quèze
15feaa278a Bug 1362882 - script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop. 2017-05-12 14:55:27 +02:00
Florian Quèze
38c24463e4 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Jonathan Guillotte-Blouin
f88cb3ef45 Bug 1361220 - Remove browser.formfill.saveHttpsForms support. r=MattN
MozReview-Commit-ID: 3c1oDYnz3KC
2017-05-10 13:48:33 -07:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Mark Banner
c5921108d5 Bug 1347884 - Enable eslint cyclomatic complexity rule at existing levels. r=jaws
Enable the rule with the maximums set to avoid current failures, except for test_form_autocomplete which is very
high (82). The levels are set per major area, with existing warnings being changed to errors.

MozReview-Commit-ID: 37M6Ry0Mr1c
2017-03-16 11:04:39 +00:00
Mark Banner
703aa9e231 Bug 1341029 - Turn on the ESLint no-undef rule for all of toolkit/. r=jaws
MozReview-Commit-ID: Ed9FfkskDos
2017-02-20 11:45:58 +00:00
Mark Banner
0172a32b29 Bug 1338195 - Define a frame-script environment for eslint and use it to clear no-undef issues for known frame script globals. r=mossop
MozReview-Commit-ID: Fcin4InbLK2
2017-02-07 10:52:06 +00:00
Matthew Noorenberghe
e30e5b9646 Bug 1330111 - Test changes for opening username autocomplete. r=johannh
MozReview-Commit-ID: CJKpsRmWorm
2017-02-03 16:41:48 -08:00
Carsten "Tomcat" Book
558027ba30 Backed out changeset d71bc4a09493 (bug 1330111) 2017-02-07 14:03:10 +01:00
Matthew Noorenberghe
850a2ace6b Bug 1330111 - Test changes for opening username autocomplete. r=johannh
MozReview-Commit-ID: CJKpsRmWorm
2017-02-03 16:41:48 -08:00
Wes Kocher
b2c1cc5f1d Backed out 9 changesets (bug 1330111) for bc bustage in various tests a=backout
Backed out changeset e87c86970a29 (bug 1330111)
Backed out changeset 9e2e44a7a159 (bug 1330111)
Backed out changeset 7abc377ef809 (bug 1330111)
Backed out changeset f1e782d1c944 (bug 1330111)
Backed out changeset d94d72846952 (bug 1330111)
Backed out changeset 23180cae4a46 (bug 1330111)
Backed out changeset 09c59f5c572a (bug 1330111)
Backed out changeset e208e0b51349 (bug 1330111)
Backed out changeset 271035a2bc64 (bug 1330111)

MozReview-Commit-ID: 6mfKgu07dow
2017-02-06 17:54:14 -08:00
Matthew Noorenberghe
b0dba28343 Bug 1330111 - Test changes for opening username autocomplete. r=johannh
MozReview-Commit-ID: 2okX1Vfh5Kh
2017-02-03 16:41:48 -08:00
Matthew Noorenberghe
8e3b5ecb32 Bug 1334026 - Show the the insecure field warning on insecure password fields even if they're not marked. r=mconley
MozReview-Commit-ID: JwEYWQmexj
2017-01-30 15:53:27 -08:00
Phil Ringnalda
aa56652d4a Backed out changeset 25c931f199e8 (bug 1334026) for Android crashes @ nsFormFillController::StartSearch
CLOSED TREE
2017-01-26 21:30:50 -08:00