Commit Graph

42 Commits

Author SHA1 Message Date
Marco Bonardo
2e63b9b6bb Bug 1371677 - Delay the database connection in the history service as far as possible. r=adw
Makes initing Places services cheaper, by delaying the connection creation to the first time
it's actually needed.
Same way, delays reading the bookmark roots at the first time they are requested.
Deprecates the concept of lazy observers, since they are no more needed, we can just use addObserver.
Simplifies the startup path: always sends "places-init-complete" (both as a category and a topic) when
the connection starts and adds a "locked" database state when we can't get a working connection.
Makes PlacesCategoriesStarter register for the new category, since it's cheaper than being a bookmarks
observer.
Fixes a couple race conditions in keywords and expiration due to new startup timings.
Removes a test in test_keywords.js that is no more easily feasible, since it'd requires a pre-build
places.sqlite that should be kept up-to-date at every version.

MozReview-Commit-ID: 6ccPUZ651m0
2017-06-09 18:51:09 +02:00
Bill McCloskey
ce42826bdf Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
238bf154d5 Backed out changeset 4f6302a98ae4 (bug 1372405) 2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993 Backed out changeset 9846de3bd954 (bug 1372405) 2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bevis Tseng
e6dc9e02bc Bug 1372453 - Part 2: Name the caller of ProxyReleaseEvent. r=billm
MozReview-Commit-ID: LYhSWnZkq0i
2017-06-14 09:27:17 +08:00
Marco Bonardo
6b33830513 Bug 1359887 - Potential deadlock when forcing wal checkpoints on Places startup. r=past
Don't enforce wal checkpoints during Places startup, since that can possibly cause a deadlock that would
make some early synchronous API calls bailout. That would indeed cause unexpected intermittent failures
in tests.
Regardless, forcing checkpoints like this in modern filesystems is unlikely to add much value, since
the probabilities to lose the whole contents of the journal are very low.
Additionally we have better startup handling of invalid databases, so we should be able to recover in any case.

MozReview-Commit-ID: G7nISZkd8s2
2017-04-29 16:49:35 +02:00
Gijs Kruitbosch
d20be8849c Bug 1344282 - prep: add a makeGuid method to nsINavHistory, r=mak
MozReview-Commit-ID: JKIjtcqyTzc
2017-03-13 22:22:57 +00:00
Vedant Sareen
a85a2ad339 Bug 1330907 - Rename Telemetry::ID to Telemetry::HistogramID. r=dexter
Changed |print("enum ID : uint32_t {", file=output)| to |print("enum HistogramID : uint32_t {", file=output)| at line 53 of the file |toolkit/components/telemetry/gen-histogram-enum.py|, and then replaced all the textual occurrences of |Telemetry::ID| to |Telemetry::HistogramID| and |ID| to |HistogramID| in 43 other files.
2017-02-16 00:45:15 +05:30
Nicholas Nethercote
1f65390cc9 Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
2016-08-08 12:18:10 +10:00
Michael Layzell
b3412e432b Bug 1292224 - Remove duplicate mRefCnt member from nsNavHistoryFolderResultNode, r=adw 2016-08-05 13:51:34 -04:00
Kyle Huey
a9cf047227 Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Aidin Gharibnavaz
bb0750ec60 Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley 2016-02-10 08:23:00 +01:00
Carsten "Tomcat" Book
498dd069da Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures 2016-02-08 11:17:38 +01:00
Aidin Gharibnavaz
d9bbb0c446 Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley 2016-02-07 10:56:00 +01:00
Ehsan Akhgari
ea41d8de48 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Ehsan Akhgari
cb3c3961e2 Bug 1118413 - Mark virtual overridden functions as MOZ_OVERRIDE in places; r=mak 2015-01-24 14:51:35 -05:00
Asaf Romano
bba5e8921d Bug 1107308 - Round dateAdded and lastModified values to milliseconds precision in places cpp components. r=mak 2014-12-04 14:09:48 -08:00
Ehsan Akhgari
5847679c76 Bug 1060974 - Fix more bad implicit constructors in places; r=mak 2014-09-03 18:25:36 -04:00
Andrew McCreight
a966f427cd Bug 1038207 - Fix various classes that reimplement nsISupports. r=ehsan 2014-07-14 12:21:34 -07:00
Benoit Jacob
029e0e533d Bug 1028588 - Fix dangerous public destructors in toolkit/ - r=ehsan 2014-06-23 18:40:02 -04:00
Nicholas Nethercote
9fc605b8f3 Bug 905017 (part 1) - Minimize inclusions of JS engine headers in .h and .idl files. r=billm. 2013-08-17 15:50:18 -07:00
Joshua Cranmer
4c1f2d0784 Bug 884061 - Part 3v: Use NS_DECL_THREADSAFE_ISUPPORTS in toolkit/, r=Mossop 2013-07-18 21:24:15 -05:00
Asaf Romano
f818d0ec78 Relanding Bug 834539 - Replace getPageTitle with an async API. r=mak. sr=gavin. 2013-06-19 10:18:38 +03:00
Ryan VanderMeulen
907d25848e Backed out changeset 8416c29fecda (bug 834539) for xpcshell failures.
CLOSED TREE
2013-06-18 14:46:00 -04:00
Asaf Romano
0fa461434f Bug 834539 - Replace getPageTitle with an async API. r=mak. sr=gavin. 2013-06-18 19:24:31 +03:00
Ehsan Akhgari
5ab06de081 Bug 817477 - Remove support for global private browsing mode; r=jdm,glandium 2013-01-29 13:12:13 -05:00
Josh Matthews
e77a3bf92a Bug 723005 - Remove all checks for global privacy status in history-related code, and add them to callers when appropriate. r=mak sr=gavin 2012-02-18 01:40:10 -05:00
Ehsan Akhgari
243c878d26 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Henri Sivonen
ee70c964a0 Bug 482911 - Reimplement Netscape bookmark import using the HTML5 parser. r=mak, sr=gavin. 2012-03-23 09:15:36 +02:00
Henri Sivonen
eeb0bdb42f Back out changeset d2693e86769d (bug 482911) due to crashes on Mac xpcshell tests. r=orange. 2012-03-23 11:25:08 +02:00
Henri Sivonen
2ca517185c Bug 482911 - Reimplement Netscape bookmark import using the HTML5 parser. r=mak, sr=gavin. 2012-03-23 09:15:36 +02:00
Marco Bonardo
52fde4f398 Bug 613588 (Backend) - Load-on-demand livemarks.
r=dietrich,mano
2012-02-24 13:42:24 +01:00
Rafael Ávila de Espíndola
215195b6ee Bug 721603 - We should spin the loop after calling asyncClose in Database.cpp. r=mak. 2012-02-16 07:03:53 -05:00
Marco Bonardo
4d082c68c5 Bug 723124 - Telemetry for time needed for idle frecency update.
r=dietrich
2012-02-04 15:12:42 +01:00
Matthew Noorenberghe
033ce45158 Bug 646993 - Cap the bookmark title length to TITLE_LENGTH_MAX r=mak 2011-10-28 20:37:13 -07:00
Marco Bonardo
50a7797537 Bug 695554 - Split a Database class out of the History service. (expected fake Ts_shutdown regressions!)
r=dietrich
2011-10-27 11:11:34 +02:00
Philipp von Weitershausen
3239b7f8be Bug 676110 - Part 3b: Remove double enqueuing from PlacesEvent. r=mak 2011-08-19 10:12:11 -07:00
Michael Wu
8d598fd0bb Bug 671185 - Incorrect return of NS_ERROR_* codes in functions returning PRBool, r=mak,ehsan,taras,biesi,pike,khuey,dholbert,josh,bjacob,bsmith 2011-07-25 21:57:58 -07:00
Mitchell Field
8969bddd5d Bug 595513 - Reduce makefile recursion in toolkit. r=khuey 2011-03-08 14:58:46 +11:00