Milan Sreckovic
997470de0f
Bug 1387514: Upgrade BaseRect (derived classes) width and height direct member variable use to instead use Width()/SetWidth() and Height()/SetHeight() in image/*. r=aosmond
...
MozReview-Commit-ID: 8gyxxLziVe7
2017-08-14 08:29:56 -04:00
Andrew Osmond
db6e1e8dfa
Bug 1315554 - Part 1. Enforce the parent decoder size (ICO) for child decoders (BMP, PNG). r=tnikkel
2017-07-22 07:50:31 -04:00
Sebastian Hengst
1b9afeceb6
Backed out changeset fd310390a64a (bug 1315554) for failing GTest's ImageDecoders.LargeICOWithPNGSingleChunk on OS X opt. r=backout
2017-07-22 11:05:35 +02:00
Andrew Osmond
e5d030062e
Bug 1315554 - Part 1. Enforce the parent decoder size (ICO) for child decoders (BMP, PNG). r=tnikkel
2017-07-22 00:14:58 -04:00
Nicholas Nethercote
a58025002f
Bug 1375392 - Tweak the PROFILER_LABEL* macros. r=mstange.
...
This patch makes the following changes to the macros.
- Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside
classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was
mostly misused.
- Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is
universally available now anyway.
- Combines the first two string literal arguments of PROFILER_LABEL and
PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for
them to be separate, and it forced a '::' in the label, which isn't always
appropriate. Also, the meaning of the "name_space" argument was interpreted
in an interesting variety of ways.
- Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make
it clearer they construct RAII objects rather than just being function calls.
(I myself have screwed up the scoping because of this in the past.)
- Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so
the caller doesn't need to. This makes a *lot* more of the uses fit onto a
single line.
The patch also makes the following changes to the macro uses (beyond those
required by the changes described above).
- Fixes a bunch of labels that had gotten out of sync with the name of the
class and/or function that encloses them.
- Removes a useless PROFILER_LABEL use within a trivial scope in
EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving
any useful purpose. It also serves as extra evidence that the AUTO_ prefix is
a good idea.
- Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is
done within them, instead of at their callsites, because that's a more
standard way of doing things.
2017-06-22 17:08:53 +10:00
Andrew Osmond
9aff749657
Bug 1341624 - Include shared handle totals in memory reports for images. r=tnikkel
2017-02-22 09:30:22 -05:00
Andrew Osmond
21758b6755
Bug 1339202 - Decode images to shared surfaces for WebRender. r=tnikkel
2017-02-08 15:48:59 -05:00
Sebastian Hengst
4c2306faba
Backed out changeset 45dd83a63162 (bug 1339202) for crashing in image processing related tests, e.g. xpcshell test test_imgtools.js. r=backout
2017-02-13 22:34:54 +01:00
Andrew Osmond
c03ed5beaf
Bug 1339202 - Decode images to shared surfaces for WebRender. r=tnikkel
2017-02-08 15:48:59 -05:00
Andrew Osmond
1c44dff661
Bug 1290293 - Part 2f. Assert there is no frame on the finish decoding error path. r=tnikkel
2017-02-10 08:33:11 -05:00
Andrew McCreight
22c76b4409
Bug 1333974, part 2 - Use new API for images. r=tnikkel
...
MozReview-Commit-ID: CmjVpXAFmjx
2017-01-31 11:34:01 -08:00
Andrew Osmond
b03319232c
Bug 1258741 - Part 2. Ensure we consistently render partially decoded images. r=tnikkel
2016-09-26 14:18:37 -04:00
Andrew Osmond
f4dafe1aa1
Bug 1258741 - Part 1. Remove dead/unused image decoder aborted flag. r=tnikkel
2016-09-21 07:13:08 -04:00
Seth Fowler
ed50277add
Bug 1293472 (Part 3) - Store animated images in the surface cache as a sequence of frames, rather than each frame getting its own cache entry. r=dholbert,edwin,njn
2016-08-18 15:42:48 -07:00
Seth Fowler
4f4921678b
Bug 1291071 (Part 5) - Pass the decoder's final status explicitly to FinalizeDecoder(). r=edwin
2016-08-05 18:50:31 -07:00
Seth Fowler
7dce2e7e42
Bug 1291071 (Part 4) - Clean up Decoder::SpeedHistogram() and related code. r=edwin
2016-08-05 18:50:29 -07:00
Seth Fowler
251ed225e5
Bug 1291071 (Part 3) - Pass telemetry explicitly to FinalizeDecoder. r=edwin
2016-08-05 18:50:27 -07:00
Seth Fowler
2c64c4a4f9
Bug 1291045 (Part 3) - Handle interactions with the SurfaceCache in DecodingTask. r=dholbert,edwin
2016-08-05 18:46:13 -07:00
Seth Fowler
89ec987429
Bug 1292505 (Part 1a) - Replace Decoder::SetTargetSize() with Decoder::SetOutputSize(). r=edwin
2016-08-05 13:44:44 -07:00
Seth Fowler
b3a5b9908b
Bug 1291054 (Part 3) - Rename Decoder::GetSize() to Decoder::Size() to be consistent with the style guide. r=edwin
2016-08-02 04:10:51 -07:00
Seth Fowler
79bcb8d151
Bug 1290759 - Convert frame number check in Decoder::AllocateFrame() into an assert. r=edwin
2016-08-01 17:40:05 -07:00
Seth Fowler
cb1acecf4d
Bug 1289957 (Part 2) - Notify RasterImage about new frames in NotifyProgress() and remove OnAddedFrame(). r=edwin
2016-07-28 00:12:50 -07:00
Seth Fowler
f56d7a7e5d
Bug 1288040 (Part 10) - Determine the first frame refresh area of animated images while decoding them. r=edwin
2016-07-20 16:30:39 -07:00
Seth Fowler
e17c8af16f
Bug 1288040 (Part 9) - Determine the loop length of animated images while decoding them. r=edwin
2016-07-20 16:30:36 -07:00
Seth Fowler
06d1ffb4e1
Bug 1288040 (Part 5) - Wrap frame timeout values in a FrameTimeout type that ensures they're normalized. r=edwin
2016-07-20 16:30:28 -07:00
Seth Fowler
09f83a51f9
Bug 1287691 (Part 4) - Leave notifying decoding progress for each frame to DecodingTask. r=edwin
2016-07-20 02:30:39 -07:00
Seth Fowler
60b6148b2d
Bug 1287691 (Part 1) - Expose yielding to decoding tasks. r=edwin
2016-07-20 02:30:33 -07:00
Makoto Kato
c4a50472e0
Backed out 4 changesets (bug 1287691) due to Windows build failure
...
MozReview-Commit-ID: KgV3nU9a64F
2016-07-20 11:03:59 +09:00
Seth Fowler
1f573d3fd9
Bug 1287691 (Part 4) - Leave notifying decoding progress for each frame to DecodingTask. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
57735f70e8
Bug 1287691 (Part 1) - Expose yielding to decoding tasks. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
8ad86fa89d
Bug 1287246 (Part 1) - Expose LexerResult from the StreamingLexer API and add an explicit Yield type. r=njn
2016-07-18 01:25:37 -07:00
Seth Fowler
533b93be57
Bug 1286165 (Part 2) - Advance decoders' SourceBufferIterator directly in StreamingLexer. r=edwin,njn
2016-07-15 17:48:57 -07:00
Seth Fowler
f11ea4dcdc
Bug 1285867 (Part 7) - Clean up remaining references to decoder 'data errors' and refer to them as just 'errors'. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
925d5578a5
Bug 1285867 (Part 6) - Record Decoder telemetry outside of the loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
ec90c8ba8b
Bug 1285867 (Part 5) - Replace Decoder::mDataDone with Decoder::mReachedTerminalState. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
3b39749548
Bug 1285867 (Part 4) - Decide whether we're done decoding by checking if we've reached a terminal state. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
c2e73e9adf
Bug 1285867 (Part 3f) - Only call PostDataError() outside the loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
8fda2d9dc9
Bug 1285867 (Part 3e) - Use TerminalState to exit the Decode() loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
991df9330a
Bug 1285867 (Part 3d) - Rely on TerminalState to decide when to post errors inside the loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
4f5fbf2791
Bug 1285867 (Part 3c) - Replace the Decode() |while| loop with a |do| loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
22d5997d4b
Bug 1285867 (Part 3b) - Replace the series of |if| statements in the Decode() loop with a |switch|. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
264a9e9b14
Bug 1285867 (Part 3a) - Don't attempt to keep decoding if we're already done. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
4605af1534
Bug 1285867 (Part 2) - Don't call Decoder::PostDataError() from Decoder subclasses. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
2ba15e348c
Bug 1285867 (Part 1) - Remove Decoder's notion of decoder errors. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
24cf4ab2a0
Bug 1285865 (Part 6) - Pass a SourceBufferIterator to Decoder::DoDecode(). r=edwin
2016-07-11 12:13:13 -07:00
Seth Fowler
b0ac5667da
Bug 1285865 (Part 5) - Return a Maybe<TerminalState> from Decoder::DoDecode(). r=edwin
2016-07-11 12:13:11 -07:00
Seth Fowler
56b1768feb
Bug 1285865 (Part 4) - Rename Decoder::WriteInternal() to Decoder::DoDecode() and fix its argument types. r=edwin
2016-07-11 12:13:09 -07:00
Seth Fowler
a2cf061dc2
Bug 1285865 (Part 3) - Inline Decoder::Write() into Decoder::Decode(). r=edwin
2016-07-11 12:13:07 -07:00
Seth Fowler
9d870f7ce8
Bug 1285865 (Part 2) - Add a RAII class to record decoder telemetry. r=edwin
2016-07-11 12:13:05 -07:00
Seth Fowler
1d745e5651
Bug 1285865 (Part 1) - Remove Decoder::Write() checks that are redundant with Decoder::Decode(). r=edwin
2016-07-11 12:13:02 -07:00