corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
508,231 Commits 1 Branch 0 Tags
38662e82c89140a4917bd901b26e2817b17686f3
Commit Graph

77 Commits

Author SHA1 Message Date
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
8030db146a Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws 
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw
 2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
8f3750d0d6 Bug 1375806 - don't overwrite the current non-empty tab when viewing pocket list, r=mixedpuppy 
This moves the logic into Pocket.jsm, and first determines the right place based on modifiers etc.
using whereToOpenLink. If that returns 'current', we override with 'tab' if and only if the current
tab is non-empty (so we'll reuse about:blank or about:newtab, but not tabs with a website / history).

MozReview-Commit-ID: H64bREBn8OU
 2017-08-23 23:31:19 +01:00
Drew Willcoxon
062e2f296c Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs 
MozReview-Commit-ID: 1wANxaD3QaV
 2017-08-16 10:13:15 -07:00
Jared Wein
a080e2809f Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw 
MozReview-Commit-ID: 5pJ96un8W5t
 2017-08-08 11:56:49 -04:00
Wes Kocher
d497d08bc6 Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout 
MozReview-Commit-ID: kEMoucDCJY
 2017-08-10 15:46:38 -07:00
Jared Wein
bb3b0a581d Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw 
MozReview-Commit-ID: 5pJ96un8W5t
 2017-08-08 11:56:49 -04:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G
 2017-07-25 23:45:41 +05:30
Drew Willcoxon
1840617556 Bug 1367927 - Add a "save to pocket" item to the page action menu. r=mixedpuppy 
MozReview-Commit-ID: APmutOUh2Q6
 2017-08-01 10:17:00 -07:00
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G
 2017-07-25 23:45:41 +05:30
Jared Wein
098efc3f24 Bug 1383886 - Remove redundant element.closest() call since one call to closest() can do the work that was previously done by two calls to closest() and a property check. r=Gijs 
MozReview-Commit-ID: L6weawO4qB0
 2017-07-24 16:27:10 -04:00
Jared Wein
a1fe16741b Bug 1383882 - Don't show the Pocket library animation if the Pocket page was removed. r=Gijs 
MozReview-Commit-ID: D6xsPEUIC96
 2017-07-24 16:16:56 -04:00
Michael Kaply
7c1b81a087 Bug 1383848 - Null check library button since it's not there by default. r=jaws 
MozReview-Commit-ID: 4IRASZc5icm
 2017-07-24 13:58:43 -05:00
Jared Wein
7feb3f7139 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs 
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg
 2017-07-21 18:00:01 -04:00
Wes Kocher
05e579c0fb Backed out changeset d4b7fc921b88 (bug 1355922) for assertions in test_display_mode.html a=backout 
MozReview-Commit-ID: GQh4DRTEUJI
 2017-07-21 00:36:41 -07:00
Jared Wein
a13c276668 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs 
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg
 2017-07-20 09:59:22 -04:00
Rajesh Kathiriya
bfb3762076 Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8 
MozReview-Commit-ID: RT5QTipaOW
 2017-07-04 21:30:18 +05:30
Andrea Marchesini
a64229ff92 Bug 1369323 - Get rid of nsScriptSecurityManager::GetNoAppCodebasePrincipal, r=bholley 2017-06-02 11:05:28 +02:00
Gijs Kruitbosch
1c0b6f626b Bug 1354155 - fix pocket button's checks for whether it is the mainview in a panelmultiview, r=mikedeboer 
MozReview-Commit-ID: 6kLNAtOmCjn
 2017-05-30 16:29:45 +01:00
Honza Bambas
f3b5a77a73 backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-13 13:55:11 +02:00
Wes Kocher
7b49a483cc Backed out changeset 95ff98f1c2e5 (bug 1319111) for talos failures a=backout 
MozReview-Commit-ID: Gs09moFm5rQ
 2017-05-12 18:24:42 -07:00
Honza Bambas
b05b600614 backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-12 22:13:49 +02:00
Honza Bambas
e8227e774f Bug 1319111 - Expose URI to make security check against on LoadInfo (no LOAD_REPLACE flag). r=bz 2017-01-27 19:10:01 +01:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8 
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
 2017-03-21 14:29:43 -04:00
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
 2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
 2017-03-14 16:09:54 -07:00
Florian Quèze
49d8db6821 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Mark Banner
358fce1e31 Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop 
MozReview-Commit-ID: FTDV8BcMGeF
 2017-03-01 21:29:52 +00:00
Mark Banner
ba10e01046 Bug 1336070 - Enable eslint no-undef for browser/, apart from components/ and base/content/. r=mossop 
MozReview-Commit-ID: CJtpm8zlLxa
 2017-02-02 09:08:42 +00:00
Mark Banner
8e77745f85 Bug 1336070 - Fix no-undef issues in the pocket code. r=mixedpuppy 
MozReview-Commit-ID: F5brmleBkca
 2017-02-02 12:08:56 +00:00
Florian Quèze
c32c931bc9 Bug 1334831 - script-generated patch to use .remove() instead of .parentNode.removeChild, r=jaws. 2017-01-30 08:10:22 +01:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Pawan Sasanka
1e3e2eaebf Bug 1319849 - Remove unused browser/extensions/pocket/content/panels/img/signup_or@*x.png images, r=florian. 2017-01-12 20:36:16 +05:30
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
0c2dd4fa35 Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8 
MozReview-Commit-ID: 2MhpvzUDgtK
 2017-01-06 12:09:28 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Gijs Kruitbosch
41dd46ed97 Bug 1320039, r=kmag,wladimir 
MozReview-Commit-ID: Fsj4bG5e2gT
 2016-11-24 11:21:05 +00:00
Gijs Kruitbosch
fbf673ec96 Bug 1320057, r=kmag 
MozReview-Commit-ID: GlM44da7hYL
 2016-11-24 13:09:58 +00:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws 
MozReview-Commit-ID: 2ZvTiZDHchz
 2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws 
MozReview-Commit-ID: HBpjT2uHJaZ
 2016-11-10 14:48:04 -08:00
Mark Banner
f1870b61b8 Bug 1315615 - Fix no-unused-vars issues in the Pocket extension. r=jaws 
MozReview-Commit-ID: 4L8XCRo1PWe
 2016-11-07 08:57:40 +00:00
Michael Kaply
356dc94be4 Bug 1309027 - Adjust test weight for Pocket towards non login version. r=Gijs 2016-10-11 14:45:30 -05:00
Shane Caraveo
b2aa7c2779 Bug 1304151 add finished locales and a couple minor bug fixes, r=flod,Gijs 
MozReview-Commit-ID: eyeDj5nxXE
 2016-09-28 23:29:52 -07:00