Commit Graph

69 Commits

Author SHA1 Message Date
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Drew Willcoxon
530f991093 Bug 1387141 - Pocket button does not stay red after URL pocketed and animation has finished. r=Gijs
MozReview-Commit-ID: KQVOUJUOfrx
2017-10-05 13:03:44 -07:00
Gijs Kruitbosch
514cadc9cc Bug 1393843 - add telemetry for page action items and the context menu that enables/disables them, data-review=rweiss, r=adw,rweiss+418169
MozReview-Commit-ID: E52TGDLgjCC
2017-09-20 17:32:11 +01:00
Gijs Kruitbosch
66e3a04794 Bug 1401238 - remove pocket entries in bookmarks menu button panel and bookmarks menu, r=jaws
MozReview-Commit-ID: HPxVus6oXjS
2017-09-20 01:00:25 +01:00
Drew Willcoxon
4ee0451f04 Bug 1397501 - Page actions added to the urlbar should always come before the bookmark star. r=Gijs
MozReview-Commit-ID: 6pVlr9d0crn
2017-09-07 16:44:34 -07:00
Drew Willcoxon
882f5d3f55 Bug 1397609 - Fix a11y of bookmark star and Pocket urlbar buttons. r=Gijs
MozReview-Commit-ID: 30zJfz52uVB
2017-09-06 22:30:35 -07:00
Jared Wein
23660f4b81 Bug 1393565 - De-duplicate the JS code and CSS that sets the bookmark and pocket library animation. r=Gijs
MozReview-Commit-ID: Z1kIdrY2Um
2017-08-30 15:58:24 -04:00
Drew Willcoxon
482ff5bc2d Bug 1395743 - Pocket button should come before bookmarks star button in urlbar. r=Gijs
MozReview-Commit-ID: 2KPSv3Fy8kn
2017-09-01 14:46:52 -07:00
Drew Willcoxon
cbe1682561 Bug 1395178 - The new buttons that can be added to the toolbar don't announce themselves to screen readers as buttons. r=jaws
MozReview-Commit-ID: AvQD9Z9ySfu
2017-08-30 13:29:54 -07:00
Drew Willcoxon
b69a7ae1a8 Bug 1388835 - Hide page action urlbar buttons on about pages (about:preferences, etc.). r=Gijs
MozReview-Commit-ID: 9lid8VpPkJE
2017-08-26 12:47:33 -07:00
Gijs Kruitbosch
8f3750d0d6 Bug 1375806 - don't overwrite the current non-empty tab when viewing pocket list, r=mixedpuppy
This moves the logic into Pocket.jsm, and first determines the right place based on modifiers etc.
using whereToOpenLink. If that returns 'current', we override with 'tab' if and only if the current
tab is non-empty (so we'll reuse about:blank or about:newtab, but not tabs with a website / history).

MozReview-Commit-ID: H64bREBn8OU
2017-08-23 23:31:19 +01:00
Jared Wein
a28e15e6eb Bug 1384953 - Run the library and pocket animations outside of the navigation-toolbar to workaround z-index issues with the selected tab. r=gijs
MozReview-Commit-ID: dXVThUXdXi
2017-08-09 20:36:17 -04:00
Drew Willcoxon
ae0ba79f65 Bug 1388170 - Page Action Menu > Pocket needs to read "Save to Pocket". r=Gijs
MozReview-Commit-ID: KRK3GYion1t
2017-08-16 15:02:07 -07:00
Drew Willcoxon
062e2f296c Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
MozReview-Commit-ID: 1wANxaD3QaV
2017-08-16 10:13:15 -07:00
Dão Gottwald
fcc243e9bd Bug 1389740 - Rename urlbar-icons to page-action-buttons. r=gijs
MozReview-Commit-ID: 980Rvv8mxtU
2017-08-14 16:45:17 +02:00
Jared Wein
a080e2809f Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t
2017-08-08 11:56:49 -04:00
Wes Kocher
d497d08bc6 Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout
MozReview-Commit-ID: kEMoucDCJY
2017-08-10 15:46:38 -07:00
Jared Wein
bb3b0a581d Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t
2017-08-08 11:56:49 -04:00
Gijs Kruitbosch
f019fcf508 Bug 1383009 - fix tests, BrowserUITelemetry and pocket to deal with the changes to the navbar, r=jaws
MozReview-Commit-ID: 9dZI5AI3kvP
2017-08-08 15:09:44 +01:00
Michael Kohler
f15ab23e9f Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui
2017-08-08 12:09:14 +02:00
Jared Wein
d016c13ec8 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU
2017-08-07 12:37:34 -04:00
Sebastian Hengst
31742f9ca2 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
a220eeb86a Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe
2017-08-05 20:37:40 +02:00
Drew Willcoxon
e6ab831747 Bug 1386474 - Pocket shouldn't assume that Photon page actions are enabled. r=mixedpuppy
MozReview-Commit-ID: H4sYvICRqx4
2017-08-01 19:10:34 -07:00
Drew Willcoxon
1840617556 Bug 1367927 - Add a "save to pocket" item to the page action menu. r=mixedpuppy
MozReview-Commit-ID: APmutOUh2Q6
2017-08-01 10:17:00 -07:00
Jared Wein
7feb3f7139 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg
2017-07-21 18:00:01 -04:00
Wes Kocher
05e579c0fb Backed out changeset d4b7fc921b88 (bug 1355922) for assertions in test_display_mode.html a=backout
MozReview-Commit-ID: GQh4DRTEUJI
2017-07-21 00:36:41 -07:00
Jared Wein
a13c276668 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg
2017-07-20 09:59:22 -04:00
Gijs Kruitbosch
5cecdacc59 Bug 1354534 - add pocket item to photon library panel, r=mixedpuppy
MozReview-Commit-ID: BEgyelipo0j
2017-06-16 23:16:29 +01:00
Shane Caraveo
5b4907d7da Bug 1359851 - "Load SocialAPI providers lazily". r=mconley 2017-04-26 09:19:00 +02:00
Kris Maglione
2a27aabf16 Bug 1356828: Don't call getAddonById from the Pocket bootstrap scope. r=rhelmer
MozReview-Commit-ID: DJM1dOIA7X4
2017-04-15 16:23:54 -07:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Quèze
49d8db6821 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Mark Banner
8e77745f85 Bug 1336070 - Fix no-undef issues in the pocket code. r=mixedpuppy
MozReview-Commit-ID: F5brmleBkca
2017-02-02 12:08:56 +00:00
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Mark Banner
f1870b61b8 Bug 1315615 - Fix no-unused-vars issues in the Pocket extension. r=jaws
MozReview-Commit-ID: 4L8XCRo1PWe
2016-11-07 08:57:40 +00:00
Shane Caraveo
58e23eae37 Bug 1301442 new layout for external l10n build support, r=Gijs,glandium
MozReview-Commit-ID: GnZ91obbR75
2016-09-14 12:13:16 -07:00
Shane Caraveo
b9224974cb Bug 1289549 P5 socialapi fix path in pocket bootstrap, r=florian
MozReview-Commit-ID: 8dqHYLjj5RX
2016-08-23 15:24:07 -07:00
Katie Broida[:ktbee]
0bcb756d06 Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws 2016-08-19 07:27:00 -04:00
Mark Banner
07d2bfc6af Bug 1291641 - Make the Pocket system add-on as e10s compatible. r=mixedpuppy
Move the about: handler registration into the content process, and set the flag on the add-on.

MozReview-Commit-ID: Ken10jJH9o8
2016-08-18 13:59:59 +01:00
Wes Kocher
60df6d1b56 Backed out changeset 33fcf83eefe4 (bug 1171746) for browser_visibleFindSelection.js failures a=backout 2016-08-12 19:11:21 -07:00
Katie Broida[:ktbee]
d45a62dd73 Bug 1171746 - ensure tab specific panels close when you switch the tab r=jaws
Adds a tabspecific attribute to the edit bookmarks panel and the Pocket subview panel to signal that these popups should close when the user navigates away from the tab. It also specifies that the localized keyboard short cut for closing a  window should close the edit bookmarks panel and the tab by adding a general function to check whether a certain <key> has been pressed. Adds tests for both closing specific tabs and checking keys.

MozReview-Commit-ID: AxW5uQgDQQB
2016-08-11 16:51:45 -04:00
Sumit Tiwari
4edded08d9 Bug 1290698 - Replace Iterator() with Object.{values, entries}; r=mossop
MozReview-Commit-ID: DEoVeqEZWpd
2016-08-07 21:58:24 -04:00
Shane Caraveo
921e84e760 Bug 1263599 fix missing menu items in pocket, r=Gijs 2016-04-25 13:24:17 -07:00