* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
the binding is already gone.
* Generalize things into `hideAllViewsExcept(thisOne)`:
- Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
in there too,
- For Photon panels, do all the 'current' attribute setting in there. To show
a panel during transition, I introduced the 'in-transition' attribute.
* I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
that confuses some,
* Move the temporary panel handling, which contains an ephemeral panelmultiview
instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
* Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
* Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
specific transition, _if_ that's passed in as an argument. This resolves any
potential raciness that might occur when `showSubView()` is called again mid-transition.
* Skip the UITour element visibility check when it's inside a panelview, because
too many things need to happen and that check is too simple to be useful in
that case.
MozReview-Commit-ID: 5HpJKs1Ny5j
This patch
- supports Screenshots page action with UITour
- adds https://screenshots.firefox.com into the uitour permission list for the bug 1393668
MozReview-Commit-ID: K4v0LU2WSyl
This patch
- supports Screenshots page action with UITour
- adds https://screenshots.firefox.com into the uitour permission list for the bug 1393668
MozReview-Commit-ID: K4v0LU2WSyl
This commit makes sure checking PanelUI.panel state is "closed" after the popuphidden event so as to avoid the intermittent fialure because of the too early checking.
MozReview-Commit-ID: LinQbytw0lC
This commit
- adds 2 utility functions to the uitour's head.js
- adds the browser_UITour4.js
- moves the tests in the browser_showMenu_controlCenter.js into the newly added the browser_showMenu.js
- deletes the browser_showMenu_urlbar.js because it's test has been modified and moved into the browser_showMenu.js
- adds one test case for the page action panel in the browser_showMenu.js
- updates the browser_UITour_availableTargets.js test because we have more targets right now.
MozReview-Commit-ID: CydEAkqAl3V
This commit
- makes UITour support showMenu, showInfo, showHighlight on the Page Action Panel
- makes UITour support showInfo, showHighlight on the Page Action buttons and on the urlbar's bookmark #star-button button btw
- fixes Bug 1382700 - "UITour lacks the `hideMenu` api support for the single search bar (urlbar) dropdown menu" together
- fixes Bug 1386201 - "UITour wouldn't close the appMenu if running the tracking-protection's ui tour" together
MozReview-Commit-ID: Fou1sD4gAs4
