Commit Graph

1360 Commits

Author SHA1 Message Date
Marco Bonardo
dcbda9bca0 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Sebastian Hengst
7a15678a21 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 2017-10-17 00:55:53 +02:00
Marco Bonardo
6652796654 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Nihanth Subramanya
f125e08aa2 Bug 1389094 - Increase height of sidebar search bar and tree items in touch mode. r=dao
MozReview-Commit-ID: HxT3eNHImyz
2017-10-08 22:06:30 +05:30
Peter Van der Beken
a8401db6ec Bug 1383059 - Remove instanceof for supplemental interfaces. Part 1: add Window.isChromeWindow and switch |instanceof [nsIDOM]ChromeWindow| to use it instead. r=bz. 2017-10-06 13:47:27 +02:00
Marco Bonardo
7af44bf697 Bug 1405687 - Remove some deprecated code from Places related code. r=standard8
MozReview-Commit-ID: 411z07otlfN
2017-10-04 16:33:46 +02:00
Mark Banner
a37a0a7508 Bug 1392533 - Make the places tree view directly communicate batch notifications to the results. r=mak
MozReview-Commit-ID: HpN0v0jSwdK
2017-09-27 15:26:35 +01:00
Mark Banner
4ebd99058d Bug 1402059 - Don't import editBookmarkOverlay.js in places.xul on Mac because it is imported elsewhere. r=florian
MozReview-Commit-ID: 5e32dMnLdik
2017-09-21 19:35:04 +01:00
Mark Banner
b4848d29a8 Bug 1400846 - Fix ordering of bookmarks with Async Transactions when dropping into different folders. r=mak
MozReview-Commit-ID: GjnehR5PumZ
2017-09-19 06:54:16 +01:00
Jared Wein
d0e54027eb Bug 1400975 - Add specific placeholders for the sidebar search boxes. r=adw
MozReview-Commit-ID: KtIFalMLw0B
2017-09-19 17:02:07 -04:00
Mark Banner
69f202466e Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak
MozReview-Commit-ID: 7fGS6jFNVPl
2017-09-19 20:47:26 +01:00
Tawny Hoover
621b5e9802 Bug 260611 - Introduce pref browser.bookmarks.openInTabClosesMenu to optionally leave menu open for single bookmark menuitem clicks that open in new tab. r=mak
MozReview-Commit-ID: HreM02pdzWP
2017-09-11 12:12:21 -04:00
Michael Layzell
151bdf2f69 Bug 1398471 - Read data from DataTransfer before yielding, r=gijs
Previously the code looped and yielded between each loop. This caused the
DataTransfer to be cleared before the read completed.

This splits the loop into 2 sections such that we read all important data from
the DataTransfer before it is cleared.
2017-09-13 11:45:48 -04:00
Marco Bonardo
f5fe23e92e Bug 1398019 - Favicons missing in Bookmarks toolbar on startup. r=past
This is due to the fact now we set the icons only when the nodes visibility is updated.
The patch always updates nodes visibility when we rebuild the toolbar.
updateChevron() is being renamed accordingly and acts regardless of chevron.collapsed.

MozReview-Commit-ID: Cz1U710J42M
2017-09-08 11:43:08 +02:00
Mark Banner
d8d6ef9810 Bug 1397387 - Move async actions out of the opening/closing cycles of the bookmarks dialog to ensure they finish. r=mak
MozReview-Commit-ID: 9H5hPfTNv0S
2017-09-06 21:53:08 +01:00
Marco Bonardo
5ed042500e Bug 1392081 - Mochitest browser test for bookmarks toolbar overflow. r=Gijs
MozReview-Commit-ID: DwDZl2AELXC
2017-08-28 14:43:59 +02:00
Marco Bonardo
8479d70360 Bug 1392081 - Only build a subset of the buttons that may become visible on the bookmarks toolbar. r=Gijs
MozReview-Commit-ID: GOlQzUKw2go
2017-08-25 17:14:31 +02:00
Marco Bonardo
04be1e5b4f Bug 1392081 - Set the image attribute on bookmarks toolbar buttons only when they are visible. r=Gijs
MozReview-Commit-ID: HIalcxcCBsv
2017-08-25 15:31:06 +02:00
Marco Bonardo
aa09f9812a Bug 1392081 - Use a document fragment to populate toolbar and menu Places views. r=Gijs
MozReview-Commit-ID: 1Q4U3xXfF4Y
2017-08-25 15:20:00 +02:00
Mark Banner
5401fe8673 Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening. r=mak
MozReview-Commit-ID: JhETMnmxNOD
2017-09-05 17:15:58 +01:00
Sebastian Hengst
3ba9799497 Backed out changeset 2b76c3b079d9 (bug 1392081) for failing browser/components/places/tests/browser/browser_toolbar_overflow.js. r=backout 2017-09-05 23:12:13 +02:00
Sebastian Hengst
ff4d94ab09 Backed out changeset ecd61b92f9b3 (bug 1392081) 2017-09-05 23:11:25 +02:00
Sebastian Hengst
c56b52bcef Backed out changeset 8998e0bed6ff (bug 1392081) 2017-09-05 23:11:20 +02:00
Sebastian Hengst
5042f49c45 Backed out changeset 882a40327e5a (bug 1392081) 2017-09-05 23:11:14 +02:00
Marco Bonardo
4d15ff5861 Bug 1392081 - Mochitest browser test for bookmarks toolbar overflow. r=Gijs
MozReview-Commit-ID: DwDZl2AELXC
2017-08-28 14:43:59 +02:00
Marco Bonardo
8bb782dfeb Bug 1392081 - Only build a subset of the buttons that may become visible on the bookmarks toolbar. r=Gijs
MozReview-Commit-ID: GOlQzUKw2go
2017-08-25 17:14:31 +02:00
Marco Bonardo
3a5abde62b Bug 1392081 - Set the image attribute on bookmarks toolbar buttons only when they are visible. r=Gijs
MozReview-Commit-ID: HIalcxcCBsv
2017-08-25 15:31:06 +02:00
Marco Bonardo
34a37131ae Bug 1392081 - Use a document fragment to populate toolbar and menu Places views. r=Gijs
MozReview-Commit-ID: 1Q4U3xXfF4Y
2017-08-25 15:20:00 +02:00
Mark Banner
c81361a63b Bug 1391393 - Cancelling the bookmarks properties dialog shouldn't undo when no changes have been made. r=mak
MozReview-Commit-ID: 7supBHcrpdu
2017-08-24 12:51:38 +01:00
Mark Banner
4cd4cb5dc8 Bug 1391166 - Fix the order of bookmarks via drag and drop when moving a bookmark down in the list. r=mak
MozReview-Commit-ID: 7Adz2Et0NQn
2017-08-23 12:24:53 +01:00
Mark Banner
eedb2f4c4e Bug 1392189 - Fix deleting bookmark tags from the Library view with Places Transactions enabled. r=mak
MozReview-Commit-ID: unNGjPpTX6
2017-08-23 13:40:44 +01:00
Mark Banner
aff3b1f389 Bug 885246 - Remove usage of the sync history.getPageTitle API from BookmarkProperties.js. r=adw
MozReview-Commit-ID: KXhWKebkdvz
2017-08-08 19:46:28 +01:00
Mark Banner
012537b0a6 Bug 885246 - Delay enabling the accept button on the bookmarks properties dialog until after init is complete. r=adw
The initialisation can sometimes take a long time. To avoid data gathering being incomplete, we disable the accept button
until it has completed.

MozReview-Commit-ID: 3gnROdZkYae
2017-08-08 14:01:57 +01:00
Nihanth Subramanya
f9ef60d29b Bug 1377003 - [Photon] Update sidebar tree styling on Linux. r=dao
MozReview-Commit-ID: 4ZR3bdN3qFX
2017-07-18 19:06:10 +05:30
Gijs Kruitbosch
d6670b90dc Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer
MozReview-Commit-ID: VQUuQHyCXi
2017-08-10 23:05:33 +01:00
Gijs Kruitbosch
279127e720 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz
2017-08-10 23:04:54 +01:00
Sebastian Hengst
d476fe4639 Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout a=merge
MozReview-Commit-ID: AHOsaTvCWms
2017-08-10 20:02:44 +02:00
Sebastian Hengst
c300aba51a Backed out changeset e4d1389a96ca (bug 1377967) because it blocks the backout of bug 1388753. r=backout
MozReview-Commit-ID: JMozgGI7pWY
2017-08-10 20:01:44 +02:00
Gijs Kruitbosch
393f93e754 Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer
MozReview-Commit-ID: VQUuQHyCXi
2017-08-09 21:04:27 +01:00
Gijs Kruitbosch
046814d043 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz
2017-08-09 18:02:36 +01:00
Mark Banner
f7cbabf467 Bug 1385733 - Improve the performance of async transactions when bookmarking all tabs. r=adw
Optimise adding a folder with child bookmarks for transactions by allowing PlacesTransactions.NewFolder to take children details and use insertTree rather than needing separate NewFolder and then multiple NewBookmark transactions.

MozReview-Commit-ID: 6s9j0pbsiUB
2017-08-03 18:32:42 +01:00
Gijs Kruitbosch
a626facc1f Bug 1385083 - history panel should actually list history, r=mikedeboer
MozReview-Commit-ID: G98QMcmASv0
2017-08-07 15:24:49 +01:00
Masatoshi Kimura
0af76969af Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC
2017-08-04 17:49:22 +09:00
Sebastian Hengst
bf0a314799 merge mozilla-central to autoland. r=merge a=merge 2017-08-05 11:59:12 +02:00
Sebastian Hengst
8c96c22f75 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 9IxbB2vCH4S
2017-08-05 11:55:25 +02:00
Dão Gottwald
4507460c0a Bug 1387084 - Use instant scroll behavior when doing pixel scrolling. r=Gijs
Touchmove and wheel events are sent frequently enough that smooth scroll behavior
prevents the expected pixel distance from being reached before the next event.

Also replace aSmoothScroll parameters with aInstant to better reflect how this
works: its purpose is to force instant scrolling, whereas omitting it falls back
to "auto" (which may mean instant or smooth depending on different factors).

The ensureElementIsVisible call from browser-customization.js can go away as
customize mode doesn't add padding around the window anymore.

Finally, remove the unused scrollPosition and scrollPaddingRect properties.

MozReview-Commit-ID: 3Ac7g6zZ0hW
2017-08-05 10:12:38 +02:00
Sam Foster
05040037c0 Bug 1352075 - Implement new animation for opening/closing the arrow panels. r=dao,mossop
* Use new panel animation when opening arrow-panels (including bookmarks menu) to fade in and drop into position
* Linux/GTK is (still) excluded
* New animation is non-directional (i.e. LTR vs. RTL)

This was landed then backed out due to test failures. New since last review:

* Make opacity & transform transition durations equal - ensuring popup is not still moving when popupshown is fired
* Fix missing comma in transition-duration values
* Add animating attribute to the arrowpanel binding to disable pointer-events during the opening transition (via :jaws)
* Wait for popupshown rather than transitionend in bookmark reparenting test
* Fix specificity of CSS rules for panels/bookmarks-menu on edges other than the top (via :jaws)

MozReview-Commit-ID: DTnvyMryf5Y
2017-07-27 11:07:23 -07:00
Paolo Amadini
d1e1b518d1 Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB
2017-08-04 14:48:53 +01:00
Marco Bonardo
2703fb553f Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8
MozReview-Commit-ID: 2pSbYtPGtYx
2017-08-03 12:16:36 +02:00