Awaiting the resolution of SessionStore.promiseInitialized as the first step in each API method that needs to interact with SessionStore.
As I needed to await a promise, took the opportunity to migrate the entire file to async/await.
MozReview-Commit-ID: 3ovavDHimhj
BookmarkTreeNodes without children do not contain a children property, but they should actually
contain a children property which is an empty array. This is what Chrome does as well.
This patch fixes that, and includes a test for a case of getChildren that was previously
untested, which I noticed when working on this code.
MozReview-Commit-ID: CjUwExma760
We know that using multiple SVGs in a single file with :not(:target)
is slower than splitting that file up into several files (see bug 1358998).
This patch attempts to fix an issue where the identity icon will
briefly flicker when hovered the first time by splitting the SVG file up.
MozReview-Commit-ID: 2FJeBvKxKmn
I want to add more tests, based on tabId.
Adding more positional arguments makes the code less readable,
so I moved the check for windowId to a separate method.
MozReview-Commit-ID: 2aTtMftoCZX
Make the onboarding being opt-in or opt-out depending on the default value of the
browser.urlbar.sugges.searches pref.
In both cases respect userMadeSearchSuggestionChoice though, so we won't further nag users that
made a choice already.
MozReview-Commit-ID: D4rRMRbdMrW
Make the onboarding being opt-in or opt-out depending on the default value of the
browser.urlbar.sugges.searches pref.
In both cases respect userMadeSearchSuggestionChoice though, so we won't further nag users that
made a choice already.
MozReview-Commit-ID: D4rRMRbdMrW
When you create a <key> element, which is what the commands API
does under the hood to allow keyboard shortcuts, the event type
that the handler listens to defaults to keypress. For printable
characters, the keyCode property of a keypress event is 0,
causing keycode bindings for these printable characters to not
work. We could use key for these properties, but the shift key
interacts with the key property in ways that make it simpler to
simply fix the keycode usage for our purposes.
MozReview-Commit-ID: HdWdN7cMfuq
Popups with remote browsers currently do not render correctly on any platform.
Since support for composited popups is marginal, at best, at the moment, we
only want to enable the features we need for these popups when they actually
contain remote content.
This bug adds an initial stopgap implementation, primarily for testing
purposes, that force enables compositing for remote popups, despite the UI
quirks it causes.
MozReview-Commit-ID: 2I6IJyIEdUd
In order to rewrite the Gecko Profiler add-on as a WebExtension,
we need an API for the profiler which allows us to control the
nsIProfiler, and symbolicate the stacks that it provides. This
is the implementation of the simpler parts of that API.
TODO:
- Support profiling of remote targets through a new devtools
API.
- Support the dump_syms breakpad code which was asm.js in the
old extension by directly calling into native code.
- Figure out a faster way to send the large volume of data from
getSymbols all the way from our extension down to the content
process and then into the page's context.
MozReview-Commit-ID: JzDbV4l2eXd
