corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
508,231 Commits 1 Branch 0 Tags
38662e82c89140a4917bd901b26e2817b17686f3
Commit Graph

142 Commits

Author SHA1 Message Date
Erica Wright
a25284c228 Bug 1407754 - exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar. r=jaws 
MozReview-Commit-ID: C7uvVVWoIeB
 2017-10-13 09:27:48 -04:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Erica Wright
2c973487b6 Bug 1407435 - After animating out from the toolbar, the widget no longer remains invisible. r=jaws 
MozReview-Commit-ID: 5WmcIFWqBYi
 2017-10-11 15:12:21 -04:00
Erica Wright
495e08000d Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs 
MozReview-Commit-ID: 5PxydbSfhpz
 2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
a70af3db06 Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh 
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.

There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.

MozReview-Commit-ID: 7rajS71FoQR
 2017-10-05 15:17:12 +01:00
Jared Wein
9d371eb04e Bug 1403382 - Dragging the back button out of the toolbar in customize mode shouldn't affect the toolbar height. r=Gijs 
MozReview-Commit-ID: JOsb2y2pzqz
 2017-10-02 23:30:29 -04:00
Gijs Kruitbosch
5acc1e4c34 Bug 1402929 - try to make overflow panel in customize mode easier to understand, r=mikedeboer 
This moves the explanatory text from a pseudoelement to a real element,
and keeps only the image in a pseudoelement. It then uses a transitioned
opacity to fade that image in and out.

Because we need to fade this based on dragging items over the panel when
it's empty, it adds/removes a 'draggingover' attribute to handle the fade.

To cope with the extra element in the drag/drop container in customize mode,
this also makes the following changes:
- bail out of _onDragStart if there's no actual selected item.
- pick the fixed list in the panelHolder more reliably
- add a max-width to avoid the description making the panel wider

MozReview-Commit-ID: 9PEJSoJJ0Rp
 2017-09-29 17:55:50 +01:00
Maya Messinger
f63e9fdbe4 Bug 1396953 - fix flexible space widget disappearing when adding to toolbar r=Gijs 
MozReview-Commit-ID: BuYzvBX439p
 2017-09-30 18:42:24 -04:00
Gijs Kruitbosch
21beddb96d Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer 
MozReview-Commit-ID: AqBwn9ovTjT
 2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
bec818f3cb Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws 
MozReview-Commit-ID: 4GxPEm119Yc
 2017-09-27 22:37:19 +01:00
Erica Wright
c684d54fd9 Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs 
MozReview-Commit-ID: 5sQPsxVaVYz
 2017-09-21 18:15:02 -04:00
Mike de Boer
11c77ce47e Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs 
MozReview-Commit-ID: IffDnXEqooR
 2017-09-20 14:37:53 +02:00
Mike de Boer
3f03abccde Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs 
MozReview-Commit-ID: 44Q9NbKEJeC
 2017-09-20 14:25:58 +02:00
Gijs Kruitbosch
8c19bfbb62 Bug 1399935 - use horizontal panel for downloads checkbox panel at all times, r=mak 
Rather than using left-hand-side at all times (which can go over the edge of the window
in some cases) this uses left or right-hand-side panels, always opening towards the
center of the window.

MozReview-Commit-ID: EvjDmKR1G5A
 2017-09-17 23:31:06 +01:00
Gijs Kruitbosch
abea81ee4d Bug 1399486 - show downloads auto hide panel after changing the pref instead of before, r=mak 
Note that we will no longer show the panel if you use the context menu to move the item in one
window and have customize mode open in the other. I don't think that edgecase matters.

MozReview-Commit-ID: 3dzGr3cs2oQ
 2017-09-17 18:09:35 +01:00
Johann Hofmann
28991ef174 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11 
MozReview-Commit-ID: IWxdOeRwDeu
 2017-09-10 20:38:19 +02:00
Gijs Kruitbosch
6d7a67d2e5 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak 
MozReview-Commit-ID: 9xN3N4aLwfv
 2017-09-11 18:54:48 +01:00
Jared Wein
6a7b8fa8ba Bug 1387313 - Allow dragging non-removable items (url bar, back/forward buttons) within their toolbar. r=Gijs 
MozReview-Commit-ID: 1EQxMcLJn9J
 2017-08-21 14:20:40 -04:00
Gijs Kruitbosch
538e9a3cf2 Bug 1390260 - make customize mode work in popup windows, r=mkaply 
MozReview-Commit-ID: 7lokGRuqNHv
 2017-08-15 12:02:11 +01:00
Sebastian Hengst
d645e3f8ed Backed out changeset fb0d8aeff611 (bug 1390260) for failing mochitest browser_bug422590.js. r=backout 2017-08-15 17:13:15 +02:00
Gijs Kruitbosch
f5e1db7d2e Bug 1390260 - make customize mode work in popup windows, r=mkaply 
MozReview-Commit-ID: 7lokGRuqNHv
 2017-08-15 12:02:11 +01:00
Gijs Kruitbosch
eea295f174 Bug 1388990 - avoid breaking the broadcast/listener relationships of the back/fwd buttons when customizing, r=dao 
MozReview-Commit-ID: EsH3lv8QXfJ
 2017-08-12 11:56:22 +01:00
Gijs Kruitbosch
01f7270ba2 Bug 1381556 - adjust panel widths to accommodate longer/wider content, r=mikedeboer 
MozReview-Commit-ID: 6bOoRIfttEy
 2017-08-09 14:04:21 +01:00
Michael Kohler
f15ab23e9f Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao 
MozReview-Commit-ID: 8w1vfF2yRui
 2017-08-08 12:09:14 +02:00
Jared Wein
d016c13ec8 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs 
MozReview-Commit-ID: 40TP43EKPCU
 2017-08-07 12:37:34 -04:00
Gijs Kruitbosch
2d0c23d1fb Bug 1387182 - fix border (empty space) compensation when dragging items in customize mode in RTL, r=jaws 
MozReview-Commit-ID: AblsJGmu5zm
 2017-08-07 12:14:19 +01:00
Sebastian Hengst
31742f9ca2 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
a220eeb86a Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao 
MozReview-Commit-ID: CoHv9mKpAe
 2017-08-05 20:37:40 +02:00
Dão Gottwald
421fc16fa5 Bug 1387602 - Update customize mode favicon. r=Gijs 
MozReview-Commit-ID: 7gin0zuJTN0
 2017-08-04 23:00:00 +02:00
Gijs Kruitbosch
4f5a9c34e6 Bug 1354117 - remove old panel code from customize mode and update related CSS, r=jaws 
MozReview-Commit-ID: IwKUWMTagCK
 2017-08-02 11:51:58 +01:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G
 2017-07-25 23:45:41 +05:30
Jared Wein
dc5a2c6671 Bug 1383689 - Remove uninterruptible reflow at setToolbarButtonHeightProperty@resource://gre/modules/BrowserUtils.jsm. r=Gijs 
MozReview-Commit-ID: 9WoXQ1nMWTZ
 2017-08-01 15:33:01 -04:00
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G
 2017-07-25 23:45:41 +05:30
Jared Wein
6b1f4aab47 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster 
MozReview-Commit-ID: ERE1FnTuIWF
 2017-07-20 12:31:06 -04:00
Dão Gottwald
1abbce4ae7 Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh 
MozReview-Commit-ID: 72S5zENy1gX
 2017-07-21 14:11:15 +02:00
Wes Kocher
a5e872bb1a Backed out changeset 320f9642bcef (bug 1381991) because it blocks backing out 1355922 a=backout 
MozReview-Commit-ID: 7gM0DJkbVwW
 2017-07-21 00:36:04 -07:00
Jared Wein
12d1295b43 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster 
MozReview-Commit-ID: ERE1FnTuIWF
 2017-07-20 12:31:06 -04:00
Jared Wein
9fa4afa5b6 Bug 1380815 - Fade overflow menu icon to grey after item is pinned. r=sfoster 
MozReview-Commit-ID: 2LQrWDxrTny
 2017-07-20 10:53:45 -04:00
Gijs Kruitbosch
6b5c96002a Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop 
MozReview-Commit-ID: 4k4VdBa4HCt
 2017-07-11 13:13:35 -07:00
Wes Kocher
a8931c7cc1 Backed out changeset 051284a3564e (bug 1366813) for apparently causing autophone tests to frequently fail a=backout 
MozReview-Commit-ID: 9GUFY9VAGW3
 2017-07-11 12:39:26 -07:00
Gijs Kruitbosch
15d7638b8e Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop 
MozReview-Commit-ID: 4k4VdBa4HCt
 2017-07-10 23:34:12 +01:00
Gijs Kruitbosch
283b2ca2ba Bug 1378427 - move context menus around, fix flickering in dynamic portion of the overflow menu for photon, r=jaws 
Apparently the hover state of the combined buttons does not interact well with the menus unless they
share the same containing popup/panel. We broke that condition in bug 1354078. The expedient thing
is to simply move the popup back, and move it back and forth if/when the photon pref is flipped.
When removing the pref, we can simplify this by always putting the menu in the overflow panel.

I also noticed that we use the toolbar context menu in the dynamic portion of the overflow panel.
This has the same problem, and to fix it I switched us to using the same (panel) context menu in
the photon case. Doing this in the non-photon case won't help because the context menu will be in
a separate panel (namely the old hamburger panel) entirely.

MozReview-Commit-ID: 4neHMukTzHA
 2017-07-07 15:54:13 +01:00
Carsten "Tomcat" Book
6ef901728e merge mozilla-inbound to mozilla-central a=merge 2017-07-04 10:48:33 +02:00
Frederik Braun
96b2642639 Bug 1351608 - Disable warnings for existing violations to no-unsanitize rule r=Standard8. 
MozReview-Commit-ID: 7cTNL5jMtRw
 2017-07-03 20:07:02 +01:00
Jared Wein
99807c87a3 Bug 1375152 - Implement animation for pinning items to the overflow menu. r=dao 
This animation can be disabled if the toolkit.cosmeticAnimations.enabled pref is set to false.

MozReview-Commit-ID: DtsrI8YflYn
 2017-06-28 15:32:34 -07:00
Johann Hofmann
f0cfcae173 Bug 1350210 - Part 1 - Add UI density settings to customize mode. r=jaws 
MozReview-Commit-ID: C0g6aFPW2pX
 2017-06-27 18:50:34 +02:00
Gijs Kruitbosch
ee955804b1 Bug 1354123 - remove customize mode transition, r=jaws 
MozReview-Commit-ID: 7j9HWxci7oB
 2017-06-28 13:17:46 +01:00
Gijs Kruitbosch
3d4e2037bc Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws 
MozReview-Commit-ID: GhQoSgPXL9q
 2017-06-28 16:55:44 +01:00
Carsten "Tomcat" Book
c36c001ff1 Backed out changeset cbf0368eea83 (bug 1373016) for unused whitelist entry: chrome://browser/skin/customizableui/customize-illustration-rtl@2x.png - 2017-06-29 16:21:39 +02:00