corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
508,231 Commits 1 Branch 0 Tags
38662e82c89140a4917bd901b26e2817b17686f3
Commit Graph

170 Commits

Author SHA1 Message Date
Gijs Kruitbosch
6ea9acbc72 Bug 1354086 - switch overflow panel to using a photonpanelmultiview, allowing webextension views to specify their own size, r=mikedeboer 
MozReview-Commit-ID: 1uHEKXsO8vh
 2017-07-19 21:23:46 +01:00
Gijs Kruitbosch
6b5c96002a Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop 
MozReview-Commit-ID: 4k4VdBa4HCt
 2017-07-11 13:13:35 -07:00
Wes Kocher
a8931c7cc1 Backed out changeset 051284a3564e (bug 1366813) for apparently causing autophone tests to frequently fail a=backout 
MozReview-Commit-ID: 9GUFY9VAGW3
 2017-07-11 12:39:26 -07:00
Gijs Kruitbosch
15d7638b8e Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop 
MozReview-Commit-ID: 4k4VdBa4HCt
 2017-07-10 23:34:12 +01:00
Gijs Kruitbosch
283b2ca2ba Bug 1378427 - move context menus around, fix flickering in dynamic portion of the overflow menu for photon, r=jaws 
Apparently the hover state of the combined buttons does not interact well with the menus unless they
share the same containing popup/panel. We broke that condition in bug 1354078. The expedient thing
is to simply move the popup back, and move it back and forth if/when the photon pref is flipped.
When removing the pref, we can simplify this by always putting the menu in the overflow panel.

I also noticed that we use the toolbar context menu in the dynamic portion of the overflow panel.
This has the same problem, and to fix it I switched us to using the same (panel) context menu in
the photon case. Doing this in the non-photon case won't help because the context menu will be in
a separate panel (namely the old hamburger panel) entirely.

MozReview-Commit-ID: 4neHMukTzHA
 2017-07-07 15:54:13 +01:00
Jared Wein
99807c87a3 Bug 1375152 - Implement animation for pinning items to the overflow menu. r=dao 
This animation can be disabled if the toolkit.cosmeticAnimations.enabled pref is set to false.

MozReview-Commit-ID: DtsrI8YflYn
 2017-06-28 15:32:34 -07:00
Johann Hofmann
f0cfcae173 Bug 1350210 - Part 1 - Add UI density settings to customize mode. r=jaws 
MozReview-Commit-ID: C0g6aFPW2pX
 2017-06-27 18:50:34 +02:00
Gijs Kruitbosch
93e37881e1 Bug 1371236 - don't try to open the overflow panel when in customize mode, r=jaws 
MozReview-Commit-ID: H2mOlOkUNLG
 2017-06-22 14:12:24 +01:00
Brian Grinstead
50909f1a9a Bug 1364238 - Add the sidebar button into the default toolbar set;r=Gijs 
MozReview-Commit-ID: 7Z0ukSPu6pL
 2017-06-20 08:42:28 -07:00
Gijs Kruitbosch
3650f38128 Bug 1370986 - disable panelmultiview in the overflow panel off-nightly for 55, r=mikedeboer 
This #ifdefs out the multiview for non-photon-theme, and checks for it being
present in various bits of JS that interact with it. As a result, this will
'fix' the issues in this bug and in bug 1370967 for 55 as it moves off
Nightly. bug 1370967 will still need fixing in the photonpanelmultiview /
webextensions.

MozReview-Commit-ID: 6x4HmyvxeRP
 2017-06-08 16:38:36 +01:00
Sebastian Hengst
abcfaafc18 Backed out changeset 71da3a25b572 (bug 1370986) for timing out in browser_photon_customization_context_menus.js. r=backout 2017-06-09 21:19:50 +02:00
Gijs Kruitbosch
6f4b386f1c Bug 1370986 - switch to photonpanelmultiview for photon, disable off-nightly, r=mikedeboer 
This #ifdefs out the multiview for non-photon-theme, and checks for it being
present in various bits of JS that interact with it. As a result, this will
'fix' the issues in this bug and in bug 1370967 for 55 as it moves off
Nightly. By switching to the photonpanelmultiview, we get proper anchoring
and slightly improved styling (bug 1354086 covers the rest of that), even
where this code *is* enabled. bug 1370967 will still need fixing in
the photonpanelmultiview / webextensions.

MozReview-Commit-ID: 6x4HmyvxeRP
 2017-06-08 16:38:36 +01:00
Mike Taylor
a05a1d5674 Bug 1368920. Part 4 - Enable Report Site Issue button for DevEdition and Nightly builds only. r=Gijs 
MozReview-Commit-ID: Fu1oGBulbLT
 2017-06-06 15:50:53 -05:00
Gijs Kruitbosch
a5e58b1afb Bug 1367012 - update edit UI visibility checks for photon, r=mikedeboer 
This ensures we update edit UI visibility state when opening/closing the
overflow panel, as well as ensuring we do so if/when the edit controls
get over/underflowed. It then updates the test to ensure we correctly
check the overflow panel, both for overflown items and for items
put there by the user when photon is enabled.

MozReview-Commit-ID: AjRH8wz5Pla
 2017-06-08 11:17:55 +01:00
Paolo Amadini
a60427a774 Bug 694291 - Add a preference mirroring the presence of the search widget in the navigation toolbar. r=past 
MozReview-Commit-ID: 9UmowyRTTMK
 2017-06-02 16:36:18 +01:00
Mike Taylor
e7d4e33b22 Bug 1341438. Part 1 - Enable Report Site Issue for DevEdition + Nightly. r=Gijs 
MozReview-Commit-ID: 7yH39YDmL6V
 2017-04-04 17:40:50 -05:00
Gijs Kruitbosch
d26133a073 Bug 1365294 - swap position of the fixed overflow list, r=mikedeboer 
MozReview-Commit-ID: 9LlTxRLuOkx
 2017-05-17 15:05:36 +01:00
Gijs
dea6f4a52b Bug 1354094 - show the overflow button when there are items in the permanent overflow menu, r=mikedeboer 
This also disables the menu button and overflow button correctly in
customize mode, and fixes an issues where the overflow button state
would stay 'open' when closing the panel by clicking the button
a second time.

MozReview-Commit-ID: BNTkE6zvv9Q
 2017-05-10 12:36:05 -04:00
Gijs Kruitbosch
a140e98983 Bug 1354082 - part 2: make overflow panel show up in customize mode and make dragging work correctly, r=mikedeboer 
This reuses the logic we have for toolbar dragging and uses it for the photon panel (ie overflow panel)
to do vertical space-making animations.

It explicitly doesn't address the styling or permanently showing the overflow button (for which we have other bugs on file).


MozReview-Commit-ID: 4qrWC0H30xi
 2017-05-05 19:26:55 +01:00
Gijs Kruitbosch
f3418cac17 Bug 1354082 - part 1: make toggling the photon structure pref at runtime not break the panels, r=mikedeboer 
This is unfortunate, but in order to keep automated tests working when we flip the pref,
it would be nice to be able to flip the pref at runtime and have things Just Work. This
tries to make that happen. We can remove most of this code post-Photon.

MozReview-Commit-ID: 8zbgCGJautO
 2017-05-05 19:25:37 +01:00
Julian Descottes
d18d132561 Bug 1183962 - stop installing webide button in menu or navbar automatically;r=jryans 
MozReview-Commit-ID: CACgml3Xijf
 2017-05-02 22:56:40 +02:00
Gijs Kruitbosch
5929e36962 Bug 1354079 - add sticky / permanent part to overflow panel, r=mikedeboer 
MozReview-Commit-ID: 7wv43JWLx8Q
 2017-04-22 10:41:03 +01:00
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Gijs Kruitbosch
dd0452dae2 Bug 1354071 - make sure context menu continues to work correctly, r=mikedeboer 
MozReview-Commit-ID: DZiwogYyDBv
 2017-04-19 11:21:12 +01:00
Gijs Kruitbosch
f60415b033 Bug 1354071 - use a panelmultiview for the overflow panel, r=mikedeboer 
MozReview-Commit-ID: ERZuwC6eYQf
 2017-04-18 12:16:47 +01:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Gijs Kruitbosch
50783595e5 Bug 1341562 - fix CustomizableUI's overflow insertion to not break if buttons aren't where we expect them, r=jaws 
MozReview-Commit-ID: Fs9IYC4bvL9
 2017-03-22 19:50:53 +00:00
Florian Quèze
0b17fc5d60 Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Florian Quèze
c7eae86054 Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Florian Quèze
91f7a2ef3a Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Gijs Kruitbosch
0cc8ee0102 Backed out changeset b3761531b00b (bug 1306561) for perma-oranging a lot of tests once 53 merges to aurora, rs=bustage,me,etc. 
MozReview-Commit-ID: 9m4g9aqYPW8
 2017-01-22 00:24:47 +00:00
Mike Taylor
fe943e70ba Bug 1324062. Part 1 - Add a "Report Site Issue" button to the panel menu for NIGHTLY_BUILDs. r=Gijs 
MozReview-Commit-ID: 74T8uRuqpyf
 2017-01-17 14:27:03 -06:00
Wes Kocher
552366bcf7 Backed out 3 changesets (bug 1324062) for frequent Win7VM bc2 failures a=backout 
Backed out changeset d01f82be01f1 (bug 1324062)
Backed out changeset 054cfcf60c75 (bug 1324062)
Backed out changeset 1658b20cb69c (bug 1324062)

MozReview-Commit-ID: LTl7fJ8zrp9
 2017-01-20 11:53:36 -08:00
Mike Taylor
fce567a665 Bug 1324062. Part 1 - Add a "Report Site Issue" button to the panel menu for NIGHTLY_BUILDs. r=Gijs 
MozReview-Commit-ID: 74T8uRuqpyf
 2017-01-17 14:27:03 -06:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Phil Ringnalda
9fd9d27b8c Backed out 2 changesets (bug 1324062) for unexpected file access errors in webcompat-reporter@mozilla.org.xpi on Win7 PGO xperf 
Backed out changeset 1df935d51464 (bug 1324062)
Backed out changeset 028db619f166 (bug 1324062)
 2017-01-12 07:34:18 -08:00
Mike Taylor
384470ea9f Bug 1324062. Part 1 - Add a "Report Site Issue" button to the panel menu for NIGHTLY_BUILDs. r=Gijs 
MozReview-Commit-ID: 74T8uRuqpyf
 2016-12-28 13:31:22 -06:00
Dão Gottwald
f3ec008608 Bug 1306561 - Make the Restore Default button take into account that the devedition theme is the default in devedition builds. r=jaws 
MozReview-Commit-ID: 3gIOZuaXOO1
 2017-01-11 13:31:37 +01:00
Dão Gottwald
1367ab44f5 Bug 1330001 - Remove browser code behind Windows XP and Vista version checks. r=jaws 2017-01-11 10:54:16 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Dão Gottwald
f54ff32336 Bug 1318276 - Clean up CustomizableUIInternal.addShortcut. r=jaws 2016-11-17 17:18:07 +01:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws 
MozReview-Commit-ID: 2ZvTiZDHchz
 2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws 
MozReview-Commit-ID: HBpjT2uHJaZ
 2016-11-10 14:48:04 -08:00