Tried to do the reverse order (move files then edit), but
reviewboard didn't seem to like me trying to undo what I had
already done. This should at least make the diffs clean though.
MozReview-Commit-ID: Ibcgg2Mc6MT
Since we now have a store of notifications that is global across
all windows, it no longer makes sense to consume the API from
within browser.js. This patch moves the browser.js logic out into
a jsm file that is wired up through nsBrowserGlue, such that it
will be lazily instantiated on the first update event it would
receive[1].
We decided to move this into toolkit, as this piece of the
system is fairly generic and shouldn't differ between
applications.
[1]: There is a change to nsBrowserGlue to use "global[module]"
instead of this[module]. This mirrors the code for all the other
types of notifications, and I suspect it was just a latent bug,
since the original diff that includes this line makes no use of
it.
MozReview-Commit-ID: 8EQdM9BOpgl
browser_tabSpinnerTypeProbe.js isn't necessary anymore since it should not possible to show
spinners for tabs that have never been presented.
MozReview-Commit-ID: AD4ppdhe346
nsITabParent.hasPresented already encapsulates the case where the TabChild might
not have been constructed, since such a tab could never have been presented to
the user. If we're async tab switching to a tab that's never presented before,
we blank it out initially while waiting for its layers.
MozReview-Commit-ID: CL76wLmjRxc
Changes:
- remove code addressed by reviewer
- remove PContent.ipdl, PBrowser.ipdl, and ProcessPriorityManager code
that relates only to removed AudioChannelService methods
- correct test case listening to event from removed code
- remove useless test case files
MozReview-Commit-ID: I96nR8zTXJt
AddonConstants duplicated AppConstants, but having it just include
the build-time constants meant that the logic for whether to enforce
signing was repeated in a few places (and it was incorrect in
the front-end code!). Now we centralize that logic in AddonSettings.jsm
MozReview-Commit-ID: 2f4x9fnUpPs
A missing dependency in "nsTypeAheadFind.h" is also fixed to allow the removal of the include files from "nsToolkitCompsModule.cpp".
MozReview-Commit-ID: EefZA9bEUW0
We recently accidentally broke the "Enable DRM" prompt without realising, so
this adds a test that if EME is disabled and is attempted to be used we we
prompt the user to enable EME.
It is important we don't regress this feature as without it users with DRM
disabled (which is our Linux popuation by default) may try to playback DRM
protected video and it won't work and there won't be an obvious way to make it
work.
MozReview-Commit-ID: D4X7D4wkwRy
Synthesized keyboard events in child process doesn't have edit commands when
it's being dispatched. With the old design, PuppetWidget needed to store all
edit commands for dispatching keyboard event but it's not necessary now because
WidgetKeyboardEvent will get only necessary edit commands when
WidgetKeyboardEvent::ExecuteEditCommands() is called.
So, PuppetWidget should stop calling TabChild::RequestNativeKeyBindings()
before dispatching keyboard events.
This patch changes browser_audioTabIcon.js which becomes permanent orange with
this change.
MozReview-Commit-ID: 1eK1mUahRMO
Make the onboarding being opt-in or opt-out depending on the default value of the
browser.urlbar.sugges.searches pref.
In both cases respect userMadeSearchSuggestionChoice though, so we won't further nag users that
made a choice already.
MozReview-Commit-ID: D4rRMRbdMrW
This was working around some old XUL layout weirdness, but nowadays this uses the same scroll frame implementation as HTML and tabStrip.scrollPosition + tabStrip.scrollClientSize > tabStrip.scrollSize cannot be true.
MozReview-Commit-ID: F5fOEpXn8ay
