Commit Graph

62 Commits

Author SHA1 Message Date
Ehsan Akhgari
498e2df734 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset
2019-01-18 10:16:18 +01:00
Sylvestre Ledru
e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Masayuki Nakano
95fb9dc8a0 Bug 900750 - part 5: Make NativeKey set KeyboardEvent.key value of AltRight key to "AltGraph" when active keyboard layout has AltGr key r=m_kato,smaug
When AltGr key is pressed, following messages come:

1. WM_KEYDOWN for ControlLeft
2. WM_KEYDOWN for AltLeft
3. WM_SYSKEYUP for ControlLeft
4. WM_KEYUP for AltLeft

In these key sequence, KeyboardEvent.key value of keydown event at #2 and keyup
event at #4 should be "AltGraph".  This patch fixes the key value and
adding new test into test_keycodes.xul to check the behavior with
SynthesizeNativeKey().

MozReview-Commit-ID: JZ6WednB8la
2018-05-31 18:36:33 +09:00
Sylvestre Ledru
42f81ff9f1 Bug 1446809 - Remove some b2g leftover in widget/NativeKeyToDOMKeyName.h r=froydnj
MozReview-Commit-ID: 7nRuHThygp1
2018-03-18 19:30:05 +01:00
Csoregi Natalia
f9fcfa011d Backed out 10 changesets (bug 1446809) for failing on jsat/test_content_integration.html . CLOSED TREE
Backed out changeset 42146f3856d0 (bug 1446809)
Backed out changeset e6b888d19add (bug 1446809)
Backed out changeset 2293192557ef (bug 1446809)
Backed out changeset 643d30faeef8 (bug 1446809)
Backed out changeset 73639fbb3a61 (bug 1446809)
Backed out changeset df179cf0797d (bug 1446809)
Backed out changeset 04c46f107d24 (bug 1446809)
Backed out changeset 9b98c5aad44c (bug 1446809)
Backed out changeset 347d7259df0f (bug 1446809)
Backed out changeset 2a350e323713 (bug 1446809)
2018-03-21 11:17:38 +02:00
Sylvestre Ledru
62599d246e Bug 1446809 - Remove some b2g leftover in widget/NativeKeyToDOMKeyName.h r=froydnj
MozReview-Commit-ID: 7nRuHThygp1
2018-03-18 19:30:05 +01:00
Masayuki Nakano
c6ce4c0e8c Bug 1343451 - part 2: KeyboardLayout and NativeKey should use native key code value to check if the key event was handled by IME r=m_kato
On Windows, VK_PROCESSKEY key message is sent if the key event is handled by
IME (in IMM mode or IMM-IME).  Therefore, we can set
WidgetKeyboardEvent::mKeyCode to NS_VK_PROCESSKEY and
WidgetKeyboardEvent::mKeyNameIndex to KEY_NAME_INDEX_Process simply when
we receive VK_PROCESSKEY.

MozReview-Commit-ID: 9B8Q7rwfXYD
2017-03-01 15:58:50 +09:00
Cosmin Sabou
7c061d752c Backed out 6 changesets (bug 1343451) for mochitest android perma failures on testInputConnection.
Backed out changeset e07105d9698e (bug 1343451)
Backed out changeset dc4a2a5932c3 (bug 1343451)
Backed out changeset 9561ed261d04 (bug 1343451)
Backed out changeset 84a5ec921442 (bug 1343451)
Backed out changeset b34d48936db8 (bug 1343451)
Backed out changeset 4dce7ab14f71 (bug 1343451)
2018-03-12 18:07:46 +02:00
Masayuki Nakano
4c1b565f75 Bug 1343451 - part 2: KeyboardLayout and NativeKey should use native key code value to check if the key event was handled by IME r=m_kato
On Windows, VK_PROCESSKEY key message is sent if the key event is handled by
IME (in IMM mode or IMM-IME).  Therefore, we can set
WidgetKeyboardEvent::mKeyCode to NS_VK_PROCESSKEY and
WidgetKeyboardEvent::mKeyNameIndex to KEY_NAME_INDEX_Process simply when
we receive VK_PROCESSKEY.

MozReview-Commit-ID: 9B8Q7rwfXYD
2017-03-01 15:58:50 +09:00
Eric Rahm
b5b0a9c37e Bug 1386825 - Part 4: Remove remaining instances of MOZ_B2G. r=froydnj
MozReview-Commit-ID: 8r4eMwiZ4Vg
2017-08-08 14:41:09 -07:00
Masayuki Nakano
f2ccc0cbf0 Bug 1339509 Map ISO_Left_Tab to DOM Tab key r=karlt
Shift + Tab key combination causes ISO_Left_Tab keysym instead of Tab.  It should be mapped to DOM Tab key.

MozReview-Commit-ID: IgQj7tkQdoJ
2017-02-17 16:47:35 +09:00
Masayuki Nakano
5ab81f8ff1 Bug 1274503 part.4 Remove some odd whitespaces in NativeKeyToDOMKeyName.h r=smaug
MozReview-Commit-ID: GxcVOPMNqOx
2016-11-21 22:14:36 +09:00
Masayuki Nakano
4ed1bde288 Bug 1274503 part.3 Remap AKEYCODE_BACK, AKEYCODE_DPAD_CENTER and AKEYCODE_CAPTIONS to same KeyboardEvent.key value as Chromium r=smaug
AKEYCODE_BACK should be remapped from "BrowserBack" to "GoBack".
AKEYCODE_DPAD_CENTER should be remapped from "Accept" to "Enter".
AKEYCODE_CAPTIONS should be remapped from "Subtitle" to "ClosedCaptionToggle".

The new values are same as Chromium and they are also declared in the spec.

FYI: Gaia doesn't use above key values, so, it's safe to use KEY_MAP_ANDROID for them.

MozReview-Commit-ID: AJwhB59cKzq
2016-11-21 22:15:07 +09:00
Masayuki Nakano
df9ecea5c4 Bug 1274503 part.2 Add KeyboardEvent.key value mapping on Android which are not mapped by Gecko but mapped on Chromium r=smaug
First, we should get rid of "Unidentified" keys which are mapped to specific value on Chromium and we can agree without any discussion.

MozReview-Commit-ID: C4TZzndahNM
2016-12-01 21:38:54 +09:00
Masayuki Nakano
1fce071a8b Bug 1274503 part.1 AKEYCODE_ASSIST shouldn't be mapped to "Help" r=smaug
I mapped AKEYCODE_ASSIST to "Help".  However, Chromium doesn't map the keycode to anything. Additionally, Android has a new keycode AKEYCODE_HELP and Chromium maps it to "Help". So, we should use Chromium's mapping for it.

MozReview-Commit-ID: 19zTP0xclYI
2016-11-04 21:08:04 +09:00
Masayuki Nakano
7123e41737 Bug 1274503 part.0 Move "MediaFastForward" to "Media Keys" section for keeping same order with the spec r=smaug
MozReview-Commit-ID: 4eGNIDmbPds
2016-11-03 22:01:10 +09:00
Sebastian Hengst
82cf47929c Bug 1306137 - remove b2g camera code: Remove dom/camera/ and code which depends on it. r=aosmond,bkelly
MozReview-Commit-ID: 7gvZrDtmcZP
2016-10-04 20:16:28 +02:00
Nicholas Nethercote
2e56b393d0 Bug 1285554 - Remove remnants of widget/qt. r=dougt,mshal.
Because bug 1282866 removed Qt support but missed a bunch of things.
* * *
Bug 1285554 - more
2016-07-12 09:16:45 +10:00
Gregor Wagner
fd5d8d59ce Bug 1277234 - Rename key name VolumeUp to AudioVolumeUp. r=masayuki 2016-06-02 15:55:53 +02:00
Masayuki Nakano
e40b267e96 Bug 1272599 part.2 Rename KeyboardEvent.key values, "MozHomeScreen" and "MozCameraFocusAdjust" to "GoHome" and "CameraFocus" except on B2G r=smaug
KEYCODE_HOME was temporarily named as "MozHomeScreen" and KEYCODE_FOCUS was temprarily named as "MozCameraFocusAdjust" since they were not defined by the spec. However, in the latest spec, they are defined as "GoHome" and "CameraFocus". So, it is the time to rename them.

However, these temporary key names are still used by Gaia. Until it's fixed, we should keep using the temporary names only on B2G.

MozReview-Commit-ID: 9ILtZdf6EUQ
2016-05-20 21:29:10 +09:00
Masayuki Nakano
d3bb88d26d Bug 1272599 part.1 Rename KeyboardEvent.key value, "MozPhoneCall" to "Call" r=smaug
Android's KEYCODE_CALL was temporarily named as "MozPhoneCall" since proper key name was not defined in the spec. However, now, it's defined as "Call" in the latest spec. Therefore, we should rename this key name.

Note that this isn't available on Android because the key event is never fired on applications. However, this key may be useful on B2G. Although, the key is not used by current Gaia.

MozReview-Commit-ID: GF4STYrGMig
2016-05-20 21:00:20 +09:00
Masayuki Nakano
c45a7bf484 Bug 1272578 part.3 Rename key name VolumeMute to AudioVolumeMute except on B2G r=smaug
VolumeMute was renamed to AudioVolumeMute in the latest draft and Chromium uses the new name. Therefore, we need to update this but Gaia uses the old name. So, we shouldn't rename on B2G until Gaia is fixed.

Note that this patch changes tests but they are not used by B2G. Therefore, just replacing with new name is enough.

Only forms.js is necessary #ifdef because the main purpose of forms.js is for B2G's IME framework. However, it's available on the other platforms if chrome needs to use it.

MozReview-Commit-ID: KSkcPbIovin
2016-05-21 00:57:18 +09:00
Masayuki Nakano
236970321d Bug 1272578 part.2 Rename key name VolumeUp to AudioVolumeUp except on B2G r=smaug
VolumeUp was renamed to AudioVolumeUp in the latest draft and Chromium uses the new name. Therefore, we need to update this but Gaia uses the old name. So, we shouldn't rename on B2G until Gaia is fixed.

Note that this patch changes tests but they are not used by B2G. Therefore, just replacing with new name is enough.

Only forms.js is necessary #ifdef because the main purpose of forms.js is for B2G's IME framework. However, it's available on the other platforms if chrome needs to use it.

MozReview-Commit-ID: KzLVL5Y2dIN
2016-05-21 00:55:48 +09:00
Masayuki Nakano
c0ba45f0e4 Bug 1272578 part.1 Rename key name VolumeDown to AudioVolumeDown except on B2G r=smaug
VolumeDown was renamed to AudioVolumeDown in the latest draft and Chromium uses the new name. Therefore, we need to update this but Gaia uses the old name. So, we shouldn't rename on B2G until Gaia is fixed.

Note that this patch changes tests but they are not used by B2G. Therefore, just replacing with new name is enough.

Only forms.js is necessary #ifdef because the main purpose of forms.js is for B2G's IME framework. However, it's available on the other platforms if chrome needs to use it.

MozReview-Commit-ID: cq98qJnS8M
2016-05-21 00:52:03 +09:00
Masayuki Nakano
bd5ac16fba Bug 1272592 Merge "MediaSelect" key value into "LaunchMediaPlayer" r=smaug
"MediaSelect" is merged into "LanuchMediaPlayer" in the spec since there is no difference between them and "LaunchMediaPlayer" explains the meaning clearer.

This patch removes "MediaSelect" key value and maps all keys which are mapped to "MediaSelect" to "LaunchMediaPlayer".

MozReview-Commit-ID: IEZhV4p6Qag
2016-05-19 20:47:32 +09:00
Masayuki Nakano
6b8fba2a4f Bug 1232919 part.2 Reorganize NativeKeyToDOMKeyName.h for using same definition order of the latest UI Events KeyboardEvent key values r=smaug
MozReview-Commit-ID: ANBe57BbVgb
2016-05-13 18:49:46 +09:00
Wes Kocher
2890317496 Backed out changeset 3c46096adeaf (bug 1272592) for landing before some requisite commits CLOSED TREE 2016-05-20 17:59:41 -07:00
Masayuki Nakano
6b7948c32b Bug 1272592 Merge "MediaSelect" key value into "LaunchMediaPlayer" r=smaug
"MediaSelect" is merged into "LanuchMediaPlayer" in the spec since there is no difference between them and "LaunchMediaPlayer" explains the meaning clearer.

This patch removes "MediaSelect" key value and maps all keys which are mapped to "MediaSelect" to "LaunchMediaPlayer".

MozReview-Commit-ID: IEZhV4p6Qag
2016-05-19 20:47:32 +09:00
Hansu Kim
64e181d088 Bug 1112712 - DOM key mapping for soft1 soft2 and call keys r=schien 2015-10-16 11:04:11 -07:00
Nigel Babu
7f2f68aa38 Backed out changeset 02a7211c3ac8 (bug 1112712) for build bustage 2015-10-05 14:29:44 +05:30
hansu9866@gmail.com
fa1aca0471 Bug 1112712 - DOM key and code mapping for simple phone hardware keys. r=masayuki
commit eb0f93fdeaba83493ad231b62e8d27793e1a67ca
Author: Hansu Kim <hansu9866@gmail.com>
    Bug 1112712 DOM key and code mapping for simple phone hardware keys

    Change-Id: I8b37b82e374ce287af334061eaaa49f1b9f350b8
2015-10-01 16:13:00 +02:00
Kartikaya Gupta
ebe4a3e37e Bug 1039866 - Rip out a bunch of metro-only code. r=jimm,gavin,rstrong 2015-04-23 15:10:30 -04:00
Alexandre Lissy
76bcd98ece Bug 1133741 - Add camera focus hardware button. r=masayuki 2015-02-20 00:06:00 -05:00
Masayuki Nakano
0e03dba758 Bug 1121878 Map Copy, Cut, ChannelDown, ChannelUp and MediaFastForward to proper WM_APPCOMMAND message r=smaug+jimm 2015-01-16 21:15:06 +09:00
Sean Lin
0631e789e1 Bug 1116762 - Add MozHomeScreen key name for home button. r=masayuki 2015-01-08 11:29:54 +08:00
Masayuki Nakano
5150598e78 Bug 1031156 Map GDK_AudioForward to "MediaFastForwar" r=karlt 2014-12-30 10:47:56 +09:00
Masayuki Nakano
770fb09fdd Bug 865561 Dispatch key events when WM_APPCOMMAND is fired for a keypress r=jimm+smaug 2014-12-30 10:47:56 +09:00
Masayuki Nakano
02acd2106c Bug 1027477 Don't map "Exit" key value to HOME button of smartphones r=mwu+nchen+smaug 2014-12-30 10:47:56 +09:00
Masayuki Nakano
17bfbcda81 Bug 1027474 Support "VideoModeNext" key value on GTK r=smaug+karlt 2014-12-30 10:47:56 +09:00
Masayuki Nakano
2c46201760 Bug 1027472 Support Symbol key value on Android and Gonk r=mwu+nchen+smaug 2014-12-30 10:47:55 +09:00
Masayuki Nakano
561d9c8e46 Bug 1027007 Support multimedia keyboard's special key values "Close", "MailForward", "MailReply", "MailSend", "New", "Open", "Print" and "SpellCheck" on GTK and Qt r=smaug+karlt+romaxa 2014-12-30 10:47:55 +09:00
Masayuki Nakano
6e38221ad2 Bug 1026939 Support "LaunchFoo" key values which launches specific application on GTK, Qt, Android and Gonk r=nchen+karlt+mwu+smaug+romaxa 2014-12-30 10:47:55 +09:00
Masayuki Nakano
5879a589dd Bug 1023062 Support "TV", "TVInput", "TVPower", "AVInput", "AVPower", "STBInput" and "STBPower" key values on Androind and Gonk r=nchen+mwu+smaug 2014-12-30 10:47:55 +09:00
Masayuki Nakano
b5e7fbaf0b Bug 936322 Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk r=nchen+karlt+mwu+smaug 2014-12-30 10:47:55 +09:00
Masayuki Nakano
d199f58cb4 Bug 896348 Support "Eisu" key value on Mac, Android and Gonk r=smichaud+nchen+mwu+smaug 2014-12-30 10:47:55 +09:00
Masayuki Nakano
2b57154c5f Bug 900400 Support "HiraganaKatakana" and "ZenkakuHankaku" on GTK, Qt, Android and Gonk r=nchen+karlt+mwu+smaug+romaxa 2014-12-30 10:47:55 +09:00
Masayuki Nakano
6e1560c831 Bug 900392 Support "SingleCandidate" key value on GTK and Qt r=romaxa+karlt+smaug 2014-12-30 10:47:55 +09:00
Masayuki Nakano
d8496c988d Bug 900384 Support "Redo" key value on GTK r=karlt+smaug 2014-12-30 10:47:54 +09:00
Masayuki Nakano
1a6c5691df Bug 900382 Support "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp" key values on Windows, GTK and Qt r=jimm+karlt+smaug+jimm 2014-12-30 10:47:54 +09:00
Masayuki Nakano
d13d262bd0 Bug 900378 Support "ZoomIn" and "ZoomOut" key values on GTK, Qt, Android and Gonk r=romaxa+nchen+karlt+mwu+smaug 2014-12-30 10:47:54 +09:00