corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
590,622 Commits 1 Branch 0 Tags
37b80d446d334a204544e9b51da323db6630a068
Commit Graph

102 Commits

Author SHA1 Message Date
Matthew Noorenberghe
e24ba068b6 Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak 
Normally autocomplete results are cached based upon the search string but to get the desired behaviour we want two different sets of results for the same search string depending on how the autocomplete search was started:
a) Via automatically focusing a password field.
b) Every other method of starting an autocomplete search.

In order to not have cached results used, the result code for case (a) [an empty result] will be `RESULT_FAILURE` and I've updated the autocomplete code to not re-use an error result.

In the coming months we may be rewriting our content autocomplete code but that would be too risky to uplift to 67 so for now I'm tracking when satchel automatically opens the popup upon focus and then using that state in the autocomplete result creation code to know whether to include the footer.

Differential Revision: https://phabricator.services.mozilla.com/D25173
 2019-03-30 04:20:20 +00:00
prathiksha
5e3dc75527 Bug 1526522 - Provide visual effects on password field autocomplete. r=MattN 
Differential Revision: https://phabricator.services.mozilla.com/D20745
 2019-03-19 16:57:18 +00:00
Marco Bonardo
5fd5e16acd Bug 1530706 - IME may be displayed along with the urlbar results panel. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D23836
 2019-03-19 14:06:33 +00:00
Matthew Noorenberghe
25b014fbfa Bug 1534896 - Don't close the login autocomplete popup when the search string becomes empty. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D23622
 2019-03-15 20:57:02 +00:00
Alexander Surkov
3ad0c4b140 Bug 1525101 - adjust nsIAutoCompletePopup to make custom element popups working, r=peterv 
Differential Revision: https://phabricator.services.mozilla.com/D20504
 2019-02-25 20:02:17 +00:00
Kris Maglione
a10656a5c8 Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D18403
 2019-01-24 16:34:52 -08:00
Csoregi Natalia
ddfb8b53b5 Backed out 79 changesets (bug 1524687, bug 1524688) for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *). CLOSED TREE 
Backed out changeset 68a001a42406 (bug 1524687)
Backed out changeset 328de611bcd3 (bug 1524688)
Backed out changeset 68cffca6927a (bug 1524687)
Backed out changeset 81dc12cc9257 (bug 1524688)
Backed out changeset c7c49f64048f (bug 1524688)
Backed out changeset fb23a0271da0 (bug 1524688)
Backed out changeset 0c1d1248e59e (bug 1524688)
Backed out changeset 9e9ec7de4160 (bug 1524688)
Backed out changeset de0b9993bd5d (bug 1524688)
Backed out changeset 92877cf4fe33 (bug 1524688)
Backed out changeset b4938f2ff8fd (bug 1524688)
Backed out changeset 230d2feaf941 (bug 1524688)
Backed out changeset 6c63bc240972 (bug 1524688)
Backed out changeset 0ad5465eace1 (bug 1524688)
Backed out changeset 1e75ce91029b (bug 1524688)
Backed out changeset 34a978503b1d (bug 1524688)
Backed out changeset 183602e8a30b (bug 1524688)
Backed out changeset 12a9135dc005 (bug 1524688)
Backed out changeset 978ef5dac9db (bug 1524688)
Backed out changeset 28105bf7bf6a (bug 1524688)
Backed out changeset a9fb74beaf2b (bug 1524688)
Backed out changeset fe106b369a72 (bug 1524688)
Backed out changeset e657e77d4271 (bug 1524688)
Backed out changeset 09f626870ad0 (bug 1524688)
Backed out changeset fe9b6695212e (bug 1524688)
Backed out changeset 995ea188bc31 (bug 1524688)
Backed out changeset 01c4d3edb1b0 (bug 1524688)
Backed out changeset 1bb7dfbb9f48 (bug 1524688)
Backed out changeset 56c61e0a1f45 (bug 1524688)
Backed out changeset c819943ff466 (bug 1524688)
Backed out changeset a1dd5cec066e (bug 1524688)
Backed out changeset 517838ee0c3c (bug 1524688)
Backed out changeset f509a5759fdf (bug 1524688)
Backed out changeset 56f5c8f0d708 (bug 1524688)
Backed out changeset 5746311ef859 (bug 1524688)
Backed out changeset df02f7d25212 (bug 1524688)
Backed out changeset c9846136d105 (bug 1524688)
Backed out changeset 2bd48db9cd0f (bug 1524688)
Backed out changeset ff120b4eeb79 (bug 1524688)
Backed out changeset fe583e7aae8d (bug 1524688)
Backed out changeset 18f156d6355a (bug 1524688)
Backed out changeset f4eaebbe2e0f (bug 1524688)
Backed out changeset bf6b18e23f69 (bug 1524688)
Backed out changeset dd89eb7e9b0d (bug 1524688)
Backed out changeset 4cbbb367ba0b (bug 1524688)
Backed out changeset 4ed0cf6be580 (bug 1524688)
Backed out changeset d8efb5ed62b1 (bug 1524688)
Backed out changeset ea347d57d73a (bug 1524688)
Backed out changeset 911689ef9f33 (bug 1524688)
Backed out changeset 28670fdc418d (bug 1524688)
Backed out changeset 38e1e42a0fb0 (bug 1524688)
Backed out changeset 35a5f031dd1e (bug 1524688)
Backed out changeset b586d55d76d5 (bug 1524688)
Backed out changeset 6dcacead1746 (bug 1524688)
Backed out changeset 9895239d8ac6 (bug 1524688)
Backed out changeset 25f982fd53bd (bug 1524688)
Backed out changeset 4fb0f0a59fe2 (bug 1524688)
Backed out changeset fdc6c4ed241a (bug 1524688)
Backed out changeset 5ce5986068f0 (bug 1524688)
Backed out changeset ab64ed7388ae (bug 1524688)
Backed out changeset 56607c5a301a (bug 1524688)
Backed out changeset 6b3684e7d8f9 (bug 1524688)
Backed out changeset ee28258a5724 (bug 1524688)
Backed out changeset 9201a7ea3c54 (bug 1524688)
Backed out changeset d5dca413e2da (bug 1524688)
Backed out changeset 68eb174a337b (bug 1524688)
Backed out changeset 625f71135038 (bug 1524687)
Backed out changeset 46e13c453538 (bug 1524687)
Backed out changeset 614be688767f (bug 1524687)
Backed out changeset 9c24919ac5c2 (bug 1524687)
Backed out changeset b9862758b98c (bug 1524687)
Backed out changeset 92d9e927deec (bug 1524687)
Backed out changeset f4ee175bc5bd (bug 1524687)
Backed out changeset 191afe83da2e (bug 1524687)
Backed out changeset c58caf41bb94 (bug 1524687)
Backed out changeset df95a56dae04 (bug 1524687)
Backed out changeset 10c69df4444d (bug 1524687)
Backed out changeset 219b84a58f50 (bug 1524687)
Backed out changeset e96e61bd282f (bug 1524687)
 2019-02-14 11:50:23 +02:00
Kris Maglione
f001a35eb9 Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D18403
 2019-01-24 16:34:52 -08:00
Sylvestre Ledru
e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 
# ignore-this-changeset
 2018-11-30 11:46:48 +01:00
Marco Bonardo
7abd9bf710 Bug 1388123 - Make autocomplete handle Enter on keydown. r=MattN 
Some pages, like the Google login form, submit information on keydown, that
causes us to not autocomplete, because we handle keypress instead.
The patch changes autocomplete to happen on keydown.
Unfortunately formautofill also uses keydown and tries to access popup data too
late, thus it needs some hacks to work properly.
In general the formautofill code has too many indirections due to e10s, and that
makes the fix more fragile than we'd want. Ideally content autocomplete should
have its own codebase, rather than sharing the same controller as chrome code.

MozReview-Commit-ID: oAyASmDFm1
 2018-06-22 12:37:09 +02:00
Jeff Gilbert
70a22b2878 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot 
MozReview-Commit-ID: JtTcLL5OPF0
 2018-06-26 17:05:01 -07:00
Marco Bonardo
fc1090f8aa Bug 1467537 - The delete trigger on moz_updateoriginsinsert_temp is recalculating the whole table every time. r=adw 
The trigger is missing a WHERE clause, and as such it ends up doing a lot more work than necessary.

The nsAutoCompleteController changes cover a bug where VK_RIGHT autofills when it's not necessary,
and by doing that it will move the caret to an unexpected position (far right) even if it didn't
actually complete some preselected text.

MozReview-Commit-ID: 1mVbxCdqVSr
 2018-06-08 11:31:13 +02:00
Julian Viereck
b14ee48f19 Bug 1124238 - The autofill placeholder should not override keywords. r=mak 
MozReview-Commit-ID: D6gBdkQxMrW
 2018-05-30 16:50:37 +02:00
Boris Zbarsky
00c784322e Bug 1455052 part 4. Stop using nsIDOMEvent in xpidl interfaces. r=masayuki 
MozReview-Commit-ID: GIs8DVfduKe
 2018-04-20 12:53:17 -04:00
Valentin Gosu
ca5c5bbf19 Bug 1439931 - nsIIOService.extractScheme/net_ExtractURLScheme should lowercase its output r=mayhemer 
MozReview-Commit-ID: LZ2rqIdIoXQ
 2018-02-26 16:42:27 +01:00
Marco Bonardo
506fe4efc1 Bug 1435711 - Remove controller support for tree autocomplete. r=Paolo 
MozReview-Commit-ID: 5NJu2ILBP5h
 2018-02-17 18:11:13 +01:00
Boris Zbarsky
d81bb35cf8 Bug 1436508 part 11. Remove the use of the nsIDOMKeyEvent::DOM_VK* constants in C++. r=masayuki 
MozReview-Commit-ID: Honw0NrVMuV
 2018-02-09 11:17:09 -05:00
Florian Quèze
2199ef4ac7 Bug 1371610 - Delay getting the search component service until the first StartSearch, r=mak. 2018-02-08 12:28:34 +01:00
Tim Nguyen
0f11886f22 Bug 1430374 - Remove support for progressmeter tree cells. r=bz,dao 
MozReview-Commit-ID: 3hydkeoneC0
 2018-01-18 10:36:05 +00:00
Masayuki Nakano
b93a0ce668 Bug 1407085 - nsAutoCompleteController shouldn't restore original value after somebody changes the input value even when Escape key is pressed r=mak 
When Escape key is pressed, nsAutoCompleteController needs to restore last
string which was default value of the input or typed by the user.  However,
somebody may change the value, e.g., an event listener which handles
Escape key.  In this case, nsAutoCompleteController shouldn't restore the
last string.

Unfortunately, when JS sets input value, DOM "input" event won't be fired.
Therefore, nsAutoCompleteController doesn't have a chance to modify
mSearchString in this case.  Therefore, nsAutoCompleteController needs to
store expected input string for checking if somebody modified the input value.
For solving this issue, this patch adds a new member, mSetValue which is
modified when the input value is modified by nsAutoCompleteController itself
or mSearchString is modified.

Even with this patch, if user temporarily selects an item of the popup and
JS sets same value as the selected item from JS, nsAutoCompleteController
restores the input value with mSearchString.  However, this must be rare
case and I don't have idea to fix this issue with simple patches.

MozReview-Commit-ID: lig8c7xvD7
 2017-12-19 16:46:20 +09:00
Drew Willcoxon
f0eb3eb041 Bug 1410240 - Search suggestions keep displacing awesomebar results as I'm about to click on them. r=mak 
MozReview-Commit-ID: 2NdV9qWzld1
 2017-11-22 16:22:32 -08:00
Marco Bonardo
c6b922c0b7 Bug 1415908 - Intermittent failure (nsIAutoCompleteController.getCommentAt) in browser_ext_omnibox.js. r=adw 
Fixes a timing bug where in certain moments matchCount may not be in sync with the current search status,
due to previous results not being cleared immediately. Still delays tree updates to avoid UI flickering.
Fixes a theorical timing issue in unifiedComplete where a stopped search could notify a result.
Removes the no more used OnUpdateSearchResult API.

MozReview-Commit-ID: COoIN4oQT4v
 2017-11-19 21:58:14 +01:00
Ray Lin
74e309f85d Bug 1410821 - Call startSearch again when the new search string could not hit the cached result. r=mak 
MozReview-Commit-ID: 1AJutt4IA0E
 2017-11-03 15:22:45 +08:00
Kris Maglione
60872d7b31 Bug 1404198: Part 2f - Switch to NS_NewTimer* in toolkit. r=njn 
MozReview-Commit-ID: 185rZ99R6zV
 2017-10-15 23:14:00 -07:00
Shane Caraveo
d540205171 Bug 1406229 fix autocomplete crash in panels when window is closed during event, r=mak 
MozReview-Commit-ID: 6TrLuwrk2nD
 2017-10-06 16:58:15 -07:00
Bevis Tseng
59627df038 Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm 2017-07-27 02:18:20 +08:00
Sylvestre Ledru
9d4a84d778 Bug 1378712 - Remove all trailing whitespaces r=Ehsan 
MozReview-Commit-ID: Kdz2xtTF9EG
 2017-07-06 14:00:35 +02:00
Marco Bonardo
999435c9e2 Bug 1370518 - Don't completely detach/attach the autocomplete controller on TabSelect. r=mconley 
Due to recent changes to tabbrowser focus behavior, now the "focus" event to the location bar
happens before the "TabSelect" event. On "focus" we would like to open the location bar popup,
but detaching the controller would immediately close it. Thus we don't want "TabSelect" to
detach the controller just to reset its internal state. Moreover, this should be cheaper.

MozReview-Commit-ID: 5NZ1TTI9NFW
 2017-06-06 18:47:19 +02:00
Marco Bonardo
817dd58fcc Bug 1368074 - Autocomplete popup is not re-opened when repeating the same search in a new tab. r=mconley 
MozReview-Commit-ID: GSZoWFgw0X8
 2017-05-30 17:28:34 +02:00
Marco Bonardo
12b2b6852f Bug 1304501 - Properly disable trimUrl on autofill. r=adw 
MozReview-Commit-ID: IxCOWkqFYV0
 2016-09-21 21:55:00 +02:00
Marco Bonardo
9f5dc75ac5 Bug 1306639 - Searching in locationbar by typing something and pressing enter is not accounted in telemetry. r=adw 
MozReview-Commit-ID: 9r8IyyyxruC
 2016-10-06 17:40:13 +02:00
Marco Bonardo
238ca13b58 Bug 1303624 - Remove typeAheadResult support from autocomplete. r=adw 
MozReview-Commit-ID: 7XLTON1Rj96
 2016-09-21 18:11:45 +02:00
Marco Bonardo
f838352255 Bug 1302472 - keyboard selected value in autocomplete popup cannot be confirmed with <enter> if completedefaultindex is true but completeselectedindex is false. r=adw 
MozReview-Commit-ID: FR4pKGZLAl2
 2016-09-17 14:03:37 +02:00
Marco Bonardo
785ad45550 Bug 1301093 - Part 3: fix delayed handleEnter regression. r=adw 
MozReview-Commit-ID: 1SZeMUtLjNg
 2016-09-13 09:35:00 +02:00
Marco Bonardo
4fc92051bb Bug 1301093 - Part 1: don't wait for a result when we won't get one. r=adw 
MozReview-Commit-ID: E6l9mW3ZoKp
 2016-09-07 17:44:46 +02:00
Marco Bonardo
b6f51668b8 Bug 1292310 - Enter may wrongly confirm a mouse selected entry in the urlbar. r=adw 
MozReview-Commit-ID: 6teMoPr1vb6
 2016-09-06 17:55:56 +02:00
Yoshi Huang
d1b4579af0 Bug 1244340 - Part 3: pass userContextId to search suggestions r=mak 2016-08-26 18:59:00 +08:00
Drew Willcoxon
a11453a5f4 Bug 1180944 - Implement one-off searches from Awesomebar. r=mak,florian 
MozReview-Commit-ID: A9YXB32L7MN
 2016-08-02 18:00:26 -07:00
Nicholas Nethercote
c74d1d066a Bug 1257128 (part 4) - Remove unused nsIAtomService references in toolkit/. r=froydnj. 2016-03-16 21:11:10 +11:00
Drew Willcoxon
826b4f753d Bug 1236364 - Don't reuse existing richlistitem in urlbar when handling a delete. r=mak 2016-01-25 10:13:26 -08:00
Marco Bonardo
299ef159d5 Bug 1234186 - Unified autocompletion Visit feature doesn't use https for https-only websites. r=adw 2016-01-19 00:39:57 +01:00
Drew Willcoxon
68436cd003 Bug 1182783 - Restore search string and selection when selecting an autofilled urlbar popup result. r=mak 2015-12-15 17:08:41 -08:00
Marco Bonardo
6c190ee363 Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil 2015-11-10 20:18:24 +01:00
Marco Bonardo
ed7123ee15 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw 
Original patch by Felipe Gomes <felipc@gmail.com>
 2015-07-30 16:54:27 +02:00
Ryan VanderMeulen
d132c6c469 Backed out changeset 91b6fe481685 (bug 1172937) for test_autocomplete_with_composition_on_input.html failures. 2015-07-30 12:45:03 -04:00
Marco Bonardo
ef650b87a0 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw 
Original patch by Felipe Gomes <felipc@gmail.com>
 2015-07-30 16:54:27 +02:00
Matt Brubeck
f9b4e572a2 Bug 1185183 - Don't replace edited URL value with old completed value [r=mak] 2015-07-27 17:58:58 -07:00
Magnus Melin
6b6bed0e6d Bug 1130858 - Recipient autocomplete suggestion overrides ANY manual address input if quickly entered/pasted and confirmed with Enter/Tab before autocomplete suggestions disappear. r=mak 2015-07-15 16:21:52 +03:00
Matthew Noorenberghe
ce47a65476 Bug 998893 - Update the autocomplete search string when pressing DOM_VK_DOWN to initiate a search. r=mak 
Some script may have changed the value of the text field since our last keypress or after our focus handler and we don't want to search for a stale string.
 2015-05-06 11:23:51 -07:00
Tim Taubert
3637495d9f Bug 1042561 - Iterate a copy of mSearches in StartSearch() so that an observer can't modify the array we're iterating r=mak 2015-03-23 08:33:53 +01:00