Commit Graph

4825 Commits

Author SHA1 Message Date
Mike Shal
c04e18fa25 Bug 1537574 - Use mozbuild's backend-out-of-date logic for RecursiveMake; r=firefox-build-system-reviewers,chmanchester
If mozbuild parsing fails due to a missing file (eg: a file not existing
in UNIFIED_SOURCES), then no Makefiles are written out, but
config.status exists. This would cause mozbuild to think that configure
doesn't need to run, and rely on make to perform the backend-out-of-date
check in rebuild-backend.mk. Unfortunately since no Makefiles were
written, the make command fails immediately and no attempt is made to
re-create the backend. Note that this is only a problem if the first
mozbuild parsing from a clobber build fails, otherwise there is
typically a top-level Makefile from a previous build to call into (at
which point make can determine it is out-of-date, and re-invoke itself).

The fix is to have the RecursiveMake backend re-use the same logic that
was introduced into mozbuild for alternate backends, and remove
rebuild-backend.mk. This way, mozbuild can always determine if the
backend needs to be regenerated, even if the initial parsing failed.

Test code was also relying on rebuild-backend.mk to generate the
TestBackend, but moving backend_out_of_date() into MozbuildObject allows
this code to be shared.

Differential Revision: https://phabricator.services.mozilla.com/D26262
2019-04-10 22:14:27 +00:00
Chris Manchester
46e8498497 Bug 1542042 - Convert arguments to unicode explicitly in |./mach run|. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D26832
2019-04-09 23:13:07 +00:00
Bobby Holley
66fadde963 Bug 1543246 - Suggest |./mach busted| when something breaks. r=froydnj
Depends on D26818

Differential Revision: https://phabricator.services.mozilla.com/D26930
2019-04-10 16:40:14 +00:00
Nicholas Cowles
50c9c30a0d Bug 1523747 - Move customize mode strings over to fluent, r=Gijs,jaws,flod
Differential Revision: https://phabricator.services.mozilla.com/D26418
2019-04-10 15:46:31 +00:00
Bastien Abadie
c1d591c411 Bug 1541412 - Add static-analysis check-java to source-test tasks, r=ahal,andi
Differential Revision: https://phabricator.services.mozilla.com/D25929
2019-04-08 15:41:30 +00:00
Andi-Bogdan Postelnicu
17c6101a85 Bug 1542871 - prevent data loss for clang-format when using incompatible/old clang-format binary. r=sylvestre
This issue has been detected and reproduced by :klotz and :jorendorff.

Differential Revision: https://phabricator.services.mozilla.com/D26872
2019-04-10 09:32:07 +00:00
Andi-Bogdan Postelnicu
51236681c7 Bug 1543024 - [Coverity] Add more information to the exported artifact that is generated by Coverity. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D26682
2019-04-10 07:19:26 +00:00
Aaron Klotz
970dca29e5 Bug 1520309: Set HGPLAIN env var when running hg push-to-try; r=ahal
If there are a large number of untracked files in the working directory, hg
will attempt to print them all out with the default pager. This does not
interact very will with commands that are built atop this functionality. We
set HGPLAIN=1 so that the underlying hg will not attempt to use a pager.

Differential Revision: https://phabricator.services.mozilla.com/D26607
2019-04-09 21:10:49 +00:00
Petr Sumbera
c99e081a11 Bug 1405345 - ldflags as defined in gypi shouldn't be ignored at least on Solaris for now r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D26287
2019-04-09 13:22:16 +00:00
Mike Hommey
1b87806fdc Bug 1541792 - Replace linker magic with manual component registration. r=froydnj
Before bug 938437, we had a rather large and error-prone
nsStaticXULComponents.cpp used to register all modules. That was
replaced with clever use of the linker, which allowed to avoid the mess
that maintaining that file was.

Fast forward to now, where after bug 1524687 and other work that
preceded it, we have a much smaller number of remaining static xpcom
components, registered via this linker hack, and don't expect to add
any new ones. The list should eventually go down to zero.

Within that context, it seems to be the right time to get rid of the
magic, and with it the problems it causes on its own.

Some of those components could probably be trivially be converted to
static registration via .conf files, but I didn't want to deal with the
possible need to increase the number of dummy modules in XPCOMInit.cpp.
They can still be converted as a followup.

Differential Revision: https://phabricator.services.mozilla.com/D26076
2019-04-05 02:30:56 +00:00
Andreea Pavel
ea755be12c Backed out changeset 95b3298fd2d4 (bug 1537574) for windows task timeouts a=backout 2019-04-08 22:23:03 +03:00
Mike Shal
684316d3e1 Bug 1537574 - Use mozbuild's backend-out-of-date logic for RecursiveMake; r=firefox-build-system-reviewers,chmanchester
If mozbuild parsing fails due to a missing file (eg: a file not existing
in UNIFIED_SOURCES), then no Makefiles are written out, but
config.status exists. This would cause mozbuild to think that configure
doesn't need to run, and rely on make to perform the backend-out-of-date
check in rebuild-backend.mk. Unfortunately since no Makefiles were
written, the make command fails immediately and no attempt is made to
re-create the backend. Note that this is only a problem if the first
mozbuild parsing from a clobber build fails, otherwise there is
typically a top-level Makefile from a previous build to call into (at
which point make can determine it is out-of-date, and re-invoke itself).

The fix is to have the RecursiveMake backend re-use the same logic that
was introduced into mozbuild for alternate backends, and remove
rebuild-backend.mk. This way, mozbuild can always determine if the
backend needs to be regenerated, even if the initial parsing failed.

Test code was also relying on rebuild-backend.mk to generate the
TestBackend, but moving backend_out_of_date() into MozbuildObject allows
this code to be shared.

Differential Revision: https://phabricator.services.mozilla.com/D26262
2019-04-08 16:37:56 +00:00
Dorel Luca
3e2f92defa Backed out changeset 471b2063c817 (bug 1540656) for XPCShell failures in dom/push/test/xpcshell/test_register_success_http2.js 2019-04-08 15:49:10 +03:00
Andi-Bogdan Postelnicu
247339291c Bug 1541147 - [Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D26145
2019-04-08 10:42:37 +00:00
Valentin Gosu
1ddeebd2af Bug 1540656 - Use dns-packet node module in test_trr.js r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D25671
2019-04-08 10:42:34 +00:00
Coroiu Cristina
879b8872ff Backed out changeset 7e2aef09165a (bug 1541147) on request by Andy 2019-04-08 13:24:38 +03:00
Andi-Bogdan Postelnicu
a16c76f04e Bug 1541147 - [Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D26145
2019-04-08 10:16:13 +00:00
Avery Berninger
3c03a62b01 Bug 1523741 - Converting legacy aboutTelemetry to Fluent aboutTelemetry, r=jaws,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D20417
2019-04-08 09:15:16 +00:00
Cosmin Sabou
f5fbf6c896 Backed out changeset 7e40ec0c948d (bug 1523741) for telemetry failures on aboutTelemetry.homeSection. 2019-04-06 20:44:55 +03:00
Avery Berninger
d8372c5a0c Bug 1523741 - Converting legacy aboutTelemetry to Fluent aboutTelemetry, r=jaws,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D20417
2019-04-06 00:54:52 +00:00
Razvan Maries
796ee3a2c2 Backed out changeset ac130652ae81 (bug 1541147) for Gecko Decision Task bustages. CLOSED TREE 2019-04-06 10:23:16 +03:00
Andi-Bogdan Postelnicu
4552824950 Bug 1541147 - [Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D26145
2019-04-06 06:32:16 +00:00
Bobby Holley
0c3936d502 Bug 1542376 - Avoid exception during Android bootstrap. r=glandium
Mozboot uses Python 2.7.3, along with the |unicode_literals| directive,
which makes string literals unicode by default. However, the
LooseVersion implementation that ships with Python throws an exception
when comparing against bare unicode strings, because it only checks for
StringType, not UnicodeType [1].

[1] https://github.com/enthought/Python-2.7.3/blob/master/Lib/distutils/version.py#L292

Differential Revision: https://phabricator.services.mozilla.com/D26378
2019-04-05 22:07:30 +00:00
Brian Grinstead
4323ff9bed Bug 1495861 - Lazify panic panel and convert it to use FTL r=flod,Gijs
This is the only <radiogroup> and <radio> consumer in browser.xul.
By making the DOM get constructed on demand, we can avoid connecting
radios at startup, and it also gives us a chance to migrate the
strings to Fluent.

Differential Revision: https://phabricator.services.mozilla.com/D24914
2019-04-05 21:16:26 +00:00
Andrew Halberstadt
697b9ce05c Bug 1195299 - [mozharness] Remove copies of mozbase from testing/mozharness r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D22185
2019-04-05 15:39:50 +00:00
Csoregi Natalia
cbdb11c3a7 Backed out changeset e2a6e9aafcf6 (bug 1541147) for gecko decision task failure. CLOSED TREE 2019-04-05 16:19:58 +03:00
Andi-Bogdan Postelnicu
3db9370984 Bug 1541147 - [Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D26145
2019-04-05 12:26:54 +00:00
Csoregi Natalia
13ffe21b06 Backed out changeset 3779175a4d7f (bug 1541147) for gecko decision bustage. CLOSED TREE 2019-04-05 15:53:56 +03:00
Andi-Bogdan Postelnicu
772312fc25 Bug 1541147 - [Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D26145
2019-04-05 12:26:54 +00:00
Bogdan Tara
497d708b3b Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-04-05 14:13:27 +03:00
Bogdan Tara
1aeb7a6046 Backed out 2 changesets (bug 1195299) for l10n bustages a=backout
Backed out changeset 9645ac1a9851 (bug 1195299)
Backed out changeset 4de7f94119fd (bug 1195299)
2019-04-05 14:11:45 +03:00
Andrew Halberstadt
a510b000be Bug 1195299 - [mozharness] Remove copies of mozbase from testing/mozharness r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D22185
2019-04-04 12:34:56 +00:00
Emilio Cobos Álvarez
650743923e Bug 1541660 - Fix clang-format subcommands that don't take a path. r=bastien
We do need some test for this stuff...

Differential Revision: https://phabricator.services.mozilla.com/D26039
2019-04-04 07:14:34 +00:00
Nicholas Cowles
8538a7340f Bug 1529071 - Convert printPreview.dtd to Fluent using conversion script, r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D23766
2019-04-05 05:38:50 +00:00
Chris Manchester
bc38b8b146 Bug 1540941 - Update artifact build routes for shippable builds. r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D26014
2019-04-03 22:14:27 +00:00
Tom Prince
819176f5c2 Bug 1533589: Add win64-aarch64 update verify configuration; r=aki
Differential Revision: https://phabricator.services.mozilla.com/D25834
2019-04-03 20:43:14 +00:00
Henrik Skupin
7b3e5521c6 Bug 1504308 - [mach] Pass path to Python interpreter to python-tests. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D25760
2019-04-03 21:02:55 +00:00
Ciure Andrei
33798e9722 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-04-04 00:57:38 +03:00
Dave Townsend
5ef583d397 Bug 1541086: Remove the embedding code and update the bug components for widget::headless. r=myk r=bdahl
Differential Revision: https://phabricator.services.mozilla.com/D25800
2019-04-02 09:07:54 -07:00
Gurzau Raul
44ee3e55dc Backed out changeset e9bbe52bbd8d (bug 1540788) for breaking bootstrap. a=backout 2019-04-03 05:31:38 +03:00
Tarek Ziadé
74bc7029b2 Bug 1527620 - Add youtube streaming tests - r=whimboo
This patch introduces a new marionette media test along
with a Youtube test.

To run the Youtube streaming test locally:

./mach marionette-test dom/media/test/marionette/test_youtube.py -vv --gecko-log -

Differential Revision: https://phabricator.services.mozilla.com/D23644
2019-04-02 15:09:47 +00:00
Bastien Abadie
d308404e97 Bug 1538770 - Remove _conv_to_abspath from mach static analysis, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D25769
2019-04-02 14:11:33 +00:00
Emilio Cobos Álvarez
0f9ead1392 Bug 1541332 - Remove unused setup feature for file records. r=glandium
Seems unused since bug 1426785, looks like.

Differential Revision: https://phabricator.services.mozilla.com/D25904
2019-04-03 07:31:05 +00:00
Emilio Cobos Álvarez
550bd1188e Bug 1540540 - Do not unconditionally re-extract stuff from mach bootstrap. r=glandium
Keep a checksum to avoid re-extracting artifacts over and over.

In the future we can also check the checksum to avoid downloading the artifact
altogether, maybe.

Differential Revision: https://phabricator.services.mozilla.com/D25542
2019-04-03 07:08:12 +00:00
Mike Hommey
b737b9ed63 Bug 1540788 - Make mach bootstrap choose arm target depending on the rust version. r=nalexander
Bootstrap is happy with rust version 1.32, but that version of rust
doesn't support the thumbv7neon target that we're trying to install
since bug 1539005. So install the armv7 target when rust is version
1.32.

Differential Revision: https://phabricator.services.mozilla.com/D25683
2019-04-03 02:36:20 +00:00
Bastien Abadie
a2aeb89f82 Bug 1538770 - Replace TRY_MODIFIED_FILES by mozversioncontrol usage, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D24876
2019-04-02 14:00:30 +00:00
Narcis Beleuzu
34d6ebe852 Backed out changeset 304b957afe29 (bug 1527620) for marionette-media failures on test_youtube.py. CLOSED TREE 2019-04-02 11:19:26 +03:00
Tarek Ziadé
ca617cd795 Bug 1527620 - Add youtube streaming tests - r=whimboo
This patch introduces a new marionette media test along
with a Youtube test.

To run the Youtube streaming test locally:

./mach marionette-test dom/media/test/marionette/test_youtube.py -vv --gecko-log -

Differential Revision: https://phabricator.services.mozilla.com/D23644
2019-04-02 07:38:41 +00:00
Mike Hommey
f2cdfd162a Bug 1540788 - Make mach bootstrap choose arm target depending on the rust version. r=nalexander
Bootstrap is happy with rust version 1.32, but that version of rust
doesn't support the thumbv7neon target that we're trying to install
since bug 1539005. So install the armv7 target when rust is version
1.32.

Differential Revision: https://phabricator.services.mozilla.com/D25683
2019-04-02 03:31:26 +00:00
Nick Alexander
dc83c80a2c Bug 1525968 - Make local development artifact builds on Android download full build symbols. r=froydnj
We produce two types of build symbol archives in automation:

- "crashreporter-symbols.zip" contains Breakpad-format .sym files
- "crashreporter-symbols-full.zip" contains Breakpad-format .sym files
  and compressed ELF debug symbol .dbg.gz files

Right now, `--enable-artifact-build-symbols` from Bug 1305502
downloads only "crashreporter-symbols.zip".

The Android Studio version of lldb, currently 7.0.0, doesn't support
Breakpad-format .sym files. It does support (uncompressed) ELF debug
symbols.  (Note that gdb isn't supported on Android and hasn't been for
some time.)

This makes ` --enable-artifact-build-symbols` download the full
symbols for Android builds that aren't in automation, to be useful for
debugging Android builds with lldb locally.

Differential Revision: https://phabricator.services.mozilla.com/D19091
2019-03-27 22:37:40 +00:00