corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
905,866 Commits 1 Branch 0 Tags
36e1885b72f1758481a49df7ac057accdfc2e6f0
Commit Graph

189 Commits

Author SHA1 Message Date
Dão Gottwald
d07c1829fd Bug 1959730 - Dispatch TabMove events when moving a group within the tab strip. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D245218
 2025-04-11 15:18:48 +00:00
Stephen Thompson
f2e07044ae Bug 1938424 - metrics event when tabs added to tab group r=dao,jswinarton,tabbrowser-reviewers,extension-reviewers,robwu 
When using the tab context menu or drag-dropping tabs to put them into a group, record a metric for the number of tabs added to the group.

Data Science asked us to launch with this metric disabled so that they could control it using server knobs. They expect a high volume of events, so they expect to only enable this metric for some proportion of users.

I converted the existing `TabMove` event derived from `UIEvent` being fired when tabs change their tab index in the tab strip. `UIEvent` doesn't allow for attaching additional context/detail to the event. `TabMove` is now a `CustomEvent` that provides more context about the moved tab and it fires in more cases -- it's possible for the tab index not to change despite the tab having "moved" into/out of a tab group.

This approach would not capture tab movements that occur across multiple frames/event loop iterations.

Differential Revision: https://phabricator.services.mozilla.com/D244616
 2025-04-11 13:52:22 +00:00
Dão Gottwald
25cb4ac928 Bug 1957434 - Remove workaround for bug 1954163. r=dwalker,tabbrowser-reviewers 
I expect that bug 1955112 was really a duplicate of bug 1954163. Based on that, let's remove this workaround since it's causing trouble.

Differential Revision: https://phabricator.services.mozilla.com/D244564
 2025-04-07 14:54:05 +00:00
Nikki Sharpley
a550747f4f Bug 1956565 - Fix drag to new window for vertical tabs on the right r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D244603
 2025-04-07 14:37:48 +00:00
Stephen Thompson
8f903ac1e3 Bug 1952530 - prevent pinned tabs from dropping outside of pinned area r=dao,tabbrowser-reviewers 
When dragging a pinned tab into an overflowing tab strip, it's possible to drop the pinned tab after the first unpinned tab. This causes one of the pinned tabs to be covered up, it breaks the browser's count of pinned tabs, and it can lead to breakages in drag-drop and the visual rendering of the tab strip.

An additional constraint on the drop position will make sure that a pinned tab can't drop between unpinned tabs and an unpinned tab can't drop between pinned tabs.

Differential Revision: https://phabricator.services.mozilla.com/D242748
 2025-04-01 14:30:25 +00:00
Dão Gottwald
e1ac9df163 Bug 1939518 - Reimplement vertical tab group line to be more consistent with horizontal tabs, and move container tab line to the end of the tab. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242949
 2025-03-27 19:27:07 +00:00
Jeremy Swinarton
34d9e59418 Bug 1938426: Record telemetry event when saving a tab group r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242984
 2025-03-27 15:29:19 +00:00
Nikki Sharpley
52f6f5d35b Bug 1954966 - Update drag behaviour for pinned tabs in expand on hover mode r=sidebar-reviewers,tabbrowser-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D242768
 2025-03-27 13:51:25 +00:00
Dão Gottwald
f9a2272451 Bug 1955361 - Make dropping a link insert the new tab at the correct drop index. r=jswinarton,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242632
 2025-03-25 14:05:34 +00:00
Dão Gottwald
e588889083 Bug 1954341 - Disable tabdrop-samewindow transition for dragged tab groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242642
 2025-03-24 15:51:54 +00:00
Dão Gottwald
9150b253ca Bug 1955112 - Finish tab moving animation when a drag session wasn't ended properly. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242631
 2025-03-24 15:00:26 +00:00
shaneziegler
37f81a03af Bug 1954799 - Move new tab, new window, home button drag/drop handlers out of browser.js into ToolbarDropHandler.sys.mjs r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D242203
 2025-03-21 14:37:32 +00:00
Dão Gottwald
5b7b89286d Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242292
 2025-03-21 12:46:03 +00:00
Stanca Serban
dfcc675d76 Backed out changeset c0e6b3896ea0 (bug 1954865) for causing mochitests failures in browser_standalonePinnedTab.js. 2025-03-21 06:18:11 +02:00
Dão Gottwald
ba53c891e3 Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242292
 2025-03-20 17:46:50 +00:00
Dão Gottwald
dbbbda7272 Bug 1954275 - Expand group when dragging a link over collapsed group label. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241724
 2025-03-20 03:27:20 +00:00
Dão Gottwald
3ba48b6655 Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt 
Differential Revision: https://phabricator.services.mozilla.com/D239937
 2025-03-19 15:07:53 +00:00
Dão Gottwald
6613f880d6 Bug 1954163 - Properly enter and exit moving tab mode when holding or releasing Ctrl key. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241704
 2025-03-19 13:48:53 +00:00
Dão Gottwald
e3e43e49ef Bug 1953214 - When dragging multiple tabs, update multiselection to reflect that pinned and unpinned tabs cannot be mixed. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241203
 2025-03-13 01:45:39 +00:00
Dão Gottwald
9417710fa1 Bug 1953193 - Don't change the selected tab when collapsing a group while dragging it. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241057
 2025-03-12 13:14:29 +00:00
Dão Gottwald
de2f1dd066 Bug 1952495 - Only collapse the dragged group instead of all groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241006
 2025-03-12 13:14:28 +00:00
Dão Gottwald
9754a011cf Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241004
 2025-03-12 11:29:36 +00:00
Alexandru Marc
e03b90be4c Backed out 4 changesets (bug 1953193, bug 1952495, bug 1953249, bug 1908441) for causing bc failures @ browser_bug495058.js CLOSED TREE 
Backed out changeset 0ccf1105aa8c (bug 1953249)
Backed out changeset 2ccc75be9d26 (bug 1953193)
Backed out changeset 02b70f25b783 (bug 1952495)
Backed out changeset 46e2f887cea6 (bug 1908441)
 2025-03-12 12:01:31 +02:00
Dão Gottwald
125ea7264f Bug 1953193 - Don't change the selected tab when collapsing a group while dragging it. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241057
 2025-03-12 08:19:41 +00:00
Dão Gottwald
ddbe423312 Bug 1952495 - Only collapse the dragged group instead of all groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241006
 2025-03-12 08:19:41 +00:00
Dão Gottwald
e53c0fb5e2 Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241004
 2025-03-12 08:19:40 +00:00
Goloman Adrian
168ed8ab47 Backed out 4 changesets (bug 1953193, bug 1908441, bug 1952495, bug 1953249) for causing bc failures @browser_tab_manager_drag.js. CLOSED TREE 
Backed out changeset f8634c4fc742 (bug 1953249)
Backed out changeset 066cede5adcc (bug 1953193)
Backed out changeset 7afc87de4a01 (bug 1952495)
Backed out changeset 2ef344554c4c (bug 1908441)
 2025-03-12 02:44:08 +02:00
Dão Gottwald
db96c7b158 Bug 1953193 - Don't change the selected tab when collapsing a group while dragging it. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241057
 2025-03-11 21:39:06 +00:00
Dão Gottwald
8b9f7d749b Bug 1952495 - Only collapse the dragged group instead of all groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241006
 2025-03-11 21:39:05 +00:00
Dão Gottwald
1642f3dfa4 Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241004
 2025-03-11 21:39:05 +00:00
Dão Gottwald
148b80000f Bug 1952962 - Be less aggressive about scrolling the selected tab into view after dragging and dropping tabs. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240997
 2025-03-11 14:55:48 +00:00
Dão Gottwald
6ff0c3ccca Bug 1952743 - Fix typo. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240883
 2025-03-10 17:09:22 +00:00
Dão Gottwald
f2fda56c21 Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239494
 2025-03-07 01:58:05 +00:00
Goloman Adrian
e5e07cd91e Backed out changeset 58ef1accf6e7 (bug 1908439) for causing mochitest failures @test_tabbrowser.xhtml. CLOSED TREE 2025-03-07 02:42:12 +02:00
Dão Gottwald
0fb65f4185 Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239494
 2025-03-06 22:20:21 +00:00
Dão Gottwald
8bce10cd45 Bug 1951939 - Save and close tab group when middle clicking the group label. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240479
 2025-03-06 13:18:26 +00:00
Nikki Sharpley
3757c82d4f Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D237645
 2025-03-05 14:35:39 +00:00
Jeremy Swinarton
8d67992ca5 Bug 1938423: Add glean metric for tab group create r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239921
 2025-03-04 20:05:19 +00:00
Dão Gottwald
7552ffe539 Bug 1951488 - Fix drag and drop of vertical pinned tabs with minimal movement. r=nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D240349
 2025-03-04 17:01:03 +00:00
Goloman Adrian
1fdec4b2d1 Backed out changeset dfdd36582a66 (bug 1938423) as requested by Aryx for missing data review. CLOSED TREE 2025-03-04 18:42:28 +02:00
Jeremy Swinarton
290d8c4e22 Bug 1938423: Add glean metric for tab group create r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239921
 2025-03-04 14:29:14 +00:00
Goloman Adrian
251308a40f Backed out changeset 9fc3318eca2c (bug 1927258) for causing bc failures @browser_multiselect_tabs_copy_through_drag_and_drop.js. CLOSED TREE 2025-02-27 18:00:00 +02:00
Nikki Sharpley
59098cf49c Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D237645
 2025-02-27 14:25:03 +00:00
Butkovits Atila
c12223cfbb Backed out changeset 7cebb9e8b38c (bug 1927258) for causing failures at browser_tabReorder_vertical.js. CLOSED TREE 2025-02-27 04:26:39 +02:00
Nikki Sharpley
89eef374ea Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D237645
 2025-02-26 19:56:35 +00:00
Dão Gottwald
84d373b75c Bug 1950622 - Correctly decide whether or not multiple selected tabs need to be moved together. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239738
 2025-02-26 14:06:55 +00:00
Cristina Horotan
4dd2dad95f Backed out changeset 85d499c8e0bf (bug 1927258) for causing multiple failures tabbrowser related. CLOSED TREE 2025-02-26 06:42:56 +02:00
Nikki Sharpley
525619dde7 Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D237645
 2025-02-25 22:01:56 +00:00
Dão Gottwald
ebf19a0299 Bug 1950113 - Remove null checks before isTabGroupLabel calls. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239346
 2025-02-24 22:10:49 +00:00
Dão Gottwald
5bb0ca5467 Bug 1950104 - Make #moveTabNextTo handle the vertical pinned tabs container. r=nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D239354
 2025-02-24 17:19:59 +00:00