Commit Graph

55 Commits

Author SHA1 Message Date
Jason Laster
3694ec93d0 Bug 1622996 - Refactor devtools codebase to use optional chaining (automated changes). r=jdescottes
Depends on D67084

Differential Revision: https://phabricator.services.mozilla.com/D67537
2020-03-19 21:13:38 +00:00
Andreea Pavel
0fe6a9f59f Backed out changeset a52a8f4ab189 (bug 1545727) for failing test_tree-view_01.html on a CLOSED TREE 2020-02-25 18:47:21 +02:00
Dickson Tan
56eda08d3a Bug 1545727 - make the JSON tree viewer more accessible. r=Honza
Make the JSON tree view more accessible.

1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.

Differential Revision: https://phabricator.services.mozilla.com/D28274
2020-02-25 12:52:30 +00:00
Julian Descottes
150349d1c5 Bug 1596686 - Use absolute paths for require calls r=gl
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D58243
2019-12-27 12:23:47 +00:00
Razvan Maries
0f5ce38e4c Backed out changeset 14698fa06ab8 (bug 1596686) for causing perma fails on browser_json_refresh.js. 2019-12-27 14:01:24 +02:00
Julian Descottes
3fa1b45876 Bug 1596686 - Use absolute paths for require calls r=gl
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D58243
2019-12-27 09:09:51 +00:00
Julian Descottes
03cdcd7b0a Bug 1593921 - Use eslint-disable-next-line to disable complexity checks in DevTools r=pbro
Using next-line is less error prone for refactorings than wrapping methods with enable/disable blocks.

Differential Revision: https://phabricator.services.mozilla.com/D51782
2019-11-05 14:29:04 +00:00
lloan
06a93a68b8 Bug 1572144 - Support search result navigation. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D43555
2019-09-04 08:31:45 +00:00
Noemi Erli
18b9b8dcd8 Backed out changeset 4e344973418a (bug 1572144) for failing in browser_accessibility_mutations.js CLOSED TREE 2019-09-03 20:12:10 +03:00
lloan
f1ea632b23 Bug 1572144 - Support search result navigation. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D43555
2019-09-03 15:55:02 +00:00
Nicolas Chevobbe
290ba5cb21 Bug 1568779 - Remove editors settings comments in devtools files. r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D42300
2019-08-19 12:48:16 +00:00
Nicolas Chevobbe
9d703719af Bug 1564138 - Fix DevTools PropTypes errors when updating eslint. r=Ola.
Differential Revision: https://phabricator.services.mozilla.com/D38093
2019-07-17 10:35:44 +00:00
Victor Porof
b7732ae890 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Dorel Luca
f833dd86e0 Backed out changeset 4c6d64a74105 (bug 1559317) for DevTools failures in devtools/client/jsonview/test/browser_jsonview_row_selection.js 2019-06-20 07:38:48 +03:00
Yura Zenevich
20409a7c92 Bug 1559317 - prevent on mouse down default action on TreeView's tbody so it never gets focused state. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D35335
2019-06-19 18:15:53 +00:00
Yura Zenevich
264170e470 Bug 1558188 - ensure TreeView's tbody container does not get keyboard focus. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D34351
2019-06-10 18:32:40 +00:00
Yura Zenevich
d558e6b0d5 Bug 1553192 - filter visible rows on demoand instead of when calculating refs. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D32030
2019-05-25 13:46:49 +00:00
Patrick Brosset
d93842478f Bug 1553451 - Lower the eslint complexity level to 20 for devtools and exlude more complex functions; r=jdescottes
We want to go back to ESLint's default complexity level so that newly introduced code is checked for complexity.
At the same time, to make that work, we're excluding all of the more complex functions for now.
We should fix them: make them less complex, and remove the eslint-disable comment.
See bug 1553449 for more information about this.

Differential Revision: https://phabricator.services.mozilla.com/D32139
2019-05-23 09:06:16 +00:00
Mihai Alexandru Michis
c358baf0c3 Backed out changeset 0f9626b48a66 (bug 1553451) for linting failures. CLOSED TREE 2019-05-23 10:58:22 +03:00
Patrick Brosset
18bd75fb8c Bug 1553451 - Lower the eslint complexity level to 20 for devtools and exlude more complex functions; r=jdescottes
We want to go back to ESLint's default complexity level so that newly introduced code is checked for complexity.
At the same time, to make that work, we're excluding all of the more complex functions for now.
We should fix them: make them less complex, and remove the eslint-disable comment.
See bug 1553449 for more information about this.

Differential Revision: https://phabricator.services.mozilla.com/D32139
2019-05-23 07:07:49 +00:00
Yura Zenevich
b6d53668ad Bug 1550542 - fix a number of issues around aria-level within the accessibility tree. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D30594
2019-05-14 12:31:13 +00:00
Yura Zenevich
46844ab918 Bug 1544710 - ensure that selected row is always visible within TreeView after update. Clean up scroll into view operations across all uses of TreeView. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D29342
2019-05-03 04:05:36 +00:00
shindli
35662c4ce4 Backed out changeset 082c0dba73cb (bug 1544710) for causing dt permafailures in devtools/client/netmonitor/test/browser_net_propertiesview-copy.js CLOSED TREE 2019-05-02 15:33:01 +03:00
Yura Zenevich
088be1e4de Bug 1544710 - ensure that selected row is always visible within TreeView after update. Clean up scroll into view operations across all uses of TreeView. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D29342
2019-05-02 04:32:33 +00:00
Yura Zenevich
014cb27f06 Bug 1540601 - Ensuring that TreeView filtering works with keyboard. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D25552
2019-04-10 18:35:58 +00:00
Brindusan Cristian
47ab5aded0 Backed out 4 changesets (bug 1541666, bug 1541446, bug 1540904, bug 1540601) for dt failures at browser_accessibility_node_audit.js
Backed out changeset 7bcd00bbcb71 (bug 1541666)
Backed out changeset a27b2d203885 (bug 1540904)
Backed out changeset 9f43419c7b40 (bug 1541446)
Backed out changeset e3294a1be947 (bug 1540601)
2019-04-10 07:13:57 +03:00
Yura Zenevich
10aba0048d Bug 1540601 - Ensuring that TreeView filtering works with keyboard. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D25552
2019-04-10 00:58:17 +00:00
Laphets
15951fd336 Bug 1442249 - Add Copy context menu to PropertiesView. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D23770
2019-04-04 16:57:22 +00:00
Yura Zenevich
1ff1580b6d Bug 1538281 - make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D24538
2019-04-04 14:12:37 +00:00
Dorel Luca
0d08a12848 Backed out changeset 29af6bb009d2 (bug 1538281) for Devtools failures in devtools/client/jsonview/test/browser_json_refresh.js. CLOSED TREE 2019-04-03 19:47:57 +03:00
Yura Zenevich
0d6d8515d5 Bug 1538281 - make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D24538
2019-04-03 14:36:42 +00:00
Coroiu Cristina
7043544187 Backed out changeset d124ebd3b9eb (bug 1538281) for mochitest failures e.g. devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js on a CLOSED TREE 2019-04-03 14:32:00 +03:00
Yura Zenevich
27d11f65d7 Bug 1538281 - make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D24538
2019-04-03 00:36:03 +00:00
Yura Zenevich
130e42e0a7 Bug 1520107 - fix focus and keyboard triggered context menu handling in a11y panel tree. r=gl
MozReview-Commit-ID: 2kzvA2Eb1eF

Differential Revision: https://phabricator.services.mozilla.com/D16986
2019-01-20 04:26:17 +00:00
Brindusan Cristian
76d20e76db Backed out changeset 50cc5c5bd5ef (bug 1520107) for mochitest failures at test_accessible_row_context_menu.html. CLOSED TREE 2019-01-19 20:57:45 +02:00
Yura Zenevich
4358b687fe Bug 1520107 - fix focus and keyboard triggered context menu handling in a11y panel tree. r=gl
MozReview-Commit-ID: 2kzvA2Eb1eF

Differential Revision: https://phabricator.services.mozilla.com/D16986
2019-01-19 18:13:55 +00:00
Oana Pop Rus
1330f0f19a Backed out changeset 611bd5949e83 (bug 1520107) for dt failures, on a CLOSED TREE. 2019-01-19 07:27:52 +02:00
Yura Zenevich
6fb9316894 Bug 1520107 - fix focus and keyboard triggered context menu handling in a11y panel tree. r=gl
MozReview-Commit-ID: 2kzvA2Eb1eF

Differential Revision: https://phabricator.services.mozilla.com/D16986
2019-01-18 20:00:47 +00:00
Mark Banner
3d6aaad3f5 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389
2018-10-19 12:55:39 +00:00
Julian Descottes
8f3d04cda8 Bug 1471540 - Make DevTools code compatible with new eslint-plugin-react;r=standard8
MozReview-Commit-ID: 1flBkghZw9
2018-07-20 14:26:45 +02:00
Micah Tigley
4ca55edcea Bug 1450930 - The Page Down/Up keys doesn't work after pressing Home/End keys. r=Honza,yzen 2018-06-06 11:10:49 -04:00
Julian Descottes
82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Yura Zenevich
50aed3b89e Bug 1456756 - select parent row if available when ArrowLeft is pressed on collapsed or non-expandable row. r=Honza
MozReview-Commit-ID: 74LXTQcj8H9
2018-05-31 00:10:48 -04:00
J. Ryan Stinnett
8d1c817851 Bug 1443081 - Apply spacing via eslint --fix for DevTools. r=jdescottes
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
Yura Zenevich
06660e0dec Bug 1428436 - further improving TreeView accessibility. r=Honza
MozReview-Commit-ID: 8plUv815ErP
2018-02-12 22:32:53 -05:00
Jan Odvarko
f2c6366eab Bug 1427718 - Display multiple headers with the same name; r=rickychien
MozReview-Commit-ID: 2nV51xLyCni
2018-01-17 09:56:09 +01:00
Oriol Brufau
c5a0bafd5c Bug 1416394 - Scroll row into view using scrollIntoView. r=Honza
MozReview-Commit-ID: KoTvLkZA3CL
2017-11-24 16:49:01 +01:00
Michael Ratcliffe
fdb9244b1b Bug 1413860 - Shared components to use prop-types and react-dom-factories r=nchevobbe
@nchevobbe: Please wait for a green try before reviewing this.

MozReview-Commit-ID: 9SLEHAq0IQQ
2017-11-03 13:34:41 +00:00
Narcis Beleuzu
6f6d04c41c Backed out changeset 9029ee56b1ad (bug 1413860) for mochitest clipboard failures on browser_jsterm_selfxss.js. r=backout on a CLOSED TREE 2017-11-13 14:16:40 +02:00
Michael Ratcliffe
658587160e Bug 1413860 - Shared components to use prop-types and react-dom-factories r=nchevobbe
@nchevobbe: Please wait for a green try before reviewing this.

MozReview-Commit-ID: 9SLEHAq0IQQ
2017-11-03 13:34:41 +00:00