- Registers the a new review checker sidebar using `registerPrefSidebar` that will display if `browser.shopping.experience2023.integratedSidebar` is enabled.
- Hides any open review checker sidebars if the pref changes.
- Adds `reviewchecker` to the sidebar revamp tools pref.
Note: this only adds the sidebar tool, it will not load anything as the actors aren't setup yet.
Differential Revision: https://phabricator.services.mozilla.com/D221362
For extension links, AccessibilityUtils was checking the `<a>` element, rather than its container. Moving `tabIndex` over to the inner "link" seemed to remedy this.
For radio inputs, we should not be checking `tabIndex` as `<moz-radio-group>` only allows focus on the active radio option (by design).
Differential Revision: https://phabricator.services.mozilla.com/D222670
Not sure if this is better but this solves the issue of having to
duplicate the custom colors stuff to keep them in sync... Thoughts?
Differential Revision: https://phabricator.services.mozilla.com/D221963
Remove the sidebar-border variable because it's unused (and it's not one
of the properties that get plumbed down anyways).
Rely on browser.xhtml's background to avoid having to plumb down the
system theme colors. Alternatively we could try to plumb these down, or
add a media query like:
```
@media not ((prefers-contrast) or (-moz-platform: linux) or ((-moz-platform: macos) and (-moz-bool-pref: "browser.theme.macos.native-theme"))) {
/* Duplicate browser-custom-colors.css */
}
```
But that's kind of unwieldy, to the point that we should move
browser-custom-colors.css import to browser-shared and use the same if
we do it, probably, so it's easy to keep them in sync...
Differential Revision: https://phabricator.services.mozilla.com/D221962
This:
* Works around the WebRender issue from bug 1916599.
* Might be a bit simpler to reason about (the sidebar special-cases to
keep the buttons at the right edge are a bit unfortunate but...).
* Avoids the squishiness that Markus and Sam were discussing in
#gfx-firefox).
There's still some flickering on the <browser> element, but I have a
good idea of how to fix it (basically, we're triggering resizes from
layout, but for remote iframes we really don't want to do that, because
it can cause raciness / flickering as observed).
Differential Revision: https://phabricator.services.mozilla.com/D221351
Depends on D220846
This looks simpler, a lot smoother on my machine, and shouldn't cause
content resizes. It also doesn't set custom properties on the root which
causes an expensive restyle, specially on big documents (like with many
tabs open).
Maybe eventually we can use view transitions for this, seems like a good
use-case.
We need to move the background to `#sidebar-main` rather than the
wrapper because during the shrinking animation the wrapper is small and
the `#sidebar-main` element would be transparent, which we don't want.
Differential Revision: https://phabricator.services.mozilla.com/D220846
Moves the sidebar padding into the moz-buttons.
This results in an accessibility improvement by giving users a larger
click surface for these buttons.
These changes prevent visual regressions in the sidebar by ensuring
visual consistency in the following cases:
- Pinned tabs in the expanded and collapsed states when using vertical
tabs
- Pinned tabs in the expanded and collapsed states when using
horizontal tabs
- New tab button, actual tabs, and action lists in the expanded and
collapsed states when using vertical tabs
Differential Revision: https://phabricator.services.mozilla.com/D219064
This:
* Works around the WebRender issue from bug 1916599.
* Might be a bit simpler to reason about (the sidebar special-cases to
keep the buttons at the right edge are a bit unfortunate but...).
* Avoids the squishiness that Markus and Sam were discussing in
#gfx-firefox).
There's still some flickering on the <browser> element, but I have a
good idea of how to fix it (basically, we're triggering resizes from
layout, but for remote iframes we really don't want to do that, because
it can cause raciness / flickering as observed).
Differential Revision: https://phabricator.services.mozilla.com/D221351
This looks simpler, a lot smoother on my machine, and shouldn't cause
content resizes. It also doesn't set custom properties on the root which
causes an expensive restyle, specially on big documents (like with many
tabs open).
Maybe eventually we can use view transitions for this, seems like a good
use-case.
We need to move the background to `#sidebar-main` rather than the
wrapper because during the shrinking animation the wrapper is small and
the `#sidebar-main` element would be transparent, which we don't want.
Differential Revision: https://phabricator.services.mozilla.com/D220846
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode
Differential Revision: https://phabricator.services.mozilla.com/D217161
On dates like August 31st, in order to create a "Last Month" card, we should use a date near the *end* of the previous month - rather than the beginning - in order to avoid exceeding 60 days of history. (At some point, we can hopefully expand or remove that limit.)
Differential Revision: https://phabricator.services.mozilla.com/D220920
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode
Differential Revision: https://phabricator.services.mozilla.com/D217161
This is also simpler because it makes various pref checks unneeded
(since browser-custom-colors.css gets loaded after this stylesheet).
Differential Revision: https://phabricator.services.mozilla.com/D220771
Add new SidebarManager singleton with init on import that allows setting user branch prefs specified in the nimbus variable for sidebar.
Differential Revision: https://phabricator.services.mozilla.com/D219903
