corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
890,588 Commits 1 Branch 0 Tags
34caedb5e06d01b718ee88c54aaa73e65e5596d9
Commit Graph

791 Commits

Author SHA1 Message Date
Gijs Kruitbosch
a42bb0c9ac Bug 1908785 - driveby: remove browser.preferences.search as there is no reason to disable search in settings, r=mconley 
This was the feature flag behind which the settings page's 'search' functionality was written.
It's been there for years now, and it is high time to clean this up.

Differential Revision: https://phabricator.services.mozilla.com/D217034
 2024-07-19 18:46:25 +00:00
Malte Juergens
7d71bae2f3 Bug 1907517 - Update strings in HTTPS-Only settings to make users aware of HTTPS-First r=freddyb,fluent-reviewers,settings-reviewers,mossop 
In light of us being in the process of enabling HTTPS-First by default, these strings have been proposed by content design to make it more clear to the user that if they disable HTTPS-Only, upgrades may still be happening.

The description generally has been updated, but the labels for the radio buttons only get the new strings in this patch when HTTPS-First is also enabled.

Differential Revision: https://phabricator.services.mozilla.com/D216381
 2024-07-19 12:34:09 +00:00
Moritz Beier
12220c0dde Bug 1906875 - Remove the old search engine selector from the search service. r=Standard8,extension-reviewers,urlbar-reviewers,settings-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D216047
 2024-07-15 11:15:22 +00:00
Mark Striemer
3550f06384 Bug 1900124 - Part 2: Use moz- components, card styling in Experimental section r=Mardak,reusable-components-reviewers,settings-reviewers,fluent-reviewers,desktop-theme-reviewers,flod,Gijs,dao 
Depends on D215262

Differential Revision: https://phabricator.services.mozilla.com/D215263
 2024-07-09 23:14:56 +00:00
Joel Maher
d70349f2c5 Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D214969
 2024-07-09 13:01:55 +00:00
Gijs Kruitbosch
a6832d7418 Bug 1904478 - clean up leftover reference to now non-existing fluent string, r=settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D214798
 2024-06-25 10:50:28 +00:00
Gijs Kruitbosch
729e9e5b81 Bug 1903820 - update intro language in nightly experiments page, r=settings-reviewers,fluent-reviewers,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D214439
 2024-06-24 23:30:05 +00:00
Hanna Jones
f26d450f6e Bug 1901264 - update settings search to work for all moz- prefixed custom elements r=reusable-components-reviewers,settings-reviewers,mstriemer 
This patch:

* adds some simple logic to settings search that should prevent us from having to manually allow searching in every moz- prefixed custom element
* cleans up the existing settings search logic slightly for improved readability
* expands the tests to check searching for text in the shadow DOM of additional moz- prefixed custom elements

Differential Revision: https://phabricator.services.mozilla.com/D214141
 2024-06-19 21:58:14 +00:00
Sean
a41f1de616 Bug 1900672 - DNS-over-HTTPS (DoH, TRR) provider OFF should default to fallbackProviderURI r=necko-reviewers,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D213838
 2024-06-18 14:15:43 +00:00
Tim Huang
ac6f31da0d Bug 1898255 - Enable third-party cookie deprecation in ETP strict and PBM. r=anti-tracking-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,pbz,mak 
Differential Revision: https://phabricator.services.mozilla.com/D212547
 2024-06-12 12:08:54 +00:00
Emilio Cobos Álvarez
3008f7bfed Bug 1901194 - Fix a test I missed. 
MANUAL PUSH: Trivial fix CLOSED TREE
 2024-06-07 15:35:29 +02:00
Emilio Cobos Álvarez
9e7668fdbe Bug 1901194 - Remove useless tail-with-learn-more class on <span>s. r=settings-reviewers 
It doesn't do anything on a span so it's just confusing.

Differential Revision: https://phabricator.services.mozilla.com/D212902
 2024-06-07 12:11:23 +00:00
Ed Lee
6c8091193e Bug 1894999 - Expose chat prefs via experiments featuregate r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D209639
 2024-06-07 04:28:22 +00:00
Barret Rennie
871e74ca58 Bug 1829412 - Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley 
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.

The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.

Differential Revision: https://phabricator.services.mozilla.com/D212318
 2024-06-06 14:42:00 +00:00
Gijs Kruitbosch
9962ebd5a0 Bug 1896187 - make FeatureGate 'features to try' page use the same jexl filtering as Nimbus, r=barret,settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D210086
 2024-06-05 13:10:49 +00:00
Sean
05c9da18d0 Bug 1861285 - DNS-over-HTTPS (DoH, TRR) provider change from default to increased/max protection set network.trr.uri to fallbackProviderURI while maintaining other mode changes r=edgul,valentin,settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D209805
 2024-06-05 13:03:11 +00:00
Henry Wilkes
27df525213 Bug 1851618 - Allow removing packaged locales from requestedLocales. r=settings-reviewers,eemeli,Gijs 
We open up the UI to allow the user to remove locales from their
requestedLocales list, except for the default locale.

Differential Revision: https://phabricator.services.mozilla.com/D209930
 2024-05-29 11:10:18 +00:00
Harshit Sohaney
684fe813a7 Bug 1892947 - (part 2) tests for clear cookies and site data on shutdown pref alignment with new clear history dialog. r=pbz,settings-reviewers 
Depends on D208410

Differential Revision: https://phabricator.services.mozilla.com/D208411
 2024-05-25 15:19:13 +00:00
Robin Steuber
819ead360b Bug 1875502 - Pre: Make UpdateManager's history functions async r=nalexander,settings-reviewers,application-update-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209113
 2024-05-16 20:01:48 +00:00
Sandor Molnar
5aee31029c Backed out 23 changesets (bug 1887980, bug 1875502) for causing xpc failures @ toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js CLOSED TREE 
Backed out changeset fb53b5f266e2 (bug 1875502)
Backed out changeset 9157c611617d (bug 1875502)
Backed out changeset 924b7230a45e (bug 1875502)
Backed out changeset d83fa2a0c858 (bug 1887980)
Backed out changeset c538de825468 (bug 1875502)
Backed out changeset a6c1ee51eadb (bug 1875502)
Backed out changeset 47bc52e77563 (bug 1875502)
Backed out changeset 54d53947927a (bug 1875502)
Backed out changeset 6bc2601a69bd (bug 1875502)
Backed out changeset 917a4aed3b4b (bug 1875502)
Backed out changeset afa0353ca6a2 (bug 1875502)
Backed out changeset 42ad3c8fe41e (bug 1875502)
Backed out changeset b5f4c67a548b (bug 1875502)
Backed out changeset d47c42d117e3 (bug 1875502)
Backed out changeset a33c98ac118c (bug 1875502)
Backed out changeset b57983b426ba (bug 1875502)
Backed out changeset a013811a156b (bug 1875502)
Backed out changeset 05b53ed47055 (bug 1875502)
Backed out changeset aa0eee306544 (bug 1875502)
Backed out changeset 5736dca8c05b (bug 1875502)
Backed out changeset 6e60ddb35c98 (bug 1875502)
Backed out changeset fcb327ff8717 (bug 1875502)
Backed out changeset 1950b330d253 (bug 1875502)
 2024-05-16 00:21:12 +03:00
Robin Steuber
d6a6cc248d Bug 1875502 - Pre: Make UpdateManager's history functions async r=nalexander,settings-reviewers,application-update-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209113
 2024-05-15 17:06:12 +00:00
Nipun Shukla
a788d363d7 Bug 1893341 - Change Firefox launch on login to use Windows StartupTask functions on MSIX r=nalexander,nrishel,settings-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D208567
 2024-05-15 15:34:43 +00:00
Tamas Szentpeteri
833395877b Backed out 2 changesets (bug 1893341, bug 1895744) for causing bc failures in browser_windows_launch_on_login_msix.js. CLOSED TREE 
Backed out changeset ce5384469c24 (bug 1893341)
Backed out changeset 658645fa9303 (bug 1895744)
 2024-05-15 11:24:17 +03:00
Nipun Shukla
3e3ebab8c6 Bug 1893341 - Change Firefox launch on login to use Windows StartupTask functions on MSIX r=nalexander,nrishel,settings-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D208567
 2024-05-15 02:54:55 +00:00
Javier Rueda
03ec1bde2b Bug 1896360 - Disable Add button when no language is selected. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D210206
 2024-05-13 21:31:26 +00:00
Mike Conley
f680db2687 Bug 1892959 - Stub out initial section for backup management within about:preferences. r=backup-reviewers,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D209055
 2024-05-08 20:37:04 +00:00
Sidharth Sachdev
98e0d52b70 Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-07 04:21:31 +00:00
Emilio Cobos Álvarez
45b669a6a7 Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 
Stop supporting following the system preference, but keep macOS users
able to switch to just text controls (accessibility.tabfocus=1) in the
settings.

Change the meaning of the "Use the tab key to move focus between form
controls and links" checkbox in the Firefox settings, which was
introduced in bug 1628476 to override the system setting.

The intention, I think was that this checkbox being off resulted in
"follow the system" behavior, but that didn't quite happen due to a bug
in the preferences code (this[1] won't unset the pref, because of
this[2], which means we'll just return 0).

This patch changes it so that the checkbox instead always ignores the
system setting. There will no longer be a Firefox setting (neither in
the UI nor on about:config) that means "follow system setting".

This allows us to somewhat simplify the approach compared to the
previous patch in D196110, and keep the accessibility.tabfocus working
as the source of truth without a migration.

In the future, we can think of migrating accessibility.tabfocus to a
boolean pref, which would allow us to do the cleanups to the preferences
code that D196110 did.

[1]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/browser/components/preferences/main.js#2252
[2]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/toolkit/content/preferencesBindings.js#450,483

Differential Revision: https://phabricator.services.mozilla.com/D208602
 2024-05-03 23:10:47 +00:00
Sandor Molnar
781c22a42f Backed out 2 changesets (bug 1892947) due to critical failure with clear on shutdown CLOSED TREE 
Backed out changeset 5c4c36caa85d (bug 1892947)
Backed out changeset eeabe25b2ac3 (bug 1892947)
 2024-05-03 19:56:31 +03:00
Tamas Szentpeteri
453ac165cb Backed out changeset 644738c3ccfe (bug 1036966) for causing mochitest failures in test_tabindex.html. CLOSED TREE 2024-05-03 04:18:36 +03:00
Emilio Cobos Álvarez
87eeb156af Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 
Stop supporting following the system preference, but keep macOS users
able to switch to just text controls (accessibility.tabfocus=1) in the
settings.

Change the meaning of the "Use the tab key to move focus between form
controls and links" checkbox in the Firefox settings, which was
introduced in bug 1628476 to override the system setting.

The intention, I think was that this checkbox being off resulted in
"follow the system" behavior, but that didn't quite happen due to a bug
in the preferences code (this[1] won't unset the pref, because of
this[2], which means we'll just return 0).

This patch changes it so that the checkbox instead always ignores the
system setting. There will no longer be a Firefox setting (neither in
the UI nor on about:config) that means "follow system setting".

This allows us to somewhat simplify the approach compared to the
previous patch in D196110, and keep the accessibility.tabfocus working
as the source of truth without a migration.

In the future, we can think of migrating accessibility.tabfocus to a
boolean pref, which would allow us to do the cleanups to the preferences
code that D196110 did.

[1]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/browser/components/preferences/main.js#2252
[2]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/toolkit/content/preferencesBindings.js#450,483

Differential Revision: https://phabricator.services.mozilla.com/D208602
 2024-05-02 22:19:53 +00:00
Harshit Sohaney
d31c7d1d35 Bug 1892947 - (part 2) tests for clear cookies and site data on shutdown pref alignment with new clear history dialog. r=pbz,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D208411
 2024-04-26 08:04:06 +00:00
Nipun Shukla
87498965b0 Bug 1888263 - Disable Firefox launch on login for MSIX builds r=nrishel,settings-reviewers,mconley,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207595
 2024-04-23 14:08:52 +00:00
Dale Harvey
5f9ad2e51c Bug 1871206 - Implement secondary actions for the urlbar. r=mak,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203381
 2024-04-23 11:33:33 +00:00
Harshit Sohaney
6e16821d9b Bug 1890595 - Add longer timeout for new clear history dialog test. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D207634
 2024-04-23 10:32:58 +00:00
Masatoshi Kimura
4d07b74011 Bug 1891926 - Make "network.proxy.system_wpad.allowed" actually work. r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D207701
 2024-04-17 14:49:40 +00:00
Harshit Sohaney
1e60c930a9 Bug 1881797 - (part 3) Testing for storage permission clearing in the new clear history dialog. r=pbz,settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D204919
 2024-04-09 15:39:32 +00:00
Joel Maher
a1c9f109b8 Bug 1889412 - skip 25+ minute manifests on asan/tsan. r=aryx,extension-reviewers,settings-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D206512
 2024-04-03 17:46:29 +00:00
Andrew Creskey
98f23f49ec Bug 1861808 - Firefox incorrectly says DNS-over-HTTPS is active when disabled by parental controls r=necko-reviewers,settings-reviewers,valentin 
We ensure that parental controls are tested in the UI.

Differential Revision: https://phabricator.services.mozilla.com/D203035
 2024-03-25 15:38:54 +00:00
Anna Yeddi
f8da9a80ab Bug 1886268 - Add exceptions from a11y_checks for two clicks on non-interactive elements in Settings UI. r=settings-reviewers,Gijs 
The `browser/browser/components/preferences/tests/browser_subdialogs.js` sends two clicks on the following non-interactive element to check the closing of the opened dialog using an alternative way of the popup dismissal is working as expected:
1. [label with "dialogTitle" class](https://searchfox.org/mozilla-central/rev/09b59a7de6848639f27297888889a06e97561074/browser/components/preferences/tests/browser_subdialogs.js#407-414) to confirm nothing happens
1. [overlay background with "dialogTemplate" ID](https://searchfox.org/mozilla-central/rev/09b59a7de6848639f27297888889a06e97561074/browser/components/preferences/tests/browser_subdialogs.js#416-435) to confirm clicking outside of the dialog does, in fact, closes it.

For users of keyboards and assistive technology another way like pressing `Esc` key is available to dismiss the dialog, thus we need to add exceptions from the a11y_checks for this tests via `setEnv` and remove the `fail-if` notation from its test manifest.

Differential Revision: https://phabricator.services.mozilla.com/D205120
 2024-03-20 23:27:36 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao 
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
 2024-03-18 09:15:07 +00:00
Mark Banner
f65518c3c0 Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak 
Differential Revision: https://phabricator.services.mozilla.com/D203026
 2024-03-13 14:51:06 +00:00
Javier Rueda
5e40504c38 Bug 1884135 - Button to add exception in Manage DNS-over-HTTPS subdialog is enabled when input box is empty. r=mossop,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D204033
 2024-03-11 13:21:37 +00:00
Dale Harvey
8b8718db79 Bug 1883776 - Remove hardcoded detection of trending engines. r=Standard8,settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D203896
 2024-03-07 21:58:01 +00:00
Javier Rueda
07a8724602 Bug 1826095 - Add tests for DoH exception list UI. r=mossop,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203921
 2024-03-07 15:40:26 +00:00
Dave Townsend
b7532be063 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 18:28:32 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE 
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
 2024-03-01 18:25:05 +02:00
Dave Townsend
b6eba7ca5c Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 15:20:18 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE 
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
 2024-03-01 12:58:03 +02:00
Dave Townsend
2a38962b3a Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 10:10:09 +00:00