Commit Graph

361 Commits

Author SHA1 Message Date
Goloman Adrian
4537c22f59 Bug 1781272 - fixed typo in manifest file. a=typo-fix 2024-12-31 21:24:38 +02:00
Goloman Adrian
a577810689 Bug 1781272 - disable browser_pocket_panel.js for causing frequent failures on macOS shippable. r=intermittent-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D232908
2024-12-31 17:46:06 +00:00
Mark Banner
d0718e3c69 Bug 1937739. r=frontend-codestyle-reviewers,perftest-reviewers,mossop,sparky
Differential Revision: https://phabricator.services.mozilla.com/D232598
2024-12-19 17:05:08 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Mark Banner
aabcf18c26 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop
Differential Revision: https://phabricator.services.mozilla.com/D221443
2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
2024-09-12 20:45:28 +03:00
Mark Banner
e3981e1099 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop
Differential Revision: https://phabricator.services.mozilla.com/D221443
2024-09-12 16:41:58 +00:00
Gijs Kruitbosch
e4e1ec3e52 Bug 1881800 - chrome/system-privileged XHR should not use credentials, r=peterv,extension-reviewers,application-update-reviewers,decoder,mossop,robwu,releng-reviewers,bytesized,jcristau
Differential Revision: https://phabricator.services.mozilla.com/D203334
2024-03-26 16:50:45 +00:00
Iulian Moraru
b12ba0dce4 Backed out 2 changesets (bug 1881800) for causing non unified build bustages on nsIPrincipal.h. CLOSED TREE
Backed out changeset 1710585070f0 (bug 1881800)
Backed out changeset 9da17ae527f3 (bug 1881800)
2024-03-26 15:46:50 +02:00
Gijs Kruitbosch
894c35ee8f Bug 1881800 - chrome/system-privileged XHR should not use credentials, r=peterv,extension-reviewers,application-update-reviewers,decoder,mossop,robwu,releng-reviewers,bytesized,jcristau
Differential Revision: https://phabricator.services.mozilla.com/D203334
2024-03-26 12:38:54 +00:00
Barret Rennie
d2c69fe517 Bug 1883682 - Migrate saveToPocket feature to use setPref r=thecount,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D204520
2024-03-25 14:02:33 +00:00
Dave Townsend
08d4362e96 Bug 1864896: Autofix unused function arguments (browser/components/pocket). r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D202951
2024-03-19 09:36:34 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00
Natalia Csoregi
e0993839dd Backed out changeset ebcab57cf7cd (bug 1883682) for causing newtab failures. CLOSED TREE 2024-03-13 21:19:25 +02:00
Barret Rennie
b8d5ffadf3 Bug 1883682 - Migrate saveToPocket feature to use setPref r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D204520
2024-03-13 18:11:30 +00:00
scottdowne
230f317398 Bug 1879587 - Update Pocket dev dependencies and build bundle from resulting dependencies update r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D201244
2024-02-13 02:38:48 +00:00
Mark Banner
6e047dd9dc Bug 1778106 - Move Pocket code to use mjs files, rather than defining sourceType for ESLint. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D200604
2024-02-09 17:33:23 +00:00
Mark Banner
c4f2b2d3ac Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200582
2024-02-07 08:55:29 +00:00
Cristian Tuns
8829a8d6c5 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
2024-02-07 01:26:39 -05:00
Mark Banner
7fdf48bc1f Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200582
2024-02-06 22:32:51 +00:00
Erik Nordin
857bffe429 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
2024-01-19 02:15:33 +00:00
Chris H-C
0c75314d46 Bug 1857324 - Remove old pocket_button ping r=thecount
Depends on D191341

Differential Revision: https://phabricator.services.mozilla.com/D191238
2023-10-26 07:20:43 +00:00
Chris H-C
3354d4b582 Bug 1857324 - Add new "pocket-button" ping r=thecount
Depends on D190857

Differential Revision: https://phabricator.services.mozilla.com/D190858
2023-10-26 07:20:42 +00:00
Emilio Cobos Álvarez
edbe0ff9a0 Bug 1857522 - Don't ignore pseudo-classes in max-nesting-depth limit. r=Gijs
As that allows you to get around the lint with :is() trivially.

Differential Revision: https://phabricator.services.mozilla.com/D190311
2023-10-08 23:07:36 +00:00
Emilio Cobos Álvarez
ede2cef8c9 Bug 1857522 - Reduce max nesting depth to 3. r=Gijs
That still doesn't trigger on the code in comment 2, so that is a bit
confusing and needs investigation.

Differential Revision: https://phabricator.services.mozilla.com/D190310
2023-10-08 22:33:39 +00:00
Sylvestre Ledru
2e0e132821 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Emilio Cobos Álvarez
b12fe82645 Bug 1853652 - Use image-set more in pocket. r=desktop-theme-reviewers,dao
Depends on D188453

Differential Revision: https://phabricator.services.mozilla.com/D188454
2023-09-18 12:57:26 +00:00
Marco Bonardo
6874dffc71 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
scottdowne
e3d4ec5e2f Bug 1849880 - Save to Pocket fixing eslint dependencies warning around useEffect. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D186975
2023-08-31 00:59:04 +00:00
Gavin Suntop
de3446bf6c Bug 1845563 - Clean up client side Pocket API r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D184610
2023-07-31 16:47:09 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Gavin Suntop
306a02ba53 Bug 1838478 - Remove topics from STP r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D180966
2023-07-05 16:32:36 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Gavin Suntop
6b000ac903 Bug 1837224 - Remove suggested articles from STP r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D180235
2023-06-13 18:04:46 +00:00
Gijs Kruitbosch
7411c97ed6 Bug 1832765 - start linting scss across the tree in our standard config, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D178532
2023-05-30 22:41:22 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D177423
2023-05-24 15:52:34 +00:00
Mark Banner
b61a6a6502 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
anwar
1d2e079021 Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu
Differential Revision: https://phabricator.services.mozilla.com/D176459
2023-05-02 16:13:24 +00:00
Bilal
f49ad16881 Bug 1817002 - ESMified browser/components/pocket/content. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175700
2023-04-19 19:18:57 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D172850
2023-03-30 20:51:58 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
2023-03-29 07:34:10 +00:00
Mark Banner
25bf79be3b Bug 1823763 - Convert consumers of toolkit/components/reader/ to import ES modules directly. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D173184
2023-03-23 12:11:44 +00:00
Francesco Lodolo (:flod)
fa28bcb157 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D172643
2023-03-15 17:00:48 +00:00