Commit Graph

550 Commits

Author SHA1 Message Date
Norisz Fay
6a89206409 Backed out changeset f6085a9f4c95 (bug 1904657) for causing newtab failures 2024-07-16 00:54:15 +03:00
Amy Churchwell
251953d0da Bug 1904657 - Add topic labels to Pocket cards. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D216429
2024-07-15 20:48:38 +00:00
Maxx Crawford
55169a87ea Bug 1907419 - Adjust top sites hover padding spacing for thumbs up/down compact view r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D216343
2024-07-15 19:38:04 +00:00
Nathan Barrett
cb1f62c3b5 Bug 1904656 - Create modal for topic selection r=home-newtab-reviewers,frontend-codestyle-reviewers,amy
Differential Revision: https://phabricator.services.mozilla.com/D215700
2024-07-15 13:42:05 +00:00
Maxx Crawford
95152e8414 Bug 1900832, Bug 1896862, Bug 1901156 - CSS adjustments for HNT weather widget r=home-newtab-reviewers,amy,nbarrett
This patch addresses three seperate issues:
- (Bug 1900832) Adjust the Weather widget to push down the page content on HNT page when the search section is disabled
- (Bug 1896862) Move the Weather widget component in the Base component so that it reflects the expected focus: tab order when navigating by keyboard
- (Bug 1901156) Adjust the Weather widget to hide current conditions symbol and detailed weather information text on medium size screens to not overlap the search logo

Differential Revision: https://phabricator.services.mozilla.com/D216057
2024-07-12 15:49:53 +00:00
Maxx Crawford
a73bec65fc Bug 1905258 - Add tests for Notifications and Thumbs up/down UI r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D215432
2024-07-09 15:43:06 +00:00
Maxx Crawford
c5283f51cc Bug 1905319 - Adjust new tab page elements spacing to be more consistent r=home-newtab-reviewers,thecount
This patch changes the spacing/padding/margins of the major sections if the thumbs up/down UI is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D215551
2024-07-03 21:24:49 +00:00
Maxx Crawford
c675d51427 Bug 1905259 - Add updated thumbs up and down icons, add CSS animation to active state r=home-newtab-reviewers,desktop-theme-reviewers,thecount,dao
Differential Revision: https://phabricator.services.mozilla.com/D215650
2024-07-03 19:29:27 +00:00
Maxx Crawford
5b142ed5e6 Bug 1902099 - Add thumbs up/down buttons to Recommended Story cards r=home-newtab-reviewers,fluent-reviewers,bolsson,thecount
Differential Revision: https://phabricator.services.mozilla.com/D213650
2024-06-28 01:41:21 +00:00
Nathan Barrett
b5cd40009b Bug 1903354 - Change weather error text color to grey r=desktop-theme-reviewers,home-newtab-reviewers,dao,thecount
Differential Revision: https://phabricator.services.mozilla.com/D214890
2024-06-27 18:41:40 +00:00
Shane Hughes
93a3b7524c Bug 1899030 - Part 4: Remove unused ASRouterButton import in newtab. r=omc-reviewers,home-newtab-reviewers,nbarrett,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D211672
2024-06-19 19:45:02 +00:00
Daniel Holbert
a616266708 Bug 1901904: Improve centering for the newtab 3-dot-menu icon within its button. r=home-newtab-reviewers,maxx
Previously we had a background-position of 55%, which is sorta close to center,
but far enough away from center that it placed the image a full pixel away from
the perfect center position at certain zoom or HiDPI levels, which looked
awkward (e.g. with 9px of space to the left of the image, and 7px of space to
the right of it, when perfect-centering would have 8px on either side).

I suspect the reason we were using 55% (rather than 'center') was to be a
"tiebreaker" in favor of a slight rightwards bias when there's an odd number of
extra pixels to use for spacing -- in that case, biasing to the right makes
sense (N+1px on the left, Npx on the right).  The new background-position value
of 50.1% should still give us that behavior, without having the unwanted side
effect of nudging us off of the perfectly-centered position in cases where we
could put the same number of pixels on either side.

Differential Revision: https://phabricator.services.mozilla.com/D213444
2024-06-17 20:52:59 +00:00
Maxx Crawford
324ac7474d Bug 1902154 - Fix contrast issue with Weather error message when wallpaper is selected r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D213689
2024-06-17 19:40:32 +00:00
scottdowne
41900ed75c Bug 1902948 - Home and newtab fixing RTL issues in weather and wallpapers r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D213907
2024-06-17 15:52:05 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
2024-06-17 14:53:04 +00:00
Amy Churchwell
06609d7eb8 Bug 1900423 - Refine nested wallpapers styles. r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D212611
2024-06-14 17:13:58 +00:00
scottdowne
5227f8003a Bug 1899788 - Home and newtab adding some Nimbus values to wallpaper feature highlight. r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212746
2024-06-06 23:59:22 +00:00
scottdowne
043fca7a10 Bug 1900931 - Home and newtab fixing topsite pinned icon contrast with wallpaper r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212760
2024-06-06 16:50:41 +00:00
Maxx Crawford
b2b64dd23a Bug 1900861 - Remove fluent comments and duplicate SVG icons from Weather feature highlight r=home-newtab-reviewers,fluent-reviewers,flod,thecount
Differential Revision: https://phabricator.services.mozilla.com/D212737
2024-06-06 14:48:01 +00:00
Amy Churchwell
528d14989b Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-05 23:02:05 +00:00
scottdowne
28cd14bfc0 Bug 1900651 - Home and newtab create solid colour wallpaper pref r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212584
2024-06-05 22:24:56 +00:00
Norisz Fay
b51870e35d Backed out changeset 6b724772e8ba (bug 1900651) for causing newtab failures CLOSED TREE 2024-06-05 23:58:39 +03:00
scottdowne
ecefc3de9a Bug 1900651 - Home and newtab create solid colour wallpaper pref r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212584
2024-06-05 19:30:53 +00:00
Butkovits Atila
4342985960 Backed out changeset fde0e6b10250 (bug 1897232) for causing bustages complaining about packager.mk. CLOSED TREE 2024-06-05 22:44:18 +03:00
Amy Churchwell
e77b770e58 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-05 17:21:22 +00:00
Sandor Molnar
093794820b Backed out changeset 711d1bed224b (bug 1897232) for causing xpc failures @ test_WallpaperFeed.js & bc failures @ browser_parsable_css.js CLOSED TREE 2024-06-04 23:34:06 +03:00
Amy Churchwell
cc94d1cbd3 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-04 19:31:03 +00:00
Maxx Crawford
370eb7ac1f Bug 1897233 - Add feature highlight for Wallpapers r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,aminomancer,bolsson,thecount,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D212157
2024-06-04 00:54:00 +00:00
Nathan Barrett
c7d3cc489b Bug 1893007 - add location query to weather widget r=thecount,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212069
2024-06-03 20:59:32 +00:00
scottdowne
142f2f4e24 Bug 1900240 - Home and newtab fixing link text colour issue with wallpaper r=home-newtab-reviewers,amy
Differential Revision: https://phabricator.services.mozilla.com/D212375
2024-06-03 17:18:03 +00:00
Norisz Fay
de0375cf98 Backed out changeset 11b5fa2ce936 (bug 1893007) for causing multiple weather related failures 2024-06-01 02:57:28 +03:00
Nathan Barrett
6320648af6 Bug 1893007 - add location query to weather widget r=thecount,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212069
2024-05-31 21:31:42 +00:00
scottdowne
0d285f9aec Bug 1900043 - Home and newtab fixing regression for light and dark mode caused by wallpaper contextual text colour changes. r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212301
2024-05-31 18:36:19 +00:00
scottdowne
8954d01757 Bug 1898818 - Home and newtab fixes so newtab with a wallpaper looks good in both light and dark mode r=desktop-theme-reviewers,home-newtab-reviewers,omc-reviewers,sfoster,aminomancer,amy
Differential Revision: https://phabricator.services.mozilla.com/D211623
2024-05-30 18:47:21 +00:00
Nathan Barrett
acb7255941 Bug 1893940 - Fix stripe in customize menu on small screens r=amy,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D210834
2024-05-21 13:56:58 +00:00
Maxx Crawford
99b8fc05eb Bug 1890136 - Add weather widget component r=home-newtab-reviewers,omc-reviewers,aminomancer,thecount
This commit adds the component - including markup, logic and styles for the weather widget on the New Tab page

Differential Revision: https://phabricator.services.mozilla.com/D208885
2024-05-09 22:11:57 +00:00
Nathan Barrett
3ae97b6c59 Bug 1886833 - Home and newtab creating weather feed r=home-newtab-reviewers,maxx,nanj
Differential Revision: https://phabricator.services.mozilla.com/D207763
2024-05-06 16:02:21 +00:00
Cristian Tuns
c89ea1335d Backed out changeset 5b371a36f78c (bug 1886833) for causing node new tab failures in bundles. CLOSED TREE 2024-05-02 12:27:45 -04:00
Nathan Barrett
82968be818 Bug 1886833 - Home and newtab creating weather feed r=home-newtab-reviewers,maxx,nanj
Differential Revision: https://phabricator.services.mozilla.com/D207763
2024-05-02 15:52:03 +00:00
Amy Churchwell
b4a125edc5 Bug 1893311 - Add two prefs for light/dark newtab wallpapers. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208568
2024-04-26 20:20:56 +00:00
Nathan Barrett
2da579d075 Bug 1892487 - Fix tabbing issue with wallpaper thumbnails r=maxx,omc-reviewers,home-newtab-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208626
2024-04-26 19:10:39 +00:00
Cosmin Sabou
3cdab91742 Backed out changeset 5e5176b23fbe (bug 1893311) for causing newtab failures. CLOSED TREE 2024-04-26 01:52:21 +03:00
Amy Churchwell
d52f3d4ae7 Bug 1893311 - Add two prefs for light/dark newtab wallpapers. r=home-newtab-reviewers,nbarrett CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D208568
2024-04-25 20:49:06 +00:00
Sandor Molnar
766c1a48c4 Backed out changeset 43278981d771 (bug 1892487) for causing node newtab failures. 2024-04-26 01:13:44 +03:00
Sandor Molnar
fe73c1ba67 Backed out changeset 095c84193edc (bug 1893311) for causing node newtab failures CLOSED TREE 2024-04-26 01:06:28 +03:00
Amy Churchwell
4e0a010b4f Bug 1893311 - Add two prefs for light/dark newtab wallpapers. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208568
2024-04-25 20:49:06 +00:00
Nathan Barrett
a7a0dbc9d6 Bug 1892487 - Fix tabbing issue with wallpaper thumbnails r=maxx,omc-reviewers,home-newtab-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208626
2024-04-25 20:34:40 +00:00
Amy Churchwell
788dc6f278 Bug 1893076 - Update wallpaper onboarding thumbnail images. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208420
2024-04-24 20:11:29 +00:00
scottdowne
cd475eec92 Bug 1892281 - Home and newtab fixing wallpaper thumbnail click area r=home-newtab-reviewers,maxxcrawford
Differential Revision: https://phabricator.services.mozilla.com/D208029
2024-04-19 22:05:25 +00:00
Maxx Crawford
f7bf5949e2 Bug 1824019 - Adjust hover/focus/active states for HNT card context menu buttons r=home-newtab-reviewers,desktop-theme-reviewers,dao,nbarrett,thecount
This patch adjusts the background-color/border/outline of the three different context menu buttons across the HNT page: top sites, pocket stories and recent activity cards.

It addresses the different link states: :hover, :focus (inlcuding :focus-visible), and :active for this button. This patch also includes attribute values for dark mode.

Differential Revision: https://phabricator.services.mozilla.com/D207067
2024-04-18 19:54:22 +00:00